Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-27 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189401
---


Ship it!




Ship It!

- Puneet Gupta


On Oct. 26, 2017, 3:28 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 26, 2017, 3:28 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-26 Thread Ankit Kailaswar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/
---

(Updated Oct. 26, 2017, 3:28 p.m.)


Review request for lens and Puneet Gupta.


Bugs: LENS-1461
https://issues.apache.org/jira/browse/LENS-1461


Repository: lens


Description
---

Persist process for Session service should not fail if any session in invalid. 
Persist service should ignore these session and continue persisting state of 
other session instead of failing.


Diffs (updated)
-

  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 b480d140 


Diff: https://reviews.apache.org/r/61881/diff/4/

Changes: https://reviews.apache.org/r/61881/diff/3-4/


Testing
---


Thanks,

Ankit Kailaswar

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-26 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189292
---




lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 424 (patched)


This is not required. sessions List size should be enough .


- Puneet Gupta


On Oct. 26, 2017, 8:23 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 26, 2017, 8:23 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-26 Thread Ankit Kailaswar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/
---

(Updated Oct. 26, 2017, 8:23 a.m.)


Review request for lens and Puneet Gupta.


Bugs: LENS-1461
https://issues.apache.org/jira/browse/LENS-1461


Repository: lens


Description
---

Persist process for Session service should not fail if any session in invalid. 
Persist service should ignore these session and continue persisting state of 
other session instead of failing.


Diffs (updated)
-

  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 b480d140 


Diff: https://reviews.apache.org/r/61881/diff/3/

Changes: https://reviews.apache.org/r/61881/diff/2-3/


Testing
---


Thanks,

Ankit Kailaswar

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-26 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189274
---



Dont see the latest patch uploaded on review board .

- Puneet Gupta


On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 17, 2017, 12:07 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-25 Thread Ankit Kailaswar 


> On Oct. 25, 2017, 5:32 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
> > Lines 432 (patched)
> > 
> >
> > Won't this cause issues While reading sessions back? As the count of 
> > sessions persisted is written as `SESSION_MAP.size()`. It'll try to read 
> > that many session objects. What will happen if some of the sessions are not 
> > written at all?

fixed it, now storing all sessions in memory before persisting individually.


- Ankit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189159
---


On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 17, 2017, 12:07 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-24 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189159
---




lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 432 (patched)


Won't this cause issues While reading sessions back? As the count of 
sessions persisted is written as `SESSION_MAP.size()`. It'll try to read that 
many session objects. What will happen if some of the sessions are not written 
at all?


- Rajat Khandelwal


On Oct. 17, 2017, 5:37 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 17, 2017, 5:37 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-18 Thread Ankit Kailaswar 


> On Aug. 28, 2017, 10:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
> > Lines 428 (patched)
> > 
> >
> > ClientError path should not come in server path. Can we avoid this?

BaseLensService for getSession is throwing ClientErrorException for,
1. invalid session handle
2. if resource for session is release my HiveSessionManager.
Ideally we shoud throw ClientErrorException for invalid session only. Only 
possible reason for "2" is since we are using Hive session manager in lens to 
retrieve HiveSession object. We can discuss this later to decide for what could 
be better approach here.


- Ankit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review183912
---


On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 17, 2017, 12:07 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-18 Thread Ankit Kailaswar 


> On Aug. 29, 2017, 10:19 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
> > Lines 430 (patched)
> > 
> >
> > out.writeInt(SESSION_MAP.size()) would be wrong in this case . It 
> > should be SESSION_MAP.size()-1. How do we handle this ?

changed logs to display correct value for number of session persisted.


- Ankit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review184038
---


On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 17, 2017, 12:07 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-10-17 Thread Ankit Kailaswar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/
---

(Updated Oct. 17, 2017, 12:07 p.m.)


Review request for lens and Puneet Gupta.


Bugs: LENS-1461
https://issues.apache.org/jira/browse/LENS-1461


Repository: lens


Description
---

Persist process for Session service should not fail if any session in invalid. 
Persist service should ignore these session and continue persisting state of 
other session instead of failing.


Diffs (updated)
-

  
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
 b480d140 


Diff: https://reviews.apache.org/r/61881/diff/2/

Changes: https://reviews.apache.org/r/61881/diff/1-2/


Testing
---


Thanks,

Ankit Kailaswar

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-08-29 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review184038
---




lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 429 (patched)


Are we sure that ClientErrorException is the only execption we are seeing 
when this issue is hit? If we do not have logs to corroborate this, other run 
time execptions should be handled too



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 430 (patched)


out.writeInt(SESSION_MAP.size()) would be wrong in this case . It should be 
SESSION_MAP.size()-1. How do we handle this ?


- Puneet Gupta


On Aug. 24, 2017, 8:11 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Aug. 24, 2017, 8:11 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d14 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

2017-08-28 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review183912
---




lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 428 (patched)


ClientError path should not come in server path. Can we avoid this?


- Amareshwari Sriramadasu


On Aug. 24, 2017, 8:11 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Aug. 24, 2017, 8:11 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d14 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>