Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)
Adding my +1. With that, the release passes with 3 binding +1 votes from Piotr, Gary, and me. I will continue the release process. On Fri, Sep 15, 2023 at 10:54 AM Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1175 > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At least 3 +1 votes and more > positive than negative votes are required. > > # RC1..RC2 changes > > - Added `Main-Class` to `MANIFEST.MF` > > # Release Notes > > This marks the first release where the Log4j JMX GUI is released > separately from the Log4j itself. > > ## Changes > > ### Added > > * Project is moved to a new repository[1] with its own release cycle > > [1] https://github.com/apache/logging-log4j-jmx-gui
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)
You're right! Apache RAT does run and I missed it, apologies!: -) Gary On Fri, Sep 15, 2023, 10:42 AM Volkan Yazıcı wrote: > Thanks for the elaborate review Gary. > > > sha512 file points to a non-existent folder "tmp" > > Fixed[1] in `logging-parent` reusable CI scripts. > It will be applicable from now on. > > [1] > https://github.com/apache/logging-parent/commit/daa46ba9a5a9879fe5989f01cdf81798f9e844a8 > > > verify goal does not run apache-rat:check > > It does. This can also be seen from the CI output[2]. (Look for the > `apache-rat:0.15:check` line there.) > > [2] > https://github.com/apache/logging-log4j-jmx-gui/actions/runs/6195943429/job/16821616066 > > On Fri, Sep 15, 2023 at 4:22 PM Gary D. Gregory > wrote: > > > > - ASC seems OK. > > - Can't easily mechanically check sha512 but eyeballing it appears OK. > > - mvn apache-rat:check OK > > - Built OK 'mvn clean verify' > > - Running with 'java -jar target\...jar localhost:333' starts the app > and fails which is fine since I did not try with an actual app. > > - We have ... ZERO unit tests or ITs? Yikes :-( > > > > I'm going +1 just based on the mechanics of building and trust the RM > ran an app ;-) > > > > Test bed: > > > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) > > Maven home: C:\java\apache-maven-3.9.4 > > Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program > Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Gary > > > > On 2023/09/15 08:54:45 Volkan Yazıcı wrote: > > > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > > > > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > > > Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 > > > Distribution: > https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > > > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1175 > > > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > > > > > Please download, test, and cast your votes on this mailing list. > > > > > > [ ] +1, release the artifacts > > > [ ] -1, don't release, because... > > > > > > This vote is open for 24 hours and will pass unless getting a > > > net negative vote count. All votes are welcome and we encourage > > > everyone to test the release, but only the Logging Services PMC > > > votes are officially counted. At least 3 +1 votes and more > > > positive than negative votes are required. > > > > > > # RC1..RC2 changes > > > > > > - Added `Main-Class` to `MANIFEST.MF` > > > > > > # Release Notes > > > > > > This marks the first release where the Log4j JMX GUI is released > > > separately from the Log4j itself. > > > > > > ## Changes > > > > > > ### Added > > > > > > * Project is moved to a new repository[1] with its own release cycle > > > > > > [1] https://github.com/apache/logging-log4j-jmx-gui > > > >
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)
Thanks for the elaborate review Gary. > sha512 file points to a non-existent folder "tmp" Fixed[1] in `logging-parent` reusable CI scripts. It will be applicable from now on. [1] https://github.com/apache/logging-parent/commit/daa46ba9a5a9879fe5989f01cdf81798f9e844a8 > verify goal does not run apache-rat:check It does. This can also be seen from the CI output[2]. (Look for the `apache-rat:0.15:check` line there.) [2] https://github.com/apache/logging-log4j-jmx-gui/actions/runs/6195943429/job/16821616066 On Fri, Sep 15, 2023 at 4:22 PM Gary D. Gregory wrote: > > - ASC seems OK. > - Can't easily mechanically check sha512 but eyeballing it appears OK. > - mvn apache-rat:check OK > - Built OK 'mvn clean verify' > - Running with 'java -jar target\...jar localhost:333' starts the app and > fails which is fine since I did not try with an actual app. > - We have ... ZERO unit tests or ITs? Yikes :-( > > I'm going +1 just based on the mechanics of building and trust the RM ran an > app ;-) > > Test bed: > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) > Maven home: C:\java\apache-maven-3.9.4 > Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program > Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Gary > > On 2023/09/15 08:54:45 Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > > Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 > > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > > Nexus: > > https://repository.apache.org/content/repositories/orgapachelogging-1175 > > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > > > Please download, test, and cast your votes on this mailing list. > > > > [ ] +1, release the artifacts > > [ ] -1, don't release, because... > > > > This vote is open for 24 hours and will pass unless getting a > > net negative vote count. All votes are welcome and we encourage > > everyone to test the release, but only the Logging Services PMC > > votes are officially counted. At least 3 +1 votes and more > > positive than negative votes are required. > > > > # RC1..RC2 changes > > > > - Added `Main-Class` to `MANIFEST.MF` > > > > # Release Notes > > > > This marks the first release where the Log4j JMX GUI is released > > separately from the Log4j itself. > > > > ## Changes > > > > ### Added > > > > * Project is moved to a new repository[1] with its own release cycle > > > > [1] https://github.com/apache/logging-log4j-jmx-gui > >
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)
- ASC seems OK. - Can't easily mechanically check sha512 but eyeballing it appears OK. - mvn apache-rat:check OK - Built OK 'mvn clean verify' - Running with 'java -jar target\...jar localhost:333' starts the app and fails which is fine since I did not try with an actual app. - We have ... ZERO unit tests or ITs? Yikes :-( I'm going +1 just based on the mechanics of building and trust the RM ran an app ;-) Test bed: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: C:\java\apache-maven-3.9.4 Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On 2023/09/15 08:54:45 Volkan Yazıcı wrote: > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1175 > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At least 3 +1 votes and more > positive than negative votes are required. > > # RC1..RC2 changes > > - Added `Main-Class` to `MANIFEST.MF` > > # Release Notes > > This marks the first release where the Log4j JMX GUI is released > separately from the Log4j itself. > > ## Changes > > ### Added > > * Project is moved to a new repository[1] with its own release cycle > > [1] https://github.com/apache/logging-log4j-jmx-gui >
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)
Not a blocker but should be fixed IMO: The verify goal does not run apache-rat:check Gary On 2023/09/15 08:54:45 Volkan Yazıcı wrote: > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1175 > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At least 3 +1 votes and more > positive than negative votes are required. > > # RC1..RC2 changes > > - Added `Main-Class` to `MANIFEST.MF` > > # Release Notes > > This marks the first release where the Log4j JMX GUI is released > separately from the Log4j itself. > > ## Changes > > ### Added > > * Project is moved to a new repository[1] with its own release cycle > > [1] https://github.com/apache/logging-log4j-jmx-gui >
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)
Probably not a blocker but the sha512 file can't be validated with the usual: $ shasum --check apache-log4j-jmx-gui-2.21.0-src.zip.sha512 Instead I get: shasum: /tmp/apache-log4j-jmx-gui-2.21.0-src.zip: No such file or directory /tmp/apache-log4j-jmx-gui-2.21.0-src.zip: FAILED open or read shasum: WARNING: 1 listed file could not be read Because the sha512 file points to a non-existent folder "tmp" instead pointing directly to the file: $ cat apache-log4j-jmx-gui-2.21.0-src.zip.sha512 5f1847021946f22a6a7e5b40ac9a409039bcb2fae668cf70439c814df4a5a6f770fef6b628c91e1dc317c7f684d5b1d13fdc112bd6369b16eff64e4ae1084474 /tmp/apache-log4j-jmx-gui-2.21.0-src.zip and eye-balling a sha512 is not "fun" ;-) Gary On 2023/09/15 08:54:45 Volkan Yazıcı wrote: > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1175 > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At least 3 +1 votes and more > positive than negative votes are required. > > # RC1..RC2 changes > > - Added `Main-Class` to `MANIFEST.MF` > > # Release Notes > > This marks the first release where the Log4j JMX GUI is released > separately from the Log4j itself. > > ## Changes > > ### Added > > * Project is moved to a new repository[1] with its own release cycle > > [1] https://github.com/apache/logging-log4j-jmx-gui >
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)
Hi Volkan, On Fri, 15 Sept 2023 at 10:54, Volkan Yazıcı wrote: > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... I checked the release: * the Maven artifacts are the same as those locally generated, * the binary distribution is the same as the one locally generated, * the GUI application works, * the JConsole plugin also works. Hence: +1 Remark: the distribution archives contain the files directly in the root of the archive (no subfolder), which is unusual. Piotr
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0
A unit test would help? Gary On Fri, Sep 15, 2023, 4:46 AM Volkan Yazıcı wrote: > Cancelling this vote due to missing `Main-Class` in `MANIFEST.MF`. As > a matter of fact, it has been missing for quite some time in `2.x` > too. Pretty solid indication that nobody is using it. Nevertheless, I > want to bury the project in decency. I will fix the problem, test it, > and issue an RC2. > > On Thu, Sep 14, 2023 at 4:35 PM Volkan Yazıcı wrote: > > > > This is a vote to release the Apache Log4j JMX GUI 2.21.0. > > > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > > Commit: 35d3021e995393a0f62198c2c65af8b47e42688b > > Distribution: > https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1174 > > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > > > Please download, test, and cast your votes on this mailing list. > > > > [ ] +1, release the artifacts > > [ ] -1, don't release, because... > > > > This vote is open for 24 hours and will pass unless getting a > > net negative vote count. All votes are welcome and we encourage > > everyone to test the release, but only the Logging Services PMC > > votes are officially counted. At least 3 +1 votes and more > > positive than negative votes are required. > > > > # Release Notes > > > > This marks the first release where the Log4j JMX GUI is released > > separately from the Log4j itself. > > > > ## Changes > > > > ### Added > > > > * Project is moved to a new repository[1] with its own release cycle > > > > [1] https://github.com/apache/logging-log4j-jmx-gui >
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0
Cancelling this vote due to missing `Main-Class` in `MANIFEST.MF`. As a matter of fact, it has been missing for quite some time in `2.x` too. Pretty solid indication that nobody is using it. Nevertheless, I want to bury the project in decency. I will fix the problem, test it, and issue an RC2. On Thu, Sep 14, 2023 at 4:35 PM Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j JMX GUI 2.21.0. > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: 35d3021e995393a0f62198c2c65af8b47e42688b > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1174 > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At least 3 +1 votes and more > positive than negative votes are required. > > # Release Notes > > This marks the first release where the Log4j JMX GUI is released > separately from the Log4j itself. > > ## Changes > > ### Added > > * Project is moved to a new repository[1] with its own release cycle > > [1] https://github.com/apache/logging-log4j-jmx-gui
Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0
+1 Remko > On Sep 14, 2023, at 16:34, Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j JMX GUI 2.21.0. > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: 35d3021e995393a0f62198c2c65af8b47e42688b > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui > Nexus: > https://repository.apache.org/content/repositories/orgapachelogging-1174 > Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At least 3 +1 votes and more > positive than negative votes are required. > > # Release Notes > > This marks the first release where the Log4j JMX GUI is released > separately from the Log4j itself. > > ## Changes > > ### Added > > * Project is moved to a new repository[1] with its own release cycle > > [1] https://github.com/apache/logging-log4j-jmx-gui
