[GitHub] lucene-solr pull request #361: SOLR-12271: Fix for analytics component readi...

2018-04-25 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/361

 SOLR-12271: Fix for analytics component reading negative values from 
double and float fields



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr 
analytics-negative-field-values

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #361


commit 127b64a5f5c7c673bdb2fdee3594e304fd021ff0
Author: Houston Putman <hputman1@...>
Date:   2018-04-25T15:05:39Z

SOLR-12271: Fix for analytics component reading negative values from double 
and float fields.

commit ef7f829d623b9cb2891c2bb232934964250d6a71
Author: Houston Putman <hputman1@...>
Date:   2018-04-25T15:11:45Z

SOLR-12271: Updating changes.txt




---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #313: SOLR-11924: Added a way to create collection set wat...

2018-04-03 Thread HoustonPutman 
Github user HoustonPutman commented on the issue:

https://github.com/apache/lucene-solr/pull/313
  
Changed the structure to follow the `LiveNodesListener` convention. 

This includes passing the previous set of collections as well as the new 
list of collections in each notification.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #313: SOLR-11924: Added a way to create collection ...

2018-03-28 Thread HoustonPutman 
Github user HoustonPutman commented on a diff in the pull request:

https://github.com/apache/lucene-solr/pull/313#discussion_r177866085
  
--- Diff: 
solr/solrj/src/java/org/apache/solr/common/cloud/CollectionSetWatcher.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.common.cloud;
+
+import java.util.Set;
+
+/**
+ * Callback registered with {@link 
ZkStateReader#registerCollectionSetWatcher(CollectionSetWatcher)}
+ * and called whenever the cluster's collection set changes.
+ */
+public interface CollectionSetWatcher {
--- End diff --

There is likely a better name. I named it this because it is watching for 
the set of collections. `CollectionsWatcher` may be a better name, or 
`CollectionsListener`.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #313: SOLR-11924: Added a way to create collection ...

2018-03-28 Thread HoustonPutman 
Github user HoustonPutman commented on a diff in the pull request:

https://github.com/apache/lucene-solr/pull/313#discussion_r177865872
  
--- Diff: 
solr/solrj/src/java/org/apache/solr/common/cloud/CollectionSetWatcher.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.common.cloud;
+
+import java.util.Set;
+
+/**
+ * Callback registered with {@link 
ZkStateReader#registerCollectionSetWatcher(CollectionSetWatcher)}
+ * and called whenever the cluster's collection set changes.
+ */
+public interface CollectionSetWatcher {
+
+  /**
+   * Called when a collection is created, a collection is deleted or a 
watched collection's state changes.
+   *
+   * Note that, due to the way Zookeeper watchers are implemented, a 
single call may be
+   * the result of several collection set changes. Also, multiple calls to 
this method can be made
+   * with the same colllection set, ie. without any new updates.
+   *
+   * @param collections   the set of collections
+   *
+   * @return true if the watcher should be removed
--- End diff --

This follows the convention used in `CollectionStateWatcher`. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #313: SOLR-11924: Added a way to create collection set wat...

2018-03-28 Thread HoustonPutman 
Github user HoustonPutman commented on the issue:

https://github.com/apache/lucene-solr/pull/313
  
Regarding your comments:

1. I'm not sure when this would be necessary, however I tried to follow the 
convention used in `CollectionStateWatcher`. `LiveNodesListener` is a similar 
interface that doesn't return a value. Maybe it would be better to follow this 
convention.
2. The use case I need this for is keeping track of all collections that a 
cloud contains so that we can monitor each collection. It could also be useful 
for pre-populating State watchers for all collections, so that they aren't 
created whenever the state information is needed.

I also have no qualms about changing the name of this interface, as I don't 
like the current name very much. It might be good to change it from a `Watcher` 
to a `Listener` if we decide to follow the `LiveNodesListener` convention 
instead of the `CollectionStateWatcher` convention for removing itself from the 
`zkStateReader`.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #330: SOLR-12045: Moving the Analytics Component fr...

2018-02-28 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/330

SOLR-12045: Moving the Analytics Component from contrib to core.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr analytics-core

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #330


commit bb1518759a651565b4eabb39bc0f2c0ebd4716c7
Author: Houston Putman <hputman1@...>
Date:   2018-02-28T15:37:07Z

SOLR-12045: Moving the Analytics Component from contrib to core.




---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #313: SOLR-11924: Added a way to create collection ...

2018-01-29 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/313

SOLR-11924: Added a way to create collection set watchers in ZkStateReader.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr 
collection-set-watchers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #313


commit be1be01d5eb1bf0a69eda65ad60f46442c366950
Author: Houston Putman <hputman1@...>
Date:   2018-01-29T20:29:06Z

Added a way to create collection set watchers to the ZkStateReader.




---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #279: SOLR-11711: Fixed minCount bug in distributed...

2017-12-12 Thread HoustonPutman 
Github user HoustonPutman closed the pull request at:

https://github.com/apache/lucene-solr/pull/279


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #279: SOLR-11711: Improved memory usage for distrib...

2017-11-30 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/279

SOLR-11711: Improved memory usage for distributed field and pivot facets.

Removed the FACET_DISTRIB_MCO option, since the behavior is now built in.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr 
pivot_facet_memory_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #279


commit 8b7ef286100730e26a9bdc8875fce31a5b47b59a
Author: Houston Putman <hputm...@bloomberg.net>
Date:   2017-11-30T21:10:50Z

Removed FACET_DISTRIB_MCO option, improved memory usage for distributed 
field and pivot facets.




---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #269: Added parameter sections for analytics facets...

2017-11-02 Thread HoustonPutman 
Github user HoustonPutman closed the pull request at:

https://github.com/apache/lucene-solr/pull/269


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #269: Added parameter sections for analytics facets.

2017-11-02 Thread HoustonPutman 
Github user HoustonPutman commented on the issue:

https://github.com/apache/lucene-solr/pull/269
  
Changes merged and added alongside all of the analytics documentation in 
[this 
commit.](https://github.com/apache/lucene-solr/commit/6428ddb10e975f8b8955aebb9b59e5de201face0)


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #229: SOLR-11144: Initial version of the analytics compone...

2017-11-02 Thread HoustonPutman 
Github user HoustonPutman commented on the issue:

https://github.com/apache/lucene-solr/pull/229
  
Analytics reference merged in [this 
commit.](https://github.com/apache/lucene-solr/commit/6428ddb10e975f8b8955aebb9b59e5de201face0)


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #229: SOLR-11144: Initial version of the analytics ...

2017-11-02 Thread HoustonPutman 
Github user HoustonPutman closed the pull request at:

https://github.com/apache/lucene-solr/pull/229


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #269: Added parameter sections for analytics facets...

2017-10-30 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/269

Added parameter sections for analytics facets.

- Added parameter sections for all of the facet types
- Fixed the example analytics expression, since there was a mistake in one 
of the lines.
- Changed the Strings section in Analytics-expression-sources.adoc to use 
and unordered list instead of an ordered list.
- Changed the Titles of the mismatched pages to reflect their shortnames. 
(So I removed the 'Reference' at the end of each)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr jira/solr-11144

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #269


commit 9cb5d14496b917a715aeffbf12dc06d8b15277e7
Author: Houston Putman <hputm...@bloomberg.net>
Date:   2017-10-30T21:41:32Z

Added parameter sections for analytics facets.




---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #229: SOLR-11144: Initial version of the analytics ...

2017-08-09 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/229

SOLR-11144: Initial version of the analytics component reference.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr 
analytics-solr_ref_guide

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #229


commit 54410ff9d13efcf174cff3ad0d8667cbe84e75a1
Author: Houston Putman <hputm...@bloomberg.net>
Date:   2017-08-03T16:33:00Z

SOLR-11144: Initial version of the analytics component reference.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #225: SOLR-11145, SOLR-11146: Added comprehensive u...

2017-08-01 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/225

SOLR-11145, SOLR-11146: Added comprehensive unit tests for Analytics …

…Component 2.0 as well as analytics bug fixes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr 
analytics-unit_tests-apache_master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #225


commit 194472751bf82fcd4e38679ed57f2dd556a3fd1c
Author: Houston Putman <hputm...@bloomberg.net>
Date:   2017-08-01T15:01:17Z

SOLR-11145, SOLR-11146: Added comprehensive unit tests for Analytics 
Component 2.0 as well as analytics bug fixes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr issue #215: SOLR-10123: Fix to better support numeric PointField...

2017-07-05 Thread HoustonPutman 
Github user HoustonPutman commented on the issue:

https://github.com/apache/lucene-solr/pull/215
  
If you are asking where in the component are they handled, it's in the 
ExpressionFactory.createField() method where Trie and Point fields are 
separated.

If you are asking about the tests, they work with both Trie and Point 
fields.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #215: SOLR-10123: Fix to better support numeric Poi...

2017-06-29 Thread HoustonPutman 
GitHub user HoustonPutman opened a pull request:

https://github.com/apache/lucene-solr/pull/215

SOLR-10123: Fix to better support numeric PointFields in Analytics.

Unit tests now use randomized numeric fields.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HoustonPutman/lucene-solr analytics-points

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #215


commit c66d149b491bb47baac5f29101f5383aa93df280
Author: Houston Putman <hputm...@bloomberg.net>
Date:   2017-06-29T19:52:08Z

SOLR-10123: Fix to better support numeric PointFields. Unit tests now use 
randomized numeric fields.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org