[jira] [Commented] (LUCENE-8932) Allow BKDReader packedIndex to be off heap
[ https://issues.apache.org/jira/browse/LUCENE-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924293#comment-16924293 ] Jack Conradson commented on LUCENE-8932: [~jpountz] Thanks for the thorough review! I will incorporate your feedback into a patch next week and try to move forward from there. > Allow BKDReader packedIndex to be off heap > -- > > Key: LUCENE-8932 > URL: https://issues.apache.org/jira/browse/LUCENE-8932 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Jack Conradson >Priority: Minor > Attachments: LUCENE-8932.patch > > > This change modifies BKDReader to read the packedIndex bytes off heap rather > than load them all on heap at a single time. > Questions for discussion: > # Should BKDReader only support packedIndex off heap? > # If not, how should the choice be made? > Using luceneutils IndexAndSearchOpenStreetMaps present the following test > results: > with -box -points (patch) > READER MB: 1.1345596313476562 > BEST M hits/sec: 73.34277344984474 > BEST QPS: 74.63011169783009 > with -box -points (original) > READER MB: 1.7249317169189453 > BEST M hits/sec: 73.77125157623486 > BEST QPS: 75.06611062353801 > with -nearest 10 -points (patch) > READER MB: 1.1345596313476562 > BEST M hits/sec: 0.013586298373879497 > BEST QPS: 1358.6298373879497 > with -nearest 10 -points (original) > READER MB: 1.7249317169189453 > BEST M hits/sec: 0.01445208197367343 > BEST QPS: 1445.208197367343 > with -box -geo3d (patch) > READER MB: 1.1345596313476562 > BEST M hits/sec: 39.84968715299074 > BEST QPS: 40.54914292796736 > with -box -geo3d (original) > READER MB: 1.7456226348876953 > BEST M hits/sec: 40.45051734329004 > BEST QPS: 41.160519101846695 -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-8932) Allow BKDReader packedIndex to be off heap
[ https://issues.apache.org/jira/browse/LUCENE-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-8932: --- Attachment: LUCENE-8932.patch > Allow BKDReader packedIndex to be off heap > -- > > Key: LUCENE-8932 > URL: https://issues.apache.org/jira/browse/LUCENE-8932 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Jack Conradson >Priority: Minor > Attachments: LUCENE-8932.patch > > > This change modifies BKDReader to read the packedIndex bytes off heap rather > than load them all on heap at a single time. > Questions for discussion: > # Should BKDReader only support packedIndex off heap? > # If not, how should the choice be made? > Using luceneutils IndexAndSearchOpenStreetMaps present the following test > results: > with -box -points (patch) > READER MB: 1.1345596313476562 > BEST M hits/sec: 73.34277344984474 > BEST QPS: 74.63011169783009 > with -box -points (original) > READER MB: 1.7249317169189453 > BEST M hits/sec: 73.77125157623486 > BEST QPS: 75.06611062353801 > with -nearest 10 -points (patch) > READER MB: 1.1345596313476562 > BEST M hits/sec: 0.013586298373879497 > BEST QPS: 1358.6298373879497 > with -nearest 10 -points (original) > READER MB: 1.7249317169189453 > BEST M hits/sec: 0.01445208197367343 > BEST QPS: 1445.208197367343 > with -box -geo3d (patch) > READER MB: 1.1345596313476562 > BEST M hits/sec: 39.84968715299074 > BEST QPS: 40.54914292796736 > with -box -geo3d (original) > READER MB: 1.7456226348876953 > BEST M hits/sec: 40.45051734329004 > BEST QPS: 41.160519101846695 -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-8932) Allow BKDReader packedIndex to be off heap
Jack Conradson created LUCENE-8932: -- Summary: Allow BKDReader packedIndex to be off heap Key: LUCENE-8932 URL: https://issues.apache.org/jira/browse/LUCENE-8932 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson This change modifies BKDReader to read the packedIndex bytes off heap rather than load them all on heap at a single time. Questions for discussion: # Should BKDReader only support packedIndex off heap? # If not, how should the choice be made? Using luceneutils IndexAndSearchOpenStreetMaps present the following test results: with -box -points (patch) READER MB: 1.1345596313476562 BEST M hits/sec: 73.34277344984474 BEST QPS: 74.63011169783009 with -box -points (original) READER MB: 1.7249317169189453 BEST M hits/sec: 73.77125157623486 BEST QPS: 75.06611062353801 with -nearest 10 -points (patch) READER MB: 1.1345596313476562 BEST M hits/sec: 0.013586298373879497 BEST QPS: 1358.6298373879497 with -nearest 10 -points (original) READER MB: 1.7249317169189453 BEST M hits/sec: 0.01445208197367343 BEST QPS: 1445.208197367343 with -box -geo3d (patch) READER MB: 1.1345596313476562 BEST M hits/sec: 39.84968715299074 BEST QPS: 40.54914292796736 with -box -geo3d (original) READER MB: 1.7456226348876953 BEST M hits/sec: 40.45051734329004 BEST QPS: 41.160519101846695 -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6830) Upgrade ANTLR to version 4.5.1
[ https://issues.apache.org/jira/browse/LUCENE-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959861#comment-14959861 ] Jack Conradson commented on LUCENE-6830: Oops! Not updating the runtime was a mistake on my part, thank you for taking the time to fix that. > Upgrade ANTLR to version 4.5.1 > -- > > Key: LUCENE-6830 > URL: https://issues.apache.org/jira/browse/LUCENE-6830 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/expressions >Reporter: Jack Conradson >Assignee: Uwe Schindler > Fix For: Trunk, 5.4 > > Attachments: LUCENE-6830.patch, LUCENE-6830.patch > > > Simple upgrade to ANTLR 4.5.1 which includes numerous bug fixes: > https://github.com/antlr/antlr4/releases/tag/4.5.1 > Note this does not change the grammar itself, only small pieces of the > generated code. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-6830) Upgrade ANTLR to version 4.5.1
Jack Conradson created LUCENE-6830: -- Summary: Upgrade ANTLR to version 4.5.1 Key: LUCENE-6830 URL: https://issues.apache.org/jira/browse/LUCENE-6830 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Simple upgrade to ANTLR 4.5.1 which includes numerous bug fixes: https://github.com/antlr/antlr4/releases/tag/4.5.1 Note this does not change the grammar itself, only small pieces of the generated code. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6830) Upgrade ANTLR to version 4.5.1
[ https://issues.apache.org/jira/browse/LUCENE-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6830: --- Attachment: LUCENE-6830.patch Patch attached. > Upgrade ANTLR to version 4.5.1 > -- > > Key: LUCENE-6830 > URL: https://issues.apache.org/jira/browse/LUCENE-6830 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Jack Conradson > Attachments: LUCENE-6830.patch > > > Simple upgrade to ANTLR 4.5.1 which includes numerous bug fixes: > https://github.com/antlr/antlr4/releases/tag/4.5.1 > Note this does not change the grammar itself, only small pieces of the > generated code. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660824#comment-14660824 ] Jack Conradson commented on LUCENE-6417: Thanks again, Uwe, for all the feedback and taking the time to get the patch into Lucene. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6417.patch, LUCENE-6417.patch, LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14658327#comment-14658327 ] Jack Conradson edited comment on LUCENE-6417 at 8/5/15 3:01 PM: Uwe, this sounds like a reasonable solution. I'll try to get a new patch up later today. Thanks for all the feedback so far. I'm fairly confident the VariableContext is meant to be used outside of the package for help parsing variables into their individual pieces -- x.y.z -- x and y and z as individual pieces map['string'].t -- map and string and t So it doesn't make sense to have it be package-private. was (Author: jdconradson): Uwe, this sounds like a reasonable solution. I'll try to get a new patch up later today. Thanks for all the feedback so far. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14658327#comment-14658327 ] Jack Conradson commented on LUCENE-6417: Uwe, this sounds like a reasonable solution. I'll try to get a new patch up later today. Thanks for all the feedback so far. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6417: --- Attachment: LUCENE-6417.patch Attached a new patch with the requested changes. All classes should be package-private now except for VariableContext and the JavascriptCompiler. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6417.patch, LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659252#comment-14659252 ] Jack Conradson edited comment on LUCENE-6417 at 8/6/15 12:30 AM: - Attached a new patch with the requested changes. All classes should be package-private now except for VariableContext and the JavascriptCompiler. The ANTLR visitor is now encapsulated in an anonymous inner class to hide the implementation details of the compiler. was (Author: jdconradson): Attached a new patch with the requested changes. All classes should be package-private now except for VariableContext and the JavascriptCompiler. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6417.patch, LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654495#comment-14654495 ] Jack Conradson edited comment on LUCENE-6417 at 8/4/15 11:10 PM: - Uwe, would it be possible to move the implemented visitor methods from the JavascriptCompiler into a private static inner class inside of the JavascriptCompiler to hide them properly and then make all the other public classes package protected through regexs like we already do for some of the classes in the build.xml file? Would this satisfy the requirements of keeping all the ANTLR methods hidden or is there more that I'm missing? The other option that I can think of is to go back to parsing the raw tree again, but I prefer to avoid this if possible due to changes in the tree structures between ANTLR 3 and 4. Please let me know what you think. was (Author: jdconradson): Uwe, would it be possible to move the implemented visitor methods from the JavascriptCompiler into a private static inner class inside of the JavascriptCompiler to hide them properly and then make all the other public classes package protected through regexs like we already do for some of the classes in the build.xml file? Would this satisfy the requirements of keeping all the ANTLR methods hidden or is there more that I'm missing? Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654409#comment-14654409 ] Jack Conradson commented on LUCENE-6417: Hey Uwe, I understand the problem. I need to give this some thought as I don't have a good solution off the top of my head. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654495#comment-14654495 ] Jack Conradson commented on LUCENE-6417: Uwe, would it be possible to move the implemented visitor methods from the JavascriptCompiler into a private static inner class inside of the JavascriptCompiler to hide them properly and then make all the other public classes package protected either through regexs like we already do for some of the classes in the build.xml file? Would this satisfy the requirements of keeping all the ANTLR methods hidden or is there more that I'm missing? Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654495#comment-14654495 ] Jack Conradson edited comment on LUCENE-6417 at 8/4/15 10:47 PM: - Uwe, would it be possible to move the implemented visitor methods from the JavascriptCompiler into a private static inner class inside of the JavascriptCompiler to hide them properly and then make all the other public classes package protected through regexs like we already do for some of the classes in the build.xml file? Would this satisfy the requirements of keeping all the ANTLR methods hidden or is there more that I'm missing? was (Author: jdconradson): Uwe, would it be possible to move the implemented visitor methods from the JavascriptCompiler into a private static inner class inside of the JavascriptCompiler to hide them properly and then make all the other public classes package protected either through regexs like we already do for some of the classes in the build.xml file? Would this satisfy the requirements of keeping all the ANTLR methods hidden or is there more that I'm missing? Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653868#comment-14653868 ] Jack Conradson commented on LUCENE-6417: Thanks for picking this up, Uwe. Please let me know if you need anything else from me. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654604#comment-14654604 ] Jack Conradson commented on LUCENE-6417: [~rcmuir] then maybe the best solution is to drop the visitor and parse the tree as before? As a possible third option, I checked to see if it was possible to easily modify the string template files used to generate the code from the grammars, but there's no easy way to point to a custom one. We might be able to still do this, but it would either be through some fragile classes that I don't anticipate were meant to be overridden or by injecting a custom template file into a copied version of the antler 4 jar -- definitely not a pretty solution. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Uwe Schindler Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652029#comment-14652029 ] Jack Conradson commented on LUCENE-6417: Sorry, Mike and Uwe, for the delayed response. I was actually on vacation the previous week. I'll fix the pre-commit and make the suggested changes. The ASM did not change at all (other than by mistake :) ), I was just forced to re-organize the ASM generation code into smaller chunks for the Antler 4.5 visitor. Thanks for reviewing the patch! Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652029#comment-14652029 ] Jack Conradson edited comment on LUCENE-6417 at 8/3/15 4:13 PM: Sorry, Mike and Uwe, for the delayed response. I was actually on vacation the previous week. I'll fix the pre-commit and make the suggested changes. The ASM did not change at all (other than by mistake :) ), I was just forced to re-organize the ASM generation code into smaller chunks for the Antlr 4.5 visitor. Thanks for reviewing the patch! was (Author: jdconradson): Sorry, Mike and Uwe, for the delayed response. I was actually on vacation the previous week. I'll fix the pre-commit and make the suggested changes. The ASM did not change at all (other than by mistake :) ), I was just forced to re-organize the ASM generation code into smaller chunks for the Antler 4.5 visitor. Thanks for reviewing the patch! Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6417: --- Attachment: LUCENE-6471.patch Attached an updated patch. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652085#comment-14652085 ] Jack Conradson edited comment on LUCENE-6417 at 8/3/15 4:55 PM: Attached an updated patch. I think precommit passes now other than the license issue. was (Author: jdconradson): Attached an updated patch. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652085#comment-14652085 ] Jack Conradson edited comment on LUCENE-6417 at 8/3/15 4:58 PM: Attached an updated patch. I think precommit passes now other than the license issue. Also converted the Stack to an ArrayDeque. was (Author: jdconradson): Attached an updated patch. I think precommit passes now other than the license issue. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch, LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639933#comment-14639933 ] Jack Conradson edited comment on LUCENE-6417 at 7/24/15 5:07 AM: - This patch contains the code necessary to upgrade to ANTLR 4.5. The following changes are included: * Updated the build.xml and ivy.xml to use ANTLR 4.5 instead of the prior version. * Modified the grammar to use only two parser rules including a left-hand recursive rule for the majority of the language. Simplified the lexer rules. * Used the provided visitor pattern classes ANTLR 4.5 provides to move through the ANTLR parse tree. The JavascriptCompiler nows inherits from a JavascriptBaseVisitor class. While this does add some extra methods, it's also a well-known design pattern that can be easily modified by future contributors. This allows for easy use of new rule context objects, so that some tokens may be ignored that aren't necessary. Note that ANTLR 4.5 no longer has ASTs because it does not allow for tree rewriting. The provided parse tree required some changes to the compiler since the root nodes now contain 3 children with something like '2' ' - ' '3' rather than tokens such as ' - ' with 2 children. * Moved all error handling out of the grammar file making the grammar language agnostic. Error handling is now part of separate java classes. was (Author: jdconradson): This patch contains the code necessary to upgrade to ANTLR 4.5. The following changes are included: * Updated the build.xml and ivy.xml to use ANTLR 4.5 instead of the prior version. * Modified the grammar to use only two parser rules including a left-hand recursive rule for the majority of the language. Simplified the lexer rules. * Used the provided visitor pattern classes ANTLR 4.5 provides to move through the ANTLR parse tree. The JavascriptCompiler nows inherits from a JavascriptBaseVisitor class. While this does add some extra methods, it's also a well-known design pattern that can be easily modified by future contributors. This allows for easy use of new rule context objects, so that some tokens may be ignored that aren't necessary. Note that ANTLR 4.5 no longer has ASTs because it does not allow for tree rewriting. The provided parse tree required some changes to the compiler since the root nodes now contain 3 children with something like '2' '-' '3' rather than tokens such as '-' with 2 children. * Moved all error handling out of the grammar file making the grammar language agnostic. Error handling is now part of separate java classes. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6417: --- Attachment: LUCENE-6471.patch This patch contains the code necessary to upgrade to ANTLR 4.5. The following changes are included: * Updated the build.xml and ivy.xml to use ANTLR 4.5 instead of the prior version. * Modified the grammar to use only two parser rules including a left-hand recursive rule for the majority of the language. Simplified the lexer rules. * Used the provided visitor pattern classes ANTLR 4.5 provides to move through the ANTLR parse tree. The JavascriptCompiler nows inherits from a JavascriptBaseVisitor class. While this does add some extra methods, it's also a well-known design pattern that can be easily modified by future contributors. This allows for easy use of new rule context objects, so that some tokens may be ignored that aren't necessary. Note that ANTLR 4.5 no longer has ASTs because it does not allow for tree rewriting. The provided parse tree required some changes to the compiler since the root nodes now contain 3 children with something like '2' '+' '3' rather than tokens such as '+' or '-' with 2 children. * Moved all error handling out of the grammar file making the grammar language agnostic. Error handling is now part of separate java classes. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639933#comment-14639933 ] Jack Conradson edited comment on LUCENE-6417 at 7/24/15 5:06 AM: - This patch contains the code necessary to upgrade to ANTLR 4.5. The following changes are included: * Updated the build.xml and ivy.xml to use ANTLR 4.5 instead of the prior version. * Modified the grammar to use only two parser rules including a left-hand recursive rule for the majority of the language. Simplified the lexer rules. * Used the provided visitor pattern classes ANTLR 4.5 provides to move through the ANTLR parse tree. The JavascriptCompiler nows inherits from a JavascriptBaseVisitor class. While this does add some extra methods, it's also a well-known design pattern that can be easily modified by future contributors. This allows for easy use of new rule context objects, so that some tokens may be ignored that aren't necessary. Note that ANTLR 4.5 no longer has ASTs because it does not allow for tree rewriting. The provided parse tree required some changes to the compiler since the root nodes now contain 3 children with something like '2' '-' '3' rather than tokens such as '-' with 2 children. * Moved all error handling out of the grammar file making the grammar language agnostic. Error handling is now part of separate java classes. was (Author: jdconradson): This patch contains the code necessary to upgrade to ANTLR 4.5. The following changes are included: * Updated the build.xml and ivy.xml to use ANTLR 4.5 instead of the prior version. * Modified the grammar to use only two parser rules including a left-hand recursive rule for the majority of the language. Simplified the lexer rules. * Used the provided visitor pattern classes ANTLR 4.5 provides to move through the ANTLR parse tree. The JavascriptCompiler nows inherits from a JavascriptBaseVisitor class. While this does add some extra methods, it's also a well-known design pattern that can be easily modified by future contributors. This allows for easy use of new rule context objects, so that some tokens may be ignored that aren't necessary. Note that ANTLR 4.5 no longer has ASTs because it does not allow for tree rewriting. The provided parse tree required some changes to the compiler since the root nodes now contain 3 children with something like '2' '*' '3' rather than tokens such as '*' or '-' with 2 children. * Moved all error handling out of the grammar file making the grammar language agnostic. Error handling is now part of separate java classes. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639933#comment-14639933 ] Jack Conradson edited comment on LUCENE-6417 at 7/24/15 5:06 AM: - This patch contains the code necessary to upgrade to ANTLR 4.5. The following changes are included: * Updated the build.xml and ivy.xml to use ANTLR 4.5 instead of the prior version. * Modified the grammar to use only two parser rules including a left-hand recursive rule for the majority of the language. Simplified the lexer rules. * Used the provided visitor pattern classes ANTLR 4.5 provides to move through the ANTLR parse tree. The JavascriptCompiler nows inherits from a JavascriptBaseVisitor class. While this does add some extra methods, it's also a well-known design pattern that can be easily modified by future contributors. This allows for easy use of new rule context objects, so that some tokens may be ignored that aren't necessary. Note that ANTLR 4.5 no longer has ASTs because it does not allow for tree rewriting. The provided parse tree required some changes to the compiler since the root nodes now contain 3 children with something like '2' '*' '3' rather than tokens such as '*' or '-' with 2 children. * Moved all error handling out of the grammar file making the grammar language agnostic. Error handling is now part of separate java classes. was (Author: jdconradson): This patch contains the code necessary to upgrade to ANTLR 4.5. The following changes are included: * Updated the build.xml and ivy.xml to use ANTLR 4.5 instead of the prior version. * Modified the grammar to use only two parser rules including a left-hand recursive rule for the majority of the language. Simplified the lexer rules. * Used the provided visitor pattern classes ANTLR 4.5 provides to move through the ANTLR parse tree. The JavascriptCompiler nows inherits from a JavascriptBaseVisitor class. While this does add some extra methods, it's also a well-known design pattern that can be easily modified by future contributors. This allows for easy use of new rule context objects, so that some tokens may be ignored that aren't necessary. Note that ANTLR 4.5 no longer has ASTs because it does not allow for tree rewriting. The provided parse tree required some changes to the compiler since the root nodes now contain 3 children with something like '2' '+' '3' rather than tokens such as '+' or '-' with 2 children. * Moved all error handling out of the grammar file making the grammar language agnostic. Error handling is now part of separate java classes. Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Attachments: LUCENE-6471.patch I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-6454) Support Member Methods in VariableContext
Jack Conradson created LUCENE-6454: -- Summary: Support Member Methods in VariableContext Key: LUCENE-6454 URL: https://issues.apache.org/jira/browse/LUCENE-6454 Project: Lucene - Core Issue Type: Bug Reporter: Jack Conradson The Javascript compiler now supports simple member methods being processed by expression Bindings. The VariableContext should also support being able to parse member methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6454) Support Member Methods in VariableContext
[ https://issues.apache.org/jira/browse/LUCENE-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6454: --- Attachment: LUCENE-6454.patch Attached a patch that includes both the change and new tests. Support Member Methods in VariableContext - Key: LUCENE-6454 URL: https://issues.apache.org/jira/browse/LUCENE-6454 Project: Lucene - Core Issue Type: Bug Reporter: Jack Conradson Attachments: LUCENE-6454.patch The Javascript compiler now supports simple member methods being processed by expression Bindings. The VariableContext should also support being able to parse member methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6454) Support Member Methods in VariableContext
[ https://issues.apache.org/jira/browse/LUCENE-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6454: --- Attachment: LUCENE-6454.patch Second patch that only parses methods for members instead of for the equivalent of method pointers. Support Member Methods in VariableContext - Key: LUCENE-6454 URL: https://issues.apache.org/jira/browse/LUCENE-6454 Project: Lucene - Core Issue Type: Bug Reporter: Jack Conradson Attachments: LUCENE-6454.patch, LUCENE-6454.patch The Javascript compiler now supports simple member methods being processed by expression Bindings. The VariableContext should also support being able to parse member methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6451) Support non-static methods in the Javascript compiler
[ https://issues.apache.org/jira/browse/LUCENE-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6451: --- Attachment: LUCENE-6451.patch Patch attached. Support non-static methods in the Javascript compiler - Key: LUCENE-6451 URL: https://issues.apache.org/jira/browse/LUCENE-6451 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Priority: Minor Attachments: LUCENE-6451.patch Allow methods such as date.getMonth() or string.getOrdinal() to be added in the same way expression variables are now (forwarded to the bindings for processing). This change will only allow non-static methods that have zero arguments due to current limitations in the architecture, and to keep the change simple. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-6451) Support non-static methods in the Javascript compiler
Jack Conradson created LUCENE-6451: -- Summary: Support non-static methods in the Javascript compiler Key: LUCENE-6451 URL: https://issues.apache.org/jira/browse/LUCENE-6451 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Priority: Minor Allow methods such as date.getMonth() or string.getOrdinal() to be added in the same way expression variables are now (forwarded to the bindings for processing). This change will only allow non-static methods that have zero arguments due to current limitations in the architecture, and to keep the change simple. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6451) Support non-static methods in the Javascript compiler
[ https://issues.apache.org/jira/browse/LUCENE-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-6451: --- Attachment: LUCENE-6451.patch Added a comment to clarify a confusing change in the code. Added a few extra test cases to ensure mixed casing is allowed in non-static methods. Support non-static methods in the Javascript compiler - Key: LUCENE-6451 URL: https://issues.apache.org/jira/browse/LUCENE-6451 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Priority: Minor Attachments: LUCENE-6451.patch, LUCENE-6451.patch Allow methods such as date.getMonth() or string.getOrdinal() to be added in the same way expression variables are now (forwarded to the bindings for processing). This change will only allow non-static methods that have zero arguments due to current limitations in the architecture, and to keep the change simple. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-6417) Upgrade ANTLR to version 4.5
Jack Conradson created LUCENE-6417: -- Summary: Upgrade ANTLR to version 4.5 Key: LUCENE-6417 URL: https://issues.apache.org/jira/browse/LUCENE-6417 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several features that will improve the existing grammars. The main improvement would be the allowance of left-hand recursion in grammar rules which will reduce the number of rules significantly for expressions. This change will require some code refactoring to the existing expressions work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5806) Extend expression grammar to allow advanced variables
[ https://issues.apache.org/jira/browse/LUCENE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056503#comment-14056503 ] Jack Conradson commented on LUCENE-5806: Current patch is fine with me. This can always be re-evaluated in the future. Extend expression grammar to allow advanced variables --- Key: LUCENE-5806 URL: https://issues.apache.org/jira/browse/LUCENE-5806 Project: Lucene - Core Issue Type: Bug Reporter: Ryan Ernst Attachments: LUCENE-5806.patch, LUCENE-5806.patch We currently allow dots in variable names in expressions, so that we can fake out object access. We should extend this to allow array access as well (both integer and string keys). This would allow faking out full object nesting through bindings. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5806) Extend expression grammar to allow advanced variables
[ https://issues.apache.org/jira/browse/LUCENE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053992#comment-14053992 ] Jack Conradson commented on LUCENE-5806: Been a while since I've used ANTLR, but is fragment OBJECT : ID (ARRAY ARRAY*)? ; not equivalent to fragment OBJECT : ID ARRAY* ; Extend expression grammar to allow advanced variables --- Key: LUCENE-5806 URL: https://issues.apache.org/jira/browse/LUCENE-5806 Project: Lucene - Core Issue Type: Bug Reporter: Ryan Ernst Attachments: LUCENE-5806.patch We currently allow dots in variable names in expressions, so that we can fake out object access. We should extend this to allow array access as well (both integer and string keys). This would allow faking out full object nesting through bindings. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-5806) Extend expression grammar to allow advanced variables
[ https://issues.apache.org/jira/browse/LUCENE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053992#comment-14053992 ] Jack Conradson edited comment on LUCENE-5806 at 7/7/14 6:40 PM: Nevermind... Need more Mountain Dew. was (Author: jdconradson): Been a while since I've used ANTLR, but is fragment OBJECT : ID (ARRAY ARRAY*)? ; not equivalent to fragment OBJECT : ID ARRAY* ; Extend expression grammar to allow advanced variables --- Key: LUCENE-5806 URL: https://issues.apache.org/jira/browse/LUCENE-5806 Project: Lucene - Core Issue Type: Bug Reporter: Ryan Ernst Attachments: LUCENE-5806.patch We currently allow dots in variable names in expressions, so that we can fake out object access. We should extend this to allow array access as well (both integer and string keys). This would allow faking out full object nesting through bindings. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-5806) Extend expression grammar to allow advanced variables
[ https://issues.apache.org/jira/browse/LUCENE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053992#comment-14053992 ] Jack Conradson edited comment on LUCENE-5806 at 7/7/14 7:05 PM: fragment OBJECT : ID (ARRAY ARRAY*)? ; Cant the above fragment just be the below fragment? (I admit it's been a while since I've used ANTLR.) fragment OBJECT : ID ARRAY* ; was (Author: jdconradson): Nevermind... Need more Mountain Dew. Extend expression grammar to allow advanced variables --- Key: LUCENE-5806 URL: https://issues.apache.org/jira/browse/LUCENE-5806 Project: Lucene - Core Issue Type: Bug Reporter: Ryan Ernst Attachments: LUCENE-5806.patch We currently allow dots in variable names in expressions, so that we can fake out object access. We should extend this to allow array access as well (both integer and string keys). This would allow faking out full object nesting through bindings. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5806) Extend expression grammar to allow advanced variables
[
https://issues.apache.org/jira/browse/LUCENE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14054255#comment-14054255
]
Jack Conradson commented on LUCENE-5806:
If you want to normalize the tokens on-the-fly you can actually write a small
java snippet right into the grammar.
An example of this would be the following which removes both the single quote
characters from a string inline. The syntax should be in one of your books for
this ;).
STRING
@after
{
setText(getText().substring(1, getText().length() - 1).replace(,
\\).replace(\\', '));
}
: '\'' STRINGCHAR* '\''
;
The other option to consider would be not skipping over whitespace but actually
inserting WS!? (where the '!' removes the WS token from the parse tree tokens)
throughout the grammar for finer control. This may be beyond the scope of this
JIRA, though, and would potentially prevent something like doc[ 'foo' ].value
altogether. I'm not sure whether or not this is actually allowed in
JavaScript.
Extend expression grammar to allow advanced variables
---
Key: LUCENE-5806
URL: https://issues.apache.org/jira/browse/LUCENE-5806
Project: Lucene - Core
Issue Type: Bug
Reporter: Ryan Ernst
Attachments: LUCENE-5806.patch, LUCENE-5806.patch
We currently allow dots in variable names in expressions, so that we can
fake out object access. We should extend this to allow array access as well
(both integer and string keys). This would allow faking out full object
nesting through bindings.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-5806) Extend expression grammar to allow advanced variables
[
https://issues.apache.org/jira/browse/LUCENE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14054255#comment-14054255
]
Jack Conradson edited comment on LUCENE-5806 at 7/7/14 10:36 PM:
-
If you want to normalize the tokens on-the-fly you can actually write a small
java snippet right into the grammar.
An example of this would be the following which removes both the single quote
characters from a string inline. The syntax should be in one of your books for
this ;).
STRING
@after
{
setText(getText().substring(1, getText().length() - 1).replace(,
\\).replace(\\', '));
}
: '\'' STRINGCHAR* '\''
;
The other option to consider would be not skipping over whitespace but actually
inserting WS!? (where the '!' removes the WS token from the parse tree tokens)
throughout the grammar for finer control. This may be beyond the scope of this
JIRA, though, and would potentially prevent something like doc[ 'foo' ].value
altogether. I'm not sure whether or not this is actually allowed in
JavaScript.
Edit: Ah, because it's a fragment this is all moot.
was (Author: jdconradson):
If you want to normalize the tokens on-the-fly you can actually write a small
java snippet right into the grammar.
An example of this would be the following which removes both the single quote
characters from a string inline. The syntax should be in one of your books for
this ;).
STRING
@after
{
setText(getText().substring(1, getText().length() - 1).replace(,
\\).replace(\\', '));
}
: '\'' STRINGCHAR* '\''
;
The other option to consider would be not skipping over whitespace but actually
inserting WS!? (where the '!' removes the WS token from the parse tree tokens)
throughout the grammar for finer control. This may be beyond the scope of this
JIRA, though, and would potentially prevent something like doc[ 'foo' ].value
altogether. I'm not sure whether or not this is actually allowed in
JavaScript.
Extend expression grammar to allow advanced variables
---
Key: LUCENE-5806
URL: https://issues.apache.org/jira/browse/LUCENE-5806
Project: Lucene - Core
Issue Type: Bug
Reporter: Ryan Ernst
Attachments: LUCENE-5806.patch, LUCENE-5806.patch
We currently allow dots in variable names in expressions, so that we can
fake out object access. We should extend this to allow array access as well
(both integer and string keys). This would allow faking out full object
nesting through bindings.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-5991) SolrCloud: Add API to move leader off a Solr instance
[ https://issues.apache.org/jira/browse/SOLR-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973218#comment-13973218 ] Jack Conradson commented on SOLR-5991: -- +1 I can see both approaches being useful; however the second approach is the one that I would like to see. SolrCloud: Add API to move leader off a Solr instance - Key: SOLR-5991 URL: https://issues.apache.org/jira/browse/SOLR-5991 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 4.7.1 Reporter: Rich Mayfield Common maintenance chores require restarting Solr instances. The process of a shutdown becomes a whole lot more reliable if we can proactively move any leadership roles off of the Solr instance we are going to shut down. The leadership election process then runs immediately. I am not sure what the semantics should be (either accomplishes the goal but one of these might be best): * A call to tell a core to give up leadership (thus the next replica is chosen) * A call to specify which core should become the leader -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5410) Add fuzziness support to SimpleQueryParser
[
https://issues.apache.org/jira/browse/LUCENE-5410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880507#comment-13880507
]
Jack Conradson commented on LUCENE-5410:
I think this patch is a good start. Personally, there's two changes I'd like
to see.
* The first was discussed briefly before, but I'm strongly in favor of having
phrase slop be a different operator from fuzzy terms. I can see users wanting
phrase slop without wanting fuzzy terms.
* The second is I'd strongly prefer to see a separate method for the parsing
logic related to slop/fuzzy where it would account for checking if there's a
'~' and the integer afterwards. I think it will help clean up the consumeTerm
and consumePhrase methods significantly. Once a term/phrase has been found, if
fuzzy/slop is on, the method can be called to check for it.
Add fuzziness support to SimpleQueryParser
--
Key: LUCENE-5410
URL: https://issues.apache.org/jira/browse/LUCENE-5410
Project: Lucene - Core
Issue Type: Improvement
Components: core/queryparser
Affects Versions: 4.7
Reporter: Lee Hinman
Priority: Minor
Attachments: LUCENE-5410.patch, LUCENE-5410.patch
Original Estimate: 168h
Remaining Estimate: 168h
It would be nice to add fuzzy query support to the {{SimpleQueryParser}} so
that:
{{foo~2}}
generates a {{FuzzyQuery}} with an max edit distance of 2 and:
{{foo bar~2}}
generates a {{PhraseQuery}} with a slop of 2.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5490) Have Prefix Queries Use a MultiTermAnalyzer in SimpleQParser.
[ https://issues.apache.org/jira/browse/SOLR-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated SOLR-5490: - Attachment: SOLR-5490.patch I have attached a patch. Have Prefix Queries Use a MultiTermAnalyzer in SimpleQParser. - Key: SOLR-5490 URL: https://issues.apache.org/jira/browse/SOLR-5490 Project: Solr Issue Type: Improvement Reporter: Jack Conradson Priority: Minor Attachments: SOLR-5490.patch I would like to make a minor change to the SimpleQParser to use a MultiTermAnalyzer on prefix queries from TextFields. This way terms can be modified to be lower-cased or have accents removed from the TextField's analysis chain before creating the prefix query. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-5490) Have Prefix Queries Use a MultiTermAnalyzer in SimpleQParser.
Jack Conradson created SOLR-5490: Summary: Have Prefix Queries Use a MultiTermAnalyzer in SimpleQParser. Key: SOLR-5490 URL: https://issues.apache.org/jira/browse/SOLR-5490 Project: Solr Issue Type: Improvement Reporter: Jack Conradson Priority: Minor I would like to make a minor change to the SimpleQParser to use a MultiTermAnalyzer on prefix queries from TextFields. This way terms can be modified to be lower-cased or have accents removed from the TextField's analysis chain before creating the prefix query. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-5447) Add a QParserPlugin for Lucene's SimpleQueryParser.
Jack Conradson created SOLR-5447: Summary: Add a QParserPlugin for Lucene's SimpleQueryParser. Key: SOLR-5447 URL: https://issues.apache.org/jira/browse/SOLR-5447 Project: Solr Issue Type: Improvement Reporter: Jack Conradson Exactly as the title says, I would like to add a QParserPlugin to make Lucene's SimpleQueryParser available easily through Solr. I will add the SimpleQParserPlugin to the standard plugins list in QParserPlugin. The following options will be exposed: * A way to specify the fields to be queried on with boosts. * A way to override the default field if a different one is desired than what the schema has. * A way to set the default operator for whitespace as either 'AND' or 'OR.' * A way to set the enabled/disabled operators that are available through the SimpleQueryParser. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-5447) Add a QParserPlugin for Lucene's SimpleQueryParser.
[ https://issues.apache.org/jira/browse/SOLR-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated SOLR-5447: - Attachment: SOLR-5447.patch I have attached a patch. Add a QParserPlugin for Lucene's SimpleQueryParser. --- Key: SOLR-5447 URL: https://issues.apache.org/jira/browse/SOLR-5447 Project: Solr Issue Type: Improvement Reporter: Jack Conradson Attachments: SOLR-5447.patch Exactly as the title says, I would like to add a QParserPlugin to make Lucene's SimpleQueryParser available easily through Solr. I will add the SimpleQParserPlugin to the standard plugins list in QParserPlugin. The following options will be exposed: * A way to specify the fields to be queried on with boosts. * A way to override the default field if a different one is desired than what the schema has. * A way to set the default operator for whitespace as either 'AND' or 'OR.' * A way to set the enabled/disabled operators that are available through the SimpleQueryParser. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5336) Add a simple QueryParser to parse human-entered queries.
[
https://issues.apache.org/jira/browse/LUCENE-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819275#comment-13819275
]
Jack Conradson commented on LUCENE-5336:
Thanks for the feedback.
To answer the malformed input question --
If
foo bar
is given as the query, the double quote will be dropped, and if whitespace is
an operator it will make term queries for both 'foo' and 'bar' otherwise it
will make a single term query 'foo bar'
If
foobar
is given as the query, the double quote will be dropped, and term queries will
be made for both 'foo' and 'bar'
The reason it's done this way is because the parser only backtracks as far as
the malformed input (in this case the extraneous double quote), so 'foo' would
already be part of the query tree. This is because only a single pass is made
for each query. The parser could be changed to do two passes to remove
extraneous characters, but I believe that only makes the code more complex, and
doesn't necessarily interpret the query any better for a user since the
malformed character gives no hint as to what he/she really intended to do.
I will try to post another patch today or tomorrow.
I plan to do the following:
* Fix the Javadoc comment
* Add more tests for random operators
* Rename the class to SimpleQueryParser and rename the package to .simple
Add a simple QueryParser to parse human-entered queries.
Key: LUCENE-5336
URL: https://issues.apache.org/jira/browse/LUCENE-5336
Project: Lucene - Core
Issue Type: Improvement
Reporter: Jack Conradson
Attachments: LUCENE-5336.patch
I would like to add a new simple QueryParser to Lucene that is designed to
parse human-entered queries. This parser will operate on an entire entered
query using a specified single field or a set of weighted fields (using term
boost).
All features/operations in this parser can be enabled or disabled depending
on what is necessary for the user. A default operator may be specified as
either 'MUST' representing 'and' or 'SHOULD' representing 'or.' The
features/operations that this parser will include are the following:
* AND specified as '+'
* OR specified as '|'
* NOT specified as '-'
* PHRASE surrounded by double quotes
* PREFIX specified as '*'
* PRECEDENCE surrounded by '(' and ')'
* WHITESPACE specified as ' ' '\n' '\r' and '\t' will cause the default
operator to be used
* ESCAPE specified as '\' will allow operators to be used in terms
The key differences between this parser and other existing parsers will be
the following:
* No exceptions will be thrown, and errors in syntax will be ignored. The
parser will do a best-effort interpretation of any query entered.
* It uses minimal syntax to express queries. All available operators are
single characters or pairs of single characters.
* The parser is hand-written and in a single Java file making it easy to
modify.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5336) Add a simple QueryParser to parse human-entered queries.
[
https://issues.apache.org/jira/browse/LUCENE-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Conradson updated LUCENE-5336:
---
Attachment: LUCENE-5336.patch
Attached an updated version of the patch with the three modifications from my
previous comment.
Add a simple QueryParser to parse human-entered queries.
Key: LUCENE-5336
URL: https://issues.apache.org/jira/browse/LUCENE-5336
Project: Lucene - Core
Issue Type: Improvement
Reporter: Jack Conradson
Attachments: LUCENE-5336.patch, LUCENE-5336.patch
I would like to add a new simple QueryParser to Lucene that is designed to
parse human-entered queries. This parser will operate on an entire entered
query using a specified single field or a set of weighted fields (using term
boost).
All features/operations in this parser can be enabled or disabled depending
on what is necessary for the user. A default operator may be specified as
either 'MUST' representing 'and' or 'SHOULD' representing 'or.' The
features/operations that this parser will include are the following:
* AND specified as '+'
* OR specified as '|'
* NOT specified as '-'
* PHRASE surrounded by double quotes
* PREFIX specified as '*'
* PRECEDENCE surrounded by '(' and ')'
* WHITESPACE specified as ' ' '\n' '\r' and '\t' will cause the default
operator to be used
* ESCAPE specified as '\' will allow operators to be used in terms
The key differences between this parser and other existing parsers will be
the following:
* No exceptions will be thrown, and errors in syntax will be ignored. The
parser will do a best-effort interpretation of any query entered.
* It uses minimal syntax to express queries. All available operators are
single characters or pairs of single characters.
* The parser is hand-written and in a single Java file making it easy to
modify.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5334) Add Namespaces to Expressions Javascript Compiler
[ https://issues.apache.org/jira/browse/LUCENE-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817809#comment-13817809 ] Jack Conradson commented on LUCENE-5334: Thanks for committing, Ryan. Add Namespaces to Expressions Javascript Compiler - Key: LUCENE-5334 URL: https://issues.apache.org/jira/browse/LUCENE-5334 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Assignee: Ryan Ernst Priority: Minor Attachments: LUCENE-5334.patch I would like to add the concept of namespaces to the expressions javascript compiler using '.' as the operator. Example of namespace usage in functions: AccurateMath.sqrt(field) FastMath.sqrt(field) Example of namespace usage in variables: location.latitude location.longitude -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-5336) Add a simple QueryParser to parse human-entered queries.
Jack Conradson created LUCENE-5336:
--
Summary: Add a simple QueryParser to parse human-entered queries.
Key: LUCENE-5336
URL: https://issues.apache.org/jira/browse/LUCENE-5336
Project: Lucene - Core
Issue Type: Improvement
Reporter: Jack Conradson
I would like to add a new simple QueryParser to Lucene that is designed to
parse human-entered queries. This parser will operate on an entire entered
query using a specified single field or a set of weighted fields (using term
boost).
All features/operations in this parser can be enabled or disabled depending on
what is necessary for the user. A default operator may be specified as either
'MUST' representing 'and' or 'SHOULD' representing 'or.' The
features/operations that this parser will include are the following:
* AND specified as '+'
* OR specified as '|'
* NOT specified as '-'
* PHRASE surrounded by double quotes
* PREFIX specified as '*'
* PRECEDENCE surrounded by '(' and ')'
* WHITESPACE specified as ' ' '\n' '\r' and '\t' will cause the default
operator to be used
* ESCAPE specified as '\' will allow operators to be used in terms
The key differences between this parser and other existing parsers will be the
following:
* No exceptions will be thrown, and errors in syntax will be ignored. The
parser will do a best-effort interpretation of any query entered.
* It uses minimal syntax to express queries. All available operators are
single characters or pairs of single characters.
* The parser is hand-written and in a single Java file making it easy to modify.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5336) Add a simple QueryParser to parse human-entered queries.
[
https://issues.apache.org/jira/browse/LUCENE-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Conradson updated LUCENE-5336:
---
Attachment: LUCENE-5336.patch
I have attached a patch for this JIRA.
Add a simple QueryParser to parse human-entered queries.
Key: LUCENE-5336
URL: https://issues.apache.org/jira/browse/LUCENE-5336
Project: Lucene - Core
Issue Type: Improvement
Reporter: Jack Conradson
Attachments: LUCENE-5336.patch
I would like to add a new simple QueryParser to Lucene that is designed to
parse human-entered queries. This parser will operate on an entire entered
query using a specified single field or a set of weighted fields (using term
boost).
All features/operations in this parser can be enabled or disabled depending
on what is necessary for the user. A default operator may be specified as
either 'MUST' representing 'and' or 'SHOULD' representing 'or.' The
features/operations that this parser will include are the following:
* AND specified as '+'
* OR specified as '|'
* NOT specified as '-'
* PHRASE surrounded by double quotes
* PREFIX specified as '*'
* PRECEDENCE surrounded by '(' and ')'
* WHITESPACE specified as ' ' '\n' '\r' and '\t' will cause the default
operator to be used
* ESCAPE specified as '\' will allow operators to be used in terms
The key differences between this parser and other existing parsers will be
the following:
* No exceptions will be thrown, and errors in syntax will be ignored. The
parser will do a best-effort interpretation of any query entered.
* It uses minimal syntax to express queries. All available operators are
single characters or pairs of single characters.
* The parser is hand-written and in a single Java file making it easy to
modify.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-5334) Add Namespaces to Expressions Javascript Compiler
Jack Conradson created LUCENE-5334: -- Summary: Add Namespaces to Expressions Javascript Compiler Key: LUCENE-5334 URL: https://issues.apache.org/jira/browse/LUCENE-5334 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Priority: Minor I would like to add the concept of namespaces to the expressions javascript compiler using '.' as the operator. Example of namespace usage in functions: AccurateMath.sqrt(field) FastMath.sqrt(field) Example of namespace usage in variables: location.latitude location.longitude -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-5334) Add Namespaces to Expressions Javascript Compiler
[ https://issues.apache.org/jira/browse/LUCENE-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Conradson updated LUCENE-5334: --- Attachment: LUCENE-5334.patch Attached a patch with unit tests. Note that a large portion of the patch is the regenerated ANTLR lexer/parser. Add Namespaces to Expressions Javascript Compiler - Key: LUCENE-5334 URL: https://issues.apache.org/jira/browse/LUCENE-5334 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Priority: Minor Attachments: LUCENE-5334.patch I would like to add the concept of namespaces to the expressions javascript compiler using '.' as the operator. Example of namespace usage in functions: AccurateMath.sqrt(field) FastMath.sqrt(field) Example of namespace usage in variables: location.latitude location.longitude -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5334) Add Namespaces to Expressions Javascript Compiler
[ https://issues.apache.org/jira/browse/LUCENE-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816779#comment-13816779 ] Jack Conradson commented on LUCENE-5334: Hi Uwe, Thanks for taking a look. Unfortunately, for even small changes within the ANTLR grammar, a large number of differences will be created for the ANTLR generated lexer/parser code. With the assumption that ANTLR has correctly generated the lexer/parser code from the grammar, it should be fine. The unit tests seem to have pretty good coverage, so I think it should be good to go :) . --Jack Add Namespaces to Expressions Javascript Compiler - Key: LUCENE-5334 URL: https://issues.apache.org/jira/browse/LUCENE-5334 Project: Lucene - Core Issue Type: Improvement Reporter: Jack Conradson Priority: Minor Attachments: LUCENE-5334.patch I would like to add the concept of namespaces to the expressions javascript compiler using '.' as the operator. Example of namespace usage in functions: AccurateMath.sqrt(field) FastMath.sqrt(field) Example of namespace usage in variables: location.latitude location.longitude -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (LUCENE-5305) DocumentExpressionDictionaryTest Failure
Jack Conradson created LUCENE-5305:
--
Summary: DocumentExpressionDictionaryTest Failure
Key: LUCENE-5305
URL: https://issues.apache.org/jira/browse/LUCENE-5305
Project: Lucene - Core
Issue Type: Bug
Reporter: Jack Conradson
reproduce with: ant test -Dtestcase=DocumentExpressionDictionaryTest
-Dtests.method=testBasic -Dtests.seed=42EFE66B86DB4740 -Dtests.slow=true
-Dtests.locale=es_BO -Dtests.timezone=US/Central -Dtests.file.encoding=UTF-8
common.test:
[junit4:pickseed] Seed property 'tests.seed' already defined: 42EFE66B86DB4740
[junit4] JUnit4 says Привет! Master seed: 42EFE66B86DB4740
[junit4] Executing 1 suite with 1 JVM.
[junit4]
[junit4] Started J0 PID(2...@a8206617c3d8.ant.amazon.com).
[junit4] Suite:
org.apache.lucene.search.suggest.DocumentExpressionDictionaryTest
[junit4] 2 NOTE: reproduce with: ant test
-Dtestcase=DocumentExpressionDictionaryTest -Dtests.method=testBasic
-Dtests.seed=42EFE66B86DB4740 -Dtests.slow=true -Dtests.locale=es_BO
-Dtests.timezone=US/Central -Dtests.file.encoding=UTF-8
[junit4] ERROR 0.65s | DocumentExpressionDictionaryTest.testBasic
[junit4] Throwable #1: java.lang.IllegalArgumentException:
CompositeReader is not supported
[junit4]at
__randomizedtesting.SeedInfo.seed([42EFE66B86DB4740:E915FB7E5907C16E]:0)
[junit4]at
org.apache.lucene.search.suggest.DocumentExpressionDictionary$DocumentExpressionInputIterator.init(DocumentExpressionDictionary.java:110)
[junit4]at
org.apache.lucene.search.suggest.DocumentExpressionDictionary.getWordsIterator(DocumentExpressionDictionary.java:98)
[junit4]at
org.apache.lucene.search.suggest.DocumentExpressionDictionaryTest.testBasic(DocumentExpressionDictionaryTest.java:92)
[junit4]at java.lang.Thread.run(Thread.java:724)
[junit4] 2 NOTE: test params are: codec=Lucene41,
sim=RandomSimilarityProvider(queryNorm=false,coord=yes): {f1=DFR I(F)3(800.0)},
locale=es_BO, timezone=US/Central
[junit4] 2 NOTE: Mac OS X 10.8.5 x86_64/Oracle Corporation 1.7.0_25
(64-bit)/cpus=8,threads=1,free=121040408,total=161349632
[junit4] 2 NOTE: All tests run in this JVM:
[DocumentExpressionDictionaryTest]
[junit4] Completed in 1.05s, 1 test, 1 error FAILURES!
[junit4]
[junit4]
[junit4] Tests with failures:
[junit4] -
org.apache.lucene.search.suggest.DocumentExpressionDictionaryTest.testBasic
[junit4]
[junit4]
[junit4] JVM J0: 0.66 .. 2.36 = 1.70s
[junit4] Execution time total: 2.37 sec.
[junit4] Tests summary: 1 suite, 1 test, 1 error
BUILD FAILED
/Users/jdconrad/Code/LuceneSolr/lucene-solr/lucene/module-build.xml:60: The
following error occurred while executing this line:
/Users/jdconrad/Code/LuceneSolr/lucene-solr/lucene/common-build.xml:1259: The
following error occurred while executing this line:
/Users/jdconrad/Code/LuceneSolr/lucene-solr/lucene/common-build.xml:902: There
were test failures: 1 suite, 1 test, 1 error
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
