[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904402#comment-16904402 ] Neal Sidhwaney commented on SOLR-13645: --- Hi there, Any chance this patch could be reviewed? Thank you. Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895461#comment-16895461 ] Neal Sidhwaney commented on SOLR-13645: --- Just an FYI - I rebased on top of HEAD, no action necessary. THanks, Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13645: -- Attachment: SOLR-13645-Analytics-function-for-date-components.patch > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13633) Small types in analytics documentation
[ https://issues.apache.org/jira/browse/SOLR-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894670#comment-16894670 ] Neal Sidhwaney commented on SOLR-13633: --- Thanks, Munendra. The way I see it having a way to pass expressions in the doc that is more general will make it easier for people to get started using analytics without running into unexpected errors or queries not working. I'd prefer to use the existing example request provided in the docs but just change --data-urlencode to --data-binary, so if the user decides to move the query to a separate input json file everything will continue to work. Let me know what you think, and thanks! Neal > Small types in analytics documentation > -- > > Key: SOLR-13633 > URL: https://issues.apache.org/jira/browse/SOLR-13633 > Project: Solr > Issue Type: Task > Components: documentation >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Assignee: Munendra S N >Priority: Trivial > Attachments: SOLR-13633.patch > > > There are a couple typos in the analytics documentation commands that might > make someone just getting started scratch their head a bit. Upcoming 2 line > patch fixes them. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13633) Small types in analytics documentation
[
https://issues.apache.org/jira/browse/SOLR-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894663#comment-16894663
]
Neal Sidhwaney commented on SOLR-13633:
---
When I use --data-urlencode, it works if the analytics expression is on the
commadn line as you indicated, but --data-binary works whether the analytics
expression is on the command line or inside a separate file and fed to curl by
using '@', i.e:
{{curl -H POST --data-binary @/Users/nealsid/testanalytics.json
http://localhost:8983/solr/testcoll/select?q=Vehicle_Make:TOYOT}}
The analytics expressions can quickly grow unwieldly and long and editing them
on the command line isn't convenient, so --data-binary & feeding it from a
separate file seems better to me, IMO.
> Small types in analytics documentation
> --
>
> Key: SOLR-13633
> URL: https://issues.apache.org/jira/browse/SOLR-13633
> Project: Solr
> Issue Type: Task
> Components: documentation
>Affects Versions: 8.1.1
>Reporter: Neal Sidhwaney
>Assignee: Munendra S N
>Priority: Trivial
> Attachments: SOLR-13633.patch
>
>
> There are a couple typos in the analytics documentation commands that might
> make someone just getting started scratch their head a bit. Upcoming 2 line
> patch fixes them.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894377#comment-16894377 ] Neal Sidhwaney commented on SOLR-13645: --- Couldn't reproduce the failures, and ditn' see anything jumping out at me when re-reviewing. The changes are independent from SOLR-13643, but my git branch was based off the branch I used for that patch (it was impossible to test with my own build of Solr otherwise), so this time, I created a patch without doing that. > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13645: -- Attachment: SOLR-13645-Analytics-function-for-date-components.patch > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894319#comment-16894319 ] Neal Sidhwaney commented on SOLR-13645: --- Woops, not sure how this happened. Will take a look and reupload. Sorry about that! Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894318#comment-16894318 ] Neal Sidhwaney commented on SOLR-13643: --- The new names and making them private sounds good to me. Re: the type of _analyticsRequestManager. I'll admit I didn't have time to look back at the entire history of the code, but my best guess was that the methods in AnalyticsRequestComponent can't store state im AnalyticsRequestComponent to be referred to between calls to init/process, which is why they store it in ResponseBuilder. It may be somethin to abstrct away through an object that is passed to each call to init/prepare in the future) . But if ResponseBuilder knew about the types inside the analytics component, it would create a dependency from the core package on contrib. Thank you Munendra. Neal > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Assignee: Munendra S N >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894094#comment-16894094 ] Neal Sidhwaney commented on SOLR-13645: --- FYI(no action necessary) the patch has been updated to apply to HEAD. Thanks! Neal > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13645: -- Attachment: SOLR-13645-Analytics-function-for-date-components.patch > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894070#comment-16894070 ] Neal Sidhwaney commented on SOLR-13643: --- FYI, no action necessary, but I updated the patch to apply against HEAD. Thanks, Neal > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13643: -- Attachment: SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891428#comment-16891428 ] Neal Sidhwaney commented on SOLR-13643: --- Hello - any chance of this being pusehd? Let me know if I can do anything else, thanks. > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13645: -- Attachment: SOLR-13645-Analytics-function-for-date-components.patch Status: Patch Available (was: Patch Available) Added documentation to the analytics mapping functions page. > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889699#comment-16889699 ] Neal Sidhwaney commented on SOLR-13645: --- I removed the use of the APIs that didn't take locales and added ones that called getDefaultLocale. I spent some time making a patch that took the locale as a parameter (so it would add another parameter to the analytics function call from the client) but decided against it for a couple reasons: * The locale for date formatting really only makes sense in the context of using the Java short/medium/long styles, but not when the user is being explicit about the format string. * It ends up exposing more of the Java date interface through the analytics interface It's a judgement call, but, in my opinion, it simplifies the interface and parameters can be added later on if it's deemed necessary to support. Happy to discuss further if anyone feels it should be done differently. > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13645: -- Attachment: SOLR-13645-Analytics-function-for-date-components.patch > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch, > SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13629) Remove trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13629: -- Status: Patch Available (was: Open) > Remove trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove trailing whitespace, but preserves newlines if > the trailing whitespace was on a line with only whitespace. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13643: -- Attachment: SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch Status: Patch Available (was: Patch Available) > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13645: -- Attachment: SOLR-13645-Analytics-function-for-date-components.patch Status: Open (was: Open) > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13645) Add analytics function to format/extract components from dates
[ https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13645: -- Status: Patch Available (was: Open) > Add analytics function to format/extract components from dates > -- > > Key: SOLR-13645 > URL: https://issues.apache.org/jira/browse/SOLR-13645 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Minor > Attachments: SOLR-13645-Analytics-function-for-date-components.patch > > > It's helpful when running analytics to be able to do manipulation on dates > such as extracting month/day/year, converting to th week of year, etc, and > other formatting as many existing libraries provide. I have a patch going > through final testing that will add this to the analytcs library. > One thing I'm sort of amibvialent about is that it exposes that we use Java > date parsing in the analytics function, because the syntax is the same format > string that SimpleDateFormat accepts. Ideally there would be an abstraction > between the analytics language and what's used on the backend to implement > it. On the other hand, implementing a syntax for time/date formatting is > something that's been done many many times before, and this is not the only > place where Java date particulars show through. It would be good to revisit > this at a later time. > > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-13645) Add analytics function to format/extract components from dates
Neal Sidhwaney created SOLR-13645: - Summary: Add analytics function to format/extract components from dates Key: SOLR-13645 URL: https://issues.apache.org/jira/browse/SOLR-13645 Project: Solr Issue Type: New Feature Security Level: Public (Default Security Level. Issues are Public) Affects Versions: 8.1.1 Reporter: Neal Sidhwaney It's helpful when running analytics to be able to do manipulation on dates such as extracting month/day/year, converting to th week of year, etc, and other formatting as many existing libraries provide. I have a patch going through final testing that will add this to the analytcs library. One thing I'm sort of amibvialent about is that it exposes that we use Java date parsing in the analytics function, because the syntax is the same format string that SimpleDateFormat accepts. Ideally there would be an abstraction between the analytics language and what's used on the backend to implement it. On the other hand, implementing a syntax for time/date formatting is something that's been done many many times before, and this is not the only place where Java date particulars show through. It would be good to revisit this at a later time. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13643: -- Status: Patch Available (was: Open) > ResponseBuilder should provide accessors/setters for analytics response > handling > > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-13643) ResponseBuilder should provide accessors/setters for analytics response handling
Neal Sidhwaney created SOLR-13643: - Summary: ResponseBuilder should provide accessors/setters for analytics response handling Key: SOLR-13643 URL: https://issues.apache.org/jira/browse/SOLR-13643 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Components: Response Writers Affects Versions: 8.1.1 Reporter: Neal Sidhwaney Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside ResponseBuilder are accessed directly. Since they're in the same package, this is OK at compile tie. But when the Solr core and Analytics jars are loaded at runtime by Solr, they are done by different classloaders, which causes an IllegalAccessError during request handling. There must be soething different about y setup which is why I am running into this, but it seems like a good idea to abstract away the fields behinds setters/getters anyway. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13629) Remove trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13629: -- Status: Open (was: Patch Available) > Remove trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove trailing whitespace, but preserves newlines if > the trailing whitespace was on a line with only whitespace. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13634) ResponseBuilderTest should be in same package as ReponseBuilder
[ https://issues.apache.org/jira/browse/SOLR-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13634: -- Status: Open (was: Patch Available) > ResponseBuilderTest should be in same package as ReponseBuilder > --- > > Key: SOLR-13634 > URL: https://issues.apache.org/jira/browse/SOLR-13634 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13634.patch > > > While playing around with the analytics package, I noticed ResponseBuilder is > in Java package org.apache.solr.handler.component, whereas > ResponseBuilderTest is in org.apache.solr.handler. We should make them > consistent. I'll send a patch to move ResponseBuilderTest into the same > package as ResponsBuilder. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13634) ResponseBuilderTest should be in same package as ReponseBuilder
[ https://issues.apache.org/jira/browse/SOLR-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13634: -- Attachment: SOLR-13634.patch Status: Open (was: Open) > ResponseBuilderTest should be in same package as ReponseBuilder > --- > > Key: SOLR-13634 > URL: https://issues.apache.org/jira/browse/SOLR-13634 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13634.patch > > > While playing around with the analytics package, I noticed ResponseBuilder is > in Java package org.apache.solr.handler.component, whereas > ResponseBuilderTest is in org.apache.solr.handler. We should make them > consistent. I'll send a patch to move ResponseBuilderTest into the same > package as ResponsBuilder. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13634) ResponseBuilderTest should be in same package as ReponseBuilder
[ https://issues.apache.org/jira/browse/SOLR-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13634: -- Status: Patch Available (was: Open) > ResponseBuilderTest should be in same package as ReponseBuilder > --- > > Key: SOLR-13634 > URL: https://issues.apache.org/jira/browse/SOLR-13634 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13634.patch > > > While playing around with the analytics package, I noticed ResponseBuilder is > in Java package org.apache.solr.handler.component, whereas > ResponseBuilderTest is in org.apache.solr.handler. We should make them > consistent. I'll send a patch to move ResponseBuilderTest into the same > package as ResponsBuilder. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13633) Small types in analytics documentation
[ https://issues.apache.org/jira/browse/SOLR-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13633: -- Component/s: documentation > Small types in analytics documentation > -- > > Key: SOLR-13633 > URL: https://issues.apache.org/jira/browse/SOLR-13633 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: documentation >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13633.patch > > > There are a couple typos in the analytics documentation commands that might > make someone just getting started scratch their head a bit. Upcoming 2 line > patch fixes them. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-13634) ResponseBuilderTest should be in same package as ReponseBuilder
Neal Sidhwaney created SOLR-13634: - Summary: ResponseBuilderTest should be in same package as ReponseBuilder Key: SOLR-13634 URL: https://issues.apache.org/jira/browse/SOLR-13634 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Components: Server Affects Versions: 8.1.1 Reporter: Neal Sidhwaney While playing around with the analytics package, I noticed ResponseBuilder is in Java package org.apache.solr.handler.component, whereas ResponseBuilderTest is in org.apache.solr.handler. We should make them consistent. I'll send a patch to move ResponseBuilderTest into the same package as ResponsBuilder. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13633) Small types in analytics documentation
[ https://issues.apache.org/jira/browse/SOLR-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13633: -- Attachment: SOLR-13633.patch Status: Open (was: Open) > Small types in analytics documentation > -- > > Key: SOLR-13633 > URL: https://issues.apache.org/jira/browse/SOLR-13633 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13633.patch > > > There are a couple typos in the analytics documentation commands that might > make someone just getting started scratch their head a bit. Upcoming 2 line > patch fixes them. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13633) Small types in analytics documentation
[ https://issues.apache.org/jira/browse/SOLR-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13633: -- Status: Patch Available (was: Open) > Small types in analytics documentation > -- > > Key: SOLR-13633 > URL: https://issues.apache.org/jira/browse/SOLR-13633 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13633.patch > > > There are a couple typos in the analytics documentation commands that might > make someone just getting started scratch their head a bit. Upcoming 2 line > patch fixes them. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-13633) Small types in analytics documentation
Neal Sidhwaney created SOLR-13633: - Summary: Small types in analytics documentation Key: SOLR-13633 URL: https://issues.apache.org/jira/browse/SOLR-13633 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Affects Versions: 8.1.1 Reporter: Neal Sidhwaney There are a couple typos in the analytics documentation commands that might make someone just getting started scratch their head a bit. Upcoming 2 line patch fixes them. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13629) Remove trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13629: -- Description: I"m making some changes to analytics and noticed that the guidelines ask to create separate patches for formatting/whitespace changes. This issue is meant for the patch to remove trailing whitespace, but preserves newlines if the trailing whitespace was on a line with only whitespace. (was: I"m making some changes to analytics and noticed that the guidelines ask to create separate patches for formatting/whitespace changes. This issue is meant for the patch to remove whitespace only lines as well as trailing whitespace from lines. ) Summary: Remove trailing whitespace from analytics package (was: Remove whitespace only lines & trailing whitespace from analytics package) > Remove trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove trailing whitespace, but preserves newlines if > the trailing whitespace was on a line with only whitespace. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13629) Remove whitespace only lines & trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884530#comment-16884530 ] Neal Sidhwaney commented on SOLR-13629: --- Good catch; apologies for not being clear about my intent. I do want to only remove trailing whitespace as you mentioned, and not remove the whitespace-only lines entirely. > Remove whitespace only lines & trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove whitespace only lines as well as trailing > whitespace from lines. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13629) Remove whitespace only lines & trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13629: -- Status: Patch Available (was: Open) > Remove whitespace only lines & trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove whitespace only lines as well as trailing > whitespace from lines. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-13629) Remove whitespace only lines & trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neal Sidhwaney updated SOLR-13629: -- Attachment: SOLR-13629.patch > Remove whitespace only lines & trailing whitespace from analytics package > - > > Key: SOLR-13629 > URL: https://issues.apache.org/jira/browse/SOLR-13629 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.1.1 >Reporter: Neal Sidhwaney >Priority: Trivial > Attachments: SOLR-13629.patch > > > I"m making some changes to analytics and noticed that the guidelines ask to > create separate patches for formatting/whitespace changes. This issue is > meant for the patch to remove whitespace only lines as well as trailing > whitespace from lines. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-13629) Remove whitespace only lines & trailing whitespace from analytics package
Neal Sidhwaney created SOLR-13629: - Summary: Remove whitespace only lines & trailing whitespace from analytics package Key: SOLR-13629 URL: https://issues.apache.org/jira/browse/SOLR-13629 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Affects Versions: 8.1.1 Reporter: Neal Sidhwaney I"m making some changes to analytics and noticed that the guidelines ask to create separate patches for formatting/whitespace changes. This issue is meant for the patch to remove whitespace only lines as well as trailing whitespace from lines. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
