[jira] [Commented] (LUCENE-3587) Attempting to link to Java SE JavaDocs is competely unreliable
[ https://issues.apache.org/jira/browse/LUCENE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155749#comment-13155749 ] Robert Muir commented on LUCENE-3587: - Thanks for the alternative patch Steven. My question remains: what is the release process? If we are going to let this warning 'thru' but then the onus is on the RM to ensure that these links are in fact actually working for release candidate builds etc, then I'm against the patch, because its a step backwards from releasing (back to manual inspections of everything). Attempting to link to Java SE JavaDocs is competely unreliable -- Key: LUCENE-3587 URL: https://issues.apache.org/jira/browse/LUCENE-3587 Project: Lucene - Java Issue Type: Bug Reporter: Hoss Man Fix For: 3.6, 4.0 Attachments: LUCENE-3587.3x.patch, LUCENE-3587.keep-javadoc-link.3x.patch, LUCENE-3587.keep-javadoc-link.trunk.patch, LUCENE-3587.trunk.patch As noted several times since Oracle bought Sun, the canonical links to the Java SE JavaDocs have been unreliable and frequently cause warnings. Since we choose to fail the build on javadoc warnings, this is a serious problem for anyone trying to build from source if/when the package-list we reference in our common-build.xml is not available. We should eliminate this dependency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3587) Attempting to link to Java SE JavaDocs is competely unreliable
[ https://issues.apache.org/jira/browse/LUCENE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156003#comment-13156003 ] Hoss Man commented on LUCENE-3587: -- rmuir: I'm not sure where/how you got the impression that anything about the release process should change. If someone intended that, they should have said so yes/no? Personally i'd prefer my patch to sarowe's, because then the generated javadocs don't change depending on if/when the oracle URL is up. In general I disagree with sarowe's comment that ignoring the warning would mean we attempt to do the right thing -- because that implies that linking to the oracle.com URL is the right thing ... i think we should move away from that thinking. In my opinion the right thing is to build our own docs and not make assumptions about external docs. If the end user wants to build docs that hyperlink to oracle.com (or my.company.com/javadocs) that can be their choice, and if the URL is down and the linkage fails then the build.xml should fail to generate the docs because it couldn't do what the user asked it to. but honestly: either patch is better then what we've got now. Attempting to link to Java SE JavaDocs is competely unreliable -- Key: LUCENE-3587 URL: https://issues.apache.org/jira/browse/LUCENE-3587 Project: Lucene - Java Issue Type: Bug Reporter: Hoss Man Fix For: 3.6, 4.0 Attachments: LUCENE-3587.3x.patch, LUCENE-3587.keep-javadoc-link.3x.patch, LUCENE-3587.keep-javadoc-link.trunk.patch, LUCENE-3587.trunk.patch As noted several times since Oracle bought Sun, the canonical links to the Java SE JavaDocs have been unreliable and frequently cause warnings. Since we choose to fail the build on javadoc warnings, this is a serious problem for anyone trying to build from source if/when the package-list we reference in our common-build.xml is not available. We should eliminate this dependency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3587) Attempting to link to Java SE JavaDocs is competely unreliable
[ https://issues.apache.org/jira/browse/LUCENE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156034#comment-13156034 ] Steven Rowe commented on LUCENE-3587: - Hoss, whatever happened to LUCENE-3228 ? Attempting to link to Java SE JavaDocs is competely unreliable -- Key: LUCENE-3587 URL: https://issues.apache.org/jira/browse/LUCENE-3587 Project: Lucene - Java Issue Type: Bug Reporter: Hoss Man Fix For: 3.6, 4.0 Attachments: LUCENE-3587.3x.patch, LUCENE-3587.keep-javadoc-link.3x.patch, LUCENE-3587.keep-javadoc-link.trunk.patch, LUCENE-3587.trunk.patch As noted several times since Oracle bought Sun, the canonical links to the Java SE JavaDocs have been unreliable and frequently cause warnings. Since we choose to fail the build on javadoc warnings, this is a serious problem for anyone trying to build from source if/when the package-list we reference in our common-build.xml is not available. We should eliminate this dependency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3587) Attempting to link to Java SE JavaDocs is competely unreliable
[ https://issues.apache.org/jira/browse/LUCENE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156300#comment-13156300 ] Jason Rutherglen commented on LUCENE-3587: -- +1 on the patch. Javadoc external links should not destroy a build. Attempting to link to Java SE JavaDocs is competely unreliable -- Key: LUCENE-3587 URL: https://issues.apache.org/jira/browse/LUCENE-3587 Project: Lucene - Java Issue Type: Bug Reporter: Hoss Man Fix For: 3.6, 4.0 Attachments: LUCENE-3587.3x.patch, LUCENE-3587.keep-javadoc-link.3x.patch, LUCENE-3587.keep-javadoc-link.trunk.patch, LUCENE-3587.trunk.patch As noted several times since Oracle bought Sun, the canonical links to the Java SE JavaDocs have been unreliable and frequently cause warnings. Since we choose to fail the build on javadoc warnings, this is a serious problem for anyone trying to build from source if/when the package-list we reference in our common-build.xml is not available. We should eliminate this dependency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3587) Attempting to link to Java SE JavaDocs is competely unreliable
[ https://issues.apache.org/jira/browse/LUCENE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155622#comment-13155622 ] Robert Muir commented on LUCENE-3587: - +1 to the patch (i think its the best solution), on the condition that the release process doesn't change... this means we won't have these links on the website. I don't want to make releases any harder so I don't think putting the burden on the RM to do something crazy to get those links on the website is worth it... for the most part lucene's classes extend other lucene classes or java.lang.Object so I don't think this is a bad compromise at all. Attempting to link to Java SE JavaDocs is competely unreliable -- Key: LUCENE-3587 URL: https://issues.apache.org/jira/browse/LUCENE-3587 Project: Lucene - Java Issue Type: Bug Reporter: Hoss Man Fix For: 3.6, 4.0 Attachments: LUCENE-3587.3x.patch, LUCENE-3587.trunk.patch As noted several times since Oracle bought Sun, the canonical links to the Java SE JavaDocs have been unreliable and frequently cause warnings. Since we choose to fail the build on javadoc warnings, this is a serious problem for anyone trying to build from source if/when the package-list we reference in our common-build.xml is not available. We should eliminate this dependency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3587) Attempting to link to Java SE JavaDocs is competely unreliable
[ https://issues.apache.org/jira/browse/LUCENE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155634#comment-13155634 ] Steven Rowe commented on LUCENE-3587: - I think we should just stop failing the build for this particular warning. I'll work up a patch. Attempting to link to Java SE JavaDocs is competely unreliable -- Key: LUCENE-3587 URL: https://issues.apache.org/jira/browse/LUCENE-3587 Project: Lucene - Java Issue Type: Bug Reporter: Hoss Man Fix For: 3.6, 4.0 Attachments: LUCENE-3587.3x.patch, LUCENE-3587.trunk.patch As noted several times since Oracle bought Sun, the canonical links to the Java SE JavaDocs have been unreliable and frequently cause warnings. Since we choose to fail the build on javadoc warnings, this is a serious problem for anyone trying to build from source if/when the package-list we reference in our common-build.xml is not available. We should eliminate this dependency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
