[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449684#comment-13449684 ] Robert Muir commented on LUCENE-4354: - I committed this: but its not yet linked into any jenkins job, until this randomizedtesting jar can actually be downloaded from maven reliably. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448546#comment-13448546 ] Uwe Schindler commented on LUCENE-4354: --- Robert: I accidentally deleted your latest patch (I got confused with the order of patches). Can you reattach? add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447612#comment-13447612 ] Robert Muir commented on LUCENE-4354: - lucene/ fails because maven is pulling in an extra jar (duplicates removed below): {noformat} -maven-check-licenses: [echo] License check under: /home/rmuir/workspace/lucene-trunk/lucene/../maven-build/lucene [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/lucene/analysis/common/target/dependency/hamcrest-core-1.1.jar ... {noformat} solr/ fails due to several extra jars (duplicates removed below): {noformat} [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/analysis-extras/target/dependency/commons-logging-1.1.1.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/analysis-extras/target/dependency/hamcrest-core-1.1.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/analysis-extras/target/dependency/javax.servlet-3.0.0.v201112011016.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/analysis-extras/target/dependency/servlet-api-2.4.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/clustering/target/dependency/ehcache-core-1.7.2.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/clustering/target/dependency/jdom-1.1.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/clustering/target/dependency/morfologik-stemming-1.5.1.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/clustering/target/dependency/rome-1.0.0.jar [licenses] MISSING sha1 checksum file for: /home/rmuir/workspace/lucene-trunk/maven-build/solr/contrib/clustering/target/dependency/rome-fetcher-1.0.0.jar {noformat} add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447617#comment-13447617 ] Chris Male commented on LUCENE-4354: hamcrest is a transitive dependency of junit, we'll need to exclude that specifically in our poms. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447622#comment-13447622 ] Robert Muir commented on LUCENE-4354: - Yeah some of this might be false fails. i just wanted to get it up here as a prototype. I think its a good check we could add to e.g. our nightly jenkins runs once we get it sorted out to prevent problems. Its true running the tests with maven is good: but this would fail in a more obvious way (e.g. the tika situation), and wouldn't rely upon having tests that ensure all dependencies are correct (I know we don't have this today!) add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447628#comment-13447628 ] selckin commented on LUCENE-4354: - If you add '-DincludeScope=runtime' to the copy call, quite a few disappear, one hamcrest still there, probably from test-framework ? Also ant clean doesn't remove the copied jars add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447630#comment-13447630 ] Robert Muir commented on LUCENE-4354: - I think any dependencies should be checked? I don't think we should hide ones only used for test-framework or whatever (its still a maven artifact published out there, unless that is intended to change). 'ant clean' doesnt remove anything maven-related: there is a maven-related clean task (clean-maven-build) that does that, I think its documented in the README.maven add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447634#comment-13447634 ] Chris Male commented on LUCENE-4354: Ignoring the scope issue, the validation has revealed valid issues. For example the jdom, rome and servlet dependencies all have different versions to our license files. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447633#comment-13447633 ] selckin commented on LUCENE-4354: - Well only things from the runtime scope will end up in the war, and i thought i saw other issues where the policy was to ignore license and other checks for build only jars. But i guess it can't hurt to force all the deps to be the same, so ignore me add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447638#comment-13447638 ] Chris Male commented on LUCENE-4354: It's not just an issue of what ends up in the war since we also publish individual artifacts / poms. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447639#comment-13447639 ] Robert Muir commented on LUCENE-4354: - Right, the check here is the same set of license exclusions etc used for the 'normal artifacts' that are put on the apache download site. Maven shouldnt have any extra dependencies beyond that. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447640#comment-13447640 ] Uwe Schindler commented on LUCENE-4354: --- There is a trick with maven-ant-tasks to get a refid to a fileset/ with all maven dependencies (something like that, maybe Steven knows how to set this up): {code:xml} maven:dependencies xmlns:maven=urn:maven-artifact-ant filesetId=foobar.fileset useScope=runtime/ {code} After that the ANT fileset should point (like ivy:cachefilset) to all dependency jars. It should be easy to run the license checker on top of this fileset (refid=foobar.fileset). See also for a code example: http://ptrthomas.wordpress.com/2009/03/08/why-you-should-use-the-maven-ant-tasks-instead-of-maven-or-ivy/ add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447641#comment-13447641 ] Robert Muir commented on LUCENE-4354: - Thanks Uwe... this looks like the way to go to remove the mvn.exe hack :) add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447673#comment-13447673 ] Uwe Schindler commented on LUCENE-4354: --- Robert: Maybe we do the check per module? We can do this after the create-maven-artifacts module target. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447691#comment-13447691 ] Robert Muir commented on LUCENE-4354: - Thanks selckin: I think I will let Steve or someone more familiar review your patch. About the commons-compress: there is a problem somewhere. Some things are depending on 1.2 and others on 1.3. But nothing should be depending on 1.2: Thats causing the failure. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447698#comment-13447698 ] Uwe Schindler commented on LUCENE-4354: --- Looks fine, works almost on windows, stupidity is the restrict thing that matches also on the file separator: {code:xml} rsel:not rsel:or rsel:name name=**/lucene-*.jar handledirsep=true/ rsel:name name=**/solr-*.jar handledirsep=true/ /rsel:or /rsel:not {code} The handledirsep=true is the needed magic. Otherwise looks fine, only some dependnecies are wrong. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447712#comment-13447712 ] selckin commented on LUCENE-4354: - Since transitive dependencies are ignored so aggressively, how about the reverse? dependencies present in lucene but not in maven? Tests should catch mosts of them i guess? add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447714#comment-13447714 ] Chris Male commented on LUCENE-4354: Yeah I think tests should be catching them. Do you have any examples? add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447716#comment-13447716 ] Robert Muir commented on LUCENE-4354: - selckin: that problem is more than maven actually, e.g. things like SOLR-3736. Really you are right, if we have a dependency we should be testing that its working :) But its good to check the inverse, at least we know we are not depending on things we didnt know about, or the wrong versions: this only complements that. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447736#comment-13447736 ] Uwe Schindler commented on LUCENE-4354: --- Looks fine now for Lucene! For consistency with the other maven macros, i would rename macrodef name=validate-maven-dependencies to macrodef name=m2-validate-dependencies, then it is consistent with others. And maybe move it up to be next to each other, so not distributes over whole common-build.xml. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447739#comment-13447739 ] Uwe Schindler commented on LUCENE-4354: --- One thing that is annoying: {noformat} dist-maven-common: [artifact:dependencies] [INFO] snapshot org.apache.lucene:lucene-core:5.0-SNAPSHOT: checking for updates from sonatype.releases [artifact:dependencies] [INFO] snapshot org.apache.lucene:lucene-core:5.0-SNAPSHOT: checking for updates from apache.snapshots [artifact:dependencies] Downloading: org/apache/lucene/lucene-core/5.0-SNAPSHOT/lucene-core-5.0-20120903.170333-49.pom from reposito ry apache.snapshots at http://repository.apache.org/snapshots [artifact:dependencies] Downloading: org/apache/lucene/lucene-core/5.0-SNAPSHOT/lucene-core-5.0-20120903.170333-49.jar from reposito ry apache.snapshots at http://repository.apache.org/snapshots [artifact:dependencies] Transferring 2200K from apache.snapshots [echo] Checking Maven dependencies for C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr2\lucene\build\poms\lucene\test-frame work\pom.xml: com\carrotsearch\randomizedtesting\randomizedtesting-runner\2.0.0.rc5\randomizedtesting-runner-2.0.0.rc5.jar;junit\jun it\4.10\junit-4.10.jar;org\apache\lucene\lucene-core\5.0-SNAPSHOT\lucene-core-5.0-20120903.170333-49.jar [licenses] Scanned 2 JAR file(s) for licenses (in 0.01s.), 0 error(s). [artifact:install-provider] Installing provider: org.apache.maven.wagon:wagon-ssh:jar:1.0-beta-7:runtime [artifact:deploy] Deploying to file://C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr2\lucene\dist\maven [artifact:deploy] [INFO] Retrieving previous build number from ${m2.repository.id} [artifact:deploy] [INFO] repository metadata for: 'snapshot org.apache.lucene:lucene-test-framework:5.0-SNAPSHOT' could not be found on repository: ${m2.repository.id}, so will be created [artifact:deploy] Uploading: org/apache/lucene/lucene-test-framework/5.0-SNAPSHOT/lucene-test-framework-5.0-20120904.150305-1.jar to repository ${m2.repository.id} at file://C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr2\lucene\dist\maven [artifact:deploy] Transferring 5945K from ${m2.repository.id} [artifact:deploy] Uploaded 5945K [artifact:deploy] [INFO] Retrieving previous metadata from ${m2.repository.id} [artifact:deploy] [INFO] repository metadata for: 'artifact org.apache.lucene:lucene-test-framework' could not be found on repositor y: ${m2.repository.id}, so will be created [artifact:deploy] [INFO] Uploading repository metadata for: 'artifact org.apache.lucene:lucene-test-framework' [artifact:deploy] [INFO] Retrieving previous metadata from ${m2.repository.id} [artifact:deploy] [INFO] repository metadata for: 'snapshot org.apache.lucene:lucene-test-framework:5.0-SNAPSHOT' could not be found on repository: ${m2.repository.id}, so will be created [artifact:deploy] [INFO] Uploading repository metadata for: 'snapshot org.apache.lucene:lucene-test-framework:5.0-SNAPSHOT' [artifact:deploy] [INFO] Uploading project information for lucene-test-framework 5.0-20120904.150305-1 [artifact:deploy] [INFO] Retrieving previous build number from ${m2.repository.id} [artifact:deploy] Uploading: org/apache/lucene/lucene-test-framework/5.0-SNAPSHOT/lucene-test-framework-5.0-20120904.150305-1-source s.jar to repository ${m2.repository.id} at file://C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr2\lucene\dist\maven [artifact:deploy] Transferring 5818K from ${m2.repository.id} [artifact:deploy] Uploaded 5818K [artifact:deploy] [INFO] Retrieving previous build number from ${m2.repository.id} [artifact:deploy] Uploading: org/apache/lucene/lucene-test-framework/5.0-SNAPSHOT/lucene-test-framework-5.0-20120904.150305-1-javado c.jar to repository ${m2.repository.id} at file://C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr2\lucene\dist\maven [artifact:deploy] Transferring 695K from ${m2.repository.id} [artifact:deploy] Uploaded 695K {noformat} See first few lines. After nuking ~/.m2 it downloads all dependency JAR files from maven central, but it also (!) downloads snapshot Lucene JARS, although it built them before. Can we supress this. Its not a problem for the license checker (because it excludes all those JARS), but i makes me nervous... add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447741#comment-13447741 ] Robert Muir commented on LUCENE-4354: - I have no idea: thats a maven issue (its not really an issue with this license checking). add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447752#comment-13447752 ] Robert Muir commented on LUCENE-4354: - I opened LUCENE-4356 to fix the commons-compress (there are 3 versions being used, which is crazy) add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447756#comment-13447756 ] Robert Muir commented on LUCENE-4354: - I also tripped LUCENE-4357. I think because i depend on compile-tools (not common.compile-tools, and icu redefines that). So the ICU tools got compiled too (which normally dont), and then forbidden APIs tripped. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447766#comment-13447766 ] Steven Rowe commented on LUCENE-4354: - bq. After nuking ~/.m2 it downloads all dependency JAR files from maven central, but it also downloads snapshot Lucene JARS, although it built them before. Can we supress this. Its not a problem for the license checker (because it excludes all those JARS), but i makes me nervous... This happens because the Apache snapshot repo is listed in the poms, but it shouldn't be - we should never download Lucene/Solr snapshots as part of the build. I'll open an issue. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447770#comment-13447770 ] Steven Rowe commented on LUCENE-4354: - bq. the Apache snapshot repo is listed in the poms, but it shouldn't be - we should never download Lucene/Solr snapshots as part of the build. I'll open an issue. LUCENE-4358 add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447776#comment-13447776 ] Robert Muir commented on LUCENE-4354: - I will update the patch shortly merging in the changes to LUCENE-4356. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448080#comment-13448080 ] Robert Muir commented on LUCENE-4354: - The test part of this patch seems hung on some ancient maven bugs. I'll leave it be: but we need to apply the fixes to the poms themselves (the dev-tools part of this patch) because the maven dependencies are currently not correct. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448083#comment-13448083 ] Robert Muir commented on LUCENE-4354: - I committed this part to trunk. Hopefully i didnt break anything (I tested by generate-maven-artifacts plus using my checker). I'll merge to 4.x with the same test. If there are bugs just revert my commits, i just want the dependencies fixed first. the check itself is less important. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448085#comment-13448085 ] Uwe Schindler commented on LUCENE-4354: --- OK! Maybe, we maybe only need a heavy commiting branch for the valiation task! add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448087#comment-13448087 ] Uwe Schindler commented on LUCENE-4354: --- OK, can you add the half-baked check as a patch? Maybe Steven can help to also fix the validation one. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448095#comment-13448095 ] Robert Muir commented on LUCENE-4354: - for 4.x we have to fix tika again. now maven depends on 1.1. But the upgrade to 1.2 was backported, so the checker currently fails (even with the patch here). Ill fix it to 1.2 and see if thats enough... add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448103#comment-13448103 ] Robert Muir commented on LUCENE-4354: - ok same patch committed to 4.x too, only with the tika bump from 1.1 to 1.2 to match Jan's commit of r1380079. The latest patch up here passes for lucene and solr on both branches now. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448202#comment-13448202 ] Robert Muir commented on LUCENE-4354: - Hi Uwe, thanks! I think we can call the internal task -validate-maven-dependencies and remove its depends, since the top-level one already depends on generate-maven-artifacts. so this work is already done... this should also make my permgen happier. add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4354) add validate-maven task to check maven dependencies
[ https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448418#comment-13448418 ] Robert Muir commented on LUCENE-4354: - {quote} not even generate-maven-artifacts passes without more permgen (Windows 7 64). {quote} Thats because you were a bit over-eager here: {noformat} - target name=generate-maven-artifacts - depends=install-maven-tasks, filter-pom-templates, package, javadocs + target name=generate-maven-artifacts {noformat} instead, depend on install-maven-tasks here (it seems redundant, its not). its then loaded once, and the property is passed in the uptodate.and.compiled.properties and you will see in the log that its task is only installed once rather than over-and-over :) I fixed this a while ago and i fixed it locally in your patch (along with similar stuff) and it clears this up fine. I'll take care of it (with a note not to remove the depends), I just wanted to explain! add validate-maven task to check maven dependencies --- Key: LUCENE-4354 URL: https://issues.apache.org/jira/browse/LUCENE-4354 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-4354-dep-fix.patch, LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch We had a situation where the maven artifacts depended on the wrong version of tika: we should test that the maven dependencies are correct. An easy way to do this is to force it to download all of its dependencies, and then run our existing license checks over that. This currently fails: maven is bringing in some extra 3rd party libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org