[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[ https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689556#comment-13689556 ] Commit Tag Bot commented on LUCENE-5063: [branch_4x commit] jpountz http://svn.apache.org/viewvc?view=revisionrevision=1495146 LUCENE-5063: ...continuation. Allow GrowableWriter to store negative values - Key: LUCENE-5063 URL: https://issues.apache.org/jira/browse/LUCENE-5063 Project: Lucene - Core Issue Type: Improvement Reporter: Adrien Grand Assignee: Adrien Grand Priority: Trivial Fix For: 4.4 Attachments: LUCENE-5063.patch, LUCENE-5063.patch For some use-cases, it would be convenient to be able to store negative values in a GrowableWriter, for example to use it in FieldCache: The first term is the minimum value and one could use a GrowableWriter to store deltas between this minimum value and the current value. (The need for negative values comes from the fact that maxValue - minValue might be larger than Long.MAX_VALUE.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[ https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689590#comment-13689590 ] Commit Tag Bot commented on LUCENE-5063: [trunk commit] jpountz http://svn.apache.org/viewvc?view=revisionrevision=1495156 LUCENE-5063: Compress integer and long field caches and remove FieldCache.get(Byte|Short)s, default parsers and related class/methods (merged from r1494753 and r1495146). Allow GrowableWriter to store negative values - Key: LUCENE-5063 URL: https://issues.apache.org/jira/browse/LUCENE-5063 Project: Lucene - Core Issue Type: Improvement Reporter: Adrien Grand Assignee: Adrien Grand Priority: Trivial Fix For: 4.4 Attachments: LUCENE-5063.patch, LUCENE-5063.patch For some use-cases, it would be convenient to be able to store negative values in a GrowableWriter, for example to use it in FieldCache: The first term is the minimum value and one could use a GrowableWriter to store deltas between this minimum value and the current value. (The need for negative values comes from the fact that maxValue - minValue might be larger than Long.MAX_VALUE.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[
https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686561#comment-13686561
]
Robert Muir commented on LUCENE-5063:
-
On one hand we pay the price of an add:
{code}
@Override
public long get(int docID) {
- return values[docID];
+ return minValue + values.get(docID);
}
{code}
But we get no benefit...
{code}
+ * pBeware that this class will accept to set negative values but in order
+ * to do this, it will grow the number of bits per value to 64.
{code}
This doesn't seem right...
Allow GrowableWriter to store negative values
-
Key: LUCENE-5063
URL: https://issues.apache.org/jira/browse/LUCENE-5063
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Trivial
Fix For: 4.4
Attachments: LUCENE-5063.patch
For some use-cases, it would be convenient to be able to store negative
values in a GrowableWriter, for example to use it in FieldCache: The first
term is the minimum value and one could use a GrowableWriter to store deltas
between this minimum value and the current value. (The need for negative
values comes from the fact that maxValue - minValue might be larger than
Long.MAX_VALUE.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[
https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686594#comment-13686594
]
Robert Muir commented on LUCENE-5063:
-
i see, so we only need negatives in growablewriter for the case where we'd use
64 bpv for longs anyway.
Can we add a comment?
Also, we start at 4bpv here, but we don't bitpack for byte/short too? it could
be a little unintuitive that using long takes less ram than byte :)
Or, maybe FC should only have a 'long' API to better match DV?
{quote}
In order to not make field cache loading too slow, the GrowableWriters are
created with an acceptable overhead ratio of 50% so that they can grow the
number of bits per value quickly in order not to perform too much resizing.
{quote}
This is consistent with SortedDocValuesImpl, except SortedDocValuesImpl has a
'startBPV' of 1, whereas its 4 here. Maybe we should use 1 here too?
Allow GrowableWriter to store negative values
-
Key: LUCENE-5063
URL: https://issues.apache.org/jira/browse/LUCENE-5063
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Trivial
Fix For: 4.4
Attachments: LUCENE-5063.patch
For some use-cases, it would be convenient to be able to store negative
values in a GrowableWriter, for example to use it in FieldCache: The first
term is the minimum value and one could use a GrowableWriter to store deltas
between this minimum value and the current value. (The need for negative
values comes from the fact that maxValue - minValue might be larger than
Long.MAX_VALUE.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[ https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686622#comment-13686622 ] Adrien Grand commented on LUCENE-5063: -- bq. i see, so we only need negatives in growablewriter for the case where we'd use 64 bpv for longs anyway. Exactly. Negative values in a GrowableWriter are more 64-bits unsigned values than actual negative values. bq. Or, maybe FC should only have a 'long' API to better match DV? Are you talking about removing all get(Bytes|Shorts|Ints|Floats|Doubles) and only have getLongs which would return a NumericDocValues instance? Indeed I think it would make things simpler and more consistent (eg. comparators and FieldCacheRangeFilter) but this looks like a big change! bq. This is consistent with SortedDocValuesImpl, except SortedDocValuesImpl has a 'startBPV' of 1, whereas its 4 here. Maybe we should use 1 here too? Agreed. Allow GrowableWriter to store negative values - Key: LUCENE-5063 URL: https://issues.apache.org/jira/browse/LUCENE-5063 Project: Lucene - Core Issue Type: Improvement Reporter: Adrien Grand Assignee: Adrien Grand Priority: Trivial Fix For: 4.4 Attachments: LUCENE-5063.patch For some use-cases, it would be convenient to be able to store negative values in a GrowableWriter, for example to use it in FieldCache: The first term is the minimum value and one could use a GrowableWriter to store deltas between this minimum value and the current value. (The need for negative values comes from the fact that maxValue - minValue might be larger than Long.MAX_VALUE.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[
https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686627#comment-13686627
]
Robert Muir commented on LUCENE-5063:
-
{quote}
Indeed I think it would make things simpler and more consistent (eg.
comparators and FieldCacheRangeFilter) but this looks like a big change!
{quote}
It doesnt need to hold up this issue. we can make a followup issue for that.
Maybe we should do something about the Bytes/Shorts though here...
Allow GrowableWriter to store negative values
-
Key: LUCENE-5063
URL: https://issues.apache.org/jira/browse/LUCENE-5063
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Trivial
Fix For: 4.4
Attachments: LUCENE-5063.patch
For some use-cases, it would be convenient to be able to store negative
values in a GrowableWriter, for example to use it in FieldCache: The first
term is the minimum value and one could use a GrowableWriter to store deltas
between this minimum value and the current value. (The need for negative
values comes from the fact that maxValue - minValue might be larger than
Long.MAX_VALUE.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[ https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686807#comment-13686807 ] Adrien Grand commented on LUCENE-5063: -- bq. Maybe we should do something about the Bytes/Shorts though here... Given that we don't even have numeric support (they are just encoded/decoded as strings) for these types, maybe we should just remove or deprecate them? Allow GrowableWriter to store negative values - Key: LUCENE-5063 URL: https://issues.apache.org/jira/browse/LUCENE-5063 Project: Lucene - Core Issue Type: Improvement Reporter: Adrien Grand Assignee: Adrien Grand Priority: Trivial Fix For: 4.4 Attachments: LUCENE-5063.patch For some use-cases, it would be convenient to be able to store negative values in a GrowableWriter, for example to use it in FieldCache: The first term is the minimum value and one could use a GrowableWriter to store deltas between this minimum value and the current value. (The need for negative values comes from the fact that maxValue - minValue might be larger than Long.MAX_VALUE.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[
https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686893#comment-13686893
]
Michael McCandless commented on LUCENE-5063:
{quote}
bq. Maybe we should do something about the Bytes/Shorts though here...
Given that we don't even have numeric support (they are just encoded/decoded as
strings) for these types, maybe we should just remove or deprecate them?
{quote}
+1
Allow GrowableWriter to store negative values
-
Key: LUCENE-5063
URL: https://issues.apache.org/jira/browse/LUCENE-5063
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Trivial
Fix For: 4.4
Attachments: LUCENE-5063.patch
For some use-cases, it would be convenient to be able to store negative
values in a GrowableWriter, for example to use it in FieldCache: The first
term is the minimum value and one could use a GrowableWriter to store deltas
between this minimum value and the current value. (The need for negative
values comes from the fact that maxValue - minValue might be larger than
Long.MAX_VALUE.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5063) Allow GrowableWriter to store negative values
[ https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686915#comment-13686915 ] Michael McCandless commented on LUCENE-5063: +1, patch looks good! Allow GrowableWriter to store negative values - Key: LUCENE-5063 URL: https://issues.apache.org/jira/browse/LUCENE-5063 Project: Lucene - Core Issue Type: Improvement Reporter: Adrien Grand Assignee: Adrien Grand Priority: Trivial Fix For: 4.4 Attachments: LUCENE-5063.patch For some use-cases, it would be convenient to be able to store negative values in a GrowableWriter, for example to use it in FieldCache: The first term is the minimum value and one could use a GrowableWriter to store deltas between this minimum value and the current value. (The need for negative values comes from the fact that maxValue - minValue might be larger than Long.MAX_VALUE.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
