[jira] [Commented] (LUCENE-5204) Make Directory easier to wrap
[
https://issues.apache.org/jira/browse/LUCENE-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765628#comment-13765628
]
ASF subversion and git services commented on LUCENE-5204:
-
Commit 1522665 from [~jpountz] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1522665 ]
LUCENE-5204: Make Directory easier to wrap.
Make Directory easier to wrap
-
Key: LUCENE-5204
URL: https://issues.apache.org/jira/browse/LUCENE-5204
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
Attachments: LUCENE-5204.patch, LUCENE-5204.patch
We have a few DirectoryWrapper implementations such as
RateLimitedDirectoryWrapper and MockDirectoryWrapper. However, the Directory
class is not straightforward to wrap since it already has logic for getting
and setting the lock factory, so wrappers need to decide whether they should
forward lock handling to the delegate or handle it themselves.
I would like to move the locking logic out of the Directory class and to have
a base {{FilterDirectory}} that could be extended by other directory wrapper
impls.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5204) Make Directory easier to wrap
[
https://issues.apache.org/jira/browse/LUCENE-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765617#comment-13765617
]
ASF subversion and git services commented on LUCENE-5204:
-
Commit 1522661 from [~jpountz] in branch 'dev/trunk'
[ https://svn.apache.org/r1522661 ]
LUCENE-5204: Make Directory easier to wrap.
Make Directory easier to wrap
-
Key: LUCENE-5204
URL: https://issues.apache.org/jira/browse/LUCENE-5204
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
Attachments: LUCENE-5204.patch, LUCENE-5204.patch
We have a few DirectoryWrapper implementations such as
RateLimitedDirectoryWrapper and MockDirectoryWrapper. However, the Directory
class is not straightforward to wrap since it already has logic for getting
and setting the lock factory, so wrappers need to decide whether they should
forward lock handling to the delegate or handle it themselves.
I would like to move the locking logic out of the Directory class and to have
a base {{FilterDirectory}} that could be extended by other directory wrapper
impls.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5204) Make Directory easier to wrap
[
https://issues.apache.org/jira/browse/LUCENE-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764908#comment-13764908
]
Robert Muir commented on LUCENE-5204:
-
Can we make FilterDirectory package-private?
I know we have done this FilterXXX strategy with other apis, but delegating
over an abstract class is always broken by definition... Its a little scary to
expose this as a supported API for directory.
Make Directory easier to wrap
-
Key: LUCENE-5204
URL: https://issues.apache.org/jira/browse/LUCENE-5204
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
Attachments: LUCENE-5204.patch
We have a few DirectoryWrapper implementations such as
RateLimitedDirectoryWrapper and MockDirectoryWrapper. However, the Directory
class is not straightforward to wrap since it already has logic for getting
and setting the lock factory, so wrappers need to decide whether they should
forward lock handling to the delegate or handle it themselves.
I would like to move the locking logic out of the Directory class and to have
a base {{FilterDirectory}} that could be extended by other directory wrapper
impls.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5204) Make Directory easier to wrap
[
https://issues.apache.org/jira/browse/LUCENE-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764910#comment-13764910
]
Robert Muir commented on LUCENE-5204:
-
Or at least mark it internal with a huge huge huge warning, thats ok too. I
just think all these delegators are going to bite us bigtime.
Make Directory easier to wrap
-
Key: LUCENE-5204
URL: https://issues.apache.org/jira/browse/LUCENE-5204
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
Attachments: LUCENE-5204.patch
We have a few DirectoryWrapper implementations such as
RateLimitedDirectoryWrapper and MockDirectoryWrapper. However, the Directory
class is not straightforward to wrap since it already has logic for getting
and setting the lock factory, so wrappers need to decide whether they should
forward lock handling to the delegate or handle it themselves.
I would like to move the locking logic out of the Directory class and to have
a base {{FilterDirectory}} that could be extended by other directory wrapper
impls.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
