[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048247#comment-15048247 ] Mikhail Khludnev commented on LUCENE-5868: -- Suggestions for [javadoc|https://builds.apache.org/job/Lucene-Artifacts-5.x/javadoc/join/org/apache/lucene/search/join/JoinUtil.html#createJoinQuery%28java.lang.String,%20boolean,%20java.lang.String,%20org.apache.lucene.document.FieldType.NumericType,%20org.apache.lucene.search.Query,%20org.apache.lucene.search.IndexSearcher,%20org.apache.lucene.search.join.ScoreMode%29] are accepted > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[
https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048745#comment-15048745
]
Mikhail Khludnev commented on LUCENE-5868:
--
{code}
Index: lucene/common-build.xml
===
--- lucene/common-build.xml (revision 1718516)
+++ lucene/common-build.xml (working copy)
@@ -321,6 +321,12 @@
+
+
+
+
+
+
{code}
This amendment will keep me from such mistakes in 5.x. Let me know if there is
a more regular approach.
> JoinUtil support for NUMERIC docValues fields
> --
>
> Key: LUCENE-5868
> URL: https://issues.apache.org/jira/browse/LUCENE-5868
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Minor
> Fix For: 5.5
>
> Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch,
> LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch,
> LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch,
> LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff
>
>
> while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at
> least.
> I plan to provide test/patch. It might be important, because Solr's join can
> do that. Please vote if you care!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047163#comment-15047163 ] Mikhail Khludnev commented on LUCENE-5868: -- Oh. Yeah!! 5.x is fiexed https://builds.apache.org/job/Lucene-Solr-Tests-5.x-Java7/3822/changes > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046506#comment-15046506 ] Mikhail Khludnev commented on LUCENE-5868: -- I'm going to fix it > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046516#comment-15046516 ] ASF subversion and git services commented on LUCENE-5868: - Commit 1718517 from m...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1718517 ] LUCENE-5868: removing Java8's parseUnsignedInt > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045484#comment-15045484 ] ASF subversion and git services commented on LUCENE-5868: - Commit 1718443 from m...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1718443 ] LUCENE-5868: query-time join for numerics > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045775#comment-15045775 ] ASF subversion and git services commented on LUCENE-5868: - Commit 1718473 from m...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1718473 ] LUCENE-5868: query-time join for numerics > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045870#comment-15045870 ] Mikhail Khludnev commented on LUCENE-5868: -- it passed https://builds.apache.org/job/Lucene-Solr-NightlyTests-trunk/875/console > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045520#comment-15045520 ] Mikhail Khludnev commented on LUCENE-5868: -- oh.my... there are no λ-s in 5.x. the patch is gonna missing its' most of beauty > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, > qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[
https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046157#comment-15046157
]
Steve Rowe commented on LUCENE-5868:
Compilation is failing on branch_5x:
https://builds.apache.org/job/Lucene-Artifacts-5.x/1037/ (java8 constructs on a
java7 build I imagine):
{noformat}
[javac] Compiling 6 source files to
/x1/jenkins/jenkins-slave/workspace/Lucene-Artifacts-5.x/lucene/build/join/classes/test
[javac]
/x1/jenkins/jenkins-slave/workspace/Lucene-Artifacts-5.x/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java:954:
error: cannot find symbol
[javac] assert nextInt ==
Integer.parseUnsignedInt(uniqueRandomValue,16);
[javac] ^
[javac] symbol: method parseUnsignedInt(String,int)
[javac] location: class Integer
[javac]
/x1/jenkins/jenkins-slave/workspace/Lucene-Artifacts-5.x/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java:1206:
error: cannot find symbol
[javac] final int linkInt = Integer.parseUnsignedInt(linkValue,16);
[javac]^
[javac] symbol: method parseUnsignedInt(String,int)
[javac] location: class Integer
[javac] Note:
/x1/jenkins/jenkins-slave/workspace/Lucene-Artifacts-5.x/lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoin.java
uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 2 errors
{noformat}
> JoinUtil support for NUMERIC docValues fields
> --
>
> Key: LUCENE-5868
> URL: https://issues.apache.org/jira/browse/LUCENE-5868
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Minor
> Fix For: 5.5
>
> Attachments: LUCENE-5868-5x.patch, LUCENE-5868-5x.patch,
> LUCENE-5868-lambdarefactoring.patch, LUCENE-5868-lambdarefactoring.patch,
> LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch, LUCENE-5868.patch,
> LUCENE-5868.patch, LUCENE-5868.patch, qtj.diff
>
>
> while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at
> least.
> I plan to provide test/patch. It might be important, because Solr's join can
> do that. Please vote if you care!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[
https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033691#comment-15033691
]
Mikhail Khludnev commented on LUCENE-5868:
--
[~martijn.v.groningen], I renamed parameter, yet locally.
It turns out that random test fails because SortedSetDV omits duplicate values,
but SortedNumberDV doesn't that leads to discrepancy in the scores. I changed
{{TestJoinUtil.createContext(int, boolean, boolean)}} to deduplicate link
values. Score asserts still fail.
> JoinUtil support for NUMERIC docValues fields
> --
>
> Key: LUCENE-5868
> URL: https://issues.apache.org/jira/browse/LUCENE-5868
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Minor
> Fix For: 5.5
>
> Attachments: LUCENE-5868-lambdarefactoring.patch,
> LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch,
> LUCENE-5868.patch, qtj.diff
>
>
> while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at
> least.
> I plan to provide test/patch. It might be important, because Solr's join can
> do that. Please vote if you care!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031595#comment-15031595 ] Martijn van Groningen commented on LUCENE-5868: --- +1 this looks good. One small thing, maybe rename the parameter name in the protected `createJoinQuery(...)` method from `termsWithScoreCollector` to just `collector`? > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031323#comment-15031323 ] David Smiley commented on LUCENE-5868: -- (I edited your comment to correct your reference to me, not a similarly named person) I think the surgery makes sense. It adds a useful feature. The approach leverages the existing underlying BytesRefHash which may not be as optimal as some sort of LongHash or similar but whatever -- progress not perfection. Should someone care, such improvements could be made later. I admit I didn't look at the details of your tests; that would take much more time. I was mostly curious about the implementation side and of the lambdas you made reference to. > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Fix For: 5.5 > > Attachments: LUCENE-5868-lambdarefactoring.patch, > LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch, > LUCENE-5868.patch, qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[
https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030794#comment-15030794
]
David Smiley commented on LUCENE-5868:
--
Nice work Mikhail! I love the lambdas.
Some random comments:
* coder() could take the field name so that the IllegalArgumentException can
report the field in error
* please put spaces after {{if}} and around {{else}}. This is the dominant
style in our codebase, and I prefer it too, FWIW.
* createCollectorSV() could have one switch instead of an if and then a switch;
no?
> JoinUtil support for NUMERIC docValues fields
> --
>
> Key: LUCENE-5868
> URL: https://issues.apache.org/jira/browse/LUCENE-5868
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Minor
> Fix For: 5.5
>
> Attachments: LUCENE-5868-lambdarefactoring.patch,
> LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch,
> qtj.diff
>
>
> while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at
> least.
> I plan to provide test/patch. It might be important, because Solr's join can
> do that. Please vote if you care!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026581#comment-15026581 ] Alexey Zelin commented on LUCENE-5868: -- See attached qty.diff > JoinUtil support for NUMERIC docValues fields > -- > > Key: LUCENE-5868 > URL: https://issues.apache.org/jira/browse/LUCENE-5868 > Project: Lucene - Core > Issue Type: New Feature >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Attachments: qtj.diff > > > while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at > least. > I plan to provide test/patch. It might be important, because Solr's join can > do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[
https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026769#comment-15026769
]
Mikhail Khludnev commented on LUCENE-5868:
--
[~a_zelin] the patch make sense please pay attention to the following points:
- http://wiki.apache.org/lucene-java/HowToContribute
bq. and save them into the LUCENE-.patch file.
bq. Read the patch file. Make sure it includes *ONLY* the modifications
required to fix a single issue.
- I suppose we need to cover all existing cases, ie. the scope of the issue
should include:
{{TermsCollector.MV, TermsCollector.SV, TermsWithScoreCollector.MV,
TermsWithScoreCollector.MV.Avg, TermsWithScoreCollector.SV,
TermsWithScoreCollector.SV.Avg}},... yepp too many, I see.
- as an idea to avoid copy-paste by _bridging_ different DV types.
{{NumericDocValues}} can be adapted to {{BinaryDocValues}}
- such adapter can reuse {{BytesRefBuilder}} (giving that {{BytesRefHash}}
copies bytes)
- the same approach can be done with adapting {{SortedNumericDocValues}} to
{{SortedSetDocValues}}
- I suppose it's ok to keep it lenient: silently allow to shoot legs by having
different DV types across segments.
- As I understand, {{TestJoinUtilInt}} is just a first scratch. I suppose it's
worth to accurately expand existing tests:
-- I suppose {{TestJoinUtil.testSimple() testSimpleWithScoring()}} you can add
{{from_num}} {{to_num}} fields into sample docs, and randomly switch these
fields for passing into {{createJoinQuery()}}
-- in {{TestJoinUtilInt}} you are trying to create numeric DV by
{{setDocValuesType(DocValuesType.NUMERIC);}}, I don't belive it work, and it's
handled by UnInvertingReader in run-time. So, I suggest to add
{{NumericDocValuesField}} and {{SortedNumericDocValuesField}} (as mv case)
explicitly. But let's randomly switch to existing approach (just add indexed
field and rely on UnInvertingReader) just for smoke testing.
I'll handle as separate issues:
- extending {{TestScoreJoinQPScore.testSimpleWithScoring()}} for coverage
- extending {{TestJoinUtil.test*ValueRandomJoin()}} for coverage
Beside of the patch, for further consideration: if we could provide field types
by something like Solr Schema/FieldTypes into JoinUtil. such issue would be
autodone.
> JoinUtil support for NUMERIC docValues fields
> --
>
> Key: LUCENE-5868
> URL: https://issues.apache.org/jira/browse/LUCENE-5868
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Minor
> Attachments: qtj.diff
>
>
> while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at
> least.
> I plan to provide test/patch. It might be important, because Solr's join can
> do that. Please vote if you care!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649363#comment-14649363 ] marc schipperheyn commented on LUCENE-5868: --- I'd vote for it. JoinUtil support for NUMERIC docValues fields -- Key: LUCENE-5868 URL: https://issues.apache.org/jira/browse/LUCENE-5868 Project: Lucene - Core Issue Type: New Feature Reporter: Mikhail Khludnev Assignee: Mikhail Khludnev Priority: Minor while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at least. I plan to provide test/patch. It might be important, because Solr's join can do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5868) JoinUtil support for NUMERIC docValues fields
[ https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649469#comment-14649469 ] Mikhail Khludnev commented on LUCENE-5868: -- [~mschipperheyn] what's your usecase? why you can't use SORTED? do you need to join cross cores? Have you had a look at OrdinalMap join? JoinUtil support for NUMERIC docValues fields -- Key: LUCENE-5868 URL: https://issues.apache.org/jira/browse/LUCENE-5868 Project: Lucene - Core Issue Type: New Feature Reporter: Mikhail Khludnev Assignee: Mikhail Khludnev Priority: Minor while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at least. I plan to provide test/patch. It might be important, because Solr's join can do that. Please vote if you care! -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
