[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518752#comment-14518752 ] Ryan Ernst commented on LUCENE-6213: i think that even if there is no official M release, the smoketester for M+1 should fail if a test for (M)x-with-(M-1)x-segments can not be found. I disagree. We shouldn't fail when there is nothing we can do. The backcompat indexes are created with official releases, so we should not fail until there is an official release with which to build the backcompat index (whether that be a pure index or mixed). Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519646#comment-14519646
]
Robert Muir commented on LUCENE-6213:
-
{quote}
I disagree. We shouldn't fail when there is nothing we can do.
{quote}
Yeah, failing jenkins over and over for a potentially long period of time is
not a solution here.
We can release version X without tests that it can read X-1. In general, test
coverage is never perfect.
Add test for IndexFormatTooOldException if a commit has a 3.x segment
-
Key: LUCENE-6213
URL: https://issues.apache.org/jira/browse/LUCENE-6213
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
Assignee: Ryan Ernst
Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch,
unsupported.4x-with-3x-segments.zip
We should add a 4.x index (4.x commit) with some 3.x segment(s) to our
backwards tests.
I don't think we throw IndexFormatTooOldException correctly in this case. I
think instead the user will get a confusing SPI error about a missing codec
Lucene3x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519640#comment-14519640 ] Hoss Man commented on LUCENE-6213: -- bq. We shouldn't fail when there is nothing we can do. -0 In my opinion you are looking at the purpose of the smoke tester backwards: the smoke tester shouldn't _pass_ unless the candidate it's smoking is ready for release -- if we know that there is no previous index format that is being adequately tested in the candidate build, then the candidate is, by definition, not ready for release. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518434#comment-14518434 ] ASF subversion and git services commented on LUCENE-6213: - Commit 1676650 from [~rjernst] in branch 'dev/trunk' [ https://svn.apache.org/r1676650 ] LUCENE-6213: Revert accidental removal of code from readCommit (bad merge) Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518460#comment-14518460
]
Ryan Ernst commented on LUCENE-6213:
[~hossman] We already check unsupported indexes are tested. I do think we
should check for this, but only once a version is released. For example, we
didn't fail expecting a bwc test for 5.0.0 until that was actually available
(we list apache archives of lucene release to find all the versions we expect).
In this case, we probably just need some extra logic for a major release. Eg.
For M.0.0, expect a test index {M}x-with-{M-1}x-segments. I think this is
essentially what you were saying?
We should also have this easily created with addBackcompatIndexes.py, so that
when it runs on a major release it also creates one of these mixed indexes. I
created LUCENE-6457 to track this.
Add test for IndexFormatTooOldException if a commit has a 3.x segment
-
Key: LUCENE-6213
URL: https://issues.apache.org/jira/browse/LUCENE-6213
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
Assignee: Ryan Ernst
Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch,
unsupported.4x-with-3x-segments.zip
We should add a 4.x index (4.x commit) with some 3.x segment(s) to our
backwards tests.
I don't think we throw IndexFormatTooOldException correctly in this case. I
think instead the user will get a confusing SPI error about a missing codec
Lucene3x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518485#comment-14518485 ] Hoss Man commented on LUCENE-6213: -- bq. Eg. For M.0.0, expect a test index (M)x-with-(M-1)x-segments. I think this is essentially what you were saying? My point was that for a sanity check like this, where the focus is on major versions, we can go even farther then just looking at the list of existing releases. In your example, i think that even if there is no official M release, the smoketester for M+1 should fail if a test for (M)x-with-(M-1)x-segments can not be found. Example: if the trunk version property is set to 8.Y (where the value of Y is irrelevant) then it should be expected that the a 7x-with-6x-segments index is tested -- even if there is no 7.X release yet according to jira / archive.apache.org. that way, in the first few days after a 7x_branch is created, and trunk's version property is updated to 8.0 it will be clear from the smokeTester failures on trunk that trunk is not in a state suitable to be released -- by definittion trunk won't be suitable for release until a 7.0 release is final and the 7x index format is used to create the 7x-with-6x-segments index for the trunk test. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518366#comment-14518366 ] ASF subversion and git services commented on LUCENE-6213: - Commit 1676648 from [~rjernst] in branch 'dev/trunk' [ https://svn.apache.org/r1676648 ] LUCENE-6213: Add useful exception message when commit contains segments from legacy codecs (forward port from branch_5x) Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518108#comment-14518108
]
Hoss Man commented on LUCENE-6213:
--
bq. When I added this logic, 5.0 was not yet released, so we didn't have an
official release to build the mixed segments with.
Perhaps this is something smokechecker should sanity check for us moving
forward? It already parses the output of TestBackwardsCompatibility to make
sure we test all known previous releases, why not also make it look for
{{testIndexFormatTooOldExceptionX}} where {{X}} is 1 less then whatever the
major version number is?
so smokechecker against trunk (where version is 6.0) will fail unless/until
there is a {{testIndexFormatTooOldException5}} run as part of
TestBackwardsCompatibility. when we create a branch_6x and update the version
on trunk to 7 it will start failing again until we change
TestBackwardsCompatibility so that {{testIndexFormatTooOldException6}} exists
(a good and legitimate smoke test to fail: we don't want to release trunk
until 6.0 is final and we have a mixed format to test against)
Add test for IndexFormatTooOldException if a commit has a 3.x segment
-
Key: LUCENE-6213
URL: https://issues.apache.org/jira/browse/LUCENE-6213
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
Assignee: Ryan Ernst
Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch,
unsupported.4x-with-3x-segments.zip
We should add a 4.x index (4.x commit) with some 3.x segment(s) to our
backwards tests.
I don't think we throw IndexFormatTooOldException correctly in this case. I
think instead the user will get a confusing SPI error about a missing codec
Lucene3x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517480#comment-14517480 ] Ryan Ernst commented on LUCENE-6213: When I added this logic, 5.0 was not yet released, so we didn't have an official release to build the mixed segments with. I'll take care of this. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301863#comment-14301863
]
Uwe Schindler commented on LUCENE-6213:
---
If you want to keep the array, use {{Arrays.asList(array).contains(element)}},
that's the pendant to your STL's {{find()}}. But I still think that a set is
the right data structure.
Add test for IndexFormatTooOldException if a commit has a 3.x segment
-
Key: LUCENE-6213
URL: https://issues.apache.org/jira/browse/LUCENE-6213
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
Assignee: Ryan Ernst
Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch,
unsupported.4x-with-3x-segments.zip
We should add a 4.x index (4.x commit) with some 3.x segment(s) to our
backwards tests.
I don't think we throw IndexFormatTooOldException correctly in this case. I
think instead the user will get a confusing SPI error about a missing codec
Lucene3x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301958#comment-14301958 ] ASF subversion and git services commented on LUCENE-6213: - Commit 1656581 from [~rjernst] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1656581 ] LUCENE-6213: Bikeshed the hell out of a 1 element list Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301869#comment-14301869 ] Ryan Ernst commented on LUCENE-6213: Well, except that would convert the array to a list on each call. I would rather keep the current code. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301938#comment-14301938
]
Uwe Schindler commented on LUCENE-6213:
---
bq. Well, except that would convert the array to a list on each call. I would
rather keep the current code.
Well, I would declare it as this List. List and array are basically the same in
Java. Arrays.asList() does only wrap not convert. In addition the
declaration of the static constant would be much more readable (sorry, I hate
this new String[] { ... } syntax - the code looks like written by a C
developer - not Java like):
{code:java}
private static final ListString unsupportedCodecs = Arrays.asList(
Lucene3x
);
{code}
Then you can do the contains().
(because its private, there is no need to make it explicitely unmodifiable)
Uwe
Add test for IndexFormatTooOldException if a commit has a 3.x segment
-
Key: LUCENE-6213
URL: https://issues.apache.org/jira/browse/LUCENE-6213
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
Assignee: Ryan Ernst
Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch,
unsupported.4x-with-3x-segments.zip
We should add a 4.x index (4.x commit) with some 3.x segment(s) to our
backwards tests.
I don't think we throw IndexFormatTooOldException correctly in this case. I
think instead the user will get a confusing SPI error about a missing codec
Lucene3x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301962#comment-14301962 ] Uwe Schindler commented on LUCENE-6213: --- Thanks for changing! Sometimes I have a bad day - I was dealing with C code a minute ago! :-) Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301651#comment-14301651
]
Uwe Schindler commented on LUCENE-6213:
---
[~jpountz]: Why is the list of unsupported codecs an Array. A simple
unmodifiable set would be better, would spare lots of code :-) If its a
singletonSet its even simpler :-) Otherwise use
{{Collections.unmodifiableSet(new HashSet(Arrays.asList(codecs)))}}. You
don't need to change that, but to me this looks simplier and more correct.
Memory usage or speed is not a problem here, it is static and never changes
after class init.
Add test for IndexFormatTooOldException if a commit has a 3.x segment
-
Key: LUCENE-6213
URL: https://issues.apache.org/jira/browse/LUCENE-6213
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
Assignee: Ryan Ernst
Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch,
unsupported.4x-with-3x-segments.zip
We should add a 4.x index (4.x commit) with some 3.x segment(s) to our
backwards tests.
I don't think we throw IndexFormatTooOldException correctly in this case. I
think instead the user will get a confusing SPI error about a missing codec
Lucene3x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301961#comment-14301961 ] ASF subversion and git services commented on LUCENE-6213: - Commit 1656582 from [~rjernst] in branch 'dev/branches/lucene_solr_5_0' [ https://svn.apache.org/r1656582 ] LUCENE-6213: Bikeshed the hell out of a 1 element list Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301478#comment-14301478 ] Robert Muir commented on LUCENE-6213: - I like the simple solution for now! When throwing the too-old exception, can we initCause() it with the original exception we got? I think it is not good to lose it. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301507#comment-14301507 ] ASF subversion and git services commented on LUCENE-6213: - Commit 1656523 from [~rjernst] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1656523 ] LUCENE-6213: Add useful exception message when commit contains segments from legacy codecs Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301492#comment-14301492 ] Robert Muir commented on LUCENE-6213: - +1, the only thing i might do is move unsupportedCodecs to be right above readCodec() in the code. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301500#comment-14301500 ] Ryan Ernst commented on LUCENE-6213: Ok, I'll move unsupportedCodecs before committing. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301510#comment-14301510 ] Adrien Grand commented on LUCENE-6213: -- +1 Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301518#comment-14301518 ] ASF subversion and git services commented on LUCENE-6213: - Commit 1656528 from [~rjernst] in branch 'dev/branches/lucene_solr_5_0' [ https://svn.apache.org/r1656528 ] LUCENE-6213: Add useful exception message when commit contains segments from legacy codecs (merged 1656523) Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301559#comment-14301559 ] Anshum Gupta commented on LUCENE-6213: -- Thanks for getting this into 5.0. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Assignee: Ryan Ernst Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301731#comment-14301731
]
Ryan Ernst commented on LUCENE-6213:
[~thetaphi] While that might be less lines of code (but only by 1 or 2 I
think), that is a much more complicated data structure than an array. In fact,
if java just had an {{Arrays.find}} like STL's {{find()}} then there would be
no difference in number of lines.
Add test for IndexFormatTooOldException if a commit has a 3.x segment
-
Key: LUCENE-6213
URL: https://issues.apache.org/jira/browse/LUCENE-6213
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
Assignee: Ryan Ernst
Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch,
unsupported.4x-with-3x-segments.zip
We should add a 4.x index (4.x commit) with some 3.x segment(s) to our
backwards tests.
I don't think we throw IndexFormatTooOldException correctly in this case. I
think instead the user will get a confusing SPI error about a missing codec
Lucene3x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14300728#comment-14300728 ] Adrien Grand commented on LUCENE-6213: -- I like the TooOldCodec idea! bq. Maybe we dont need anything there, but we can think about the error message +1 on improving the error message to mention the backwards-codecs jar Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299877#comment-14299877 ] Robert Muir commented on LUCENE-6213: - Thanks Ryan, i thought of another related issue: the backwards-codecs.jar is new in 5.0, so i imagine its common someone will try to open a 4.x index with just a lucene core JAR and get a similar SPI error Maybe we dont need anything there, but we can think about the error message. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299365#comment-14299365 ] Robert Muir commented on LUCENE-6213: - I dont want to cause delays for 5.0, but this might be one to fix as it will confuse users. First we need the test to know if its really a bug, but I think it is. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299376#comment-14299376 ] Robert Muir commented on LUCENE-6213: - One way to fix this would be, to have an TooOldCodec that throws IndexFormatTooOldException for every method. We could register it in SPI with the names of codecs we no longer support. So in trunk, it would be registered for all the 4.x codecs for example. When SegmentInfos asks the codec for the segmentInfoWriter() when decoding the commit, the user will get the correct exception. Alternatively we could just have a hardcoded list/map and conditional logic in SegmentInfos for this. Add test for IndexFormatTooOldException if a commit has a 3.x segment - Key: LUCENE-6213 URL: https://issues.apache.org/jira/browse/LUCENE-6213 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests. I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec Lucene3x. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
