[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656105#comment-16656105 ] ASF subversion and git services commented on LUCENE-6572: - Commit 11a1b8c1a8fdca9f6314bd61695345737309b630 in lucene-solr's branch refs/heads/jira/http2 from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=11a1b8c ] LUCENE-6572: Remove dependency on analyzer-common from highlighing This makes a simplifed copy of LimitTokenOffsetFilter to the highlighting module to detach the dependency on analyzer-common. > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Fix For: master (8.0) > > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653864#comment-16653864 ] Simon Willnauer commented on LUCENE-6572: - ok folks, think this particular issue is fixed. I will go and open a new one for the block-join discussion. > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Fix For: master (8.0) > > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653407#comment-16653407 ] Martijn van Groningen commented on LUCENE-6572: --- > do you have background on why we have support for these queries in >highlighting? I don't recall why, but like the in comment you mention, it is weird to support this. A different highlight query should used for when child or parent documents need to be highlighed. Elasticsearch ignores parent/child queries when highlighting and expects that when users want highlighting for child docs that a highlight query should be specified. > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653283#comment-16653283 ] Simon Willnauer commented on LUCENE-6572: - seems like related to https://issues.apache.org/jira/browse/LUCENE-5929 > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653281#comment-16653281 ] Simon Willnauer commented on LUCENE-6572: - > Another solution would be to remove the support for the parent/child query in > highlighting. I don't see how this can be useful since the inner query > explicitly targets a different set of documents (not the one returned in the > top hits). If users really wants this feature the unified highlighter has a > simple mechanism to rewrite custom queries that are not handled by the > default implementation. I am ok with this. this is a breaking change FWIW. [~martijn.v.groningen] do you have background on why we have support for these queries in highlighting? > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653277#comment-16653277 ] ASF subversion and git services commented on LUCENE-6572: - Commit 11a1b8c1a8fdca9f6314bd61695345737309b630 in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=11a1b8c ] LUCENE-6572: Remove dependency on analyzer-common from highlighing This makes a simplifed copy of LimitTokenOffsetFilter to the highlighting module to detach the dependency on analyzer-common. > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653212#comment-16653212 ] Jim Ferenczi commented on LUCENE-6572: -- Another solution would be to remove the support for the parent/child query in highlighting. I don't see how this can be useful since the inner query explicitly targets a different set of documents (not the one returned in the top hits). If users really wants this feature the unified highlighter has a simple mechanism to rewrite custom queries that are not handled by the default implementation. > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653188#comment-16653188 ] Simon Willnauer commented on LUCENE-6572: - > I also don't understand why it depends on join. So messy that's a mess too and a general problem with highligiting. It's because we don't have a good way to extract the parent/child query to do the highlighting. One way of doing this would be to have a simple interface or query subclass that we can also extend ConstantScoreQuery from that has a `getQuery()` method. I am not sure we want this to be in core? > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653179#comment-16653179 ] Jim Ferenczi commented on LUCENE-6572: -- +1 > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653176#comment-16653176 ] Simon Willnauer commented on LUCENE-6572: - I attached an updated patch for this to remove the dependency on the analyzer-common module. Can somebody take a quick look? > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Assignee: Simon Willnauer >Priority: Blocker > Attachments: LUCENE-6572.patch, LUCENE-6572.patch > > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322697#comment-15322697 ] Michael McCandless commented on LUCENE-6572: bq. Given how simple this token filter is, what about having a copy it in the highlighter module? +1 > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter >Reporter: Robert Muir >Priority: Blocker > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1534#comment-1534 ] Adrien Grand commented on LUCENE-6572: -- Given how simple this token filter is, what about having a copy it in the highlighter module? I tend to agree that keeping dependencies between modules at a minimum is important to keep things manageable. > Highlighter depends on analyzers-common > --- > > Key: LUCENE-6572 > URL: https://issues.apache.org/jira/browse/LUCENE-6572 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir >Priority: Blocker > > This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful > for highlighting. > Adding all these intermodule dependencies makes things too hard to use. > This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591180#comment-14591180 ] David Smiley commented on LUCENE-6572: -- Rob, I put LimitTokenOffsetFilter into analysis/common from the Highlighter because it didn't seem to fundamentally be about highlighting, and because there are other TokenFilters of the pattern LimitToken*Filter TokenFilters there. The highlighter module depends on some other modules, like Join, because in short we don't yet have a Query visitor API. Highlighter depends on analyzers-common --- Key: LUCENE-6572 URL: https://issues.apache.org/jira/browse/LUCENE-6572 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Priority: Blocker This is a huge WTF, just for LimitTokenOffsetFilter which is only useful for highlighting. Adding all these intermodule dependencies makes things too hard to use. This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587892#comment-14587892 ] Robert Muir commented on LUCENE-6572: - I also don't understand why it depends on join. So messy Highlighter depends on analyzers-common --- Key: LUCENE-6572 URL: https://issues.apache.org/jira/browse/LUCENE-6572 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Priority: Blocker This is a huge WTF, just for LimitTokenOffsetFilter which is only useful for highlighting. Adding all these intermodule dependencies makes things too hard to use. This is a 5.3 release blocker. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
