[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314132#comment-15314132 ] Michael McCandless commented on LUCENE-7307: [~martijn.v.groningen] can this be closed now? > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE-7307, LUCENE_7307.patch, LUCENE_7307.patch, > LUCENE_7307.patch, LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312275#comment-15312275 ] ASF subversion and git services commented on LUCENE-7307: - Commit 50feae82af5d297b720a98db07ab43e093e788b8 in lucene-solr's branch refs/heads/branch_6x from [~martijn] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=50feae8 ] LUCENE-7307: Add getters to the PointInSetQuery and PointRangeQuery queries. > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE-7307, LUCENE_7307.patch, LUCENE_7307.patch, > LUCENE_7307.patch, LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312276#comment-15312276 ] ASF subversion and git services commented on LUCENE-7307: - Commit b977275185a111fad55da2bd993c1afb73a00b51 in lucene-solr's branch refs/heads/master from [~martijn] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b977275 ] LUCENE-7307: Add getters to the PointInSetQuery and PointRangeQuery queries. > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE-7307, LUCENE_7307.patch, LUCENE_7307.patch, > LUCENE_7307.patch, LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311914#comment-15311914 ] Adrien Grand commented on LUCENE-7307: -- Thanks Martijn, +1 > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE-7307, LUCENE_7307.patch, LUCENE_7307.patch, > LUCENE_7307.patch, LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311882#comment-15311882 ] Martijn van Groningen commented on LUCENE-7307: --- bq. I think the byte[] version was better since it is consitent with PointPangeQuery which exposes the low/high bounds as a byte[]? Good point. I'll change that. bq. Also I don't think it is true that the sortedPackedPoints iterator makes a copy: looking at PrefixCodedTerms, it seems to be reusing the same BytesRef object? True... we need to make a copy. I guess what I was confused with is the copy that PrefixCodedTerms makes from the input, but if it is reusing the BytesRef it copies into then a copy is required if we return the points in a collection. bq. Something else we should do is throwing a NoSuchElementException in the Iterator whin upTo==size to comply with the Iterator API. +1! > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE_7307.patch, LUCENE_7307.patch, LUCENE_7307.patch, > LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311847#comment-15311847 ] Adrien Grand commented on LUCENE-7307: -- bq. Also I changed the return type from Collectionto Collection because the sortedPackedPoints iterator already makes a copy and returns that as BytesRef. I think the byte[] version was better since it is consitent with PointPangeQuery which exposes the low/high bounds as a byte[]? Also I don't think it is true that the sortedPackedPoints iterator makes a copy: looking at PrefixCodedTerms, it seems to be reusing the same BytesRef object? Something else we should do is throwing a NoSuchElementException in the Iterator whin upTo==size to comply with the Iterator API. > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE_7307.patch, LUCENE_7307.patch, LUCENE_7307.patch, > LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309960#comment-15309960 ] Adrien Grand commented on LUCENE-7307: -- Maybe the collection should be a view rather than a copy? For instance this would allow knowing how many points there are in canstant time (by calling size()) and without duplicating all points in memory? > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE_7307.patch, LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309881#comment-15309881 ] Adrien Grand commented on LUCENE-7307: -- Should we be defensive and copy the low/high points before returning them? Also I don't think sortedPackedPointsHashCode should have a getter, and maybe sortedPackedPoints should be returned as a Collectionrather exposing PrefixCodedTerms (which should remain internal to Lucene). > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308721#comment-15308721 ] Michael McCandless commented on LUCENE-7307: +1 > Add getters to PointInSetQuery and PointRangeQuery classes > -- > > Key: LUCENE-7307 > URL: https://issues.apache.org/jira/browse/LUCENE-7307 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Martijn van Groningen >Priority: Trivial > Attachments: LUCENE_7307.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org