[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703638#comment-15703638 ] Michael McCandless commented on LUCENE-7466: OK it was definitely in some bizarro state ;) But I think I fixed it by reopening and then resolving again! > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: master (7.0), 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703302#comment-15703302 ] Tommaso Teofili commented on LUCENE-7466: - well .. that's weird, I had set it to resolved back on Nov 20th (click on the 'All' tab), but then when you commented I saw it was still unresolved and therefore assumed it was reopened by someone else. Now it looks fixed resolved because you can close and reopen, but also unresolved as per current resolution value ... > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703298#comment-15703298 ] Michael McCandless commented on LUCENE-7466: I'm confused: why does the issue say it's Open yet I only see a Reopen Issue or Close Issue buttons here? > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702674#comment-15702674 ] Tommaso Teofili commented on LUCENE-7466: - sure, thanks Mike. > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702676#comment-15702676 ] Peilin Yang commented on LUCENE-7466: - Sure. Please feel free to close the issue. On Mon, Nov 28, 2016 at 1:05 PM Michael McCandless (JIRA) > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702670#comment-15702670 ] Michael McCandless commented on LUCENE-7466: Can this issue be resolved now? > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681149#comment-15681149 ] ASF subversion and git services commented on LUCENE-7466: - Commit c3f172a40830b31d005dbb7c6bd518ea236aa5fb in lucene-solr's branch refs/heads/master from [~teofili] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c3f172a ] LUCENE-7466 - adjusted changes.txt to reflect added axiomatic sim > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680844#comment-15680844 ] ASF subversion and git services commented on LUCENE-7466: - Commit 033614692a743a07227fc96fc46bffb00b407db6 in lucene-solr's branch refs/heads/branch_6x from [~teofili] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0336146 ] LUCENE-7466 - added axiomatic similarity, patch from Peilin Yang (cherry picked from commit 4236da2) > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680845#comment-15680845 ] ASF subversion and git services commented on LUCENE-7466: - Commit 4ce7ce08442e191ca6c013bda2e052a91f27b2f4 in lucene-solr's branch refs/heads/branch_6x from [~teofili] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4ce7ce0 ] LUCENE-7466 - adjusted changes.txt to reflect added axiomatic sim > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > Fix For: 6.4 > > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678786#comment-15678786 ] Tommaso Teofili commented on LUCENE-7466: - thanks [~ypeilin], I've applied your patch (with minor fixes to javadoc and unused imports). > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678784#comment-15678784 ] ASF subversion and git services commented on LUCENE-7466: - Commit 4236da27d1b1cbced6c3fed4b3d3094fe796fa7e in lucene-solr's branch refs/heads/master from [~teofili] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4236da2 ] LUCENE-7466 - added axiomatic similarity, patch from Peilin Yang > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672434#comment-15672434 ] Peilin Yang commented on LUCENE-7466: - Thanks for pointing this out. For the test cases, since all of the variations extend from the base Axiomatic class and all the constructors all basically the same (except AxiomaticF3EXP where a queryLen is needed that is why there is a QL test) so I just pick F2EXP to test. Does this make any sense to you? > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[
https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671519#comment-15671519
]
Tommaso Teofili commented on LUCENE-7466:
-
when running 'ant clean test' under lucene/core the only error I see is in
{{TestAxiomaticSimilarity#testIllegalQL}} (note that _testSaneNormValues_ uses
{{BM25Similarity}}, I have locally changed it to {{AxiomaticF2EXP}}).
Other than that it seems the {{TestAxiomaticSimilarity}} actually tests only
{{AxiomaticF2EXP}}, shouldn't it also test the other {{Axiomatic}} extensions?
> add axiomatic similarity
> -
>
> Key: LUCENE-7466
> URL: https://issues.apache.org/jira/browse/LUCENE-7466
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Peilin Yang
>Assignee: Tommaso Teofili
> Labels: patch
>
> Add axiomatic similarity approaches to the similarity family.
> More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and
> https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf
> There are in total six similarity models. All of them are based on BM25,
> Pivoted Document Length Normalization or Language Model with Dirichlet prior.
> We think it is worthy to add the models as part of Lucene.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670915#comment-15670915 ] Peilin Yang commented on LUCENE-7466: - Hi [~teofili] I just added the test cases. But when I run `ant test` it fails for some other tests. Do you know a easier way to just test the test cases I added? > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670373#comment-15670373 ] Peilin Yang commented on LUCENE-7466: - ok, will add test cases > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670273#comment-15670273 ] Tommaso Teofili commented on LUCENE-7466: - sorry for the confusion, forget about the NumericDocValues related comment, that came from another leftover patch I had applied locally. Therefore it would just be good to have some tests for the axiom similarities, everything else looks good to me. > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670225#comment-15670225 ] Peilin Yang commented on LUCENE-7466: - Hi [~teofili], thanks for your feedback. For the `NDV`, `FDV` and `DDV` you've mentioned, could you please directly annotate them in the PR? It is more clear that what line or which part of the PR you refer to. > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang >Assignee: Tommaso Teofili > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[
https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670066#comment-15670066
]
Tommaso Teofili commented on LUCENE-7466:
-
thanks [~ypeilin] for your patch, here're a couple of comments:
- I think a testcase for all the added models should be provided in order to
make sure they work as expected
- the changes to {{NumericDocValues}}, {{FloatDocValues}} and
{{DoubleDocValues}} break some tests as it seems NDV always returns a _Long_
while FDV and DDV convert such a _Long_ value to an _Integer_ and then back to
a _Float_ / _Double_ using _Float.intBitsToFloat_ / _Double.intBitsToDouble_,
can you clarify if / why is that needed for axiomatic similarity ? (if I remove
the mentioned changes all the tests pass but then I'm not sure if that has an
impact on the Axiomatic similarities because of the missing tests)
> add axiomatic similarity
> -
>
> Key: LUCENE-7466
> URL: https://issues.apache.org/jira/browse/LUCENE-7466
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Peilin Yang
>Assignee: Tommaso Teofili
> Labels: patch
>
> Add axiomatic similarity approaches to the similarity family.
> More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and
> https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf
> There are in total six similarity models. All of them are based on BM25,
> Pivoted Document Length Normalization or Language Model with Dirichlet prior.
> We think it is worthy to add the models as part of Lucene.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7466) add axiomatic similarity
[ https://issues.apache.org/jira/browse/LUCENE-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15519408#comment-15519408 ] ASF GitHub Bot commented on LUCENE-7466: GitHub user Peilin-Yang opened a pull request: https://github.com/apache/lucene-solr/pull/83 [LUCENE-7466] add axiomatic similarity Add axiomatic similarity approaches to the similarity family. More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf There are in total six similarity models. All of them are based on BM25, Pivoted Document Length Normalization or Language Model with Dirichlet prior. We think it is worthy to add the models as part of Lucene. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Peilin-Yang/lucene-solr add_axiomatic_funcs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit a71d7d9662b57cc704b9c92d2c013826d9ad8c73 Author: Peilin Yang Date: 2016-09-24T17:56:28Z add axiomatic similarity > add axiomatic similarity > - > > Key: LUCENE-7466 > URL: https://issues.apache.org/jira/browse/LUCENE-7466 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Affects Versions: master (7.0) >Reporter: Peilin Yang > Labels: patch > > Add axiomatic similarity approaches to the similarity family. > More details can be found at http://dl.acm.org/citation.cfm?id=1076116 and > https://www.eecis.udel.edu/~hfang/pubs/sigir05-axiom.pdf > There are in total six similarity models. All of them are based on BM25, > Pivoted Document Length Normalization or Language Model with Dirichlet prior. > We think it is worthy to add the models as part of Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
