[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121501#comment-16121501 ] Ignacio Vera commented on LUCENE-7918: -- Thanks for the quick fix [~daddywri]! I am not too alarmed either :) If I find the time I will submit a patch as I think it is a better behavior and as you said close the hole. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121483#comment-16121483 ] Karl Wright commented on LUCENE-7918: - [~ivera], you can always verify that the types of the two classes are identical (using this.getClass() and other.getClass()), but in the case of generics that does not help you. You instead would want to have the type check (using instanceof) in the derived class, since generics only mean anything at compile time. So if you wanted to close that hole, both the derived classes would need equals methods with instanceof checks and calls to super.equals(). You are free to submit a patch that does this but I'm not too alarmed about this. :-) Please note that I also removed the super.hashCode() invocation since that seemed broken in exactly the same way. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121469#comment-16121469 ] ASF subversion and git services commented on LUCENE-7918: - Commit fc431f685440033ba0d91b4624966b03dcefc86e in lucene-solr's branch refs/heads/branch_7x from [~kwri...@metacarta.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc431f6 ] LUCENE-7918: Fix incorrect equals method. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121468#comment-16121468 ] ASF subversion and git services commented on LUCENE-7918: - Commit 75a7e2e2c5cee70a476cecf9421ec1e6e30574df in lucene-solr's branch refs/heads/branch_6x from [~kwri...@metacarta.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=75a7e2e ] LUCENE-7918: Fix incorrect equals method. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121465#comment-16121465 ] ASF subversion and git services commented on LUCENE-7918: - Commit 84d8385fb9fa3f794d5e473219ca6b5b2abee5f2 in lucene-solr's branch refs/heads/master from [~kwri...@metacarta.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=84d8385 ] LUCENE-7918: Fix incorrect equals method. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121463#comment-16121463 ] Ignacio Vera commented on LUCENE-7918: -- Note one thing as well. If you remove that, the following case will be true: 1. Create a GeoCompositeMembershipShape 2. Create a GeoCompositeAreaShape 3. add the same shapes to the composites: Then both are equal, is that right? or should be add equals methods to the other composites? > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121460#comment-16121460 ] Karl Wright commented on LUCENE-7918: - I agree; that code is incorrect and definitely should not be there. I can fix without a patch. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116433#comment-16116433 ] Karl Wright commented on LUCENE-7918: - Thanks again for the contribution! Everything is now committed. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Fix For: 6.6, master (8.0), 7.1 > > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116431#comment-16116431 ] ASF subversion and git services commented on LUCENE-7918: - Commit 7d1c7e757668337ec33bc543c9718320fd6974fe in lucene-solr's branch refs/heads/branch_7x from [~kwri...@metacarta.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7d1c7e7 ] LUCENE-7918: Revamp the API for composites so that it's generic and useful for many kinds of shapes. Committed (as was LUCENE-7906) on behalf of Ignacio Vera. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116429#comment-16116429 ] ASF subversion and git services commented on LUCENE-7918: - Commit e3f5aed562b2e398a40ea85ee8264d28fc0e023b in lucene-solr's branch refs/heads/branch_6x from [~kwri...@metacarta.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e3f5aed ] LUCENE-7918: Revamp the API for composites so that it's generic and useful for many kinds of shapes. Committed (as was LUCENE-7906) on behalf of Ignacio Vera. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116427#comment-16116427 ] ASF subversion and git services commented on LUCENE-7918: - Commit 18e1b40b1c4a15379da865fef05f9a58a2dbdcbf in lucene-solr's branch refs/heads/master from [~kwri...@metacarta.com] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=18e1b40 ] LUCENE-7918: Revamp the API for composites so that it's generic and useful for many kinds of shapes. Committed (as was LUCENE-7906) on behalf of Ignacio Vera. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116233#comment-16116233
]
Karl Wright commented on LUCENE-7918:
-
Hi [~ivera], I think this looks pretty good actually. The new API exposure is
minimal, but all public classes in geom should be annotated with
"lucene-experimental" to be sure we can change them if we need to.
Also, you have a number of unnecessary casts in GeoPolygonTest:
{code}
-GeoPolygon polygon =
(GeoPolygon)((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
points)).shapes.get(0);
+GeoPolygon polygon =
((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
points)).shapes.get(0);
GeoPolygon polygonConcave =
GeoPolygonFactory.makeGeoConcavePolygon(PlanetModel.SPHERE,points);
assertEquals(polygon,polygonConcave);
{code}
There's no need to cast to a GeoPolygon; the output of makeGeoPolygon is
already a GeoPolygon.
I think you're almost there; one more pass and we're good.
> Give access to members of a composite shape
> ---
>
> Key: LUCENE-7918
> URL: https://issues.apache.org/jira/browse/LUCENE-7918
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
> Attachments: LUCENE-7918.patch
>
>
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I
> need to access the members of a composite geoshape. This is currently not
> possible so I was wondering if it is possible to add to more methods to the
> class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115691#comment-16115691 ] Karl Wright commented on LUCENE-7918: - Also, [~ivera], Steve Rowe just committed a fix for "ant precommit", so you can use that now. Thanks! > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115488#comment-16115488
]
Karl Wright commented on LUCENE-7918:
-
[~ivera], didn't pass documentation-lint. This is what it said:
{code}
[exec]
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/GeoBaseCompositeAreaShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec]
[exec]
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/GeoCompositePolygon.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec]
[exec]
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/GeoCompositeAreaShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec]
[exec]
file:///build/docs/spatial3d/org/apache/lucene/spatial3d/geom/GeoCompositeMembershipShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/spatial3d.geom.GeoBaseCompositeShape.html
[exec]
[exec] Broken javadocs links were found! Common root causes:
[exec] * A typo of some sort for manually created links.
[exec] * Public methods referencing non-public classes in their signature.
{code}
Can you fix and resubmit your patch?
> Give access to members of a composite shape
> ---
>
> Key: LUCENE-7918
> URL: https://issues.apache.org/jira/browse/LUCENE-7918
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
> Attachments: LUCENE-7918.patch
>
>
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I
> need to access the members of a composite geoshape. This is currently not
> possible so I was wondering if it is possible to add to more methods to the
> class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115482#comment-16115482
]
Karl Wright commented on LUCENE-7918:
-
I'm also seeing build warnings compiling this code, e.g.:
{code}
[javac]
C:\wipgit\lucene4\lucene-solr\lucene\spatial3d\src\test\org\apache\lucene\spatial3d\geom\GeoPolygonTest.java:978:
warning: [cast] redundant cast to
GeoPolygon
[javac] GeoPolygon polygon = (GeoPolygon)((GeoCompositePolygon)GeoPolygo
nFactory.makeGeoPolygon(PlanetModel.SPHERE, points)).shapes.get(0);
[javac] ^
[javac]
C:\wipgit\lucene4\lucene-solr\lucene\spatial3d\src\test\org\apache\lucene\spatial3d\geom\GeoPolygonTest.java:997:
warning: [cast] redundant cast to GeoPolygon
[javac] GeoPolygon polygon =
(GeoPolygon)((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
points,Collections.singletonList(hole))).shapes.get(0);
[javac] ^
[javac] C:\wipgit\lucene4\lucene-solr\lucene\spatial3d\src\test\org\apache\l
ucene\spatial3d\geom\GeoPolygonTest.java:1009: warning: [cast] redundant cast to
GeoPolygon
[javac] GeoPolygon polygon =
(GeoPolygon)((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
points)).shapes.get(0);
[javac] ^
[javac]
C:\wipgit\lucene4\lucene-solr\lucene\spatial3d\src\test\org\apache\lucene\spatial3d\geom\GeoPolygonTest.java:1028:
warning: [cast] redundant cast to GeoPolygon
[javac] GeoPolygon polygon =
(GeoPolygon)((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
points,Collections.singletonList(hole))).shapes.get(0);
[javac] ^
[javac] 4 warnings
{code}
I'll fix those if it passes precommit.
> Give access to members of a composite shape
> ---
>
> Key: LUCENE-7918
> URL: https://issues.apache.org/jira/browse/LUCENE-7918
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
> Attachments: LUCENE-7918.patch
>
>
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I
> need to access the members of a composite geoshape. This is currently not
> possible so I was wondering if it is possible to add to more methods to the
> class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[
https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115481#comment-16115481
]
Karl Wright commented on LUCENE-7918:
-
[~ivera], I've been looking at the build.xml code for the top-level project. I
think we can do a fair approximation of "ant precommit" on the lucene side of
the tree by doing the following:
{code}
cd lucene
ant documentation-lint validate
{code}
This works for me generally. Would you like to give it a try on your new code?
I will give it a try tomorrow if I don't hear from you. Thanks!
> Give access to members of a composite shape
> ---
>
> Key: LUCENE-7918
> URL: https://issues.apache.org/jira/browse/LUCENE-7918
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
> Attachments: LUCENE-7918.patch
>
>
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I
> need to access the members of a composite geoshape. This is currently not
> possible so I was wondering if it is possible to add to more methods to the
> class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114386#comment-16114386 ] Karl Wright commented on LUCENE-7918: - [~ivera] I like the generics approach very much; I just want to be sure it passes precommit before going ahead. And yes, I'm seeing exactly what you're seeing with the precommit. :-( > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114380#comment-16114380 ] Karl Wright commented on LUCENE-7918: - [~ivera], there is no requirement in Lucene that all classes need a toString() method, but I do find it is very helpful, and all the concrete object classes in Geo3D have one. So I think that the composite classes should too. They can rely on the members' toString() methods as needed. > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7918.patch > > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
[ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114212#comment-16114212 ] Karl Wright commented on LUCENE-7918: - Hi [~ivera], A word of warning: There's a great deal of concern when we add to the public API of anything in Lucene. This has to be thought out carefully. The addition of GeoCompositeAreaShape was barely OK, and caused precommit errors that I was scrambling around to fix for seven hours yesterday. I would therefore like to revisit the public method signature of GeoCompositeAreaShape as part of this request. The public API for GeoCompositeAreaShape should accept GeoAreaShape for its add method, and the public API for GeoCompositeMembershipShape should accept GeoMembershipShape for its add method. I strongly suggest that both of these classes be derived from a base class with package scope that has protected methods in it only, and some care is made to keep the public API consistent with the classes that define them. For example, your getShape() method needs to return GeoAreaShape for GeoCompositeAreaShape, and GeoMembershipShape for GeoCompositeMembershipShape. Does this make sense? Finally, the patch has to pass "ant precommit" (runnable only at the topmost level of the Lucene/Solr tree). Unfortunately due to a bug in one of the checks I cannot run this on my setup so I will need to rely on you to do it before a patch can be committed. Thanks!! > Give access to members of a composite shape > --- > > Key: LUCENE-7918 > URL: https://issues.apache.org/jira/browse/LUCENE-7918 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > > Hi [~daddywri], > I hope this is my last point in my wish list. In order to serialize objects I > need to access the members of a composite geoshape. This is currently not > possible so I was wondering if it is possible to add to more methods to the > class GeoCompositeMembershipShape: > public int size() > public GeoMembershipShape getShape(int index) > Thanks, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
