[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617581#comment-16617581 ] ASF subversion and git services commented on LUCENE-8503: - Commit 895bff46b2c3d3d027e693e11a2feac9f518191d in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=895bff4 ] Add missing changes entries for LUCENE-8502 and LUCENE-8503 > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.5, master (8.0) > > Time Spent: 20m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617577#comment-16617577 ] ASF subversion and git services commented on LUCENE-8503: - Commit e61f6961cc09b708a438f2fc41a653de0ea0de17 in lucene-solr's branch refs/heads/branch_7_5 from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e61f696 ] Add missing changes entries for LUCENE-8502 and LUCENE-8503 > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.5, master (8.0) > > Time Spent: 20m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617579#comment-16617579 ] ASF subversion and git services commented on LUCENE-8503: - Commit d38e90b85495610a7411305745b50e24201babb6 in lucene-solr's branch refs/heads/branch_7x from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d38e90b ] Add missing changes entries for LUCENE-8502 and LUCENE-8503 > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.5, master (8.0) > > Time Spent: 20m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617573#comment-16617573 ] ASF subversion and git services commented on LUCENE-8503: - Commit 7fe2281f12ef646804aba175f70c18353f65ba37 in lucene-solr's branch refs/heads/branch_7x from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7fe2281 ] LUCENE-8503: Call #getDelegate instead of direct member access during unwrap Filter*Reader instances access the member or the delegate directly instead of calling getDelegate(). In order to track access of the delegate these methods should call #getDelegat() > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617572#comment-16617572 ] ASF subversion and git services commented on LUCENE-8503: - Commit d98e4929a0ea55e8cae4f791ad705f6b776c7c7f in lucene-solr's branch refs/heads/branch_7_5 from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d98e492 ] LUCENE-8503: Call #getDelegate instead of direct member access during unwrap Filter*Reader instances access the member or the delegate directly instead of calling getDelegate(). In order to track access of the delegate these methods should call #getDelegat() > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617570#comment-16617570 ] ASF subversion and git services commented on LUCENE-8503: - Commit 44dbfaab19b5845f27d6174071bd3808756ff552 in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=44dbfaa ] LUCENE-8503: Call #getDelegate instead of direct member access during unwrap Filter*Reader instances access the member or the delegate directly instead of calling getDelegate(). In order to track access of the delegate these methods should call #getDelegat() > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617534#comment-16617534 ] Adrien Grand commented on LUCENE-8503: -- +1 > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617332#comment-16617332 ] Simon Willnauer commented on LUCENE-8503: - I have to revert my statement. I was under the assumption that this happens in way more places than expected. Maybe I was way too deep in it to see it all over the place. :) Nevermind. I will change my pr to only fix the calls to reader.in. instead and keep the rest like it is. > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617309#comment-16617309 ] Simon Willnauer commented on LUCENE-8503: - The reality is that unwrapping happens all over the place even in our codebase. I suspect this is a common problem if you start work with reader hierarchies. I wonder if you would ever see this interface if you don't work with expert API. In this case I think we just make our live easier without risking anything. > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617289#comment-16617289 ] Adrien Grand commented on LUCENE-8503: -- I'm a bit on the fence about adding such an API to ease unwrapping as unwrapping is something that we should avoid to use since it breaks encapsulation? > Simplify unwrapping Filter*Reader > - > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.5, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
