[jira] [Commented] (LUCENE-8535) Should we drop support for highlighting block-join queris
[ https://issues.apache.org/jira/browse/LUCENE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654847#comment-16654847 ] Simon Willnauer commented on LUCENE-8535: - [~jim.ferenczi] I referenced a github PR for this, can you take a look? > Should we drop support for highlighting block-join queris > - > > Key: LUCENE-8535 > URL: https://issues.apache.org/jira/browse/LUCENE-8535 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (8.0) >Reporter: Simon Willnauer >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This is a spin-off from LUCENE-6572. We currently depend on the block-join > module which is due to the fact that we try to highlight the queries wrapped > by the block join queries. The current discussion on LUCENE-6572 mentioned > that this doesn't make much sense from an highlighting perspecitve and if we > should drop support for it. Lucene 8.0 would be a good time to do so. > Thoughts? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8535) Should we drop support for highlighting block-join queris
[ https://issues.apache.org/jira/browse/LUCENE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654045#comment-16654045 ] Jim Ferenczi commented on LUCENE-8535: -- +1 to support this through the extension points. We can add javadocs explaining why we don't handle all queries in the relevant class (WeightedSpanTermsExtractor). > Should we drop support for highlighting block-join queris > - > > Key: LUCENE-8535 > URL: https://issues.apache.org/jira/browse/LUCENE-8535 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (8.0) >Reporter: Simon Willnauer >Priority: Major > > This is a spin-off from LUCENE-6572. We currently depend on the block-join > module which is due to the fact that we try to highlight the queries wrapped > by the block join queries. The current discussion on LUCENE-6572 mentioned > that this doesn't make much sense from an highlighting perspecitve and if we > should drop support for it. Lucene 8.0 would be a good time to do so. > Thoughts? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8535) Should we drop support for highlighting block-join queris
[ https://issues.apache.org/jira/browse/LUCENE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654039#comment-16654039 ] Simon Willnauer commented on LUCENE-8535: - [~jtibshirani] thanks for providing context to this. I do wonder if we should support this our of the box or should use the extension points for unknown queries to support this down the road. That might be a better option now that we have them? > Should we drop support for highlighting block-join queris > - > > Key: LUCENE-8535 > URL: https://issues.apache.org/jira/browse/LUCENE-8535 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (8.0) >Reporter: Simon Willnauer >Priority: Major > > This is a spin-off from LUCENE-6572. We currently depend on the block-join > module which is due to the fact that we try to highlight the queries wrapped > by the block join queries. The current discussion on LUCENE-6572 mentioned > that this doesn't make much sense from an highlighting perspecitve and if we > should drop support for it. Lucene 8.0 would be a good time to do so. > Thoughts? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8535) Should we drop support for highlighting block-join queris
[ https://issues.apache.org/jira/browse/LUCENE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654018#comment-16654018 ] Julie Tibshirani commented on LUCENE-8535: -- I initially added a dependency on ‘join’ as part of https://issues.apache.org/jira/browse/LUCENE-5929. This change addressed an elasticsearch issue where standard highlighting would not work on a nested query ([https://github.com/elastic/elasticsearch/issues/6420]). Because nested documents show up in the same _source as the top-level document, it was pretty natural to want the nested content to be highlighted when performing a nested query. I think we reluctantly added a dependency on ‘join’ because a better solution like a query visitor wasn’t readily available. For additional context, this issue came up several years ago, before elasticsearch supported inner_hits and the ability to highlight nested + child documents. > Should we drop support for highlighting block-join queris > - > > Key: LUCENE-8535 > URL: https://issues.apache.org/jira/browse/LUCENE-8535 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: master (8.0) >Reporter: Simon Willnauer >Priority: Major > > This is a spin-off from LUCENE-6572. We currently depend on the block-join > module which is due to the fact that we try to highlight the queries wrapped > by the block join queries. The current discussion on LUCENE-6572 mentioned > that this doesn't make much sense from an highlighting perspecitve and if we > should drop support for it. Lucene 8.0 would be a good time to do so. > Thoughts? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
