[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890248#comment-15890248 ] Mikhail Khludnev commented on SOLR-10134: - We've done! [~robert_alex], happy testing! > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Fix For: 6.5, master (7.0) > > Attachments: SOLR-10134.patch, SOLR-10134.patch, SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889665#comment-15889665 ] Mikhail Khludnev commented on SOLR-10134: - noticing warnings below, will check them soon {code} [ecj-lint] 1. WARNING in C:\Users\jenkins\workspace\Lucene-Solr-6.x-Windows\solr\core\src\java\org\apache\solr\client\solrj\embedded\EmbeddedSolrServer.java (at line 203) [ecj-lint] new JavaBinCodec(resolver) { [ecj-lint] [ecj-lint] @Override [ecj-lint] public void writeSolrDocument(SolrDocument doc) { [ecj-lint] callback.streamSolrDocument(doc); [ecj-lint] //super.writeSolrDocument( doc, fields ); [ecj-lint] } [ecj-lint] [ecj-lint] @Override [ecj-lint] public void writeSolrDocumentList(SolrDocumentList docs) throws IOException { [ecj-lint] if (docs.size() > 0) { [ecj-lint] SolrDocumentList tmp = new SolrDocumentList(); [ecj-lint] tmp.setMaxScore(docs.getMaxScore()); [ecj-lint] tmp.setNumFound(docs.getNumFound()); [ecj-lint] tmp.setStart(docs.getStart()); [ecj-lint] docs = tmp; [ecj-lint] } [ecj-lint] callback.streamDocListInfo(docs.getNumFound(), docs.getStart(), docs.getMaxScore()); [ecj-lint] super.writeSolrDocumentList(docs); [ecj-lint] } [ecj-lint] [ecj-lint] }.setWritableDocFields(resolver). marshal(rsp.getValues(), out); [ecj-lint] [ecj-lint] Resource leak: '' is never closed [ecj-lint] -- [ecj-lint] 2. WARNING in C:\Users\jenkins\workspace\Lucene-Solr-6.x-Windows\solr\core\src\java\org\apache\solr\client\solrj\embedded\EmbeddedSolrServer.java (at line 227) [ecj-lint] return (NamedList) new JavaBinCodec(resolver).unmarshal(in); [ecj-lint]^^ [ecj-lint] Resource leak: '' is never closed [ecj-lint] -- [ecj-lint] -- {code} > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch, SOLR-10134.patch, SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889662#comment-15889662 ] ASF subversion and git services commented on SOLR-10134: Commit bce1417fceeed2054f16565e96dc49268c1b2ea1 in lucene-solr's branch refs/heads/branch_6x from [~mkhludnev] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bce1417 ] SOLR-10134: EmbeddedSolrServer handles SchemaAPI requests > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch, SOLR-10134.patch, SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889532#comment-15889532 ] ASF subversion and git services commented on SOLR-10134: Commit 0baf2fa33cef485df94649fd408c22e6430b68cf in lucene-solr's branch refs/heads/master from [~mkhludnev] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0baf2fa ] SOLR-10134: EmbeddedSolrServer handles SchemaAPI requests > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch, SOLR-10134.patch, SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875045#comment-15875045 ] Mikhail Khludnev commented on SOLR-10134: - [~robert_alex], the patch is great. I'm tweaking it a little to reduce test footprint. wip. > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871484#comment-15871484 ] Robert Alexandersson commented on SOLR-10134: - I have added a test and noticed that the code had changed quite alot in this so needed to add change more to support the EmbeddedSolrServer requests. It does seem like you are in need of adding more tests in general for the EmbeddedSolrServer as it seems to get lost in the main "http" flows. The tests and code changes can be found in PR on github, https://github.com/apache/lucene-solr/pull/158 > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871482#comment-15871482 ] ASF GitHub Bot commented on SOLR-10134: --- GitHub user alero opened a pull request: https://github.com/apache/lucene-solr/pull/158 SOLR-10134 - Support SchemaAPI in EmbeddedSolrServer Adds support for changing the schema in mutable mode and using EmbeddedSolrServer You can merge this pull request into a Git repository by running: $ git pull https://github.com/alero/lucene-solr master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 3603832e3d4fdb3bfe3fa9eb27202b71dda4e068 Author: Robert AlexanderssonDate: 2017-02-16T16:06:20Z SOLR-10134 Added the httpMethod param to context so SolR SchemaAPI can handle POST calls commit 6de410703d0e1be497289017ca1e1c1c4d8303bd Author: Robert Alexandersson Date: 2017-02-17T07:54:43Z SOLR-10134 Added testcase and enabled the SchemaHandler to parse the incoming command commit 09559122d445aa4efa4cf9beffa6622120fe5f6f Author: Robert Alexandersson Date: 2017-02-17T07:59:25Z SOLR-10134 Added testcase and enabled the SchemaHandler to parse the incoming command commit dc02bcf8de62169dbbe9674c5d5f899c5064e37c Author: Robert Alexandersson Date: 2017-02-17T09:03:00Z SOLR-10134 Improved the test case and added a failing test for immutable config > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870303#comment-15870303 ] Mikhail Khludnev commented on SOLR-10134: - [~alero], can you also contribute a test? > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870187#comment-15870187 ] Robert Alexandersson commented on SOLR-10134: - Path uploaded and can be found here as well: https://github.com/alero/lucene-solr/commit/3603832e3d4fdb3bfe3fa9eb27202b71dda4e068 > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Attachments: SOLR-10134.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10134) EmbeddedSolrServer does not support SchemaAPI
[ https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869582#comment-15869582 ] Mikhail Khludnev commented on SOLR-10134: - can you create a patch? > EmbeddedSolrServer does not support SchemaAPI > - > > Key: SOLR-10134 > URL: https://issues.apache.org/jira/browse/SOLR-10134 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Server, SolrJ >Affects Versions: 6.4.1 >Reporter: Robert Alexandersson > Labels: test-driven > Original Estimate: 2h > Remaining Estimate: 2h > > The EmbeddedSolrServer server does not support calls to the POST methods of > SchemaAPI using SolRJ api. The reason is that the httpMethod param is never > set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later > required by the SchemaHandler class that actually performs the call at > SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). > Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at > aprox row 174 with the following: "req.getContext().put("httpMethod", > request.getMethod().name());". This change requires the Factory methods of > SolrJ to add the intended method to be used example : new > SchemaRequest.AddField() should append the POST method similar to how the > SchemaRequest.Field appends the GET method. > I have written a separate EmbeddedSolrServer that replaces the one in SolR. > It works for now and fields can be created on the fly using the SchemaAPI of > the solrj client, but would like to be able to remove this workaround. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org