[jira] [Commented] (SOLR-10414) RecoveryStrategy should be Runnable and not a Thread
[
https://issues.apache.org/jira/browse/SOLR-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013285#comment-16013285
]
ASF subversion and git services commented on SOLR-10414:
Commit c9abe7db23578545eaa67414778b501b2b115b8a in lucene-solr's branch
refs/heads/master from Tomas Fernandez Lobbe
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c9abe7d ]
SOLR-10414: RecoveryStrategy is now a Runnable instead of a Thread
> RecoveryStrategy should be Runnable and not a Thread
>
>
> Key: SOLR-10414
> URL: https://issues.apache.org/jira/browse/SOLR-10414
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Tomás Fernández Löbbe
>Priority: Minor
> Attachments: SOLR-10414.patch
>
>
> {{RecoveryStrategy}} is currently a {{Thread}} but is never started, it's
> just used as a {{Runnable}} and submitted to Executors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10414) RecoveryStrategy should be Runnable and not a Thread
[
https://issues.apache.org/jira/browse/SOLR-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955389#comment-15955389
]
Tomás Fernández Löbbe commented on SOLR-10414:
--
If I'm reading the code correctly, the {{setName(...)}} inside
{{RecoveryStrategy}}'s constructor is changing it's own {{Thread#name}},
however that thread is never started, so that name is never really reflected
anywhere, the Executor is just calling {{RecoveryStrategy#run()}}. I thought
about setting the name of the current thread inside {{run()}}, however, the
executor where this is ran from already handles thread names (added with MDC
logging changes as you say).
> RecoveryStrategy should be Runnable and not a Thread
>
>
> Key: SOLR-10414
> URL: https://issues.apache.org/jira/browse/SOLR-10414
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Tomás Fernández Löbbe
>Priority: Minor
> Attachments: SOLR-10414.patch
>
>
> {{RecoveryStrategy}} is currently a {{Thread}} but is never started, it's
> just used as a {{Runnable}} and submitted to Executors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10414) RecoveryStrategy should be Runnable and not a Thread
[
https://issues.apache.org/jira/browse/SOLR-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955150#comment-15955150
]
Christine Poerschke commented on SOLR-10414:
SOLR-6885 added the {{setName("RecoveryThread-"+this.coreName);}} that is being
removed here and I'd be curious as to whether or not logging from different
cores in the same JVM would still be distinguishable without it. I think it
would be, via the {{MDCLoggingContext}} stuff added later under SOLR-7590.
So +1 for RecoveryStrategy not being a Thread then.
> RecoveryStrategy should be Runnable and not a Thread
>
>
> Key: SOLR-10414
> URL: https://issues.apache.org/jira/browse/SOLR-10414
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Tomás Fernández Löbbe
>Priority: Minor
> Attachments: SOLR-10414.patch
>
>
> {{RecoveryStrategy}} is currently a {{Thread}} but is never started, it's
> just used as a {{Runnable}} and submitted to Executors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
