[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633047#comment-16633047
]
Mikhail Khludnev commented on SOLR-11380:
-
In scope of SOLR-12798 I'd like to note that deprecating
{{SolrRequest.getContentStreams()}} enforces passing parameters via url at
contrast to content streams which can be put along side with params as separate
parts of mulipart requests. And therefore, it may hit too long url. Beside of
it, I truly support the issue summary.
> SolrJ must stream docs to server instead of writing to a byte[] first
> --
>
> Key: SOLR-11380
> URL: https://issues.apache.org/jira/browse/SOLR-11380
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Fix For: 7.2, master (8.0)
>
> Attachments: SOLR-11380.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251779#comment-16251779 ] Noble Paul commented on SOLR-11380: --- bq.RE GenericSolrRequest: I think you may misunderstand what I'm getting at. right. bq.I think you should mark every public reference to a method referencing ContentStream as deprecated in SolrJ so that by 8.0 users know not to use it anymore. right. we should make it more obvious > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251775#comment-16251775 ] ASF subversion and git services commented on SOLR-11380: Commit 79283834bcbf4bd802e9ce146a441838047d4c90 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7928383 ] SOLR-11380:removed GenericRequest.setContentStreams() > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251773#comment-16251773 ] ASF subversion and git services commented on SOLR-11380: Commit 4fbc6efd5d71fbf23656a7e63107ea3315f1b1ae in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4fbc6ef ] SOLR-11380:removed GenericRequest.setContentStreams() > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251614#comment-16251614 ] David Smiley commented on SOLR-11380: - RE GenericSolrRequest: I think you may misunderstand what I'm getting at. GSR had a getter & setter for a field. You removed the getter from this class, letting it use a new default implementation at the SolrRequest level that returns null. This is clearly broken; if someone uses this class, calling the setter, they expect the getter will return it! RE your suggestion of a getter & setter for ContentWriter is good. I think you should mark every public reference to a method referencing ContentStream as deprecated in SolrJ so that by 8.0 users know not to use it anymore. To enhance visibility in the community of this fact, perhaps file as a separate issue. BTW I looked at the viability of my 2nd bullet question on implementing RequestWriter.getContentWriter in terms of a getContentStreams but its impossible. So that's some technical debt to be cleaned up in 8.0. > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242492#comment-16242492 ] Noble Paul commented on SOLR-11380: --- bq.I suppose org.apache.solr.client.solrj.request.RequestWriter#getContentStreams should also be deprecated? +1 bq. You removed the getter of content streams from GenericSolrRequest but I think it should stay for this class? There's certainly something wrong if the setter stays without the getter. No , it's not removed. But, we can add setter/getter for contentWriter > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242439#comment-16242439
]
David Smiley commented on SOLR-11380:
-
Ah; much clearer!
* I suppose
{{org.apache.solr.client.solrj.request.RequestWriter#getContentStreams}} should
also be deprecated?
* Did you try to implement RequestWriter.getContentWriter in terms of a
getContentStreams if the latter was provided? It'd be great if that were
possible as it would greatly simplify
{{org.apache.solr.client.solrj.impl.HttpSolrClient#createMethod}} which calls
both. That said, perhaps it's not easy and needs to be punted until 8.0.
* You removed the getter of content streams from GenericSolrRequest but I think
it should stay for this class? There's certainly something wrong if the setter
stays without the getter.
> SolrJ must stream docs to server instead of writing to a byte[] first
> --
>
> Key: SOLR-11380
> URL: https://issues.apache.org/jira/browse/SOLR-11380
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
> Fix For: 7.2, master (8.0)
>
> Attachments: SOLR-11380.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241638#comment-16241638 ] ASF subversion and git services commented on SOLR-11380: Commit b48d87cde07c94e28e3940d52cbd7491ca1427b2 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b48d87c ] SOLR-11380: deprecated getContentStreams() > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241613#comment-16241613 ] ASF subversion and git services commented on SOLR-11380: Commit a03d6bc8c27d3d97011bc5bdc2aeb94c4820628c in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a03d6bc ] SOLR-11380: deprecated getContentStreams() > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241486#comment-16241486
]
David Smiley commented on SOLR-11380:
-
[~noble.paul] it's confusing to me that SolrRequest now has a
{{getContentWriter}} method which now seems to compete with
{{getContentStreams}}. I think it will be confusing to our users too --
SolrRequest is a visible part of SolrJ. Perhaps you could add some
documentation to these methods to deconflict when they are used, and what the
"expectedType" param is?
BTW the CHANGES.txt entry appears in "Other" yet isn't "Optimizations" fitting?
> SolrJ must stream docs to server instead of writing to a byte[] first
> --
>
> Key: SOLR-11380
> URL: https://issues.apache.org/jira/browse/SOLR-11380
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
> Fix For: 7.2, master (8.0)
>
> Attachments: SOLR-11380.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235416#comment-16235416 ] ASF subversion and git services commented on SOLR-11380: Commit f564f9ca4b7766d1bcad18f2f18f8b64929cdef2 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f564f9c ] SOLR-11380: Test failure > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235413#comment-16235413 ] ASF subversion and git services commented on SOLR-11380: Commit 3f0a012d92b2d3f4138f87ed48ca5a0e59ddb76d in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3f0a012 ] SOLR-11380: Test failure > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235305#comment-16235305 ] ASF subversion and git services commented on SOLR-11380: Commit c4b033b7f76e63da7b7c3193ab137efdebdd8533 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c4b033b ] SOLR-11380: V2request also converted to do streaming write > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235299#comment-16235299 ] ASF subversion and git services commented on SOLR-11380: Commit 0e738a0369fe3ece62b74ae10d7fd843ce5df91a in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0e738a0 ] SOLR-11380: V2request also converted to do streaming write > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233799#comment-16233799 ] ASF subversion and git services commented on SOLR-11380: Commit 1b8747ec4f3dfd0c1572c8e34857a8d12a71b7b4 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1b8747e ] SOLR-11380: XML request writer also stream request > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233798#comment-16233798 ] ASF subversion and git services commented on SOLR-11380: Commit 9192e7e6887f08beea3f61e2c574c1e2232b0c38 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9192e7e ] SOLR-11380: XML request writer also stream request > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227207#comment-16227207 ] David Smiley commented on SOLR-11380: - IMO a separate issue isn't needed since the paint is still wet, so to speak. Either way, please fix this duplication. > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227067#comment-16227067 ] Noble Paul commented on SOLR-11380: --- bq. I don't see how what you're saying explains how the code needs to be the way it is – how it can't be simplified. the code can be simplified. I just wasn't focussing on this part. I was tackling the low hanging fruit. We can open a ticket to clean up this > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226867#comment-16226867 ] David Smiley commented on SOLR-11380: - Sorry I'm still confused. Is there an actual point to the "if" condition with code duplication? I don't see how what you're saying explains how the code needs to be the way it is -- how it can't be simplified. I can't imagine how in _any_ circumstance that it has a semantic difference with the simplified replacement. If it does, man you have stumped me badly and I want to learn! Perhaps chat with me on IRC "dsmiley"; I want to understand this. If it can be replaced and tests pass / semantically equivalent, then I think we should do so. Otherwise, it needs comments on how this code needs to be this way. BTW thanks for doing this issue -- I love it when we can stream data more instead of wasteful buffering! > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226306#comment-16226306 ] ASF subversion and git services commented on SOLR-11380: Commit cb3ed762fb418ff2af43b520cbe233cf74bccdd1 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cb3ed76 ] SOLR-11380: use the inNull() method to check for empty UpdateRequest > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226305#comment-16226305 ] ASF subversion and git services commented on SOLR-11380: Commit dd56f5ca845bb06c2621188fe9a1e20bdec5e25d in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dd56f5c ] SOLR-11380: use the inNull() method to check for empty UpdateRequest > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226261#comment-16226261
]
Noble Paul commented on SOLR-11380:
---
Correct. The code is identical AND useless.
The point is even if we make it better, it is extremely difficult to do a
Streaming WRITE to an {{InputStream}} .
> SolrJ must stream docs to server instead of writing to a byte[] first
> --
>
> Key: SOLR-11380
> URL: https://issues.apache.org/jira/browse/SOLR-11380
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
> Fix For: 7.2, master (8.0)
>
> Attachments: SOLR-11380.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226245#comment-16226245
]
David Smiley commented on SOLR-11380:
-
Ok but the code is identical on both sides of the {{else}} which can't be
intended?
> SolrJ must stream docs to server instead of writing to a byte[] first
> --
>
> Key: SOLR-11380
> URL: https://issues.apache.org/jira/browse/SOLR-11380
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
> Fix For: 7.2, master (8.0)
>
> Attachments: SOLR-11380.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226223#comment-16226223 ] ASF subversion and git services commented on SOLR-11380: Commit 4b316ec1397431525e25f4c7ceba23c636e71209 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b316ec ] SOLR-11380: SolrJ must stream docs to server instead of writing to a buffer first > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 7.2, master (8.0) > > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226216#comment-16226216
]
Noble Paul commented on SOLR-11380:
---
The {{ if (contentStream\[0\] instanceof RequestWriter.LazyContentStream)}}
check is done because the payload size cannot be determined ahead of time. The
{{ContentStream}} interface is not suitable to generate and write content
just-in-time. The new {{ContentWriter}} interface is similar to our
{{QueryResponseWriter}} interface.
> SolrJ must stream docs to server instead of writing to a byte[] first
> --
>
> Key: SOLR-11380
> URL: https://issues.apache.org/jira/browse/SOLR-11380
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
> Attachments: SOLR-11380.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226209#comment-16226209
]
David Smiley commented on SOLR-11380:
-
Noble, why does HttpSolrClient check {{if (contentStream\[0\] instanceof
RequestWriter.LazyContentStream)}} and do the same dozen lines of code for both
true & false? This looks like something you had in-progress.
> SolrJ must stream docs to server instead of writing to a byte[] first
> --
>
> Key: SOLR-11380
> URL: https://issues.apache.org/jira/browse/SOLR-11380
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
> Attachments: SOLR-11380.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
[ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226151#comment-16226151 ] ASF subversion and git services commented on SOLR-11380: Commit 706b6c91718a1d5e4e7fd8d677798bb7ee3cb2ad in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=706b6c9 ] SOLR-11380: SolrJ must stream docs to server instead of writing to a buffer first > SolrJ must stream docs to server instead of writing to a byte[] first > -- > > Key: SOLR-11380 > URL: https://issues.apache.org/jira/browse/SOLR-11380 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul > Attachments: SOLR-11380.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
