[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603409#comment-16603409 ] ASF subversion and git services commented on SOLR-11861: Commit 7f0967ad9303f4fa7fa302bca0908c8754948aad in lucene-solr's branch refs/heads/branch_7x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7f0967a ] SOLR-11861: baseConfigSet now defaults to _default (cherry picked from commit b1b0963947503dac20e84950ca30511e9aace9e1) > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch, SOLR-11861.patch, SOLR-11861.patch, > SOLR-11861.patch, SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603398#comment-16603398 ] ASF subversion and git services commented on SOLR-11861: Commit b1b0963947503dac20e84950ca30511e9aace9e1 in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b1b0963 ] SOLR-11861 baseConfigSet default > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch, SOLR-11861.patch, SOLR-11861.patch, > SOLR-11861.patch, SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[
https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601149#comment-16601149
]
Lucene/Solr QA commented on SOLR-11861:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} |
{color:green} 1m 2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 47m 41s{color}
| {color:red} core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
38s{color} | {color:green} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.handler.RequestLoggingTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11861 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12938028/SOLR-11861.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns validaterefguide |
| uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu
Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / d93c46e |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/175/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/175/testReport/ |
| modules | C: solr solr/core solr/solrj solr/solr-ref-guide U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/175/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ConfigSets CREATE baseConfigSet param should default to _default
>
>
> Key: SOLR-11861
> URL: https://issues.apache.org/jira/browse/SOLR-11861
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: David Smiley
>Priority: Minor
> Labels: newdev
> Attachments: SOLR-11861.patch, SOLR-11861.patch, SOLR-11861.patch,
> SOLR-11861.patch, SOLR-11861.patch
>
>
> It would be nice if I didn't have to specify the baseConfigSet param now that
> we have a default configSet "_default".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599934#comment-16599934 ] Amrit Sarkar commented on SOLR-11861: - Should have prepared final patch with updated doc reviews, thanks David for feedback and corresponding improvements. > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch, SOLR-11861.patch, SOLR-11861.patch, > SOLR-11861.patch, SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599930#comment-16599930 ] David Smiley commented on SOLR-11861: - Thanks Amrit. There were some issues so I updated a new patch: * modified the v2 API docs to account for the fact that this parameter is no longer required * modified the ref guide to mention this parameter now has a default. * changed the ConfigSetHandler action code: ** use the SolrParams.get(name,default) overloaded version instead doing a null check after which is more verbose ** changed the "props" line back to how it was, though removing BASE_CONFIGSET_NAME since that part isn't required. You changed it to use a deprecated method on SolrParams, so I reverted. * improved OverseerConfigSetMessageHandler to use the overloaded version of ZkNodeProps.getStr(name,default) instead doing a null check after which is more verbose Upon reflection, it's pretty sad such a simple change has to touch so many things. > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch, SOLR-11861.patch, SOLR-11861.patch, > SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[
https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599468#comment-16599468
]
Lucene/Solr QA commented on SOLR-11861:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 41m
32s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
35s{color} | {color:green} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11861 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12937923/SOLR-11861.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu
Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 4d78db2 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/174/testReport/ |
| modules | C: solr/core solr/solrj U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/174/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ConfigSets CREATE baseConfigSet param should default to _default
>
>
> Key: SOLR-11861
> URL: https://issues.apache.org/jira/browse/SOLR-11861
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: David Smiley
>Priority: Minor
> Labels: newdev
> Attachments: SOLR-11861.patch, SOLR-11861.patch, SOLR-11861.patch
>
>
> It would be nice if I didn't have to specify the baseConfigSet param now that
> we have a default configSet "_default".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[
https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598783#comment-16598783
]
Lucene/Solr QA commented on SOLR-11861:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} SOLR-11861 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-11861 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12915389/SOLR-11861.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/173/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ConfigSets CREATE baseConfigSet param should default to _default
>
>
> Key: SOLR-11861
> URL: https://issues.apache.org/jira/browse/SOLR-11861
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: David Smiley
>Priority: Minor
> Labels: newdev
> Attachments: SOLR-11861.patch, SOLR-11861.patch
>
>
> It would be nice if I didn't have to specify the baseConfigSet param now that
> we have a default configSet "_default".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598080#comment-16598080 ] Amrit Sarkar commented on SOLR-11861: - Just glanced through the current patch, and it looks good. There are two manner config gets created and need the default behavior at both places. Requesting feedback. > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch, SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495121#comment-16495121 ] Amrit Sarkar commented on SOLR-11861: - Sorry for being this late; unfortunately I don't see myself completing this before July. I am open and will appreciate if someone else picks up and finishes it. > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch, SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434223#comment-16434223 ] Amrit Sarkar commented on SOLR-11861: - Will finish up the tests by this weekend positively. > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch, SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[
https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407117#comment-16407117
]
Amrit Sarkar commented on SOLR-11861:
-
oh, what did I do! Attached patch with relevant changes. One single assertion
is failing in {{TestConfigSetsAPI}}, and had to set
{{DEFAULT_BASE_CONFIGSET_NAME}} as default in {{ConfigSetsHandler}} for now,
figuring out what am I missing. Will post final patch soon.
> ConfigSets CREATE baseConfigSet param should default to _default
>
>
> Key: SOLR-11861
> URL: https://issues.apache.org/jira/browse/SOLR-11861
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: David Smiley
>Priority: Minor
> Labels: newdev
> Attachments: SOLR-11861.patch
>
>
> It would be nice if I didn't have to specify the baseConfigSet param now that
> we have a default configSet "_default".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406981#comment-16406981 ] David Smiley commented on SOLR-11861: - [~sarkaramr...@gmail.com] you've changed the SolrJ client to do the default but instead we want this server-side. There will be some of your changes here nonetheless so that SolrJ doesn't complain that the configSet hasn't been set (since it's no longer required). > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11861) ConfigSets CREATE baseConfigSet param should default to _default
[ https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403115#comment-16403115 ] Amrit Sarkar commented on SOLR-11861: - [~dsmiley], attached small patch for the improvement here with relevant tests validating the same. Feedback will be deeply appreciated. > ConfigSets CREATE baseConfigSet param should default to _default > > > Key: SOLR-11861 > URL: https://issues.apache.org/jira/browse/SOLR-11861 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: David Smiley >Priority: Minor > Labels: newdev > Attachments: SOLR-11861.patch > > > It would be nice if I didn't have to specify the baseConfigSet param now that > we have a default configSet "_default". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
