[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[
https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773687#comment-16773687
]
Mikhail Khludnev commented on SOLR-12208:
-
Hello, I suppose it's not hard to tackle
{quote}
Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/3182/
1 tests failed.
FAILED:
org.apache.solr.cloud.autoscaling.sim.TestSimExtremeIndexing.testScaleUp
Error Message:
java.util.concurrent.ExecutionException:
java.util.ConcurrentModificationException
Stack Trace:
java.io.IOException: java.util.concurrent.ExecutionException:
java.util.ConcurrentModificationException
at
__randomizedtesting.SeedInfo.seed([EAB60F4AA87A3212:CBE849E8A454ECB3]:0)
at
org.apache.solr.cloud.autoscaling.sim.SimCloudManager.request(SimCloudManager.java:656)
at
org.apache.solr.cloud.autoscaling.sim.SimCloudManager$1.request(SimCloudManager.java:224)
at
org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:207)
{quote}
> Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
> --
>
> Key: SOLR-12208
> URL: https://issues.apache.org/jira/browse/SOLR-12208
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: 7.5, 8.0
>
> Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch
>
>
> CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume
> the values are expressed in gigabytes. This alone is confusing considering
> the name of the metric.
> Additionally, it causes conflicts in the simulation framework that would
> require substantial changes to resolve (ReplicaInfo-s in
> SimClusterStateProvider keep metric values in their variables, expressed in
> original units - but then the Policy assumes it can put the values expressed
> in GB under the same key... hilarity ensues).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607289#comment-16607289 ] Cassandra Targett commented on SOLR-12208: -- Thanks [~ab], I won't change anything for this then. > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607009#comment-16607009 ] Andrzej Bialecki commented on SOLR-12208: -- No - all of these doc references are still correct. This issue addresses how this metric name was used internally for autoscaling policy calculations. > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[
https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606227#comment-16606227
]
Cassandra Targett commented on SOLR-12208:
--
[~ab], [~noble.paul]: The Ref Guide still references {{INDEX.sizeInBytes}} in 3
places in 2 files: 2x in {{metrics-history.adoc}} and 1x in
{{solrcloud-autoscaling-triggers.adoc}}.
ALL of these references need to be changed to {{INDEX.sizeInGB}}, correct?
> Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
> --
>
> Key: SOLR-12208
> URL: https://issues.apache.org/jira/browse/SOLR-12208
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Reporter: Andrzej Bialecki
>Assignee: Andrzej Bialecki
>Priority: Major
> Fix For: master (8.0), 7.5
>
> Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch
>
>
> CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume
> the values are expressed in gigabytes. This alone is confusing considering
> the name of the metric.
> Additionally, it causes conflicts in the simulation framework that would
> require substantial changes to resolve (ReplicaInfo-s in
> SimClusterStateProvider keep metric values in their variables, expressed in
> original units - but then the Policy assumes it can put the values expressed
> in GB under the same key... hilarity ensues).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511190#comment-16511190 ] ASF subversion and git services commented on SOLR-12208: Commit 1fd62773c51f7a84c2f6d732f59c688bb8f1233b in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1fd6277 ] SOLR-12208: added a testcase for fetching arbitrary replica info > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511188#comment-16511188 ] ASF subversion and git services commented on SOLR-12208: Commit 377f16de5e465277209d1f791d95416132584b16 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=377f16d ] SOLR-12208: added a testcase for fetching arbitrary replica info > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509746#comment-16509746 ] ASF subversion and git services commented on SOLR-12208: Commit e8d37eb8e9b4b133710a3ecdbc3849605b204452 in lucene-solr's branch refs/heads/branch_7x from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e8d37eb ] SOLR-12208: Add simulator support for properly tracking INDEX.sizeInBytes and INDEX.sizeInGB. > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509683#comment-16509683 ] ASF subversion and git services commented on SOLR-12208: Commit 7c4bad0e8f6c6befa1aeb79b9a047cae40134ba8 in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7c4bad0 ] SOLR-12208: Add simulator support for properly tracking INDEX.sizeInBytes and INDEX.sizeInGB. > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Andrzej Bialecki >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509337#comment-16509337 ] ASF subversion and git services commented on SOLR-12208: Commit 6013fa4aeb2113746153cef25e0a8b8be3ae090a in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6013fa4 ] SOLR-12208: ignored the test , because it fails now > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Noble Paul >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509336#comment-16509336 ] ASF subversion and git services commented on SOLR-12208: Commit d9da757bc5613ab89b208e59ad14bdf1ddfb4cd7 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d9da757 ] SOLR-12208: ignored the test , because it fails now > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Noble Paul >Priority: Major > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509128#comment-16509128 ] ASF subversion and git services commented on SOLR-12208: Commit f847488e8dc59b5562f1a15db10ca12ba50814a7 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f847488 ] SOLR-12208: Renamed the autoscaling variable 'INDEX.sizeInBytes' to 'INDEX.sizeInGB' > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509127#comment-16509127 ] ASF subversion and git services commented on SOLR-12208: Commit 98a4dd29ef615897656f01ebac40957ca5fce432 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=98a4dd2 ] SOLR-12208: Renamed the autoscaling variable 'INDEX.sizeInBytes' to 'INDEX.sizeInGB' > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[
https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508311#comment-16508311
]
Andrzej Bialecki commented on SOLR-12208:
--
True - {{metricsAttribute}} sounds fine.
> Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
> --
>
> Key: SOLR-12208
> URL: https://issues.apache.org/jira/browse/SOLR-12208
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
>Priority: Major
> Attachments: SOLR-12208.patch, SOLR-12208.patch, SOLR-12208.patch
>
>
> CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume
> the values are expressed in gigabytes. This alone is confusing considering
> the name of the metric.
> Additionally, it causes conflicts in the simulation framework that would
> require substantial changes to resolve (ReplicaInfo-s in
> SimClusterStateProvider keep metric values in their variables, expressed in
> original units - but then the Policy assumes it can put the values expressed
> in GB under the same key... hilarity ensues).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508008#comment-16508008 ] Noble Paul commented on SOLR-12208: --- it's not the actual metrics name , right? > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[
https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507990#comment-16507990
]
Andrzej Bialecki commented on SOLR-12208:
--
This looks good. Minor issue: {{Suggestion.metricsAttrSuffix}} is a confusing
name in the context of this class - it's used as a suffix in
{{SolrClientNodeStateProvider}} but IMHO it should have a name that reflects
what it really is, eg. {{metricName}} and makes sense also in other contexts.
> Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
> --
>
> Key: SOLR-12208
> URL: https://issues.apache.org/jira/browse/SOLR-12208
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
>Reporter: Andrzej Bialecki
>Assignee: Noble Paul
>Priority: Major
> Attachments: SOLR-12208.patch
>
>
> CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume
> the values are expressed in gigabytes. This alone is confusing considering
> the name of the metric.
> Additionally, it causes conflicts in the simulation framework that would
> require substantial changes to resolve (ReplicaInfo-s in
> SimClusterStateProvider keep metric values in their variables, expressed in
> original units - but then the Policy assumes it can put the values expressed
> in GB under the same key... hilarity ensues).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12208) Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
[ https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507981#comment-16507981 ] Noble Paul commented on SOLR-12208: --- [~ab] please take a look > Don't use "INDEX.sizeInBytes" as a tag name in policy calculations > -- > > Key: SOLR-12208 > URL: https://issues.apache.org/jira/browse/SOLR-12208 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling >Reporter: Andrzej Bialecki >Assignee: Noble Paul >Priority: Major > Attachments: SOLR-12208.patch > > > CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume > the values are expressed in gigabytes. This alone is confusing considering > the name of the metric. > Additionally, it causes conflicts in the simulation framework that would > require substantial changes to resolve (ReplicaInfo-s in > SimClusterStateProvider keep metric values in their variables, expressed in > original units - but then the Policy assumes it can put the values expressed > in GB under the same key... hilarity ensues). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
