[jira] [Commented] (SOLR-12251) pk ids not sort when in deltaQuery
[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859597#comment-16859597
]
Lucene/Solr QA commented on SOLR-12251:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} SOLR-12251 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12251 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920026/SOLR-12251.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/414/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> pk ids not sort when in deltaQuery
> ---
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
>Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
>Reporter: wzhonggo
>Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12251) pk ids not sort when in deltaQuery
[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447393#comment-16447393
]
Shawn Heisey commented on SOLR-12251:
-
I'm trying to examine the current DIH tests. I can't make any sense of them.
The inheritance is too deep and intricate.
> pk ids not sort when in deltaQuery
> ---
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - DataImportHandler
>Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
>Reporter: wzhonggo
>Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12251) pk ids not sort when in deltaQuery
[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447384#comment-16447384
]
Shawn Heisey commented on SOLR-12251:
-
[~mkhludnev], I'm all for tests. Got any idea how to write one?
I think we have some tests using one of the all-java databases. Could we start
with one of them to duplicate the data that ends up out of order?
> pk ids not sort when in deltaQuery
> ---
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - DataImportHandler
>Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
>Reporter: wzhonggo
>Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12251) pk ids not sort when in deltaQuery
[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446790#comment-16446790
]
Mikhail Khludnev commented on SOLR-12251:
-
Despite the change is really small, I still prefer to have a test asserting
linkage nature of the maps.
> pk ids not sort when in deltaQuery
> ---
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - DataImportHandler
>Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
>Reporter: wzhonggo
>Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12251) pk ids not sort when in deltaQuery
[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446758#comment-16446758
]
Lucene/Solr QA commented on SOLR-12251:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
2s{color} | {color:green} dataimporthandler in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 6m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12251 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920026/SOLR-12251.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 8f296d0 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
| Default Java | 1.8.0_152 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/63/testReport/ |
| modules | C: solr/contrib/dataimporthandler U: solr/contrib/dataimporthandler
|
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/63/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> pk ids not sort when in deltaQuery
> ---
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - DataImportHandler
>Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
>Reporter: wzhonggo
>Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12251) pk ids not sort when in deltaQuery
[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446667#comment-16446667
]
wzhonggo commented on SOLR-12251:
-
Hi
I not search #SOLR-7952 before create this issue. This is my mistake.
I clone [lucene-solr|https://github.com/apache/lucene-solr] form github ,
change HashSet to LinkedHashSet , HashMap to LinkedHashMap. I reset version to
7.1 branch and rebuild dataimporthandle.jar. Use new dataimporthandle.jar will
correct. It is like [SOLR-7952.patch|[^SOLR-7952.patch].]
I want to know why not use LinkedHashSet and LinkedHashMap. I am newer for solr.
Is there any other reason.
Thank you very much
> pk ids not sort when in deltaQuery
> ---
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - DataImportHandler
>Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
>Reporter: wzhonggo
>Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12251) pk ids not sort when in deltaQuery
[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445884#comment-16445884
]
Shawn Heisey commented on SOLR-12251:
-
The patch also removes wildcard imports and makes a few formatting adjustments.
I looked at all usages of HashMap as well as HashSet in DocBuilder and
adjusted one of the HashMap usages to LinkedHashMap.
In the JdbcDataSource class, there were a couple of warnings from my IDE about
unnecessary else clauses, so I adjusted those too, and removed the wildcard
imports found there. (I was looking at JdbcDataSource to confirm which class
would log SQL statements, if that became necessary)
I've looked into the arguments on both sides of the debate on wildcard versus
specific imports. I think the potential problems with wildcard imports far
outweigh any level of convenience for somebody who wants to avoid hand-typing a
lot of import statements.
> pk ids not sort when in deltaQuery
> ---
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - DataImportHandler
>Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
>Reporter: wzhonggo
>Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
