[jira] [Commented] (SOLR-12870) Use StandardCharsets instead of String values

2019-07-19 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889367#comment-16889367
 ] 

ASF subversion and git services commented on SOLR-12870:


Commit 37955f789edf8f97d542c6bf114ad1c52bd03acd in lucene-solr's branch 
refs/heads/branch_8x from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=37955f7 ]

SOLR-12870: use StandardCharsets instead of String values

Fixes #469


> Use StandardCharsets instead of String values
> -
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
>  Issue Type: Improvement
>Reporter: Peter Somogyi
>Priority: Minor
> Attachments: SOLR-12870.master.1.patch, SOLR-12870.patch, 
> SOLR-12870.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is 
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch 
> block caused by UnsupportedEncodingException.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-12870) Use StandardCharsets instead of String values

2019-07-19 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889363#comment-16889363
 ] 

ASF subversion and git services commented on SOLR-12870:


Commit 96d400f5118abb581cba078f2acf83bd7106aeb9 in lucene-solr's branch 
refs/heads/master from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=96d400f ]

SOLR-12870: use StandardCharsets instead of String values

Fixes #469


> Use StandardCharsets instead of String values
> -
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
>  Issue Type: Improvement
>Reporter: Peter Somogyi
>Priority: Minor
> Attachments: SOLR-12870.master.1.patch, SOLR-12870.patch, 
> SOLR-12870.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is 
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch 
> block caused by UnsupportedEncodingException.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-12870) Use StandardCharsets instead of String values

2019-07-19 Thread Lucene/Solr QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889278#comment-16889278
 ] 

Lucene/Solr QA commented on SOLR-12870:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 10 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m 
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  2m 16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  1m 58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  1m 58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 32m 
39s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
48s{color} | {color:green} solrj in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
32s{color} | {color:green} test-framework in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 45s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12870 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12975166/SOLR-12870.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / c5cabf1e03 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/501/testReport/ |
| modules | C: solr solr/core solr/solrj solr/test-framework U: solr |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/501/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Use StandardCharsets instead of String values
> -
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
>  Issue Type: Improvement
>Reporter: Peter Somogyi
>Priority: Minor
> Attachments: SOLR-12870.master.1.patch, SOLR-12870.patch, 
> SOLR-12870.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is 
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch 
> block caused by UnsupportedEncodingException.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-12870) Use StandardCharsets instead of String values

2019-07-18 Thread Munendra S N (JIRA) 


[ 
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888020#comment-16888020
 ] 

Munendra S N commented on SOLR-12870:
-

 [^SOLR-12870.patch] 
Rebased to the latest master

> Use StandardCharsets instead of String values
> -
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
>  Issue Type: Improvement
>Reporter: Peter Somogyi
>Priority: Minor
> Attachments: SOLR-12870.master.1.patch, SOLR-12870.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is 
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch 
> block caused by UnsupportedEncodingException.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-12870) Use StandardCharsets instead of String values

2019-06-09 Thread Lucene/Solr QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859662#comment-16859662
 ] 

Lucene/Solr QA commented on SOLR-12870:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} 
| {color:red} SOLR-12870 does not apply to master. Rebase required? Wrong 
Branch? See 
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help. 
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12870 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12943988/SOLR-12870.master.1.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/428/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Use StandardCharsets instead of String values
> -
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
>  Issue Type: Improvement
>Reporter: Peter Somogyi
>Priority: Minor
> Attachments: SOLR-12870.master.1.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is 
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch 
> block caused by UnsupportedEncodingException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-12870) Use StandardCharsets instead of String values

2018-10-16 Thread Peter Somogyi (JIRA) 


[ 
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652160#comment-16652160
 ] 

Peter Somogyi commented on SOLR-12870:
--

I tested the 2 failures and they don't look related to this patch. 
TestCollectionStateWatchers fails on parent commit as well and 
MultiThreadedOCPTest fails intermittently.

Could someone take a look?

> Use StandardCharsets instead of String values
> -
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Peter Somogyi
>Priority: Minor
> Attachments: SOLR-12870.master.1.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is 
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch 
> block caused by UnsupportedEncodingException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-12870) Use StandardCharsets instead of String values

2018-10-15 Thread Lucene/Solr QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651015#comment-16651015
 ] 

Lucene/Solr QA commented on SOLR-12870:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 11 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  3m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  2m 51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  2m 51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 81m 44s{color} 
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  9m 20s{color} 
| {color:red} solrj in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
40s{color} | {color:green} test-framework in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}105m 44s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.MultiThreadedOCPTest |
|   | solr.common.cloud.TestCollectionStateWatchers |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12870 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12943988/SOLR-12870.master.1.patch
 |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP 
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 73a413c |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_172 |
| unit | 
https://builds.apache.org/job/PreCommit-SOLR-Build/202/artifact/out/patch-unit-solr_core.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-SOLR-Build/202/artifact/out/patch-unit-solr_solrj.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/202/testReport/ |
| modules | C: solr solr/core solr/solrj solr/test-framework U: solr |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/202/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Use StandardCharsets instead of String values
> -
>
> Key: SOLR-12870
> URL: https://issues.apache.org/jira/browse/SOLR-12870
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Peter Somogyi
>Priority: Minor
> Attachments: SOLR-12870.master.1.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Charsets are hardcoded in some places around the codebase which is 
> error-prone.
> Moving to StandardCharsets also has the benefit of dropping the try-catch 
> block caused by UnsupportedEncodingException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org