[jira] [Commented] (SOLR-13049) make contrib/ltr Feature.defaultValue configurable
[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836562#comment-16836562
]
ASF subversion and git services commented on SOLR-13049:
Commit 726fb8facc15653fc3358521d226f10bd7dfff9c in lucene-solr's branch
refs/heads/branch_8x from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=726fb8f ]
SOLR-13049: Make contrib/ltr Feature.defaultValue configurable. (Stanislav
Livotov, Christine Poerschke)
> make contrib/ltr Feature.defaultValue configurable
> --
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
>Reporter: Stanislav Livotov
>Assignee: Christine Poerschke
>Priority: Major
> Attachments: SOLR-13049.patch, SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13049) make contrib/ltr Feature.defaultValue configurable
[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836527#comment-16836527
]
ASF subversion and git services commented on SOLR-13049:
Commit 38573881368344aba24b8e819955f428f52873fd in lucene-solr's branch
refs/heads/master from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3857388 ]
SOLR-13049: Make contrib/ltr Feature.defaultValue configurable. (Stanislav
Livotov, Christine Poerschke)
> make contrib/ltr Feature.defaultValue configurable
> --
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
>Reporter: Stanislav Livotov
>Assignee: Christine Poerschke
>Priority: Major
> Attachments: SOLR-13049.patch, SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13049) make contrib/ltr Feature.defaultValue configurable
[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832997#comment-16832997
]
Lucene/Solr QA commented on SOLR-13049:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
20s{color} | {color:green} ltr in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13049 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12967800/SOLR-13049.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 1882a17 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/393/testReport/ |
| modules | C: solr/contrib/ltr U: solr/contrib/ltr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/393/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> make contrib/ltr Feature.defaultValue configurable
> --
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
>Reporter: Stanislav Livotov
>Assignee: Christine Poerschke
>Priority: Major
> Attachments: SOLR-13049.patch, SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13049) make contrib/ltr Feature.defaultValue configurable
[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832728#comment-16832728
]
Christine Poerschke commented on SOLR-13049:
Finally returning to this ticket ... thanks [~slivotov] for your input!
Attached patch passes {{ant precommit}} (including {{ant
check-forbidden-apis}}) on the current master branch after four straightforward
{code}
-defaultValue = new Float(0.5f);
+defaultValue = Float.valueOf(0.5f);
{code}
style replacements. {{cd solr/contrib/ltr ; ant beast -Dbeast.iters=10}} also
passed.
If there are no further comments, questions, concerns, etc. then I'll aim to
commit this patch next week.
> make contrib/ltr Feature.defaultValue configurable
> --
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
>Reporter: Stanislav Livotov
>Priority: Major
> Attachments: SOLR-13049.patch, SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13049) make contrib/ltr Feature.defaultValue configurable
[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714118#comment-16714118
]
Stanislav Livotov commented on SOLR-13049:
--
Agree with everything, except I'm not sure whether a default value is
applicable for all type of features. For example FieldLength and OriginalScore.
But anyway I agree with the attached patch.
Yep, I don't see any issues with combining this Jira patches, if this patch
will be applied before then we will have to cut changes from Feature and
FieldValueFeature#paramsToMap() of SOLR-12697 patch.
> make contrib/ltr Feature.defaultValue configurable
> --
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
>Reporter: Stanislav Livotov
>Priority: Major
> Attachments: SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13049) make contrib/ltr Feature.defaultValue configurable
[
https://issues.apache.org/jira/browse/SOLR-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713360#comment-16713360
]
Christine Poerschke commented on SOLR-13049:
{quote}... small issue with defaultValue ... impossible to set it from
feature.json ...
{quote}
That's a good find, thank you [~slivotov]! And quite an interesting code change
actually, because if a {{defaultValue}} was configured then it (of course)
needs to be persisted but if no default value was configured then it might be
confusing to include the default default value in the parameters map.
Attached patch started off with parts of your Dec 4th SOLR-12697 patch and then
combined the three {{String/Double/Float Feature.setDefaultValue}} accessors
into one {{setDefaultValue(Object)}} accessor which is similar to the
{{ValueFeature.setValue(Object)}} accessor. I've then also included the default
value in the {{paramsToMap()}} implementation of all features and added tests
to check that parameters are correctly included in the parameter map. What do
you think?
Potential next steps:
* The patch in its current form includes no javadoc or documentation changes;
i'm unsure on if/how best to document the default value feature parameter.
* The patch started off with only parts of your Dec 4th SOLR-12697 patch; i
think it would be okay to combine the two patches without issues but i have not
yet tried to do so.
> make contrib/ltr Feature.defaultValue configurable
> --
>
> Key: SOLR-13049
> URL: https://issues.apache.org/jira/browse/SOLR-13049
> Project: Solr
> Issue Type: New Feature
> Components: contrib - LTR
>Reporter: Stanislav Livotov
>Priority: Major
> Attachments: SOLR-13049.patch
>
>
> [~slivotov] wrote in SOLR-12697:
> {quote}
> I had also done a couple of additional code changes:
> 1. fixed small issue with defaultValue(previously it was impossible to set it
> from feature.json, and the tests were written where Feature was created
> manually, and not by parsing json). Tests are added which are validating
> defaultValue from schema field configuration and from a feature default value.
> {quote}
> (Please see
> https://issues.apache.org/jira/browse/SOLR-12697?focusedCommentId=16708618=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16708618
> for more context.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
