[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027429#comment-15027429 ] ASF subversion and git services commented on SOLR-7169: --- Commit 1716518 from [~thelabdude] in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1716518 ] SOLR-7169: bin/solr status should return exit code 3 no Solr is running instead of 0 > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > Fix For: 5.4 > > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027487#comment-15027487 ] Dominik Siebel commented on SOLR-7169: -- Thanks for merging this, Timothy. This will then be fixed with 5.4.0 I assume? Will there be another 5.3.x before that? > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > Fix For: 5.4 > > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027471#comment-15027471 ] ASF GitHub Bot commented on SOLR-7169: -- Github user dsiebel commented on the pull request: https://github.com/apache/lucene-solr/pull/212#issuecomment-159714390 Changes merged via JIRA/SVN: * trunk: https://svn.apache.org/viewvc?view=revision=r1716516 * branch_5x: https://svn.apache.org/viewvc?view=revision=r1716517 * lucene_solr_5_4: https://svn.apache.org/viewvc?view=revision=r1716518 > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > Fix For: 5.4 > > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027472#comment-15027472 ] ASF GitHub Bot commented on SOLR-7169: -- Github user dsiebel closed the pull request at: https://github.com/apache/lucene-solr/pull/212 > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > Fix For: 5.4 > > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027504#comment-15027504 ] Upayavira commented on SOLR-7169: - [~dsiebel] We have already started the process of releasing 5.4. First release candidate should be produced middle of next week. > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > Fix For: 5.4 > > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027515#comment-15027515 ] Dominik Siebel commented on SOLR-7169: -- [~upayavira] Excellent, Thanks! > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > Fix For: 5.4 > > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027426#comment-15027426 ] ASF subversion and git services commented on SOLR-7169: --- Commit 1716516 from [~thelabdude] in branch 'dev/trunk' [ https://svn.apache.org/r1716516 ] SOLR-7169: bin/solr status should return exit code 3 no Solr is running instead of 0 > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027427#comment-15027427 ] ASF subversion and git services commented on SOLR-7169: --- Commit 1716517 from [~thelabdude] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1716517 ] SOLR-7169: bin/solr status should return exit code 3 no Solr is running instead of 0 > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021774#comment-15021774 ] Dominik Siebel commented on SOLR-7169: -- Since this task seems to be "IN PROGRESS" already: I have a patched, working version of the solr run script that I use in our setup. Anybody interested in that? [~tpot], [~m...@addwish.com] > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021786#comment-15021786 ] Ishan Chattopadhyaya commented on SOLR-7169: I think it is always a good idea to have patches. It'll be nice if you can contribute your patch so that others can review. Thanks. This page has info on how to start creating patches, https://wiki.apache.org/solr/HowToContribute > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021939#comment-15021939 ] Dominik Siebel commented on SOLR-7169: -- [~ichattopadhyaya] Thanks, it's not my first change ;) Is it already possible to provide patches via GitHub Pull Requests? I saw a couple of them being opened and integrated by committers manually... > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022065#comment-15022065 ] Dominik Siebel commented on SOLR-7169: -- Seems like it works :D > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022063#comment-15022063 ] ASF GitHub Bot commented on SOLR-7169: -- GitHub user dsiebel opened a pull request: https://github.com/apache/lucene-solr/pull/212 SOLR-7169: Use proper exit code in `status` command to signal process status As reported in [SOLR-7169](https://issues.apache.org/jira/browse/SOLR-7169) the solr run script always return `0` as exit code. This causes provisioners like Puppet or Saltstack assume that he process is already running. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dsiebel/lucene-solr SOLR-7169-proper-exit-code-for-runscript Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #212 commit b6d279ae19bf8d4c0cca8a0bcf0be50aa15ca3ec Author: dsiebelDate: 2015-11-23T13:01:10Z SOLR-7169 use proper exit code in `status` command to signal process status > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022001#comment-15022001 ] Upayavira commented on SOLR-7169: - The Solr development community does not make much collective use of github - its workflow is based upon JIRA, and patches uploaded to JIRA. Deviations from that norm may reduce the likelihood of a patch being reviewed (but not necessarily prevent it). If you mention this ticket (i.e. SOLR-7169) in your PR message, it should automatically be included in this JIRA, which will make review easier. > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022246#comment-15022246 ] Ishan Chattopadhyaya commented on SOLR-7169: Thanks Dominik. I tried to take a look at your patch. There are lots of whitespace changes. Is it please possible for you to post another patch that contains just the required change? It would be easier to review the change that way. As Upayavira mentioned, an SVN patch is more likely to be reviewed here than a git patch, but I can volunteer to convert your git patch to an SVN one for now for ease of reviewing. > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022370#comment-15022370 ] Dominik Siebel commented on SOLR-7169: -- [~ichattopadhyaya] Sure, I will give it another try. I also realized that it's not yet working in all cases because the script forks subshells to read the pid files for example. I will provide another changeset that hopefully covers all of them. > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022394#comment-15022394 ] Dominik Siebel commented on SOLR-7169: -- New patch: https://github.com/apache/lucene-solr/pull/212.patch I threw away all previous changes and combined everything into one commit. The subshell problem seems to be solved but there is still on minor issue remaining: If there are running Solr instances the return value of {{get_info}} will always be the outcome of the last call to {{run_tool status}} since all pid files / running processes are processed in a loop. This is fine for single-node setups but might lead to side effects on multi-node setups (multiple instances / services running on one machine). > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022217#comment-15022217 ] Dominik Siebel commented on SOLR-7169: -- As it turns out following the LSB standard and returning 3 if the service is not running does not fix the problem with saltstack orchestration (returning 1 however does). Does it fix the problem for Puppet? Any chance you could test the patch, [~m...@addwish.com]? > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7169) init.d status command has incorrect return value
[ https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016698#comment-15016698 ] Dominik Siebel commented on SOLR-7169: -- Experiencing the same problem with orchestration via Saltstack currently. > init.d status command has incorrect return value > > > Key: SOLR-7169 > URL: https://issues.apache.org/jira/browse/SOLR-7169 > Project: Solr > Issue Type: Bug > Components: scripts and tools >Affects Versions: 5.0 > Environment: Debian stable >Reporter: Martin Skøtt >Assignee: Timothy Potter > > {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according > to the LSB 0 means that the service is running > (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html). > In my situation this causes problems when managing the service with Puppet > which uses the status command to determine if a service should be started. > Puppet simply doesn't start the service because it thinks its already > running. Any other script depending on the result of the status command will > suffer similar problems. > Workaround for other Puppet users: > Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the > service definition works for me. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org