[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577561#comment-14577561 ] ASF subversion and git services commented on SOLR-7409: --- Commit 1684236 from [~elyograg] in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1684236 ] SOLR-7588: Fix javascript bug introduced by SOLR-7409 that broke dataimport in admin UI. (merge trunk r1684234) Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Fix For: Trunk, 5.2 Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577549#comment-14577549 ] ASF subversion and git services commented on SOLR-7409: --- Commit 1684234 from [~elyograg] in branch 'dev/trunk' [ https://svn.apache.org/r1684234 ] SOLR-7588: Fix javascript bug introduced by SOLR-7409 that broke dataimport in admin UI. Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Fix For: Trunk, 5.2 Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577555#comment-14577555 ] ASF subversion and git services commented on SOLR-7409: --- Commit 1684235 from [~elyograg] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1684235 ] SOLR-7588: Fix javascript bug introduced by SOLR-7409 that broke dataimport in admin UI. (merge trunk r1684234) Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Fix For: Trunk, 5.2 Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525649#comment-14525649 ] ASF subversion and git services commented on SOLR-7409: --- Commit 1677365 from [~elyograg] in branch 'dev/trunk' [ https://svn.apache.org/r1677365 ] SOLR-7409: Sort datimport handlers in the admin UI Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Fix For: Trunk, 5.2 Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525659#comment-14525659 ] ASF subversion and git services commented on SOLR-7409: --- Commit 1677366 from [~elyograg] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1677366 ] SOLR-7409: Sort datimport handlers in the admin UI (backport trunk r1677365) Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Fix For: Trunk, 5.2 Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505532#comment-14505532 ] Shawn Heisey commented on SOLR-7409: That -2 patch looks really good. It looks like you re-used somebody else's code, specifically this project: https://github.com/overset/javascript-natural-sort/blob/master/naturalSort.js This isn't a problem. I believe we should probably use their source file which includes the author and the license, which is MIT, and compatible with Solr's license. I wonder if we need to include a license and notice file in solr/licenses for this code. Regarding patch attachments, normally they really should be just named after the issue, for *every* upload, which means they all get named SOLR-7409.patch. If I am making an alternate proposal on an issue that somebody else is working, I will sometimes do a name like SOLR-7409-elyograg.patch to keep it separate from the more official work in progress. Jira will automatically grey out all but the newest version of each attachment that has the same name, but the older ones will remain available. This is in line with the open source ideal of keeping all discussion and development in the public view. Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[
https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504937#comment-14504937
]
Jellyfrog commented on SOLR-7409:
-
Pick one of the patches only!
h1. Without any of the patches
{quote}
/dataimport37
/dataimport38
/dataimport35
/dataimport36
/dataimport39
/dataimport40
/dataimport41
/dataimport44
/dataimport45
/dataimport42
/dataimport43
/dataimport26
/dataimport27
/dataimport24
/dataimport25
/dataimport28
/dataimport29
/dataimport30
/dataimport33
/dataimport34
/dataimport31
/dataimport32
/dataimport59
/dataimport57
/dataimport58
/dataimport6
/dataimport7
/dataimport8
/dataimport9
/dataimport62
/dataimport63
/dataimport0
/dataimport60
/dataimport1
/dataimport61
/dataimport2
/dataimport66
/dataimport3
/dataimport67
/dataimport4
/dataimport64
/dataimport5
/dataimport65
/dataimport48
/dataimport49
/dataimport46
/dataimport47
/dataimport51
/dataimport52
/dataimport50
/dataimport55
/dataimport56
/dataimport53
/dataimport54
/dataimport68
/dataimport69
/dataimport15
/dataimport16
/dataimport13
/dataimport14
/dataimport19
/dataimport17
/dataimport18
/dataimport22
/dataimport23
/dataimport20
/dataimport21
/dataimport11
/dataimport12
/dataimport10
{quote}
h1. With SOLR-7409-1.patch
{quote}
/dataimport0
/dataimport1
/dataimport10
/dataimport11
/dataimport12
/dataimport13
/dataimport14
/dataimport15
/dataimport16
/dataimport17
/dataimport18
/dataimport19
/dataimport2
/dataimport20
/dataimport21
/dataimport22
/dataimport23
/dataimport24
/dataimport25
/dataimport26
/dataimport27
/dataimport28
/dataimport29
/dataimport3
/dataimport30
/dataimport31
/dataimport32
/dataimport33
/dataimport34
/dataimport35
/dataimport36
/dataimport37
/dataimport38
/dataimport39
/dataimport4
/dataimport40
/dataimport41
/dataimport42
/dataimport43
/dataimport44
/dataimport45
/dataimport46
/dataimport47
/dataimport48
/dataimport49
/dataimport5
/dataimport50
/dataimport51
/dataimport52
/dataimport53
/dataimport54
/dataimport55
/dataimport56
/dataimport57
/dataimport58
/dataimport59
/dataimport6
/dataimport60
/dataimport61
/dataimport62
/dataimport63
/dataimport64
/dataimport65
/dataimport66
/dataimport67
/dataimport68
/dataimport69
/dataimport7
/dataimport8
/dataimport9
{quote}
h1. With SOLR-7409-2.patch
{quote}
/dataimport0
/dataimport1
/dataimport2
/dataimport3
/dataimport4
/dataimport5
/dataimport6
/dataimport7
/dataimport8
/dataimport9
/dataimport10
/dataimport11
/dataimport12
/dataimport13
/dataimport14
/dataimport15
/dataimport16
/dataimport17
/dataimport18
/dataimport19
/dataimport20
/dataimport21
/dataimport22
/dataimport23
/dataimport24
/dataimport25
/dataimport26
/dataimport27
/dataimport28
/dataimport29
/dataimport30
/dataimport31
/dataimport32
/dataimport33
/dataimport34
/dataimport35
/dataimport36
/dataimport37
/dataimport38
/dataimport39
/dataimport40
/dataimport41
/dataimport42
/dataimport43
/dataimport44
/dataimport45
/dataimport46
/dataimport47
/dataimport48
/dataimport49
/dataimport50
/dataimport51
/dataimport52
/dataimport53
/dataimport54
/dataimport55
/dataimport56
/dataimport57
/dataimport58
/dataimport59
/dataimport60
/dataimport61
/dataimport62
/dataimport63
/dataimport64
/dataimport65
/dataimport66
/dataimport67
/dataimport68
/dataimport69
{quote}
Sort dataimport by name in gui
--
Key: SOLR-7409
URL: https://issues.apache.org/jira/browse/SOLR-7409
Project: Solr
Issue Type: Improvement
Components: web gui
Affects Versions: Trunk
Reporter: Jellyfrog
Priority: Trivial
Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch
As discussed with steffkes on IRC
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505856#comment-14505856 ] Jellyfrog commented on SOLR-7409: - Fine for me! Its acutely this fork; https://github.com/jarinudom/naturalSort.js btw. Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Fix For: Trunk, 5.2 Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch, SOLR-7409.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7409) Sort dataimport by name in gui
[ https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506107#comment-14506107 ] Shawn Heisey commented on SOLR-7409: On precommit, it seems that rat requires a license header in the .js source file. I have added one with the MIT license. Once precommit passes, I will upload a new patch. Sort dataimport by name in gui -- Key: SOLR-7409 URL: https://issues.apache.org/jira/browse/SOLR-7409 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: Trunk Reporter: Jellyfrog Priority: Trivial Fix For: Trunk, 5.2 Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch, SOLR-7409.patch, SOLR-7409.patch, SOLR-7409.patch As discussed with steffkes on IRC -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
