[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117197#comment-15117197 ] Joel Bernstein commented on SOLR-8518: -- Before we commit to this approach I have a question. How much of the Catalog (DatabaseMetaData) information are we going to need to get DBVisualizer working? If we're going to need to get this working for SOLR-8502 then it makes sense to populate the column types directly from the Catalog. But if we can close out SOLR-8502 without digging into the DatabaseMetaData then let's take that the first Tuple approach in the latest patch. > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --- > > Key: SOLR-8518 > URL: https://issues.apache.org/jira/browse/SOLR-8518 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8518.patch > > > DBVisualizer uses getColumnType and getColumnTypeName to determine which > ResultSetImpl.get* method to use when displaying the data otherwise it falls > back to ResultSetImpl.getObject. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117294#comment-15117294 ] Kevin Risden commented on SOLR-8518: Well a very rough DBVisualizer is currently working as of SOLR-8512 getting committed. There are some "errors" that get printed about getting catalog/schema info and some other minor things. As far as this ticket, I think the catalog and getColumnType/getColumnTypeName are going to have to both be implemented separately. There are fields can be created by a query (ie: concat, constants, aliases) that won't match what the schema says. Using the first tuple is the only sure way to get the proper types returned from a query I think. > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --- > > Key: SOLR-8518 > URL: https://issues.apache.org/jira/browse/SOLR-8518 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8518.patch > > > DBVisualizer uses getColumnType and getColumnTypeName to determine which > ResultSetImpl.get* method to use when displaying the data otherwise it falls > back to ResultSetImpl.getObject. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117305#comment-15117305 ] Joel Bernstein commented on SOLR-8518: -- Ok, we'll go with the latest patch then. I think the main goal is to get DBVisualizer working. We can always change things in later tickets as things mature. > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --- > > Key: SOLR-8518 > URL: https://issues.apache.org/jira/browse/SOLR-8518 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8518.patch > > > DBVisualizer uses getColumnType and getColumnTypeName to determine which > ResultSetImpl.get* method to use when displaying the data otherwise it falls > back to ResultSetImpl.getObject. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117421#comment-15117421 ] Joel Bernstein commented on SOLR-8518: -- I made a few slight changes and am running precommit now. 1) I moved the wrapping of the PushBackStream into the ResultSetImpl. Just felt this was a detail only the ResultSet needed to know. 2) Checking for null value on a column and setting the class to String. This is actually correct because only String fields can be null. Numerics will return 0 if null. > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --- > > Key: SOLR-8518 > URL: https://issues.apache.org/jira/browse/SOLR-8518 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8518.patch > > > DBVisualizer uses getColumnType and getColumnTypeName to determine which > ResultSetImpl.get* method to use when displaying the data otherwise it falls > back to ResultSetImpl.getObject. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117498#comment-15117498 ] Joel Bernstein commented on SOLR-8518: -- commit: https://github.com/apache/lucene-solr/commit/3654fc33b9e2ac0066d03ae864dea418d27f8841 > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --- > > Key: SOLR-8518 > URL: https://issues.apache.org/jira/browse/SOLR-8518 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8518.patch > > > DBVisualizer uses getColumnType and getColumnTypeName to determine which > ResultSetImpl.get* method to use when displaying the data otherwise it falls > back to ResultSetImpl.getObject. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116584#comment-15116584 ] Joel Bernstein commented on SOLR-8518: -- Using the approach where we look at the column types of the first real Tuple means that numerics will always be either a long or a double. From a practical standpoint this approach is very fast and it will work fine with visualization clients. As the implementation matures we can look at ways to cache the real types in the SQLHandler and return it with the meta-data tuple. > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --- > > Key: SOLR-8518 > URL: https://issues.apache.org/jira/browse/SOLR-8518 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > Attachments: SOLR-8518.patch > > > DBVisualizer uses getColumnType and getColumnTypeName to determine which > ResultSetImpl.get* method to use when displaying the data otherwise it falls > back to ResultSetImpl.getObject. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8518) Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
[ https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088091#comment-15088091 ] Kevin Risden commented on SOLR-8518: Requires ResultSetMetaDataImpl class from SOLR-8513 to be merged first. > Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName > --- > > Key: SOLR-8518 > URL: https://issues.apache.org/jira/browse/SOLR-8518 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Affects Versions: Trunk >Reporter: Kevin Risden > > DBVisualizer uses getColumnType and getColumnTypeName to determine which > ResultSetImpl.get* method to use when displaying the data otherwise it falls > back to ResultSetImpl.getObject. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
