[jira] [Commented] (SOLR-9244) Lots of "Previous SolrRequestInfo was not closed" in Solr log

2016-06-24 Thread Gary Lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348946#comment-15348946
 ] 

Gary Lee commented on SOLR-9244:


[~tomasflobbe] I don't think I've seen a stack trace - just a lot of these 
messages in our solr logs:
{noformat}
2016-06-24 23:05:24,173 ERROR org.apache.solr.request.SolrRequestInfo - 
Previous SolrRequestInfo was not closed!  req=commit=true
2016-06-24 23:05:24,173 ERROR org.apache.solr.request.SolrRequestInfo - prev == 
info : false
{noformat}

When I debugged through this one time, I remember it was the HttpSolrCall.call 
where I saw the error occur, so i was led to believe that this was possibly the 
point where we do not close, but as you pointed out, the destroy is called, so 
it is getting cleaned up. In that case, the code path in SOLR-8657 is probably 
the same one we're hitting.

> Lots of "Previous SolrRequestInfo was not closed" in Solr log
> -
>
> Key: SOLR-9244
> URL: https://issues.apache.org/jira/browse/SOLR-9244
> Project: Solr
>  Issue Type: Bug
>  Components: Server
>Affects Versions: 5.3.1
>Reporter: Gary Lee
>Priority: Minor
> Fix For: 5.3.1
>
>
> After upgrading to Solr 5.3.1, we started seeing a lot of "Previous 
> SolrRequestInfo was not closed" ERROR level messages in the logs. Upon 
> further inspection, it appears this is a sanity check and not an error that 
> needs attention. It appears that the SolrRequestInfo isn't freed in one 
> particular path (no corresponding call to SolrRequestInfo.clearRequestInfo in 
> HttpSolrCall.call), which often leads to a lot of these messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9244) Lots of "Previous SolrRequestInfo was not closed" in Solr log

2016-06-24 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/SOLR-9244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348890#comment-15348890
 ] 

Tomás Fernández Löbbe commented on SOLR-9244:
-

[~gary.lee], SolrRequestInfo.clearRequestInfo() is being called on 
{{HttpSolrCall.destroy()}}, which looks like the correct place to me. See 
{{SolrDispatchFilter}}
{code:java}
  try {
Action result = call.call();
switch (result) {
  case PASSTHROUGH:
chain.doFilter(request, response);
break;
  case RETRY:
doFilter(request, response, chain, true);
break;
  case FORWARD:
request.getRequestDispatcher(call.getPath()).forward(request, 
response);
break;
}
  } finally {
call.destroy();
ExecutorUtil.setServerThreadFlag(null);
  }
{code}
Is the stack trace you see the same as what was pasted in SOLR-8657? If not, 
can you provide one?

> Lots of "Previous SolrRequestInfo was not closed" in Solr log
> -
>
> Key: SOLR-9244
> URL: https://issues.apache.org/jira/browse/SOLR-9244
> Project: Solr
>  Issue Type: Bug
>  Components: Server
>Affects Versions: 5.3.1
>Reporter: Gary Lee
>Priority: Minor
> Fix For: 5.3.1
>
>
> After upgrading to Solr 5.3.1, we started seeing a lot of "Previous 
> SolrRequestInfo was not closed" ERROR level messages in the logs. Upon 
> further inspection, it appears this is a sanity check and not an error that 
> needs attention. It appears that the SolrRequestInfo isn't freed in one 
> particular path (no corresponding call to SolrRequestInfo.clearRequestInfo in 
> HttpSolrCall.call), which often leads to a lot of these messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9244) Lots of "Previous SolrRequestInfo was not closed" in Solr log

2016-06-23 Thread Gary Lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-9244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347349#comment-15347349
 ] 

Gary Lee commented on SOLR-9244:


SOLR-8657 appears to detail another path in which the same issue occurs - lots 
of those errors polluting the logs. In our case it seems that HttpSolrCall.call 
isn't properly clearing the SolrRequestInfo:
{noformat}
  public Action call() throws IOException {
MDCLoggingContext.reset();
MDCLoggingContext.setNode(cores);

if (cores == null) {
  sendError(503, "Server is shutting down or failed to initialize");
  return RETURN;
}

if (solrDispatchFilter.abortErrorMessage != null) {
  sendError(500, solrDispatchFilter.abortErrorMessage);
  return RETURN;
}

try {
  init();
...
SolrRequestInfo.setRequestInfo(new SolrRequestInfo(solrReq, 
solrRsp));
execute(solrRsp);
HttpCacheHeaderUtil.checkHttpCachingVeto(solrRsp, resp, reqMethod);
Iterator> headers = solrRsp.httpHeaders();
while (headers.hasNext()) {
  Map.Entry entry = headers.next();
  resp.addHeader(entry.getKey(), entry.getValue());
}
QueryResponseWriter responseWriter = 
core.getQueryResponseWriter(solrReq);
if (invalidStates != null) 
solrReq.getContext().put(CloudSolrClient.STATE_VERSION, invalidStates);
writeResponse(solrRsp, responseWriter, reqMethod);
  }
  return RETURN;
default: return action;
  }
} catch (Throwable ex) {
  sendError(ex);
  // walk the the entire cause chain to search for an Error
  Throwable t = ex;
  while (t != null) {
if (t instanceof Error) {
  if (t != ex) {
log.error("An Error was wrapped in another exception - please 
report complete stacktrace on SOLR-6161", ex);
  }
  throw (Error) t;
}
t = t.getCause();
  }
  return RETURN;
} finally {
// I WOULD HAVE EXPECTED SolrRequestInfo.clearRequestInfo(); call here
  MDCLoggingContext.clear();
}

  }
{noformat}

So yes appears to be the same issue as SOLR-8657, but this details another code 
path that needs to be addressed.

> Lots of "Previous SolrRequestInfo was not closed" in Solr log
> -
>
> Key: SOLR-9244
> URL: https://issues.apache.org/jira/browse/SOLR-9244
> Project: Solr
>  Issue Type: Bug
>  Components: Server
>Affects Versions: 5.3.1
>Reporter: Gary Lee
>Priority: Minor
> Fix For: 5.3.1
>
>
> After upgrading to Solr 5.3.1, we started seeing a lot of "Previous 
> SolrRequestInfo was not closed" ERROR level messages in the logs. Upon 
> further inspection, it appears this is a sanity check and not an error that 
> needs attention. It appears that the SolrRequestInfo isn't freed in one 
> particular path (no corresponding call to SolrRequestInfo.clearRequestInfo in 
> HttpSolrCall.call), which often leads to a lot of these messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-9244) Lots of "Previous SolrRequestInfo was not closed" in Solr log

2016-06-23 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/SOLR-9244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347229#comment-15347229
 ] 

Tomás Fernández Löbbe commented on SOLR-9244:
-

Probably the same issue as reported in SOLR-8657. If so, we can close this one 
as duplicate and update the affected versions in SOLR-8657.

> Lots of "Previous SolrRequestInfo was not closed" in Solr log
> -
>
> Key: SOLR-9244
> URL: https://issues.apache.org/jira/browse/SOLR-9244
> Project: Solr
>  Issue Type: Bug
>  Components: Server
>Affects Versions: 5.3.1
>Reporter: Gary Lee
>Priority: Minor
> Fix For: 5.3.1
>
>
> After upgrading to Solr 5.3.1, we started seeing a lot of "Previous 
> SolrRequestInfo was not closed" ERROR level messages in the logs. Upon 
> further inspection, it appears this is a sanity check and not an error that 
> needs attention. It appears that the SolrRequestInfo isn't freed in one 
> particular path (no corresponding call to SolrRequestInfo.clearRequestInfo in 
> HttpSolrCall.call), which often leads to a lot of these messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org