[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113012#comment-16113012 ] ASF subversion and git services commented on SOLR-9371: --- Commit bdb3ad58a825662b6491590d9335f6944ea3f0c0 in lucene-solr's branch refs/heads/branch_6x from [~cpoerschke] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bdb3ad5 ] Correct SOLR_STOP_WAIT value in Solr Ref Guide (it changed from 5 to 180s in SOLR-9371). > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.3, 7.0 > > Attachments: SOLR-9371.patch, SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113009#comment-16113009 ] ASF subversion and git services commented on SOLR-9371: --- Commit 227dbad4f71468613e8431322dcaf481caab07d0 in lucene-solr's branch refs/heads/branch_7_0 from [~cpoerschke] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=227dbad ] Correct SOLR_STOP_WAIT value in Solr Ref Guide (it changed from 5 to 180s in SOLR-9371). > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.3, 7.0 > > Attachments: SOLR-9371.patch, SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113008#comment-16113008 ] ASF subversion and git services commented on SOLR-9371: --- Commit 41e9c17443cb27e6b62e9a244e4503b234bcd0db in lucene-solr's branch refs/heads/branch_7x from [~cpoerschke] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=41e9c17 ] Correct SOLR_STOP_WAIT value in Solr Ref Guide (it changed from 5 to 180s in SOLR-9371). > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.3, 7.0 > > Attachments: SOLR-9371.patch, SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113006#comment-16113006 ] ASF subversion and git services commented on SOLR-9371: --- Commit 78b6e5031a49b7328cb27704a583044ebbcfe91d in lucene-solr's branch refs/heads/master from [~cpoerschke] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=78b6e50 ] Correct SOLR_STOP_WAIT value in Solr Ref Guide (it changed from 5 to 180s in SOLR-9371). > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.3, 7.0 > > Attachments: SOLR-9371.patch, SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613863#comment-15613863 ] ASF subversion and git services commented on SOLR-9371: --- Commit d4797a16765ce6f451a149688c8e134864aaf90d in lucene-solr's branch refs/heads/branch_6_3 from [~erickerickson] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d4797a1 ] SOLR-9371: Fix bin/solr script calculations - start/stop wait time and RMI_PORT (cherry picked from commit 1344d89) (cherry picked from commit 23591ff) > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613862#comment-15613862 ] ASF subversion and git services commented on SOLR-9371: --- Commit 23591ff9b8850baae8edce571590f1d091d2be86 in lucene-solr's branch refs/heads/branch_6x from [~erickerickson] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=23591ff ] SOLR-9371: Fix bin/solr script calculations - start/stop wait time and RMI_PORT (cherry picked from commit 1344d89) > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613858#comment-15613858 ] ASF subversion and git services commented on SOLR-9371: --- Commit 1344d895f96644a4d541acd5a9fbe9fe4d1969a5 in lucene-solr's branch refs/heads/master from [~erickerickson] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1344d89 ] SOLR-9371: Fix bin/solr script calculations - start/stop wait time and RMI_PORT > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[
https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613339#comment-15613339
]
Jan Høydahl commented on SOLR-9371:
---
Hi, you can do something like this
{code}
bin/solr assert --not-started http://localhost:8983/solr/ --timeout 3 -e
{code}
But it will only check if Solr is listening on the port, it will not check if
the process or PID file is gone, which I guess is what we need. I started on a
UtilsTool that will check PIDs and optionally kill, but that is not committed
yet. I'm fine with opening another JIRA for Windows and tackle it in next
release.
> Fix bin/solr script calculations - start/stop wait time and RMI_PORT
>
>
> Key: SOLR-9371
> URL: https://issues.apache.org/jira/browse/SOLR-9371
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 6.1
>Reporter: Shawn Heisey
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9371.patch, SOLR-9371.patch
>
>
> The bin/solr script doesn't wait long enough for Solr to stop before it sends
> the KILL signal to the process. The start could use a longer wait too.
> Also, the RMI_PORT is calculated by simply prefixing the port number with a
> "1" instead of adding 1. If the solr port has five digits, then the rmi
> port will be invalid, because it will be greater than 65535.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612469#comment-15612469 ] Erick Erickson commented on SOLR-9371: -- WDYT about naming this param scarily? I.e. SOLR_KILL_WAIT? I think that's more descriptive... > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612424#comment-15612424 ] Erick Erickson commented on SOLR-9371: -- OK, I'm going to commit this over the weekend and raise a different JIRA for Windows unless 1> some kind person makes it work with windows or 2> there are howls of protest. Progress, not perfection and all that. [~janhoy] Not sure I want to go into the assert tool this close to a release since I'm not very familiar with it. Perhaps separate JIRA? > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602032#comment-15602032 ] Ere Maijala commented on SOLR-9371: --- Oops, sorry for being so vague. With "both" I meant "committing this" and "put it on 6_2 as well". I can't help with Windows, and I think that's why SOLR-8065 got stalled, but if you agree on doing this separately for Windows, that would be great. It's not easy to maintain your own version of the solr script when it's being enhanced all the time, and this issue has existed way too long already without anyone stepping up to do something about the Windows version. > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602006#comment-15602006 ] Erick Erickson commented on SOLR-9371: -- Can you help with the Windows scripting? If so, please attach a patch. > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601833#comment-15601833 ] Ere Maijala commented on SOLR-9371: --- Please do both. I've been hoping to get this fixed for over a year (see the linked issue SOLR-8065). > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597841#comment-15597841 ] Erick Erickson commented on SOLR-9371: -- What do people think about committing this sometime soon and maybe open a separate issue for Windows? I really think this is a bad trap and I'd really like to get in place before anyone thinks about cutting the next version of Solr. I also wonder if we should put it on 6_2 as well in case there's another release. I've got a couple of other things on my plate, but may try to get to the *nix version next week. > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[
https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596777#comment-15596777
]
Jan Høydahl commented on SOLR-9371:
---
Perhaps you can use the new AssertTool from the windows script?
{code}
call :run_assert -e -S http://localhost:8983/solr/
IF errorlevel 1
{code}
> Fix bin/solr script calculations - start/stop wait time and RMI_PORT
>
>
> Key: SOLR-9371
> URL: https://issues.apache.org/jira/browse/SOLR-9371
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 6.1
>Reporter: Shawn Heisey
>Assignee: Shawn Heisey
>Priority: Minor
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9371.patch, SOLR-9371.patch
>
>
> The bin/solr script doesn't wait long enough for Solr to stop before it sends
> the KILL signal to the process. The start could use a longer wait too.
> Also, the RMI_PORT is calculated by simply prefixing the port number with a
> "1" instead of adding 1. If the solr port has five digits, then the rmi
> port will be invalid, because it will be greater than 65535.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437304#comment-15437304 ] Erick Erickson commented on SOLR-9371: -- I just happened to run across 8065 during a search and said to myself "Hey, I remember something more recent about this." So I thought I'd add it in solely in the interests of closing JIRAs when possible +1 to making it 3 minutes. Since (if I'm reading it correctly), the loop exits much more quickly if the process actually stops, there's no real problem there IMO. Especially for those of us who start/stop Solr about a zillion times a day when testing stuff. Plus, the pain of leader election/full sync/whatever can be high enough that waiting a bit more is a small price to pay for real-live production systems. > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437204#comment-15437204 ] Shawn Heisey commented on SOLR-9371: I didn't notice SOLR-8605. If I had, I would have put the patch there. [~markrmil...@gmail.com] makes a very good point in his last comment on that issue. Perhaps the default timeout should be something really long. Initial bikeshed: maybe 3 minutes, same as Collections API? I did increase it in my patch, to 60 seconds. A non-windows system *will* exit earlier than the timeout if shutdown happens faster, and with my proposed patch, the user has the option of changing the timeout to make the hard kill happen faster if they want. Opening a separate issue for Windows seems prudent. It needs some work before we can increase the default timeout. > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437176#comment-15437176 ] Erick Erickson commented on SOLR-9371: -- WDYT about just committing this and raising a separate JIRA for Windows? This has bitten us in the field repeatedly because it can force leader election, recovery and the like. I'd have a different opinion if it was new functionality or the like... > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405386#comment-15405386 ] Varun Thacker commented on SOLR-9371: - +1 for the change. I've once seen a case with a client running solr on hdfs , where Solr didn't shut down in 5 seconds and the start script killed the process. Restart won't work because of the write.lock issue on hdfs > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404588#comment-15404588 ] Shawn Heisey commented on SOLR-9371: Yeah, that occurred to me... but the name I came up with at first (SOLR_START_STOP_WAIT_TIME) was so long that I changed it back. SOLR_WAIT_TIME could work. Windows is going to be a bit harder, because I'm not as familiar with batch mehods as I am shell script. Any ideas are welcome. > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404448#comment-15404448 ] Shawn Heisey commented on SOLR-9371: I looked into the Windows start script. It just uses a plain "wait" sort of timeout. The "wait briefly and check PID" loop might be adaptable to the "stop" action in Windows by somebody who really knows the batch syntax. Question for the peanut gallery: What's the earliest Windows version we will support? One command that I found for doing silent pauses won't work on XP. XP is end of life ... so do we need to support it? > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404236#comment-15404236 ] Erick Erickson commented on SOLR-9371: -- Oh please commit this! May I suggest the variable be renamed to SOLR_WAIT_TIME? Or maybe SOLR_STOP_WAIT? At any rate prefix it with SOLR I think... Second, whatever the name, it should also be added to the solr.in.cmd for Windows users... > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch, SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9371) Fix bin/solr script calculations - start/stop wait time and RMI_PORT
[ https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404109#comment-15404109 ] Shawn Heisey commented on SOLR-9371: The wait time is configurable in solr.in.sh ... I should probably put a commented example in there. > Fix bin/solr script calculations - start/stop wait time and RMI_PORT > > > Key: SOLR-9371 > URL: https://issues.apache.org/jira/browse/SOLR-9371 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools >Affects Versions: 6.1 >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Minor > Fix For: 6.2, master (7.0) > > Attachments: SOLR-9371.patch > > > The bin/solr script doesn't wait long enough for Solr to stop before it sends > the KILL signal to the process. The start could use a longer wait too. > Also, the RMI_PORT is calculated by simply prefixing the port number with a > "1" instead of adding 1. If the solr port has five digits, then the rmi > port will be invalid, because it will be greater than 65535. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
