Re: Porting LTR plugin for Solr-5.5.0

[aanilpala]

The patch compiles and LTR works fine on 5.5! 


Trey Grainger wrote
> They included at 5x patch on the JIRA here:
> https://issues.apache.org/jira/secure/attachment/12782146/SOLR-8542-branch_5x.patch
> (it's
> one of the files attached to the Jira). The JIRA has two patches included
> on it, one for master (approximately 6.0), and the one I just linked to
> for
> the 5x branch.





--
View this message in context: 
http://lucene.472066.n3.nabble.com/Porting-LTR-plugin-for-Solr-5-5-0-tp4267825p4269784.html
Sent from the Lucene - Java Developer mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Porting LTR plugin for Solr-5.5.0

[Trey Grainger]

Ahmet,

They included at 5x patch on the JIRA here:
https://issues.apache.org/jira/secure/attachment/12782146/SOLR-8542-branch_5x.patch
(it's
one of the files attached to the Jira). The JIRA has two patches included
on it, one for master (approximately 6.0), and the one I just linked to for
the 5x branch.

Assuming you checkout branch 5x (which should be approximately the same
code 5.5.0), then I would assume the Bloomberg patch would work.  I've
personally also back-ported it to 5.4.1, which required a fair number of
changes related to iterator changes on Scorers, but wasn't too much trouble.

Hopefully the patch above gives you what you need.

Trey Grainger
SVP of Engineering @ Lucidworks
Co-author, Solr in Action


On Wed, Apr 6, 2016 at 6:21 PM, Shawn Heisey  wrote:

> On 4/6/2016 1:55 PM, Ahmet Anil Pala wrote:
> > Hi Michael, thanks for answering and sorry for the late reply.
> >
> > By 5.x branch build, do you mean this
> > -> https://github.com/bloomberg/lucene-solr/tree/branch_5x
> >
> > It seems that LTR is not merged onto it and I doubt it is mergable
> > without changes as this is exactly what I have tried and failed. As
> > for your pull request SOLR-8542, it is supposed to be merged to the
> > master branch which is already the version 7.0.0. Is the LTR plugin
> > originally developed only compatible with Solr-6x and later or am I
> > missing something here?
>
> I think that something like this will not make it into 5.x.  With the
> 6.0.0 release just around the corner (probably a matter of days), 5.x
> goes into maintenance mode, and 4.x basically goes dormant.  Maintenance
> mode basically means that no significant changes will happen, especially
> changes that might affect stability.  A strict interpretation of this is
> "no new features", and this is typically the stance that most committers
> adopt for the previous major version.  It also means that only *major*
> bugs will be fixed, especially as time goes on.
>
> You've indicated that you couldn't merge it cleanly to branch_5x.  If
> the change requires significant work just to merge, and the
> functionality is already present in a later release, it's probably not
> going to happen.
>
> There are some important bugfixes that have already been committed to
> 5x, which should result in a 5.5.1 release in the near future, and it is
> entirely possible that somebody will volunteer to release 5.6.0,
> although the current changelog for 5.6.0 only has two issues, and
> neither is particularly interesting for most users.
>
> If somebody wants to volunteer to do the work, then what I've said might
> not apply at all.
>
> Thanks,
> Shawn
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>

Re: Porting LTR plugin for Solr-5.5.0

[Shawn Heisey]

On 4/6/2016 1:55 PM, Ahmet Anil Pala wrote:
> Hi Michael, thanks for answering and sorry for the late reply.
>
> By 5.x branch build, do you mean this
> -> https://github.com/bloomberg/lucene-solr/tree/branch_5x
>
> It seems that LTR is not merged onto it and I doubt it is mergable
> without changes as this is exactly what I have tried and failed. As
> for your pull request SOLR-8542, it is supposed to be merged to the
> master branch which is already the version 7.0.0. Is the LTR plugin
> originally developed only compatible with Solr-6x and later or am I
> missing something here?

I think that something like this will not make it into 5.x.  With the
6.0.0 release just around the corner (probably a matter of days), 5.x
goes into maintenance mode, and 4.x basically goes dormant.  Maintenance
mode basically means that no significant changes will happen, especially
changes that might affect stability.  A strict interpretation of this is
"no new features", and this is typically the stance that most committers
adopt for the previous major version.  It also means that only *major*
bugs will be fixed, especially as time goes on.

You've indicated that you couldn't merge it cleanly to branch_5x.  If
the change requires significant work just to merge, and the
functionality is already present in a later release, it's probably not
going to happen.

There are some important bugfixes that have already been committed to
5x, which should result in a 5.5.1 release in the near future, and it is
entirely possible that somebody will volunteer to release 5.6.0,
although the current changelog for 5.6.0 only has two issues, and
neither is particularly interesting for most users.

If somebody wants to volunteer to do the work, then what I've said might
not apply at all.

Thanks,
Shawn


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Porting LTR plugin for Solr-5.5.0

[Ahmet Anil Pala]

Hi Michael, thanks for answering and sorry for the late reply.

By 5.x branch build, do you mean this -> 
https://github.com/bloomberg/lucene-solr/tree/branch_5x 


It seems that LTR is not merged onto it and I doubt it is mergable without 
changes as this is exactly what I have tried and failed. As for your pull 
request SOLR-8542, it is supposed to be merged to the master branch which is 
already the version 7.0.0. Is the LTR plugin originally developed only 
compatible with Solr-6x and later or am I missing something here?

Regards
Anil

On 04 Apr 2016, at 20:33, Michael Nilsson > wrote:

> Hi Ahmet, I'm one of the developers working on the LTR plugin.  Please feel 
> free to leave comments directly on the pull request for now for SOLR-8542 
>  here:
> https://github.com/apache/lucene-solr/pull/4 
> 
> 
> I went ahead and made a ticket internally for us to look at.  We have a 5.x 
> branch build, so we'll see what's going with that and get back to you.
> 
> -Michael
> 
> On Mon, Apr 4, 2016 at 12:16 PM, Ahmet Anil Pala  > wrote:
> Hi! thanks for the answer. Unfortunately that’s not possible because they 
> disabled issue tracking on their repo. I thought maybe someone reading this 
> forum had to use LTR plugin before and could help me.
> 
> Anil
> 
>> On Apr 4, 2016, at 5:25 PM, David Smiley > > wrote:
>> 
>> comments
> 
> 

Re: Porting LTR plugin for Solr-5.5.0

[Michael Nilsson]

Hi Ahmet, I'm one of the developers working on the LTR plugin.  Please feel
free to leave comments directly on the pull request for now for SOLR-8542
 here:
https://github.com/apache/lucene-solr/pull/4

I went ahead and made a ticket internally for us to look at.  We have a 5.x
branch build, so we'll see what's going with that and get back to you.

-Michael

On Mon, Apr 4, 2016 at 12:16 PM, Ahmet Anil Pala 
wrote:

> Hi! thanks for the answer. Unfortunately that’s not possible because they
> disabled issue tracking on their repo. I thought maybe someone reading this
> forum had to use LTR plugin before and could help me.
>
> Anil
>
> On Apr 4, 2016, at 5:25 PM, David Smiley  wrote:
>
> comments
>
>
>

Re: Porting LTR plugin for Solr-5.5.0

[Ahmet Anil Pala]

Hi! thanks for the answer. Unfortunately that’s not possible because they 
disabled issue tracking on their repo. I thought maybe someone reading this 
forum had to use LTR plugin before and could help me.

Anil

> On Apr 4, 2016, at 5:25 PM, David Smiley  wrote:
> 
> comments

Re: Porting LTR plugin for Solr-5.5.0

[David Smiley]

Hi Ahmet,

I think you are trying to get help from the wrong place.  I suggest filing
a GitHub issue on the repo from which you are getting this from.

Good luck,

~ David

On Mon, Apr 4, 2016 at 4:41 AM Ahmet Anil Pala  wrote:

> Hi, I need to use the LTR plugin which compiles for Solr-6.0.0 [here](
> https://github.com/bloomberg/lucene-solr/tree/master-ltr-plugin-rfc-cpoerschke-
> comments)
>
> I have attempted to port the plugin for Solr-5.5.0 [here](
> https://github.com/aanilpala/lucene-solr/commit/94ad14c4b9eae2c899e3941967f59b9fc20401b9
> )
>
> Reranking works fine, however when I want to extract features with the
> following parameters, I get an NPE : fv=true=*,[features]`
> Here is the stack trace :
>
> ```
>
> o.a.s.s.HttpSolrCall null:java.lang.NullPointerException
>   at 
> org.apache.solr.ltr.ranking.LTRFeatureLoggerTransformerFactory$FeatureTransformer.transform(LTRFeatureLoggerTransformerFactory.java:131)
>   at 
> org.apache.solr.response.transform.DocTransformers.transform(DocTransformers.java:76)
>   at org.apache.solr.response.DocsStreamer.next(DocsStreamer.java:160)
>   at 
> org.apache.solr.response.TextResponseWriter.writeDocuments(TextResponseWriter.java:246)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:151)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:183)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:299)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:95)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:60)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:52)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:743)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:467)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:225)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:183)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
>   at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
>   at 
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
>   at org.eclipse.jetty.server.Server.handle(Server.java:499)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
>   at 
> org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
>   at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
>   at 
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
>   at java.lang.Thread.run(Thread.java:745)
>
> ```
>
> Regards
>
> Anil
>
> --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com

Porting LTR plugin for Solr-5.5.0

[Ahmet Anil Pala]

Hi, I need to use the LTR plugin which compiles for Solr-6.0.0 
[here](https://github.com/bloomberg/lucene-solr/tree/master-ltr-plugin-rfc-cpoerschke-comments)

I have attempted to port the plugin for Solr-5.5.0 
[here](https://github.com/aanilpala/lucene-solr/commit/94ad14c4b9eae2c899e3941967f59b9fc20401b9)

Reranking works fine, however when I want to extract features with the 
following parameters, I get an NPE : fv=true=*,[features]`
Here is the stack trace :

```
o.a.s.s.HttpSolrCall null:java.lang.NullPointerException
at 
org.apache.solr.ltr.ranking.LTRFeatureLoggerTransformerFactory$FeatureTransformer.transform(LTRFeatureLoggerTransformerFactory.java:131)
at 
org.apache.solr.response.transform.DocTransformers.transform(DocTransformers.java:76)
at org.apache.solr.response.DocsStreamer.next(DocsStreamer.java:160)
at 
org.apache.solr.response.TextResponseWriter.writeDocuments(TextResponseWriter.java:246)
at 
org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:151)
at 
org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:183)
at 
org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:299)
at 
org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:95)
at 
org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:60)
at 
org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:52)
at 
org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:743)
at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:467)
at 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:225)
at 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:183)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at 
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
at 
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
at org.eclipse.jetty.server.Server.handle(Server.java:499)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
at 
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
at 
org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
```
Regards
Anil