Re: reviews.apache.org / GIT migration
Yes, thanks for the input everyone. https://issues.apache.org/jira/browse/INFRA-11152 created for a lucene-solr.git project on ReviewBoard. From: dev@lucene.apache.org At: Jan 26 2016 19:55:44 To: dev@lucene.apache.org Cc: Christine Poerschke (BLOOMBERG/ LONDON) Subject: Re: reviews.apache.org / GIT migration Thanks for the input guys. On Tue, Jan 26, 2016 at 2:37 PM Mike Drob wrote: To add another possibility to the mix, I'd suggest using something like Apache Yetus to manage commit process. On Tue, Jan 26, 2016 at 1:22 PM, Gregory Chanan wrote: IMO reviewboard with git is strictly better than reviewboard with svn; getting reviewboard from svn to accept my patches was always a chore -- I've never had that problem with git. I have mixed feelings about gerrit. The main advantages are: 1) automatic pre commit checks (i.e. I can have it run the unit tests / precommit when I put a patch up for review), no extra effort on my part or taxing of my dev machine. 2) better source repository integration. I can see which patches have been committed and which haven't and it's easier to submit and track multiple changes that depend on each other). I can also set it up to commit to the repository the way I want (i.e. always cherry pick). The downside is the UI is just awful, at least for the version I'm used to. As an example, I haven't even figured out a good way of replying to a review comment without copying the comment (from a different page!), pasting it and adding my own quotes so it's clear which comment I'm referring to. So, if you are looking for a tool to assist in reviews, I would recommend Review Board. If you are looking for a tool to help you manage the commit process, gerrit does that pretty well. Greg On Tue, Jan 26, 2016 at 7:42 AM, david.w.smi...@gmail.com wrote: +1; I can't see how anyone would object to adding/retaining support for the tool. Nobody is forced to use it. I'm curious of the move to Git allows for possibly better options. I've heard good things about Gerrit but I've never tried it. I have mixed feelings of my experience with Reviewboard, but *anything* beats reviewing big patch files! Mark, Greg what do you guys think? I recall you two used it too. On Tue, Jan 26, 2016 at 10:33 AM Christine Poerschke (BLOOMBERG/ LONDON) wrote: Looks like https://issues.apache.org/jira/browse/INFRA-7630 set up the original/existing review board. If there are no objections or existing ticket then I will raise a similar ticket towards the end of this week. Christine - Original Message - From: dev@lucene.apache.org To: dev@lucene.apache.org At: Jan 26 2016 15:18:22 Hello. Having not used it before, I'd like to try out reviews.apache.org (even though it's only been used a few times for the project in the past based on the https://reviews.apache.org/groups/lucene/ listing). The review board seems so far unware of the svn-to-git migration. Other projects have dual listings e.g. hive and hive-git or zookeeper and zookeeper-git. If no one else is looking yet then I'd be happy to look into setting up a lucene-solr-git reviews.apache.org entry? Christine - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
Re: reviews.apache.org / GIT migration
Thanks for the input guys. On Tue, Jan 26, 2016 at 2:37 PM Mike Drob wrote: > To add another possibility to the mix, I'd suggest using something like > Apache Yetus to manage commit process. > > On Tue, Jan 26, 2016 at 1:22 PM, Gregory Chanan > wrote: > >> IMO reviewboard with git is strictly better than reviewboard with svn; >> getting reviewboard from svn to accept my patches was always a chore -- >> I've never had that problem with git. >> >> I have mixed feelings about gerrit. The main advantages are: >> 1) automatic pre commit checks (i.e. I can have it run the unit tests / >> precommit when I put a patch up for review), no extra effort on my part or >> taxing of my dev machine. >> 2) better source repository integration. I can see which patches have >> been committed and which haven't and it's easier to submit and track >> multiple changes that depend on each other). I can also set it up to >> commit to the repository the way I want (i.e. always cherry pick). >> >> The downside is the UI is just awful, at least for the version I'm used >> to. As an example, I haven't even figured out a good way of replying to a >> review comment without copying the comment (from a different page!), >> pasting it and adding my own quotes so it's clear which comment I'm >> referring to. >> >> So, if you are looking for a tool to assist in reviews, I would recommend >> Review Board. If you are looking for a tool to help you manage the commit >> process, gerrit does that pretty well. >> >> Greg >> >> On Tue, Jan 26, 2016 at 7:42 AM, david.w.smi...@gmail.com < >> david.w.smi...@gmail.com> wrote: >> >>> +1; I can't see how anyone would object to adding/retaining support for >>> the tool. Nobody is forced to use it. >>> >>> I'm curious of the move to Git allows for possibly better options. I've >>> heard good things about Gerrit but I've never tried it. I have mixed >>> feelings of my experience with Reviewboard, but *anything* beats reviewing >>> big patch files! >>> >>> Mark, Greg what do you guys think? I recall you two used it too. >>> >>> On Tue, Jan 26, 2016 at 10:33 AM Christine Poerschke (BLOOMBERG/ LONDON) >>> wrote: >>> Looks like https://issues.apache.org/jira/browse/INFRA-7630 set up the original/existing review board. If there are no objections or existing ticket then I will raise a similar ticket towards the end of this week. Christine - Original Message - From: dev@lucene.apache.org To: dev@lucene.apache.org At: Jan 26 2016 15:18:22 Hello. Having not used it before, I'd like to try out reviews.apache.org (even though it's only been used a few times for the project in the past based on the https://reviews.apache.org/groups/lucene/ listing). The review board seems so far unware of the svn-to-git migration. Other projects have dual listings e.g. hive and hive-git or zookeeper and zookeeper-git. If no one else is looking yet then I'd be happy to look into setting up a lucene-solr-git reviews.apache.org entry? Christine - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org -- >>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >>> http://www.solrenterprisesearchserver.com >>> >> >> > -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
Re: reviews.apache.org / GIT migration
To add another possibility to the mix, I'd suggest using something like Apache Yetus to manage commit process. On Tue, Jan 26, 2016 at 1:22 PM, Gregory Chanan wrote: > IMO reviewboard with git is strictly better than reviewboard with svn; > getting reviewboard from svn to accept my patches was always a chore -- > I've never had that problem with git. > > I have mixed feelings about gerrit. The main advantages are: > 1) automatic pre commit checks (i.e. I can have it run the unit tests / > precommit when I put a patch up for review), no extra effort on my part or > taxing of my dev machine. > 2) better source repository integration. I can see which patches have > been committed and which haven't and it's easier to submit and track > multiple changes that depend on each other). I can also set it up to > commit to the repository the way I want (i.e. always cherry pick). > > The downside is the UI is just awful, at least for the version I'm used > to. As an example, I haven't even figured out a good way of replying to a > review comment without copying the comment (from a different page!), > pasting it and adding my own quotes so it's clear which comment I'm > referring to. > > So, if you are looking for a tool to assist in reviews, I would recommend > Review Board. If you are looking for a tool to help you manage the commit > process, gerrit does that pretty well. > > Greg > > On Tue, Jan 26, 2016 at 7:42 AM, david.w.smi...@gmail.com < > david.w.smi...@gmail.com> wrote: > >> +1; I can't see how anyone would object to adding/retaining support for >> the tool. Nobody is forced to use it. >> >> I'm curious of the move to Git allows for possibly better options. I've >> heard good things about Gerrit but I've never tried it. I have mixed >> feelings of my experience with Reviewboard, but *anything* beats reviewing >> big patch files! >> >> Mark, Greg what do you guys think? I recall you two used it too. >> >> On Tue, Jan 26, 2016 at 10:33 AM Christine Poerschke (BLOOMBERG/ LONDON) < >> cpoersc...@bloomberg.net> wrote: >> >>> Looks like https://issues.apache.org/jira/browse/INFRA-7630 set up the >>> original/existing review board. If there are no objections or existing >>> ticket then I will raise a similar ticket towards the end of this week. >>> >>> Christine >>> >>> - Original Message - >>> From: dev@lucene.apache.org >>> To: dev@lucene.apache.org >>> At: Jan 26 2016 15:18:22 >>> >>> Hello. >>> >>> Having not used it before, I'd like to try out reviews.apache.org (even >>> though it's only been used a few times for the project in the past based on >>> the https://reviews.apache.org/groups/lucene/ listing). >>> >>> The review board seems so far unware of the svn-to-git migration. Other >>> projects have dual listings e.g. hive and hive-git or zookeeper and >>> zookeeper-git. >>> >>> If no one else is looking yet then I'd be happy to look into setting up >>> a lucene-solr-git reviews.apache.org entry? >>> >>> Christine >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >>> -- >> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >> http://www.solrenterprisesearchserver.com >> > >
Re: reviews.apache.org / GIT migration
IMO reviewboard with git is strictly better than reviewboard with svn; getting reviewboard from svn to accept my patches was always a chore -- I've never had that problem with git. I have mixed feelings about gerrit. The main advantages are: 1) automatic pre commit checks (i.e. I can have it run the unit tests / precommit when I put a patch up for review), no extra effort on my part or taxing of my dev machine. 2) better source repository integration. I can see which patches have been committed and which haven't and it's easier to submit and track multiple changes that depend on each other). I can also set it up to commit to the repository the way I want (i.e. always cherry pick). The downside is the UI is just awful, at least for the version I'm used to. As an example, I haven't even figured out a good way of replying to a review comment without copying the comment (from a different page!), pasting it and adding my own quotes so it's clear which comment I'm referring to. So, if you are looking for a tool to assist in reviews, I would recommend Review Board. If you are looking for a tool to help you manage the commit process, gerrit does that pretty well. Greg On Tue, Jan 26, 2016 at 7:42 AM, david.w.smi...@gmail.com < david.w.smi...@gmail.com> wrote: > +1; I can't see how anyone would object to adding/retaining support for > the tool. Nobody is forced to use it. > > I'm curious of the move to Git allows for possibly better options. I've > heard good things about Gerrit but I've never tried it. I have mixed > feelings of my experience with Reviewboard, but *anything* beats reviewing > big patch files! > > Mark, Greg what do you guys think? I recall you two used it too. > > On Tue, Jan 26, 2016 at 10:33 AM Christine Poerschke (BLOOMBERG/ LONDON) < > cpoersc...@bloomberg.net> wrote: > >> Looks like https://issues.apache.org/jira/browse/INFRA-7630 set up the >> original/existing review board. If there are no objections or existing >> ticket then I will raise a similar ticket towards the end of this week. >> >> Christine >> >> - Original Message - >> From: dev@lucene.apache.org >> To: dev@lucene.apache.org >> At: Jan 26 2016 15:18:22 >> >> Hello. >> >> Having not used it before, I'd like to try out reviews.apache.org (even >> though it's only been used a few times for the project in the past based on >> the https://reviews.apache.org/groups/lucene/ listing). >> >> The review board seems so far unware of the svn-to-git migration. Other >> projects have dual listings e.g. hive and hive-git or zookeeper and >> zookeeper-git. >> >> If no one else is looking yet then I'd be happy to look into setting up a >> lucene-solr-git reviews.apache.org entry? >> >> Christine >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> -- > Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker > LinkedIn: http://linkedin.com/in/davidwsmiley | Book: > http://www.solrenterprisesearchserver.com >
Re: reviews.apache.org / GIT migration
+1; I can't see how anyone would object to adding/retaining support for the tool. Nobody is forced to use it. I'm curious of the move to Git allows for possibly better options. I've heard good things about Gerrit but I've never tried it. I have mixed feelings of my experience with Reviewboard, but *anything* beats reviewing big patch files! Mark, Greg what do you guys think? I recall you two used it too. On Tue, Jan 26, 2016 at 10:33 AM Christine Poerschke (BLOOMBERG/ LONDON) < cpoersc...@bloomberg.net> wrote: > Looks like https://issues.apache.org/jira/browse/INFRA-7630 set up the > original/existing review board. If there are no objections or existing > ticket then I will raise a similar ticket towards the end of this week. > > Christine > > - Original Message - > From: dev@lucene.apache.org > To: dev@lucene.apache.org > At: Jan 26 2016 15:18:22 > > Hello. > > Having not used it before, I'd like to try out reviews.apache.org (even > though it's only been used a few times for the project in the past based on > the https://reviews.apache.org/groups/lucene/ listing). > > The review board seems so far unware of the svn-to-git migration. Other > projects have dual listings e.g. hive and hive-git or zookeeper and > zookeeper-git. > > If no one else is looking yet then I'd be happy to look into setting up a > lucene-solr-git reviews.apache.org entry? > > Christine > > - > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
reviews.apache.org / GIT migration
Hello. Having not used it before, I'd like to try out reviews.apache.org (even though it's only been used a few times for the project in the past based on the https://reviews.apache.org/groups/lucene/ listing). The review board seems so far unware of the svn-to-git migration. Other projects have dual listings e.g. hive and hive-git or zookeeper and zookeeper-git. If no one else is looking yet then I'd be happy to look into setting up a lucene-solr-git reviews.apache.org entry? Christine
