Re: seconder on other fixes for Maven 3.5.3

2018-02-10 Thread Arnaud Héritier 
+1 for them Hervé

Thx

On Fri, Feb 9, 2018 at 12:29 AM, Hervé BOUTEMY 
wrote:

> Hi,
>
> Here is a new list of fixes I'd like to merge:
>
> - update parent pom to version 31
> https://builds.apache.org/view/M-R/view/Maven/job/maven-
> wip/job/maven/job/upgrade_parent_pom/
>
> - MNG-6255 Maven script cannot parse jvm.config with CRLF
> https://issues.apache.org/jira/browse/MNG-6255
> https://builds.apache.org/view/M-R/view/Maven/job/maven-
> wip/job/maven/job/MNG-6255/
>
> - Jansi 1.17 upgrade, which fixes 3 Jira issues on encoding & MingW/GitBash
> https://issues.apache.org/jira/browse/MNG-6320
> https://issues.apache.org/jira/browse/MNG-6282
> https://issues.apache.org/jira/browse/MNG-6218
> https://builds.apache.org/view/M-R/view/Maven/job/maven-
> wip/job/maven/job/MNG-6320_jansi-1.17/
>
> - Mockito upgrade
> https://issues.apache.org/jira/browse/MNG-6335
> https://builds.apache.org/view/M-R/view/Maven/job/maven-
> wip/job/maven/job/MNG-6335_Mockito_upgrade/
>
>
> Regards,
>
> Hervé
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
-
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier

Re: seconder on other fixes for Maven 3.5.3

2018-02-10 Thread Hervé BOUTEMY 
Le samedi 10 février 2018, 19:31:13 CET Sylwester Lachiewicz a écrit :
> Hi,
> i would like to add also:
> https://github.com/apache/maven/pull/149 to fast fix all checkstyle
> violations
+1

> MNG-6069 https://github.com/apache/maven/pull/153 commons-cli updates
> MNG-5378 https://github.com/apache/maven/pull/155 partial plexus-utils ->
> commons-lang
I don't know on these ones: review from others would be useful

> https://github.com/apache/maven/pull/156 partial replacement to Google Guava
+1

> 
> 
> I'm not sure, but a pull requests from GitHub is not always closed - maybe
> we need to update the documentation on how to contribute to Maven [1] using
> the GitHub?
with the move to GitBox, we'll be able to close the PRs

> 
> There is also more than 40 already delivered fixes [2] for review.
> 
> Regards
> Sylwester
> 
> [1]
> http://maven.apache.org/guides/development/guide-maven-development.html#Crea
> ting_and_submitting_a_patch [2] https://github.com/apache/maven/pulls
> 
> 
> pt., 9 lut 2018 o 08:19 użytkownik Stephen Connolly <
> 
> stephen.alan.conno...@gmail.com> napisał:
> > +1 on all of those
> > 
> > On Thu 8 Feb 2018 at 23:30, Hervé BOUTEMY  wrote:
> > > Hi,
> > > 
> > > Here is a new list of fixes I'd like to merge:
> > > 
> > > - update parent pom to version 31
> > 
> > https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/
> > upgrade_parent_pom/> 
> > > - MNG-6255 Maven script cannot parse jvm.config with CRLF
> > > https://issues.apache.org/jira/browse/MNG-6255
> > 
> > https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/
> > MNG-6255/> 
> > > - Jansi 1.17 upgrade, which fixes 3 Jira issues on encoding &
> > 
> > MingW/GitBash
> > 
> > > https://issues.apache.org/jira/browse/MNG-6320
> > > https://issues.apache.org/jira/browse/MNG-6282
> > > https://issues.apache.org/jira/browse/MNG-6218
> > 
> > https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/
> > MNG-6320_jansi-1.17/> 
> > > - Mockito upgrade
> > > https://issues.apache.org/jira/browse/MNG-6335
> > 
> > https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/
> > MNG-6335_Mockito_upgrade/> 
> > > Regards,
> > > 
> > > Hervé
> > > 
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > > 
> > > --
> > 
> > Sent from my phone



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: seconder on other fixes for Maven 3.5.3

2018-02-10 Thread Sylwester Lachiewicz 
Hi,
i would like to add also:
https://github.com/apache/maven/pull/149 to fast fix all checkstyle
violations
MNG-6069 https://github.com/apache/maven/pull/153 commons-cli updates
MNG-5378 https://github.com/apache/maven/pull/155 partial plexus-utils ->
commons-lang
https://github.com/apache/maven/pull/156 partial replacement to Google Guava


I'm not sure, but a pull requests from GitHub is not always closed - maybe
we need to update the documentation on how to contribute to Maven [1] using
the GitHub?

There is also more than 40 already delivered fixes [2] for review.

Regards
Sylwester

[1]
http://maven.apache.org/guides/development/guide-maven-development.html#Creating_and_submitting_a_patch
[2] https://github.com/apache/maven/pulls


pt., 9 lut 2018 o 08:19 użytkownik Stephen Connolly <
stephen.alan.conno...@gmail.com> napisał:

> +1 on all of those
>
> On Thu 8 Feb 2018 at 23:30, Hervé BOUTEMY  wrote:
>
> > Hi,
> >
> > Here is a new list of fixes I'd like to merge:
> >
> > - update parent pom to version 31
> >
> >
> https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/upgrade_parent_pom/
> >
> > - MNG-6255 Maven script cannot parse jvm.config with CRLF
> > https://issues.apache.org/jira/browse/MNG-6255
> >
> >
> https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/MNG-6255/
> >
> > - Jansi 1.17 upgrade, which fixes 3 Jira issues on encoding &
> MingW/GitBash
> > https://issues.apache.org/jira/browse/MNG-6320
> > https://issues.apache.org/jira/browse/MNG-6282
> > https://issues.apache.org/jira/browse/MNG-6218
> >
> >
> https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/MNG-6320_jansi-1.17/
> >
> > - Mockito upgrade
> > https://issues.apache.org/jira/browse/MNG-6335
> >
> >
> https://builds.apache.org/view/M-R/view/Maven/job/maven-wip/job/maven/job/MNG-6335_Mockito_upgrade/
> >
> >
> > Regards,
> >
> > Hervé
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> > --
> Sent from my phone
>

[GitHub] maven pull request #156: Remove Google Guava usage (move to Java7)

2018-02-10 Thread slachiewicz 
GitHub user slachiewicz opened a pull request:

https://github.com/apache/maven/pull/156

Remove Google Guava usage (move to Java7)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/slachiewicz/maven remove-guava-java7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #156


commit 6eede1a8ff4b7bcbbbafd0729548b87deec30e07
Author: Sylwester Lachiewicz 
Date:   2017-11-08T21:29:50Z

Remove Google Guava usage (move to Java7)




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #155: [MNG-5378] Replace plexus-util StringUtils with com...

2018-02-10 Thread slachiewicz 
GitHub user slachiewicz opened a pull request:

https://github.com/apache/maven/pull/155

[MNG-5378] Replace plexus-util StringUtils with commons-lang3



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/slachiewicz/maven fix/MNG-5378

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #155


commit 6c57ccb33ef97170dba63b835200a0fd84de6a68
Author: Sylwester Lachiewicz 
Date:   2018-02-10T18:05:53Z

[MNG-5378] Replace plexus-utils with commons-lang3




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[DISCUSS] Do we want to keep “seconding” for core?

2018-02-10 Thread Stephen Connolly 
When we had the “big reset” I asked for seconding before merging as the
priority was to get a functioning release out.

IMHO outside of burndown towards a release, a successful CI build of the
branch, providing the branch is fast-forward mergable (not that we actually
do a fast forward merge - merge policy being a separate topic, just that
all commits are on top of master without rebasing) should be all that is
required to merge (the release manager, ie whoever steps up to do a
release, may revert any problematic merges when time comes to actually
release)

Once a release manager has stepped up and declared the start of a
burn-down... in that case seconding should apply.

Wdyt?

(Ps I haven’t declared burn down for core *yet*, but I will in the next
week or two)
-- 
Sent from my phone

Re: Second MNG-6353

2018-02-10 Thread Sylwester Lachiewicz 
+1

I checked also with casting to LoggerLevelRenderer

Sylwester

sob., 10 lut 2018 o 16:31 użytkownik Karl Heinz Marbaise 
napisał:

> Hi,
>
> On 10/02/18 16:16, Robert Scholte wrote:
> > Who wants to second
>
> I want ...
>
> +1 from me...
>
>
> Kind regards
> Karl Heinz Marbaise
> >
> > https://github.com/apache/maven/compare/MNG-6353 ?
> > https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6353/
> >
> > thanks,
> > Robert
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: Second MNG-6353

2018-02-10 Thread Karl Heinz Marbaise 

Hi,

On 10/02/18 16:16, Robert Scholte wrote:

Who wants to second


I want ...

+1 from me...


Kind regards
Karl Heinz Marbaise


https://github.com/apache/maven/compare/MNG-6353 ?
https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6353/

thanks,
Robert


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Second MNG-6353

2018-02-10 Thread Robert Scholte 

Who wants to second

https://github.com/apache/maven/compare/MNG-6353 ?
https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6353/

thanks,
Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #153: [MNG-6069] Migrate to non deprecated parts of Commo...

2018-02-10 Thread slachiewicz 
Github user slachiewicz commented on a diff in the pull request:

https://github.com/apache/maven/pull/153#discussion_r167400525
  
--- Diff: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java 
---
@@ -1620,14 +1620,18 @@ static void populateProperties( CommandLine 
commandLine, Properties systemProper
 
 if ( commandLine.hasOption( CLIManager.SET_SYSTEM_PROPERTY ) )
 {
-String[] defStrs = commandLine.getOptionValues( 
CLIManager.SET_SYSTEM_PROPERTY );
-
-if ( defStrs != null )
+Properties lineOptionProperties = 
commandLine.getOptionProperties( CLIManager.SET_SYSTEM_PROPERTY );
+
+for ( String defStr : 
lineOptionProperties.stringPropertyNames( ) )
 {
-for ( String defStr : defStrs )
-{
-setCliProperty( defStr, userProperties );
-}
+String optValue = lineOptionProperties.getProperty( defStr 
);
+userProperties.setProperty( defStr, optValue );
+
+// 
--
+// I'm leaving the setting of system properties here as 
not to break
+// the SystemPropertyProfileActivator. This won't harm 
embedding. jvz.
+// 
--
+   System.setProperty( defStr, optValue );
--- End diff --

System properties will stay, new commons-cli just simplified setCliProperty.


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #154: [MNG-5967] Correct Mockito scope to test

2018-02-10 Thread slachiewicz 
Github user slachiewicz closed the pull request at:

https://github.com/apache/maven/pull/154


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #150: [ MNG-6335] Update Mockito to 2.12.0

2018-02-10 Thread slachiewicz 
Github user slachiewicz closed the pull request at:

https://github.com/apache/maven/pull/150


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[ANN] Apache Maven Shared Utils 3.2.1 Released

2018-02-10 Thread Robert Scholte 
The Apache Maven team is pleased to announce the release of the Apache  
Maven Shared Utils, version 3.2.1


This project aims to be a functional replacement for plexus-utils in Maven.

https://maven.apache.org/shared/maven-shared-utils/

You should specify the version in your project's dependency configuration:


  org.apache.maven.plugins
  maven-shared-utils
  3.2.1


You can download the appropriate sources etc. from the download page:

https://maven.apache.org/shared/maven-shared-utils/download.cgi

Release Notes - Maven Shared Components - Version maven-shared-utils-3.2.1

** New Feature
* [MSHARED-648] - Add registerShutdownHook to MessageUtils

** Dependency upgrade
* [MSHARED-672] - Upgrade plexus-container-default to 1.7.1


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Surefire 2.21 release date ?

2018-02-10 Thread Tibor Digana 
Jesus, the things are different. Let it be I will complete it this
weekend!!!

On Sat, Feb 10, 2018 at 12:09 PM, Olivier Lamy  wrote:

> this build is failing:
> https://builds.apache.org/view/M-R/view/Maven/job/
> surefire/job/SUREFIRE-1463/136/console
> to be able to run with jdk9/10 we need to change enforcer jdk rule which is
> currently [1.8, 1.9)
> until this change we cannot build with 9/10 without skipping enforcer check
> So if we want to build with 9/10 we must change that or remove this rule
> which doesn't help for testing with new jdk
>
> On 10 February 2018 at 10:35, Tibor Digana  wrote:
>
> > If you could see my issues reported to INFRA you would see what is going
> > on. I am currently running 23 parallel jobs, also supporting JDK10.
> > If they run standalone there is no issue. Once the machine is overloaded
> 3
> > or 4 problems happen nevertheless JDK is set.
> > So from my side it is working on JDKs but I want to working on these few
> > issues and change the concurrency in the build script.
> > I will work on it this weekend.
> > I will get back to you tomorrow evening.
> >
> > On Fri, Feb 9, 2018 at 11:51 PM, Olivier Lamy  wrote:
> >
> > > On 9 February 2018 at 21:57, Enrico Olivelli 
> > wrote:
> > >
> > > > Il ven 9 feb 2018, 02:13 Olivier Lamy  ha scritto:
> > > >
> > > > > On 8 February 2018 at 07:00, Hervé BOUTEMY 
> > > > wrote:
> > > > >
> > > > > > Le jeudi 8 février 2018, 06:45:24 CET Olivier Lamy a écrit :
> > > > > > > Hi,
> > > > > > > I'm looking now at having surefire/failsafe working with jdk10
> > (yup
> > > > > first
> > > > > > > RC is expected really soon :-)
> > > > > > > I can't get failsafe working with jdk10 because of a
> > commons-lang3
> > > > bug
> > > > > > (see
> > > > > > > https://issues.apache.org/jira/browse/SUREFIRE-1473 due to
> > > > > > > https://issues.apache.org/jira/browse/LANG-1365)
> > > > > > > So I simply upgraded to commons-lang3 but now it looks enforcer
> > is
> > > > > > > configured to enforce 1.6.
> > > > > > > Well as I was thinking: 1.6 really in 2018?
> > > > > > > So I created SUREFIRE-1474 and push it.
> > > > > > > Let me know if you have any issues with that?
> > > > > > no issue with that: if people want old JDK, they need old Maven
> > > > Surefire
> > > > > > Plugin
> > > > > > version, that's quite natural
> > > > > > Please just add a table in the plugin doc about which is the
> latest
> > > > > > Surefire
> > > > > > version that support which JDK
> > > > > >
> > > > >
> > > > > where is the page?
> > > > >
> > > >
> > > > Is it this one?
> > > >
> > > > https://cwiki.apache.org/confluence/display/MAVEN/Java+9+-+Jigsaw
> > >
> > >
> > > not sure if it's this page. I was looking for one with a kind of matrix
> > > saying jdk level for plugins etc...
> > >
> > >
> > >
> > > >
> > > >
> > > > Enrico
> > > >
> > > >
> > >
> > >
> > >
> > > >
> > > > >
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > > Hervé
> > > > > >
> > > > > > > As jdk10 is very soon. I'm happy to release surefire ASAP now.
> > > > > > >
> > > > > > > WDYT?
> > > > > > >
> > > > > > > Cheers
> > > > > > > Olivier
> > > > > > >
> > > > > > > On 4 February 2018 at 19:11, Enrico Olivelli <
> > eolive...@gmail.com>
> > > > > > wrote:
> > > > > > > > Il dom 4 feb 2018, 19:38 Tibor Digana <
> tibordig...@apache.org>
> > > ha
> > > > > > scritto:
> > > > > > > > > Hi Enrico,
> > > > > > > > >
> > > > > > > > > I have got working build script and got some issues on
> > > > integration
> > > > > > tests
> > > > > > > >
> > > > > > > > in
> > > > > > > >
> > > > > > > > > TestNG & Java 10.
> > > > > > > > > See this CLI. I think the JaCoCo Agent property is the
> issue
> > > > > because
> > > > > > it
> > > > > > > >
> > > > > > > > is
> > > > > > > >
> > > > > > > > > not resolved. I will try to put an empty string in there.
> > Maybe
> > > > the
> > > > > > > > > build
> > > > > > > > > would pass.
> > > > > > > >
> > > > > > > > Thank you Tibor for the update. Unfortunately I don't have a
> > > > Windows
> > > > > > box
> > > > > > > > to
> > > > > > > > reproduce the issue.
> > > > > > > >
> > > > > > > > From the error I guess you are right
> > > > > > > >
> > > > > > > > Enrico
> > > > > > > >
> > > > > > > > > [windows-jdk10-maven3.5.x] [ERROR] Command was cmd.exe /X
> /C
> > > > > > > > > "F:\jenkins\tools\java\jdk10-ea+37\bin\java
> ${jacoco.agent}
> > > -jar
> > > > > > > > >
> > > > > > > > > C:\Users\jenkins\AppData\Local\Temp\1\
> > > > surefire3375403847264435698\
> > > > > > > >
> > > > > > > > surefirebooter6458194328264691762.jar
> > > > > > > >
> > > > > > > > > C:\Users\jenkins\AppData\Local\Temp\1\
> > > > surefire3375403847264435698
> > > > > > > > > 2018-02-04T17-23-23_801-jvmRun1
> > surefire15708374661287747855tm
> > > p
> > > > > > > > > surefire_015474024382399849038tmp"
> > > > > > > > >
> > > > > > > > >
> >

[RESULT] [VOTE] Release Apache Maven Shared Utils version 3.2.1

2018-02-10 Thread Robert Scholte 

Hi,

The vote has passed with the following result:

+1 : Robert Scholte, Karl Heinz Marbaise, Hervé BOUTEMY

PMC quorum: reached

I will promote the artifacts to the central repo.

On Tue, 06 Feb 2018 23:11:40 +0100, Robert Scholte   
wrote:



Hi,

We solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922=12340978=Text

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317922%20AND%20component%20%3D%20maven-shared-utils%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1394
https://repository.apache.org/content/repositories/maven-1394/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1-source-release.zip

Source release checksum(s):
maven-shared-utils-3.2.1-source-release.zip sha1:  
015559e466938c7e9053603d37b96ef3e03b802b


Staging site:
https://maven.apache.org/shared-archives/maven-shared-utils-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shared Utils version 3.2.1

2018-02-10 Thread Hervé BOUTEMY 
+1

notice I checked build reproducibility with diffoscope: in addition to usual 
small differences, there is one unusual difference that surprises me
I built with the exact same JDK version 1.7.0_80, but there are some little 
differences in resulting bytecode. Perhaps this is because Robert built on 
Windows (I suppose) and me on Linux
But definitely, there are challenges to full build reproducibility/
verifiability...

Regards,

Hervé

Le mardi 6 février 2018, 23:11:40 CET Robert Scholte a écrit :
> Hi,
> 
> We solved 2 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922
> rsion=12340978=Text
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317922%20AND%20
> component%20%3D%20maven-shared-utils%20AND%20status%20%3D%20Open%20ORDER%20B
> Y%20key%20DESC%2C%20priority%20DESC
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1394
> https://repository.apache.org/content/repositories/maven-1394/org/apache/mav
> en/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1-source-release.z
> ip
> 
> Source release checksum(s):
> maven-shared-utils-3.2.1-source-release.zip sha1:
> 015559e466938c7e9053603d37b96ef3e03b802b
> 
> Staging site:
> https://maven.apache.org/shared-archives/maven-shared-utils-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Snapshot deployments by CI

2018-02-10 Thread Hervé BOUTEMY 
Le samedi 10 février 2018, 00:10:14 CET Olivier Lamy a écrit :
> Policy: snaphots from master branches (and possibly long lived maintenance
> branches) are deployed automatically.
+1
for long lived branches, the version must have some differentiator from master

> 
> Build setup: downstream projects must be build after a master build and
> deploy.
if possible, that would be great

Regards,

Hervé

> 
> On 9 February 2018 at 13:03, Stephen Connolly <
> 
> stephen.alan.conno...@gmail.com> wrote:
> > Write down the policy you would like
> > 
> > On 9 February 2018 at 12:25, Olivier Lamy  wrote:
> > > On 9 February 2018 at 12:01, Stephen Connolly <
> > > 
> > > stephen.alan.conno...@gmail.com> wrote:
> > > > Document what you think the policy should be and we'll go from there.
> > > > 
> > > > My (current) preferred policy is:
> > > > There is no automatic deployment of snapshots. Developers can
> > > 
> > > manually
> > > 
> > > > publish snapshots on an as needed basis and if they require downstream
> > > > builds to pick those up then they need to configure the downstream
> > > > jobs
> > > > with the explicit timestamped snapshot version.
> > > > 
> > > > 
> > > > The above, IMHO, leads to the least amount of confusion as to why
> > > 
> > > specific
> > > 
> > > > builds are failing, but it does not provide as nice a user experience
> > 
> > as
> > 
> > > I
> > > 
> > > > would like.
> > > > 
> > > > Ideally I would like each branch name to be able to pull the latest
> > > > snapshots from matching branch names of other repositories in the org
> > > > folder where the artifacts were captured by Jenkins in the "verify"
> > 
> > phase
> > 
> > > > or by using a different "deploy" plugin. That would enable the CI
> > 
> > server
> > 
> > > to
> > > 
> > > > manage the lifetime of those artifacts and trigger cross-repository
> > > > dependencies. The end developers would not see these CI only
> > > > artifacts,
> > > 
> > > and
> > > 
> > > > would have to build and install locally. This has the advantage that
> > 
> > your
> > 
> > > > local build always uses what you locally installed... you don't have
> > > > to
> > > > worry about starting the next day and doing `mvn clean install` on the
> > > 
> > > repo
> > > 
> > > > you were trying to debug... going to make a cup of coffee... and
> > > > coming
> > > > back to find stuff not working because you didn't see Maven doing it's
> > > 
> > > "oh
> > > 
> > > > I haven't checked for newer snapshots in 24h, I last checked yesterday
> > > > morning... oh look a new snapshot, let's ignore the snapshot that was
> > > > installed locally at 4pm yesterday" and replacing your locally
> > 
> > installed
> > 
> > > > snapshot with the latest from the CI server.
> > > 
> > > Sorry but I don't want to go to over complicated things and too much
> > > bureaucracy.
> > > IMHO The problem was more due a monolithic build of all shared/plugins
> > > etc... (as if only one part of the source was modified everything was
> > > rebuild and redeploy even non touched modules)
> > > We had a very convenient auto deployment in the past of
> > 
> > trunk(s)/master(s)
> > 
> > > Someone modified a shared library so it's deploy then a build of
> > 
> > downstream
> > 
> > > projects are scheduled to verify everything is still working,
> > > And then everything is deployed for early testers.
> > > so it's pretty simple (and IMHO should be stay very simple as we are a
> > 
> > very
> > 
> > > limited number of volunteers who don't want to waste in over complicated
> > > procedures...)
> > > 
> > > > But anyway, that is my opinion and rationale. We are a community, my
> > > > opinion should not dictate what the community wants to do.
> > > > 
> > > > I do feel that we need to write down and document what our policy
> > > 
> > > actually
> > > 
> > > > is before we try and implement it.
> > > > 
> > > > On 9 February 2018 at 09:06, Olivier Lamy  wrote:
> > > > > Perso I don't want anything else than master deployed..
> > > > > wip feature branch doesn't make really sense to be deployed.
> > > > > and makes our life easier :-)
> > > > > 
> > > > > On 9 February 2018 at 07:40, Stephen Connolly <
> > > > > 
> > > > > stephen.alan.conno...@gmail.com> wrote:
> > > > > > I personally think there are a lot of issues with CI automatically
> > > > > > deploying snapshots...
> > > > > > 
> > > > > > Some of these issues a social, and some are not.
> > > > > > 
> > > > > > Hervé, Olivier,
> > > > > > 
> > > > > > I suggest we start by writing down the policy you think you
> > > > > > want...
> > > > 
> > > > i’ll
> > > > 
> > > > > > poke holes, you fix or ack until we get a good compromise... then
> > 
> > we
> > 
> > > > can
> > > > 
> > > > > > implement.
> > > > > > 
> > > > > > Policy should cover:
> > > > > > * what to do on different branches
> > > > > > * who is responsible for snapshots and non snapshots
> > > > > > 
> > > > > > Eg
> > > > > > 
>

Re: Surefire 2.21 release date ?

2018-02-10 Thread Olivier Lamy 
this build is failing:
https://builds.apache.org/view/M-R/view/Maven/job/surefire/job/SUREFIRE-1463/136/console
to be able to run with jdk9/10 we need to change enforcer jdk rule which is
currently [1.8, 1.9)
until this change we cannot build with 9/10 without skipping enforcer check
So if we want to build with 9/10 we must change that or remove this rule
which doesn't help for testing with new jdk

On 10 February 2018 at 10:35, Tibor Digana  wrote:

> If you could see my issues reported to INFRA you would see what is going
> on. I am currently running 23 parallel jobs, also supporting JDK10.
> If they run standalone there is no issue. Once the machine is overloaded 3
> or 4 problems happen nevertheless JDK is set.
> So from my side it is working on JDKs but I want to working on these few
> issues and change the concurrency in the build script.
> I will work on it this weekend.
> I will get back to you tomorrow evening.
>
> On Fri, Feb 9, 2018 at 11:51 PM, Olivier Lamy  wrote:
>
> > On 9 February 2018 at 21:57, Enrico Olivelli 
> wrote:
> >
> > > Il ven 9 feb 2018, 02:13 Olivier Lamy  ha scritto:
> > >
> > > > On 8 February 2018 at 07:00, Hervé BOUTEMY 
> > > wrote:
> > > >
> > > > > Le jeudi 8 février 2018, 06:45:24 CET Olivier Lamy a écrit :
> > > > > > Hi,
> > > > > > I'm looking now at having surefire/failsafe working with jdk10
> (yup
> > > > first
> > > > > > RC is expected really soon :-)
> > > > > > I can't get failsafe working with jdk10 because of a
> commons-lang3
> > > bug
> > > > > (see
> > > > > > https://issues.apache.org/jira/browse/SUREFIRE-1473 due to
> > > > > > https://issues.apache.org/jira/browse/LANG-1365)
> > > > > > So I simply upgraded to commons-lang3 but now it looks enforcer
> is
> > > > > > configured to enforce 1.6.
> > > > > > Well as I was thinking: 1.6 really in 2018?
> > > > > > So I created SUREFIRE-1474 and push it.
> > > > > > Let me know if you have any issues with that?
> > > > > no issue with that: if people want old JDK, they need old Maven
> > > Surefire
> > > > > Plugin
> > > > > version, that's quite natural
> > > > > Please just add a table in the plugin doc about which is the latest
> > > > > Surefire
> > > > > version that support which JDK
> > > > >
> > > >
> > > > where is the page?
> > > >
> > >
> > > Is it this one?
> > >
> > > https://cwiki.apache.org/confluence/display/MAVEN/Java+9+-+Jigsaw
> >
> >
> > not sure if it's this page. I was looking for one with a kind of matrix
> > saying jdk level for plugins etc...
> >
> >
> >
> > >
> > >
> > > Enrico
> > >
> > >
> >
> >
> >
> > >
> > > >
> > > > >
> > > > > Regards,
> > > > >
> > > > > Hervé
> > > > >
> > > > > > As jdk10 is very soon. I'm happy to release surefire ASAP now.
> > > > > >
> > > > > > WDYT?
> > > > > >
> > > > > > Cheers
> > > > > > Olivier
> > > > > >
> > > > > > On 4 February 2018 at 19:11, Enrico Olivelli <
> eolive...@gmail.com>
> > > > > wrote:
> > > > > > > Il dom 4 feb 2018, 19:38 Tibor Digana 
> > ha
> > > > > scritto:
> > > > > > > > Hi Enrico,
> > > > > > > >
> > > > > > > > I have got working build script and got some issues on
> > > integration
> > > > > tests
> > > > > > >
> > > > > > > in
> > > > > > >
> > > > > > > > TestNG & Java 10.
> > > > > > > > See this CLI. I think the JaCoCo Agent property is the issue
> > > > because
> > > > > it
> > > > > > >
> > > > > > > is
> > > > > > >
> > > > > > > > not resolved. I will try to put an empty string in there.
> Maybe
> > > the
> > > > > > > > build
> > > > > > > > would pass.
> > > > > > >
> > > > > > > Thank you Tibor for the update. Unfortunately I don't have a
> > > Windows
> > > > > box
> > > > > > > to
> > > > > > > reproduce the issue.
> > > > > > >
> > > > > > > From the error I guess you are right
> > > > > > >
> > > > > > > Enrico
> > > > > > >
> > > > > > > > [windows-jdk10-maven3.5.x] [ERROR] Command was cmd.exe /X /C
> > > > > > > > "F:\jenkins\tools\java\jdk10-ea+37\bin\java ${jacoco.agent}
> > -jar
> > > > > > > >
> > > > > > > > C:\Users\jenkins\AppData\Local\Temp\1\
> > > surefire3375403847264435698\
> > > > > > >
> > > > > > > surefirebooter6458194328264691762.jar
> > > > > > >
> > > > > > > > C:\Users\jenkins\AppData\Local\Temp\1\
> > > surefire3375403847264435698
> > > > > > > > 2018-02-04T17-23-23_801-jvmRun1
> surefire15708374661287747855tm
> > p
> > > > > > > > surefire_015474024382399849038tmp"
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Fri, Feb 2, 2018 at 12:23 AM, Tibor Digana <
> > > > > tibordig...@apache.org>
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > > > It's ok, not annoying.
> > > > > > > > > The issue SUREFIRE-1374 is quite easy to workaround and
> > > therefore
> > > > > I am
> > > > > > > > > working on more difficult issue - the build process.
> > > > > > > > > So regarding build process I contacted our INFRA team and
> > found
> >

Re: Surefire 2.21 release date ?

2018-02-10 Thread Tibor Digana 
If you could see my issues reported to INFRA you would see what is going
on. I am currently running 23 parallel jobs, also supporting JDK10.
If they run standalone there is no issue. Once the machine is overloaded 3
or 4 problems happen nevertheless JDK is set.
So from my side it is working on JDKs but I want to working on these few
issues and change the concurrency in the build script.
I will work on it this weekend.
I will get back to you tomorrow evening.

On Fri, Feb 9, 2018 at 11:51 PM, Olivier Lamy  wrote:

> On 9 February 2018 at 21:57, Enrico Olivelli  wrote:
>
> > Il ven 9 feb 2018, 02:13 Olivier Lamy  ha scritto:
> >
> > > On 8 February 2018 at 07:00, Hervé BOUTEMY 
> > wrote:
> > >
> > > > Le jeudi 8 février 2018, 06:45:24 CET Olivier Lamy a écrit :
> > > > > Hi,
> > > > > I'm looking now at having surefire/failsafe working with jdk10 (yup
> > > first
> > > > > RC is expected really soon :-)
> > > > > I can't get failsafe working with jdk10 because of a commons-lang3
> > bug
> > > > (see
> > > > > https://issues.apache.org/jira/browse/SUREFIRE-1473 due to
> > > > > https://issues.apache.org/jira/browse/LANG-1365)
> > > > > So I simply upgraded to commons-lang3 but now it looks enforcer is
> > > > > configured to enforce 1.6.
> > > > > Well as I was thinking: 1.6 really in 2018?
> > > > > So I created SUREFIRE-1474 and push it.
> > > > > Let me know if you have any issues with that?
> > > > no issue with that: if people want old JDK, they need old Maven
> > Surefire
> > > > Plugin
> > > > version, that's quite natural
> > > > Please just add a table in the plugin doc about which is the latest
> > > > Surefire
> > > > version that support which JDK
> > > >
> > >
> > > where is the page?
> > >
> >
> > Is it this one?
> >
> > https://cwiki.apache.org/confluence/display/MAVEN/Java+9+-+Jigsaw
>
>
> not sure if it's this page. I was looking for one with a kind of matrix
> saying jdk level for plugins etc...
>
>
>
> >
> >
> > Enrico
> >
> >
>
>
>
> >
> > >
> > > >
> > > > Regards,
> > > >
> > > > Hervé
> > > >
> > > > > As jdk10 is very soon. I'm happy to release surefire ASAP now.
> > > > >
> > > > > WDYT?
> > > > >
> > > > > Cheers
> > > > > Olivier
> > > > >
> > > > > On 4 February 2018 at 19:11, Enrico Olivelli 
> > > > wrote:
> > > > > > Il dom 4 feb 2018, 19:38 Tibor Digana 
> ha
> > > > scritto:
> > > > > > > Hi Enrico,
> > > > > > >
> > > > > > > I have got working build script and got some issues on
> > integration
> > > > tests
> > > > > >
> > > > > > in
> > > > > >
> > > > > > > TestNG & Java 10.
> > > > > > > See this CLI. I think the JaCoCo Agent property is the issue
> > > because
> > > > it
> > > > > >
> > > > > > is
> > > > > >
> > > > > > > not resolved. I will try to put an empty string in there. Maybe
> > the
> > > > > > > build
> > > > > > > would pass.
> > > > > >
> > > > > > Thank you Tibor for the update. Unfortunately I don't have a
> > Windows
> > > > box
> > > > > > to
> > > > > > reproduce the issue.
> > > > > >
> > > > > > From the error I guess you are right
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > > > [windows-jdk10-maven3.5.x] [ERROR] Command was cmd.exe /X /C
> > > > > > > "F:\jenkins\tools\java\jdk10-ea+37\bin\java ${jacoco.agent}
> -jar
> > > > > > >
> > > > > > > C:\Users\jenkins\AppData\Local\Temp\1\
> > surefire3375403847264435698\
> > > > > >
> > > > > > surefirebooter6458194328264691762.jar
> > > > > >
> > > > > > > C:\Users\jenkins\AppData\Local\Temp\1\
> > surefire3375403847264435698
> > > > > > > 2018-02-04T17-23-23_801-jvmRun1 surefire15708374661287747855tm
> p
> > > > > > > surefire_015474024382399849038tmp"
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Feb 2, 2018 at 12:23 AM, Tibor Digana <
> > > > tibordig...@apache.org>
> > > > > > >
> > > > > > > wrote:
> > > > > > > > It's ok, not annoying.
> > > > > > > > The issue SUREFIRE-1374 is quite easy to workaround and
> > therefore
> > > > I am
> > > > > > > > working on more difficult issue - the build process.
> > > > > > > > So regarding build process I contacted our INFRA team and
> found
> > > the
> > > > > > > > problem. Now the build is running in [1] and the build script
> > is
> > > in
> > > > > >
> > > > > > [2].
> > > > > >
> > > > > > > I
> > > > > > >
> > > > > > > > should get this working first. We are testing JDK 7, 8, 9, 10
> > on
> > > > Linux
> > > > > > >
> > > > > > > and
> > > > > > >
> > > > > > > > Windows and Maven 3.2 - 3.5.
> > > > > > > >
> > > > > > > > [1]: https://builds.apache.org/
> view/M-R/view/Maven/job/maven->
> > >
> > > > > > surefire-pipeline/job/SUREFIRE-1463/
> > > > > > > > [2]: https://github.com/apache/maven-surefire/blob/SUREFIRE-
> >
> > >
> > > >
> > > > > 1463/Jenkinsfile
> > > > > > > >
> > > > > > > >
> > > > > > > > On Thu, Feb 1, 2018 at 1:55 PM, Enrico Olivelli <
> > > > eolive...@gmail.com>
> > > > > > >