[GitHub] maven issue #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to ...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/129 Closed as per conversation with @hboutemy on JIRA, see this [comment](https://issues.apache.org/jira/browse/MNG-6282?focusedCommentId=16161977=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16161977). --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in or...
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/129 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in or...
GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/129 [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to solve issues s on Windows/GitBash JIRA ticket: https://issues.apache.org/jira/browse/MNG-6282 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6282-jansi-downgrade Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit e1f140fbfc5aa2b443b56bcd88759a78221ce335 Author: dejan2609 <dejan2...@gmail.com> Date: 2017-09-11T17:25:55Z [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to solve issues on Windows/GitBash note: related to MNG-6205 and MNG-6218 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Compiler Plugin version 3.7.0
*+1 * Tested via Maven 3.5.0 and Oracle Java 1.8 on Windows 10 and Linux Centos 6. -- Sent from: http://maven.40175.n5.nabble.com/Maven-Developers-f142166.html - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Compiler Plugin version 3.7.0
*+1 * Tested with Maven 3.5.0 / Oracle Java 1.8.0_131 on Windows 10. -- Sent from: http://maven.40175.n5.nabble.com/Maven-Developers-f142166.html - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/123 Just on more thing that recalled from my memory: I did tried to execute tests (http://maven.apache.org/core-its/core-it-suite) like this: `mvn clean test -Prun-its` but I received warning that profile doesn't exists: > [WARNING] The requested profile "run-its" could not be activated because it does not exist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #123: [MNG-6207] display deprecation build warning for de...
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...
Github user dejan2609 commented on the issue:
https://github.com/apache/maven/pull/123
Just for the record: somehow it slipped of my mind that `package` phase
doesn't execute integration tests
(http://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html#default_Lifecycle)
and hence this checkstyle error pass unnoticed on my side:
> [ERROR]
src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java[471:104]
(blocks) LeftCurly: '{' should be on a new line.
Thanx @khmarbaise for this correction and for overall review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/121 I'm happy to help ! Regards. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #121: [MNG-6206] display deprecation build warning in cas...
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #123: [MNG-6207] display deprecation build warning for de...
GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/123 [MNG-6207] display deprecation build warning for dependencies with scope 'system' declaration Note: this PR is created instead of #119 @khmarbaise: FYI You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6207 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #123 commit 1ddb1f3982a031105384716a1b983228221e00c5 Author: dejan2609 <dejan2...@gmail.com> Date: 2017-05-20T13:42:43Z [MNG-6207] display deprecation build warning for dependencies with scope 'system' declaration Note about tests: existing 'systemPath' related tests are reused/expanded (rationale: scope 'system' and 'systemPath' are mutually dependent) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #119: [MNG-6207] display build WARNING if deprecated 'sys...
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 @khmarbaise Ok, I'll open new PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/121 @khmarbaise Integration tests passed as expected, that's nice. Commit message is altered just a little bit and force-pushed here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 @khmarbaise done, I altered commit messaged (added note about tests). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #121: [MNG-6206] display deprecation build warning in cas...
GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/121 [MNG-6206] display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE) **JIRA ticket**: [MNG-6206: We should produce a WARNING by using RELEASE, LATEST as versions](https://issues.apache.org/jira/browse/MNG-6206) (Note: replaces previously closed PR #120) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6206-deprecating-metaversions-for-dependencies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit 0f98bbe0c2604aa1a89ab48f2df3861f533b8bbc Author: dejan2609 <dejan2...@gmail.com> Date: 2017-05-20T14:57:55Z [MNG-6206] display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 Just to narrow discussion to PR scope only and to eliminate bonus question: there is/was an initiative to increase validation level (**_MNG-6075_** Increase the model validation level to the next minor level version). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #120: [MNG-6206] display deprecation build warning in cas...
Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #120: [MNG-6206] display deprecation build warning in case when ...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/120 My bad, I mistakenly pushed commit without testing; so sorry for that. I will close this merge request and create another. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #120: [MNG-6206] display deprecation build warning in cas...
GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/120 [MNG-6206] display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE) JIRA ticket: [MNG-6206: We should produce a WARNING by using RELEASE, LATEST as versions](https://issues.apache.org/jira/browse/MNG-6206) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6206-deprecating-metaversions-for-dependencies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #120 commit b1e934839812ff207b0046a2e6fd4969f08a789c Author: dejan2609 <dejan2...@gmail.com> Date: 2017-05-20T14:57:55Z [MNG-6206] display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...
Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 New changes are pushed via new commit (all commits will be squashed into one eventually). Solution is tested across different Maven versions (**3.0.5**, **3.1.1**, **3.2.5**, **3.3.9** and **3.5.0**). Test renaming is recalled; however, it seems kind of reasonable (necessary ?) to fine-grain those test cases instead of adding a new one. **Rationale:** since both existing test cases already consume pom.xml files with mutually dependent tags: > \_**system**_\ > \_**Some_Path**_\ it seems convenient to carefully reuse those existing test cases, because both tags end up tested anyway (I reckon that adding a new test case with same two tags would be redundant). @khmarbaise: let me know what you think (and please forgive me if my rationale is not that rational, I'll be ready to dig deeper and accommodate solution in order to fit standards). Bonus question (in the unlikely case that I got it all right): does it make sense to introduce new **ModelBuildingRequest** **_VALIDATION_LEVEL_MAVEN_** (_**3_5**_ or _**3_6**_) ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #119: [MNG-6207] display build WARNING if deprecated 'sys...
GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/119 [MNG-6207] display build WARNING if deprecated 'system' scope is used JIRA ticket: [MNG-6207: Create WARNINGs in case of using system scope](https://issues.apache.org/jira/browse/MNG-6207) Note: since **_system_** scope requires _**systemPath**_ I decided to expand existing and rename systemPath tests; if that kind of change is not acceptable please suggest different approach. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6207-system-scope-deprecation-warning Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/119.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #119 commit 0158be5884be228693ecc43f78561e65f0fc59f0 Author: dejan2609 <dejan2...@gmail.com> Date: 2017-05-20T13:42:43Z [MNG-6207] display build WARNING if deprecated 'system' scope is used --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.0
*+1* (non binding). Tested Maven 3.5.0 on a large project with a bunch of plugins: all is green. -- View this message in context: http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-3-5-0-tp5904383p5904485.html Sent from the Maven Developers mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.5.0-beta-1
+1, it works on dozen of projects. Minor issue is related to maven wrapper: $ ./mvnw clean install Downloading https://repository.apache.org/content/repositories/maven-1325/org/apache/maven/apache-maven/3.5.0-beta- 1/apache-maven-3.5.0-beta-1-bin.zip ... ... ... . Unzipping C:\Users\dejans\.m2\wrapper\dists\apache-maven-3.5.0-beta-1-bin\14d9j0jl6n88hltofuad2ealo5\apache-maven-3 .5.0-beta-1-bin.zip to C:\Users\dejans\.m2\wrapper\dists\apache-maven-3.5.0-beta-1-bin\14d9j0jl6n88hltofuad2ealo5 Exception in thread "main" java.io.FileNotFoundException: C:\Users\dejans\.m2\wrapper\dists\apache-maven-3.5.0-beta -1-bin\14d9j0jl6n88hltofuad2ealo5\apache-maven-3.5.0-beta-1\README.txt (The system cannot find the path specified) at java.io.FileOutputStream.open0(Native Method) at java.io.FileOutputStream.open(FileOutputStream.java:270) at java.io.FileOutputStream.(FileOutputStream.java:213) at java.io.FileOutputStream.(FileOutputStream.java:162) at org.apache.maven.wrapper.Installer.unzip(Installer.java:173) at org.apache.maven.wrapper.Installer.createDist(Installer.java:78) at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:121) at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:50) stephenconnolly wrote > Hi, > > We solved 15 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12339665=Text > > There are still 10 issues left in JIRA for 3.5.0, but I do not think any > of those are blocking an beta release and perhaps could be descoped for > 3.5.0: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20in%20(3.5.0%2C%203.5.0-candidate)%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > In addition there are 313 issues left in JIRA for Maven core: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1325 > > The distributable binaries and sources for testing can be found here: > https://repository.apache.org/content/repositories/maven-1325/org/apache/maven/apache-maven/3.5.0-beta-1/ > > Specifically the zip, tarball, and source archives can be found here: > https://repository.apache.org/content/repositories/maven-1325/org/apache/maven/apache-maven/3.5.0-beta-1/apache-maven-3.5.0-beta-1-bin.zip > https://repository.apache.org/content/repositories/maven-1325/org/apache/maven/apache-maven/3.5.0-beta-1/apache-maven-3.5.0-beta-1-bin.tar.gz > https://repository.apache.org/content/repositories/maven-1325/org/apache/maven/apache-maven/3.5.0-beta-1/apache-maven-3.5.0-beta-1-src.zip > https://repository.apache.org/content/repositories/maven-1325/org/apache/maven/apache-maven/3.5.0-beta-1/apache-maven-3.5.0-beta-1-src.tar.gz > > Source release checksum(s): > apache-maven-3.5.0-beta-1-src.tar.gz sha1: > 6f24770bfff1882ab7ff7120cda6774332c452ff > apache-maven-3.5.0-beta-1-src.zip sha1: > c4ea6e55687f4c02338490dbe99bab9eca027841 > > Git tag: > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=214540c2ae5431645bb927d6dc5498ebafc27359 > > Staging site: > https://maven.apache.org/components/ref/3-LATEST/ > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > > Thanks, > -Stephen -- View this message in context: http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-3-5-0-beta-1-tp5902743p5902918.html Sent from the Maven Developers mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
