Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
On 29 June 2013 11:47, Robert Scholte rfscho...@apache.org wrote: Hi Sebb, none of these files will end up in Maven Central, they are all used for tests. However, they do end up in the source release which is published via the ASF mirrors. It's vital that all released source files have the appropriate header. For me that's not enough reason to cancel the vote. thanks, Robert Op Thu, 27 Jun 2013 12:26:03 +0200 schreef sebb seb...@gmail.com: On 25 June 2013 21:23, Robert Scholte rfscho...@apache.org wrote: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [X] -1 There are lots of files in the source archive that don't have AL headers: enforcer-1.3/DEPENDENCIES enforcer-1.3/enforcer-api/src/custom-rule-sample/pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/src/main/java/org/apache/maven/enforcer/rule/MyCustomRule.java enforcer-1.3/enforcer-api/src/custom-rule-sample/src/usage-pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/usage-pom.xml enforcer-1.3/enforcer-api/src/main/assembly/custom-rule-sample.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginPropertyVersion/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginVersionProfile/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/b/c/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/b/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentExpression/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentExpression/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePathDirectory/parent/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePathDirectory/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePath/parent/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePath/pom.xml enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer126_maven-plugin-1.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.4.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.5.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.6.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_classic-0.9.9.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_model-1.0-20130423.042904-7222.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_model-1.0-20130423.044324-5638.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_modelbuilder-1.0-SNAPSHOT.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_project-1.0-SNAPSHOT.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_archiver-2.1.1.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_classworlds-1.1-alpha-2.pom
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
On Sunday, 30 June 2013, sebb wrote: On 29 June 2013 11:47, Robert Scholte rfscho...@apache.org javascript:; wrote: Hi Sebb, none of these files will end up in Maven Central, they are all used for tests. However, they do end up in the source release which is published via the ASF mirrors. It's vital that all released source files have the appropriate header. Not true, for example where a source file is in a format that does not support comments or where the source file is data for a test case and the presence of a comment breaks the test case... Thus there is no requirement for *all* files to contain the license, and hence the LICENSE file is required to be sufficient as the effective license for all files unless the file indicates otherwise... Now it is best practice that we put the license on as many files as possible, but the straw-man example proves that the license is not *required* on all files, just *recommended* on as many as possible. Where some of the code comes under different licenses in the one code base, then is is required that we provide some indication as to which files are covered by which licenses. That is easiest to achieve by having license headers, but it is not required to be such. -Stephen For me that's not enough reason to cancel the vote. thanks, Robert Op Thu, 27 Jun 2013 12:26:03 +0200 schreef sebb seb...@gmail.com: On 25 June 2013 21:23, Robert Scholte rfscho...@apache.org wrote: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [X] -1 There are lots of files in the source archive that don't have AL headers: enforcer-1.3/DEPENDENCIES enforcer-1.3/enforcer-api/src/custom-rule-sample/pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/src/main/java/org/apache/maven/enforcer/rule/MyCustomRule.java enforcer-1.3/enforcer-api/src/custom-rule-sample/src/usage-pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/usage-pom.xml enforcer-1.3/enforcer-api/src/main/assembly/custom-rule-sample.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginPropertyVersion/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginVersionProfile/pom.xml enforcer-1.3/enforcer-rules/src/test/resourc -- Sent from my phone
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
On 30 June 2013 21:04, Stephen Connolly stephen.alan.conno...@gmail.com wrote: On Sunday, 30 June 2013, sebb wrote: On 29 June 2013 11:47, Robert Scholte rfscho...@apache.org javascript:; wrote: Hi Sebb, none of these files will end up in Maven Central, they are all used for tests. However, they do end up in the source release which is published via the ASF mirrors. It's vital that all released source files have the appropriate header. Not true, for example where a source file is in a format that does not support comments or where the source file is data for a test case and the presence of a comment breaks the test case... That's why I wrote appropriate. Thus there is no requirement for *all* files to contain the license, and hence the LICENSE file is required to be sufficient as the effective license for all files unless the file indicates otherwise... Now it is best practice that we put the license on as many files as possible, but the straw-man example proves that the license is not *required* on all files, just *recommended* on as many as possible. Which has not happened here. Where some of the code comes under different licenses in the one code base, then is is required that we provide some indication as to which files are covered by which licenses. That is easiest to achieve by having license headers, but it is not required to be such. Again appropriate applies here. -Stephen For me that's not enough reason to cancel the vote. thanks, Robert Op Thu, 27 Jun 2013 12:26:03 +0200 schreef sebb seb...@gmail.com: On 25 June 2013 21:23, Robert Scholte rfscho...@apache.org wrote: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [X] -1 There are lots of files in the source archive that don't have AL headers: enforcer-1.3/DEPENDENCIES enforcer-1.3/enforcer-api/src/custom-rule-sample/pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/src/main/java/org/apache/maven/enforcer/rule/MyCustomRule.java enforcer-1.3/enforcer-api/src/custom-rule-sample/src/usage-pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/usage-pom.xml enforcer-1.3/enforcer-api/src/main/assembly/custom-rule-sample.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginPropertyVersion/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginVersionProfile/pom.xml enforcer-1.3/enforcer-rules/src/test/resourc -- Sent from my phone - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
Hi Sebb, none of these files will end up in Maven Central, they are all used for tests. For me that's not enough reason to cancel the vote. thanks, Robert Op Thu, 27 Jun 2013 12:26:03 +0200 schreef sebb seb...@gmail.com: On 25 June 2013 21:23, Robert Scholte rfscho...@apache.org wrote: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [X] -1 There are lots of files in the source archive that don't have AL headers: enforcer-1.3/DEPENDENCIES enforcer-1.3/enforcer-api/src/custom-rule-sample/pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/src/main/java/org/apache/maven/enforcer/rule/MyCustomRule.java enforcer-1.3/enforcer-api/src/custom-rule-sample/src/usage-pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/usage-pom.xml enforcer-1.3/enforcer-api/src/main/assembly/custom-rule-sample.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginPropertyVersion/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginVersionProfile/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/b/c/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/b/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentExpression/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentExpression/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePathDirectory/parent/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePathDirectory/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePath/parent/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePath/pom.xml enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer126_maven-plugin-1.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.4.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.5.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.6.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_classic-0.9.9.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_model-1.0-20130423.042904-7222.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_model-1.0-20130423.044324-5638.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_modelbuilder-1.0-SNAPSHOT.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_project-1.0-SNAPSHOT.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_archiver-2.1.1.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_classworlds-1.1-alpha-2.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_container-default-1.0-alpha-9-stable-1.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_io-2.0.3.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_utils-1.0.4.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_utils-3.0.pom
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
+1 Regards, Hervé Le mardi 25 juin 2013 22:23:13 Robert Scholte a écrit : Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=190 11 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530sta tus=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/mave n/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
+1 Op Tue, 25 Jun 2013 22:23:13 +0200 schreef Robert Scholte rfscho...@apache.org: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
+1 2013/6/26 Robert Scholte rfscho...@apache.org: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Olivier Lamy Ecetera: http://ecetera.com.au http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
On 25 June 2013 21:23, Robert Scholte rfscho...@apache.org wrote: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [X] -1 There are lots of files in the source archive that don't have AL headers: enforcer-1.3/DEPENDENCIES enforcer-1.3/enforcer-api/src/custom-rule-sample/pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/src/main/java/org/apache/maven/enforcer/rule/MyCustomRule.java enforcer-1.3/enforcer-api/src/custom-rule-sample/src/usage-pom.xml enforcer-1.3/enforcer-api/src/custom-rule-sample/usage-pom.xml enforcer-1.3/enforcer-api/src/main/assembly/custom-rule-sample.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginPropertyVersion/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginVersionProfile/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/b/c/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/b/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/getPomRecursively/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentExpression/child/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentExpression/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePathDirectory/parent/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePathDirectory/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePath/parent/pom.xml enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/parentRelativePath/pom.xml enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer126_maven-plugin-1.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.4.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.5.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_api-1.6.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer128_classic-0.9.9.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_model-1.0-20130423.042904-7222.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_model-1.0-20130423.044324-5638.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_modelbuilder-1.0-SNAPSHOT.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer134_project-1.0-SNAPSHOT.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_archiver-2.1.1.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_classworlds-1.1-alpha-2.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_container-default-1.0-alpha-9-stable-1.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_io-2.0.3.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_utils-1.0.4.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer138_utils-3.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer146_b-1.0.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer146_x-1.1.pom enforcer-1.3/maven-enforcer-plugin/src/it/mrm/repository/menforcer146_x-2.1.pom
Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)
On Tue, 25 Jun 2013 22:23:13 +0200 Robert Scholte rfscho...@apache.org wrote: +1, tony. Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-070/ https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Tony Chemit tél: +33 (0) 2 40 50 29 28 email: che...@codelutin.com http://www.codelutin.com - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Enforcer version 1.3
+1 on that one: going onto a major version change like 2.x could be better
here imo.
I'm totally OK with releasing things that are more correct (not working
correctly about artifact resolution here).
But since this is likely to break a lot of internal rules (for example,
it's gonna break 50% of the extra-enforcer-rules rules), it should be
conveyed very clearly that it's an important upgrade.
Cheers
2013/6/23 Mirko Friedenhagen mfriedenha...@gmail.com
Hello,
I did the tests wrongly for extra-enforcer-rules, the new version of
enforcer is backwards incompatible:
org.apache.maven.plugins.enforcer.AbstractStandardEnforcerRule had a
public message field in 1.2, this is now (1.3) private and uses
getMessage and setMessage methods.
This would mean a major update IMO.
I can imagine this would mean a lot of private rules to break, so I
withdraw my +1 and make it
-1 (non-binding).
Regards
Mirko
Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/
https://bitbucket.org/mfriedenhagen/
On Sun, Jun 23, 2013 at 3:33 PM, Baptiste MATHUS bmat...@batmat.net
wrote:
Hi,
No problem, I'll see how I can fix that.
FWIW, I've just run the ITs of mojo's extra-enforcer-rules project with
m-enforcer-p:1.3.
This gives:
[ERROR] The following builds failed:
[ERROR] * enforce-bytecode-version-jdkVersionOption\pom.xml
[ERROR] * enforce-bytecode-version-with-banned-deps\pom.xml
[ERROR] * enforce-bytecode-version-wo-banned-deps\pom.xml
[ERROR] * mojo-1682\pom.xml
[ERROR] * mojo-1731\pom.xml
[ERROR] * mojo-1744\pom.xml
[ERROR] * mojo-1769\pom.xml
[ERROR] * mojo-1853\pom.xml
[ERROR] * mojo-1929\pom.xml
[ERROR] * require-property-diverges\pom.xml
[ERROR] * smokes\pom.xml
So, to sum up, the impacted rules are:
- enforceBytecodeVersion
- banDuplicateClasses
- requirePropertyDiverges
Cheers
2013/6/23 Robert Scholte rfscho...@apache.org
Hi Baptiste,
you're hitting the result of the changes due to MENFORCER-42[1]
Up until 1.2 the dependencies were resolved instead of calculated.
So if you run 'mvn validate' you can't use the results of the reactor,
since those files aren't available yet. So the build will fail or it
will
use artifacts from an older run. IMO both are wrong.
The EnforceBytecodeVersion is an example of a rule which needs to be
bound
after compilation.
My suggestion is to rewrite the rule and let it depend on a
DependencyTree
instead of a DependencyGraph[2]
I noticed that the extra-enforcer-rules depend on the (standard)
enforcer-rules. I think that could be improved by extracting abstract
classes to a separate module. That way we have a better separation on
concerns. That would be something for a next release.
I'm not going to cancel the vote for this reason.
Robert
ps. Thanks for testing!
[1] http://jira.codehaus.org/**browse/MENFORCER-42
http://jira.codehaus.org/browse/MENFORCER-42
[2] http://maven.apache.org/**shared/maven-dependency-tree/
http://maven.apache.org/shared/maven-dependency-tree/
Op Sun, 23 Jun 2013 11:45:30 +0200 schreef Baptiste MATHUS
bmat...@batmat.net:
-0.9 (non binding).
I just tested on a local project, codehaus mojo EnforceBytecodeVersion
fails with an NPE with m-enforcer-p 1.3 but correctly thows an
EnforcerRuleException with 1.2.
That is, as I am the one who wrote that rule, that's perfectly possible
I'm
doing something stooopid in the code that gets revealed with this new
enforcer-p version.
I've pasted the stack trace here: http://pastebin.com/3sHY0Fvf
After a quick dive in the code, from the stack trace, seems like the
following code:
*private boolean isBadArtifact( Artifact a )** throws
EnforcerRuleException*
*{*
*File f = a.getFile();*
*if ( !f.getName().endsWith( .jar ) )*
*{*
fails because the returned File is null.
Is this something that should always work. If you feel this is correct
code, then just let me know and I'll file the corresponding JIRA.
Cheers
2013/6/23 Olivier Lamy ol...@apache.org
+1
2013/6/22 Robert Scholte rfscho...@apache.org:
Hi,
We solved 15 issues:
http://jira.codehaus.org/**secure/ReleaseNote.jspa?**
projectId=11530version=19011
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011
There are still a couple of issues left in JIRA:
http://jira.codehaus.org/**secure/IssueNavigator.jspa?**
reset=truepid=11530status=1
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1
Staging repo:
https://repository.apache.org/**content/repositories/maven-**056/
https://repository.apache.org/content/repositories/maven-056/
https://repository.apache.org/**content/repositories/maven-**
056/org/apache/maven/enforcer/**enforcer/1.3/enforcer-1.3-**
source-release.zip
Re: [VOTE] Release Maven Enforcer version 1.3
+1 2013/6/22 Robert Scholte rfscho...@apache.org: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-056/ https://repository.apache.org/content/repositories/maven-056/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Olivier Lamy Ecetera: http://ecetera.com.au http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Enforcer version 1.3
-0.9 (non binding).
I just tested on a local project, codehaus mojo EnforceBytecodeVersion
fails with an NPE with m-enforcer-p 1.3 but correctly thows an
EnforcerRuleException with 1.2.
That is, as I am the one who wrote that rule, that's perfectly possible I'm
doing something stooopid in the code that gets revealed with this new
enforcer-p version.
I've pasted the stack trace here: http://pastebin.com/3sHY0Fvf
After a quick dive in the code, from the stack trace, seems like the
following code:
*private boolean isBadArtifact( Artifact a )** throws
EnforcerRuleException*
*{*
*File f = a.getFile();*
*if ( !f.getName().endsWith( .jar ) )*
*{*
fails because the returned File is null.
Is this something that should always work. If you feel this is correct
code, then just let me know and I'll file the corresponding JIRA.
Cheers
2013/6/23 Olivier Lamy ol...@apache.org
+1
2013/6/22 Robert Scholte rfscho...@apache.org:
Hi,
We solved 15 issues:
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011
There are still a couple of issues left in JIRA:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1
Staging repo:
https://repository.apache.org/content/repositories/maven-056/
https://repository.apache.org/content/repositories/maven-056/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip
Staging site:
http://maven.apache.org/enforcer-archives/enforcer-LATEST/
Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--
Baptiste Batmat MATHUS - http://batmat.net
Sauvez un arbre,
Mangez un castor !
Re: [VOTE] Release Maven Enforcer version 1.3
Hi Baptiste,
you're hitting the result of the changes due to MENFORCER-42[1]
Up until 1.2 the dependencies were resolved instead of calculated.
So if you run 'mvn validate' you can't use the results of the reactor,
since those files aren't available yet. So the build will fail or it will
use artifacts from an older run. IMO both are wrong.
The EnforceBytecodeVersion is an example of a rule which needs to be bound
after compilation.
My suggestion is to rewrite the rule and let it depend on a DependencyTree
instead of a DependencyGraph[2]
I noticed that the extra-enforcer-rules depend on the (standard)
enforcer-rules. I think that could be improved by extracting abstract
classes to a separate module. That way we have a better separation on
concerns. That would be something for a next release.
I'm not going to cancel the vote for this reason.
Robert
ps. Thanks for testing!
[1] http://jira.codehaus.org/browse/MENFORCER-42
[2] http://maven.apache.org/shared/maven-dependency-tree/
Op Sun, 23 Jun 2013 11:45:30 +0200 schreef Baptiste MATHUS
bmat...@batmat.net:
-0.9 (non binding).
I just tested on a local project, codehaus mojo EnforceBytecodeVersion
fails with an NPE with m-enforcer-p 1.3 but correctly thows an
EnforcerRuleException with 1.2.
That is, as I am the one who wrote that rule, that's perfectly possible
I'm
doing something stooopid in the code that gets revealed with this new
enforcer-p version.
I've pasted the stack trace here: http://pastebin.com/3sHY0Fvf
After a quick dive in the code, from the stack trace, seems like the
following code:
*private boolean isBadArtifact( Artifact a )** throws
EnforcerRuleException*
*{*
*File f = a.getFile();*
*if ( !f.getName().endsWith( .jar ) )*
*{*
fails because the returned File is null.
Is this something that should always work. If you feel this is correct
code, then just let me know and I'll file the corresponding JIRA.
Cheers
2013/6/23 Olivier Lamy ol...@apache.org
+1
2013/6/22 Robert Scholte rfscho...@apache.org:
Hi,
We solved 15 issues:
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011
There are still a couple of issues left in JIRA:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1
Staging repo:
https://repository.apache.org/content/repositories/maven-056/
https://repository.apache.org/content/repositories/maven-056/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip
Staging site:
http://maven.apache.org/enforcer-archives/enforcer-LATEST/
Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Enforcer version 1.3
Hi,
No problem, I'll see how I can fix that.
FWIW, I've just run the ITs of mojo's extra-enforcer-rules project with
m-enforcer-p:1.3.
This gives:
[ERROR] The following builds failed:
[ERROR] * enforce-bytecode-version-jdkVersionOption\pom.xml
[ERROR] * enforce-bytecode-version-with-banned-deps\pom.xml
[ERROR] * enforce-bytecode-version-wo-banned-deps\pom.xml
[ERROR] * mojo-1682\pom.xml
[ERROR] * mojo-1731\pom.xml
[ERROR] * mojo-1744\pom.xml
[ERROR] * mojo-1769\pom.xml
[ERROR] * mojo-1853\pom.xml
[ERROR] * mojo-1929\pom.xml
[ERROR] * require-property-diverges\pom.xml
[ERROR] * smokes\pom.xml
So, to sum up, the impacted rules are:
- enforceBytecodeVersion
- banDuplicateClasses
- requirePropertyDiverges
Cheers
2013/6/23 Robert Scholte rfscho...@apache.org
Hi Baptiste,
you're hitting the result of the changes due to MENFORCER-42[1]
Up until 1.2 the dependencies were resolved instead of calculated.
So if you run 'mvn validate' you can't use the results of the reactor,
since those files aren't available yet. So the build will fail or it will
use artifacts from an older run. IMO both are wrong.
The EnforceBytecodeVersion is an example of a rule which needs to be bound
after compilation.
My suggestion is to rewrite the rule and let it depend on a DependencyTree
instead of a DependencyGraph[2]
I noticed that the extra-enforcer-rules depend on the (standard)
enforcer-rules. I think that could be improved by extracting abstract
classes to a separate module. That way we have a better separation on
concerns. That would be something for a next release.
I'm not going to cancel the vote for this reason.
Robert
ps. Thanks for testing!
[1]
http://jira.codehaus.org/**browse/MENFORCER-42http://jira.codehaus.org/browse/MENFORCER-42
[2]
http://maven.apache.org/**shared/maven-dependency-tree/http://maven.apache.org/shared/maven-dependency-tree/
Op Sun, 23 Jun 2013 11:45:30 +0200 schreef Baptiste MATHUS
bmat...@batmat.net:
-0.9 (non binding).
I just tested on a local project, codehaus mojo EnforceBytecodeVersion
fails with an NPE with m-enforcer-p 1.3 but correctly thows an
EnforcerRuleException with 1.2.
That is, as I am the one who wrote that rule, that's perfectly possible
I'm
doing something stooopid in the code that gets revealed with this new
enforcer-p version.
I've pasted the stack trace here: http://pastebin.com/3sHY0Fvf
After a quick dive in the code, from the stack trace, seems like the
following code:
*private boolean isBadArtifact( Artifact a )** throws
EnforcerRuleException*
*{*
*File f = a.getFile();*
*if ( !f.getName().endsWith( .jar ) )*
*{*
fails because the returned File is null.
Is this something that should always work. If you feel this is correct
code, then just let me know and I'll file the corresponding JIRA.
Cheers
2013/6/23 Olivier Lamy ol...@apache.org
+1
2013/6/22 Robert Scholte rfscho...@apache.org:
Hi,
We solved 15 issues:
http://jira.codehaus.org/**secure/ReleaseNote.jspa?**
projectId=11530version=19011http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011
There are still a couple of issues left in JIRA:
http://jira.codehaus.org/**secure/IssueNavigator.jspa?**
reset=truepid=11530status=1http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1
Staging repo:
https://repository.apache.org/**content/repositories/maven-**056/https://repository.apache.org/content/repositories/maven-056/
https://repository.apache.org/**content/repositories/maven-**
056/org/apache/maven/enforcer/**enforcer/1.3/enforcer-1.3-**
source-release.ziphttps://repository.apache.org/content/repositories/maven-056/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip
Staging site:
http://maven.apache.org/**enforcer-archives/enforcer-**LATEST/http://maven.apache.org/enforcer-archives/enforcer-LATEST/
Guide to testing staged releases:
http://maven.apache.org/**guides/development/guide-**
testing-releases.htmlhttp://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
--**--**
-
To unsubscribe, e-mail:
dev-unsubscribe@maven.apache.**orgdev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy
--**--**
-
To unsubscribe, e-mail:
dev-unsubscribe@maven.apache.**orgdev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--**--**-
To unsubscribe, e-mail:
dev-unsubscribe@maven.apache.**orgdev-unsubscr...@maven.apache.org
For additional commands,
Re: [VOTE] Release Maven Enforcer version 1.3
Hello,
I did the tests wrongly for extra-enforcer-rules, the new version of
enforcer is backwards incompatible:
org.apache.maven.plugins.enforcer.AbstractStandardEnforcerRule had a
public message field in 1.2, this is now (1.3) private and uses
getMessage and setMessage methods.
This would mean a major update IMO.
I can imagine this would mean a lot of private rules to break, so I
withdraw my +1 and make it
-1 (non-binding).
Regards
Mirko
Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/
https://bitbucket.org/mfriedenhagen/
On Sun, Jun 23, 2013 at 3:33 PM, Baptiste MATHUS bmat...@batmat.net wrote:
Hi,
No problem, I'll see how I can fix that.
FWIW, I've just run the ITs of mojo's extra-enforcer-rules project with
m-enforcer-p:1.3.
This gives:
[ERROR] The following builds failed:
[ERROR] * enforce-bytecode-version-jdkVersionOption\pom.xml
[ERROR] * enforce-bytecode-version-with-banned-deps\pom.xml
[ERROR] * enforce-bytecode-version-wo-banned-deps\pom.xml
[ERROR] * mojo-1682\pom.xml
[ERROR] * mojo-1731\pom.xml
[ERROR] * mojo-1744\pom.xml
[ERROR] * mojo-1769\pom.xml
[ERROR] * mojo-1853\pom.xml
[ERROR] * mojo-1929\pom.xml
[ERROR] * require-property-diverges\pom.xml
[ERROR] * smokes\pom.xml
So, to sum up, the impacted rules are:
- enforceBytecodeVersion
- banDuplicateClasses
- requirePropertyDiverges
Cheers
2013/6/23 Robert Scholte rfscho...@apache.org
Hi Baptiste,
you're hitting the result of the changes due to MENFORCER-42[1]
Up until 1.2 the dependencies were resolved instead of calculated.
So if you run 'mvn validate' you can't use the results of the reactor,
since those files aren't available yet. So the build will fail or it will
use artifacts from an older run. IMO both are wrong.
The EnforceBytecodeVersion is an example of a rule which needs to be bound
after compilation.
My suggestion is to rewrite the rule and let it depend on a DependencyTree
instead of a DependencyGraph[2]
I noticed that the extra-enforcer-rules depend on the (standard)
enforcer-rules. I think that could be improved by extracting abstract
classes to a separate module. That way we have a better separation on
concerns. That would be something for a next release.
I'm not going to cancel the vote for this reason.
Robert
ps. Thanks for testing!
[1]
http://jira.codehaus.org/**browse/MENFORCER-42http://jira.codehaus.org/browse/MENFORCER-42
[2]
http://maven.apache.org/**shared/maven-dependency-tree/http://maven.apache.org/shared/maven-dependency-tree/
Op Sun, 23 Jun 2013 11:45:30 +0200 schreef Baptiste MATHUS
bmat...@batmat.net:
-0.9 (non binding).
I just tested on a local project, codehaus mojo EnforceBytecodeVersion
fails with an NPE with m-enforcer-p 1.3 but correctly thows an
EnforcerRuleException with 1.2.
That is, as I am the one who wrote that rule, that's perfectly possible
I'm
doing something stooopid in the code that gets revealed with this new
enforcer-p version.
I've pasted the stack trace here: http://pastebin.com/3sHY0Fvf
After a quick dive in the code, from the stack trace, seems like the
following code:
*private boolean isBadArtifact( Artifact a )** throws
EnforcerRuleException*
*{*
*File f = a.getFile();*
*if ( !f.getName().endsWith( .jar ) )*
*{*
fails because the returned File is null.
Is this something that should always work. If you feel this is correct
code, then just let me know and I'll file the corresponding JIRA.
Cheers
2013/6/23 Olivier Lamy ol...@apache.org
+1
2013/6/22 Robert Scholte rfscho...@apache.org:
Hi,
We solved 15 issues:
http://jira.codehaus.org/**secure/ReleaseNote.jspa?**
projectId=11530version=19011http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011
There are still a couple of issues left in JIRA:
http://jira.codehaus.org/**secure/IssueNavigator.jspa?**
reset=truepid=11530status=1http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1
Staging repo:
https://repository.apache.org/**content/repositories/maven-**056/https://repository.apache.org/content/repositories/maven-056/
https://repository.apache.org/**content/repositories/maven-**
056/org/apache/maven/enforcer/**enforcer/1.3/enforcer-1.3-**
source-release.ziphttps://repository.apache.org/content/repositories/maven-056/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip
Staging site:
http://maven.apache.org/**enforcer-archives/enforcer-**LATEST/http://maven.apache.org/enforcer-archives/enforcer-LATEST/
Guide to testing staged releases:
http://maven.apache.org/**guides/development/guide-**
testing-releases.htmlhttp://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
--**--**
-
To unsubscribe,
Re: [VOTE] Release Maven Enforcer version 1.3
+1 (non-binding) tested with two homegrown plugins, the extra-enforcer-rules and one small multi-module project. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ https://bitbucket.org/mfriedenhagen/ On Sat, Jun 22, 2013 at 2:26 PM, Robert Scholte rfscho...@apache.org wrote: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1 Staging repo: https://repository.apache.org/content/repositories/maven-056/ https://repository.apache.org/content/repositories/maven-056/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip Staging site: http://maven.apache.org/enforcer-archives/enforcer-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
