Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/07/16 um 01:23 schrieb Christian Schulte:
> And then there is this MNG-NOT-YET-FILED-BY-ME





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 23:49 schrieb Christian Schulte:
> 
> I'll take a closer look at the project tomorrow. Could be it's the
> Aether bug I mentioned in that other mail which got reverted and makes
> the project build again. That would mean the project really should not
> build and error out but does not, because there is a bug in Aether.
> 
> Regards,
> 

That's the situation making me think: Ship all of this together in one
release. Cause, there also is
 waiting to be shipped
and that also has a noticable impact.
()
And then there is  also
having a noticable impact
().
And then there is this MNG-NOT-YET-FILED-BY-ME about splitting
"application" and "test" classpaths completely superceding MNG-5988. We
cannot ship things like these one after the other.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 23:40 schrieb Stuart McCulloch:
> On Wednesday, 6 July 2016 at 22:17, Christian Schulte wrote:
>> Am 07/06/16 um 23:08 schrieb Stuart McCulloch:
>>> On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
 Am 07/06/16 um 22:21 schrieb Ralph Goers:
> This is an interesting situation. The classes that use Jackson are all 
> considered optional in Log4j, so having optional set to true is indeed 
> what is desired. However, we require those dependencies to compile and to 
> run the unit tests. With scope set to test I would expect that the 
> non-test classes that need them would fail to compile. So it sounds like 
> we have to make sure all transitive dependencies needed for testing are 
> also specified with optional set to true?
>  
> Ralph
>  
  
  
 Not sure I understand the situation correctly. If the scope is set to
 test, it's not available in any other scope than test. Could you please
 point me at the POM in question? So I can 'mvn compile' that project
 successfully and you would expect it to not compile due to some optional
 transitive dependency?
  
  
  
>>>  
>>>  
>>> Hi Christian,
>>>  
>>> Gary posted a link to the build in his original post.
>>>  
>>> Basically at the moment it has a dependencyManagement section in the 
>>> top-level pom that declares various jackson dependencies as optional, 
>>> including jackson-module-jaxb-annotations. The log4j-core sub-project 
>>> declares a direct dependency to jackson-dataformat-xml with compile scope, 
>>> marked as optional (also note that jackson-module-jaxb-annotations is a 
>>> transitive dependency of jackson-dataformat-xml).
>>>  
>>> With the fix for MNG-5227 the transitive dependency to 
>>> jackson-module-jaxb-annotations is managed as optional and is removed from 
>>> the compile and test classpath. Because the code doesn’t directly depend on 
>>> jackson-module-jaxb-annotations then it compiles ok. However, the tests 
>>> fail because both jackson-dataformat-xml and 
>>> jackson-module-jaxb-annotations are needed at test time.
>>>  
>>> Without the fix for MNG-5227 the optional flags in the dependencyManagement 
>>> section are ignored, and jackson-module-jaxb-annotations is included on the 
>>> compile and test classpath (because the optional jackson-dataformat-xml 
>>> dependency is selected and jackson-module-jaxb-annotations is now seen as a 
>>> non-optional transitive dependency of jackson-dataformat-xml).
>> Ok. That's MNG-5935.
>>  
>>  
> 
> But also related to MNG-5227 right?  Since the build fails with the old maven 
> snapshot that had the fix for MNG-5227 (and the fix for MNG-5935) but passes 
> with the more recent snapshot where MNG-5227 was reverted (but still contains 
> the fix for MNG-5935)

I'll take a closer look at the project tomorrow. Could be it's the
Aether bug I mentioned in that other mail which got reverted and makes
the project build again. That would mean the project really should not
build and error out but does not, because there is a bug in Aether.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

On Wednesday, 6 July 2016 at 22:17, Christian Schulte wrote:
> Am 07/06/16 um 23:08 schrieb Stuart McCulloch:
> > On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
> > > Am 07/06/16 um 22:21 schrieb Ralph Goers:
> > > > This is an interesting situation. The classes that use Jackson are all 
> > > > considered optional in Log4j, so having optional set to true is indeed 
> > > > what is desired. However, we require those dependencies to compile and 
> > > > to run the unit tests. With scope set to test I would expect that the 
> > > > non-test classes that need them would fail to compile. So it sounds 
> > > > like we have to make sure all transitive dependencies needed for 
> > > > testing are also specified with optional set to true?
> > > >  
> > > > Ralph
> > > >  
> > >  
> > >  
> > > Not sure I understand the situation correctly. If the scope is set to
> > > test, it's not available in any other scope than test. Could you please
> > > point me at the POM in question? So I can 'mvn compile' that project
> > > successfully and you would expect it to not compile due to some optional
> > > transitive dependency?
> > >  
> > >  
> > >  
> >  
> >  
> > Hi Christian,
> >  
> > Gary posted a link to the build in his original post.
> >  
> > Basically at the moment it has a dependencyManagement section in the 
> > top-level pom that declares various jackson dependencies as optional, 
> > including jackson-module-jaxb-annotations. The log4j-core sub-project 
> > declares a direct dependency to jackson-dataformat-xml with compile scope, 
> > marked as optional (also note that jackson-module-jaxb-annotations is a 
> > transitive dependency of jackson-dataformat-xml).
> >  
> > With the fix for MNG-5227 the transitive dependency to 
> > jackson-module-jaxb-annotations is managed as optional and is removed from 
> > the compile and test classpath. Because the code doesn’t directly depend on 
> > jackson-module-jaxb-annotations then it compiles ok. However, the tests 
> > fail because both jackson-dataformat-xml and 
> > jackson-module-jaxb-annotations are needed at test time.
> >  
> > Without the fix for MNG-5227 the optional flags in the dependencyManagement 
> > section are ignored, and jackson-module-jaxb-annotations is included on the 
> > compile and test classpath (because the optional jackson-dataformat-xml 
> > dependency is selected and jackson-module-jaxb-annotations is now seen as a 
> > non-optional transitive dependency of jackson-dataformat-xml).
> Ok. That's MNG-5935.
>  
>  

But also related to MNG-5227 right?  Since the build fails with the old maven 
snapshot that had the fix for MNG-5227 (and the fix for MNG-5935) but passes 
with the more recent snapshot where MNG-5227 was reverted (but still contains 
the fix for MNG-5935)
>  
>  
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org 
> (mailto:dev-unsubscr...@maven.apache.org)
> For additional commands, e-mail: dev-h...@maven.apache.org 
> (mailto:dev-h...@maven.apache.org)
>  
>  

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 23:08 schrieb Stuart McCulloch:
> On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
>> Am 07/06/16 um 22:21 schrieb Ralph Goers:
>>> This is an interesting situation. The classes that use Jackson are all 
>>> considered optional in Log4j, so having optional set to true is indeed what 
>>> is desired. However, we require those dependencies to compile and to run 
>>> the unit tests. With scope set to test I would expect that the non-test 
>>> classes that need them would fail to compile. So it sounds like we have to 
>>> make sure all transitive dependencies needed for testing are also specified 
>>> with optional set to true?
>>>  
>>> Ralph
>>  
>> Not sure I understand the situation correctly. If the scope is set to
>> test, it's not available in any other scope than test. Could you please
>> point me at the POM in question? So I can 'mvn compile' that project
>> successfully and you would expect it to not compile due to some optional
>> transitive dependency?
>>  
>>  
> 
> Hi Christian,
> 
> Gary posted a link to the build in his original post.
> 
> Basically at the moment it has a dependencyManagement section in the 
> top-level pom that declares various jackson dependencies as optional, 
> including jackson-module-jaxb-annotations. The log4j-core sub-project 
> declares a direct dependency to jackson-dataformat-xml with compile scope, 
> marked as optional (also note that jackson-module-jaxb-annotations is a 
> transitive dependency of jackson-dataformat-xml).
> 
> With the fix for MNG-5227 the transitive dependency to 
> jackson-module-jaxb-annotations is managed as optional and is removed from 
> the compile and test classpath. Because the code doesn’t directly depend on 
> jackson-module-jaxb-annotations then it compiles ok. However, the tests fail 
> because both jackson-dataformat-xml and jackson-module-jaxb-annotations are 
> needed at test time.
> 
> Without the fix for MNG-5227 the optional flags in the dependencyManagement 
> section are ignored, and jackson-module-jaxb-annotations is included on the 
> compile and test classpath (because the optional jackson-dataformat-xml 
> dependency is selected and jackson-module-jaxb-annotations is now seen as a 
> non-optional transitive dependency of jackson-dataformat-xml).
> 

Ok. That's MNG-5935.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
> Am 07/06/16 um 22:21 schrieb Ralph Goers:
> > This is an interesting situation. The classes that use Jackson are all 
> > considered optional in Log4j, so having optional set to true is indeed what 
> > is desired. However, we require those dependencies to compile and to run 
> > the unit tests. With scope set to test I would expect that the non-test 
> > classes that need them would fail to compile. So it sounds like we have to 
> > make sure all transitive dependencies needed for testing are also specified 
> > with optional set to true?
> >  
> > Ralph
>  
> Not sure I understand the situation correctly. If the scope is set to
> test, it's not available in any other scope than test. Could you please
> point me at the POM in question? So I can 'mvn compile' that project
> successfully and you would expect it to not compile due to some optional
> transitive dependency?
>  
>  

Hi Christian,

Gary posted a link to the build in his original post.

Basically at the moment it has a dependencyManagement section in the top-level 
pom that declares various jackson dependencies as optional, including 
jackson-module-jaxb-annotations. The log4j-core sub-project declares a direct 
dependency to jackson-dataformat-xml with compile scope, marked as optional 
(also note that jackson-module-jaxb-annotations is a transitive dependency of 
jackson-dataformat-xml).

With the fix for MNG-5227 the transitive dependency to 
jackson-module-jaxb-annotations is managed as optional and is removed from the 
compile and test classpath. Because the code doesn’t directly depend on 
jackson-module-jaxb-annotations then it compiles ok. However, the tests fail 
because both jackson-dataformat-xml and jackson-module-jaxb-annotations are 
needed at test time.

Without the fix for MNG-5227 the optional flags in the dependencyManagement 
section are ignored, and jackson-module-jaxb-annotations is included on the 
compile and test classpath (because the optional jackson-dataformat-xml 
dependency is selected and jackson-module-jaxb-annotations is now seen as a 
non-optional transitive dependency of jackson-dataformat-xml).

HTH
>  
> Regards,
> --  
> Christian
>  
>  
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org 
> (mailto:dev-unsubscr...@maven.apache.org)
> For additional commands, e-mail: dev-h...@maven.apache.org 
> (mailto:dev-h...@maven.apache.org)
>  
>  

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Gary Gregory]

On Wed, Jul 6, 2016 at 12:47 PM, Karl Heinz Marbaise 
wrote:

> Hi Gary,
>
> done so.
>
> See announce on dev / user list...


The new version fixes the Log4j build.

Thank you,
Gary


>
>
> Kind regards
> Karl Heinz Marbaise
> On 7/6/16 9:18 PM, Gary Gregory wrote:
>
>> On Wed, Jul 6, 2016 at 11:52 AM, Karl Heinz Marbaise 
>> wrote:
>>
>> Hi Gary,
>>>
>>> On 7/6/16 8:47 PM, Gary Gregory wrote:
>>>
>>> On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch 
 wrote:

 That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)

> before MNG-5227 and other breaking changes were rolled back
>
> I just tried with a maven distribution built from latest master
> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is
> passing
>
>
> Is there a download for that?


>>> Should I create one?
>>>
>>
>>
>> If you want folks like me to test something up to date, yes ;-)
>>
>> Gary
>>
>>
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>>
>>> Gary



 On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>
> A while back, a post made available a 3.4.0 SNAPSHOT build for testing.
>
>>
>> So
>
> I'm using it here and there.
>>
>> To replicate the 3.4.0-S failure (works fine on 3.3.9):
>>
>> Download
>>
>>
>>
> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>
>
>> (this link will be gone in a couple of days)
>>
>> Or checkout the tag with "git clone
>> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then
>>
>> "git
>
> checkout tags/log4j-2.6.2-rc1”
>>
>> Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT),
>> I
>>
>> am
>
> getting:
>>
>> Failed tests:
>> XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
>> [http://logging.apache.org/log4j/2.0/events;>], does not
>>
>> contain:
>
> [> XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
>> line3 incorrect: [], must have two-space indentation
>> XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
>> XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
>> Tests in error:
>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>> com/fasterxml/ja...
>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>> com/fasterxml/ja...
>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>> com/fasterxml/ja...
>> ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
>> NoClassDefFound
>> StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
>> NoClassDefFound
>> XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
>> com/fasterxml/jackson/module/ja...
>> XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
>> com/fasterxml/jackson...
>> XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122
>> ╗
>> NoClassDefFound
>> XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
>> NoClassDefFound
>>
>> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.
>>
> apache.logging.log4j.core.net.server.SslXmlSocketServerTest
>
> Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
>> com/fasterxml/jackson/m...
>> Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
>>
>>
>> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.
>>
> apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
>
> Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>> com/fasterxml/jackson/m...
>> Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
>>
>>
>> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.
>>
> apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
>
> Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>> com/fasterxml/jackson/m...
>> Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
>>
>> Everything works fine with Maven 3.3.9.
>>
>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>> 2015-11-10T08:41:47-08:00)
>> Maven home: E:\Java\apache-maven-3.3.9
>> Java version: 1.8.0_91, vendor: Oracle Corporation
>> Java home: C:\Program Files\Java\jdk1.8.0_91\jre
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>>
>> Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
>> 2016-06-11T12:17:57-07:00)
>> Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
>> Java version: 

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Mark Derricutt]

On Thu, Jul 7, 2016 at 8:21 AM, Ralph Goers 
wrote:

> With scope set to test I would expect that the non-test classes that need
> them would fail to compile.


Sadly this falls into one of my biggest pet-peeves with maven. IMHO neither
compile or test scope should ever be transitive. Sadly, such a change would
break 99% of central - the only work around to that IMHO would be a
different scope, say "build" that literally meant, this dep is solely for
building THIS project ( ideally, also a scope for annotation processors,
rather than messing with the compiler plugin ).

-- 
"Great artists are extremely selfish and arrogant things" — Steven Wilson,
Porcupine Tree

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 22:21 schrieb Ralph Goers:
> This is an interesting situation. The classes that use Jackson are all 
> considered optional in Log4j, so having optional set to true is indeed what 
> is desired. However, we require those dependencies to compile and to run the 
> unit tests.  With scope set to test I would expect that the non-test classes 
> that need them would fail to compile.  So it sounds like we have to make sure 
> all transitive dependencies needed for testing are also specified with 
> optional set to true?
> 
> Ralph

Not sure I understand the situation correctly. If the scope is set to
test, it's not available in any other scope than test. Could you please
point me at the POM in question? So I can 'mvn compile' that project
successfully and you would expect it to not compile due to some optional
transitive dependency?

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Ralph Goers]

This is an interesting situation. The classes that use Jackson are all 
considered optional in Log4j, so having optional set to true is indeed what is 
desired. However, we require those dependencies to compile and to run the unit 
tests.  With scope set to test I would expect that the non-test classes that 
need them would fail to compile.  So it sounds like we have to make sure all 
transitive dependencies needed for testing are also specified with optional set 
to true?

Ralph


> On Jul 6, 2016, at 12:18 PM, Stuart McCulloch  wrote:
> 
> BTW, https://issues.apache.org/jira/browse/MNG-5227 was about making the 
> optional flag of a dependency manageable.
> 
> Previously any optional flags in dependencyManagement sections were ignored, 
> and it looks like the Log4j build relies on that historical behaviour. For 
> example the jackson dependencies are all currently marked as optional in the 
> top-level dependencyManagement. With previous versions of Maven these managed 
> flags were simply ignored and had no effect on the build. With the 
> 644ac9c40ad41bf61e3b099918af33b8eb950621 maven build these optional flags 
> were now being managed across any jackson dependencies in all sub-projects. 
> Since jackson-module-jaxb-annotations was not declared as a direct dependency 
> in log4j-core, but was only a transitive dependency of 
> jackson-dataformat-xml, this ended up being marked as ‘optional’ and removed 
> from the test-classpath.
> 
> Removing the ‘optional’ flags from the dependencyManagement section in the 
> top-level pom.xml cleans up the build and should work with both old and 
> future versions of Maven.  
> 
> On Wednesday, 6 July 2016 at 19:45, Stuart McCulloch wrote:
> 
>> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
>> MNG-5227 and other breaking changes were rolled back
>> 
>> I just tried with a maven distribution built from latest master 
>> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing  
>> 
>> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>> 
>>> A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
>>> I'm using it here and there.
>>> 
>>> To replicate the 3.4.0-S failure (works fine on 3.3.9):
>>> 
>>> Download
>>> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>>> 
>>> (this link will be gone in a couple of days)
>>> 
>>> Or checkout the tag with "git clone
>>> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then "git
>>> checkout tags/log4j-2.6.2-rc1”
>>> 
>>> Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
>>> getting:
>>> 
>>> Failed tests:
>>> XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
>>> [http://logging.apache.org/log4j/2.0/events;>], does not contain:
>>> [>> XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
>>> line3 incorrect: [], must have two-space indentation
>>> XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
>>> XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
>>> Tests in error:
>>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>>> com/fasterxml/ja...
>>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>>> com/fasterxml/ja...
>>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>>> com/fasterxml/ja...
>>> ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
>>> NoClassDefFound
>>> StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
>>> NoClassDefFound
>>> XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
>>> com/fasterxml/jackson/module/ja...
>>> XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
>>> com/fasterxml/jackson...
>>> XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
>>> NoClassDefFound
>>> XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
>>> NoClassDefFound
>>> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
>>> Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
>>> com/fasterxml/jackson/m...
>>> Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
>>> 
>>> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
>>> Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>>> com/fasterxml/jackson/m...
>>> Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
>>> 
>>> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
>>> Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>>> com/fasterxml/jackson/m...
>>> Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
>>> 
>>> Everything works fine with Maven 3.3.9.
>>> 
>>> Apache Maven 3.3.9 

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Karl Heinz Marbaise]

Hi Gary,

done so.

See announce on dev / user list...

Kind regards
Karl Heinz Marbaise
On 7/6/16 9:18 PM, Gary Gregory wrote:

On Wed, Jul 6, 2016 at 11:52 AM, Karl Heinz Marbaise 
wrote:


Hi Gary,

On 7/6/16 8:47 PM, Gary Gregory wrote:


On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch 
wrote:

That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)

before MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing



Is there a download for that?



Should I create one?



If you want folks like me to test something up to date, yes ;-)

Gary




Kind regards
Karl Heinz Marbaise



Gary




On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:

A while back, a post made available a 3.4.0 SNAPSHOT build for testing.



So


I'm using it here and there.

To replicate the 3.4.0-S failure (works fine on 3.3.9):

Download



https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip



(this link will be gone in a couple of days)

Or checkout the tag with "git clone
https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then


"git


checkout tags/log4j-2.6.2-rc1”

Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I


am


getting:

Failed tests:
XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
[http://logging.apache.org/log4j/2.0/events;>], does not


contain:


[], must have two-space indentation
XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
Tests in error:
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
NoClassDefFound
StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
NoClassDefFound
XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
com/fasterxml/jackson/module/ja...
XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
com/fasterxml/jackson...
XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
NoClassDefFound
XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
NoClassDefFound

org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.

apache.logging.log4j.core.net.server.SslXmlSocketServerTest


Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer


org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.

apache.logging.log4j.core.net.server.TcpXmlSocketServerTest


Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer


org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.

apache.logging.log4j.core.net.server.UdpXmlSocketServerTest


Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

Everything works fine with Maven 3.3.9.

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
2016-06-11T12:17:57-07:00)
Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

Thank you
Gary (Apache Logging PMC)

--
E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |


ggreg...@apache.org (mailto:ggreg...@apache.org)


Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

BTW, https://issues.apache.org/jira/browse/MNG-5227 was about making the 
optional flag of a dependency manageable.

Previously any optional flags in dependencyManagement sections were ignored, 
and it looks like the Log4j build relies on that historical behaviour. For 
example the jackson dependencies are all currently marked as optional in the 
top-level dependencyManagement. With previous versions of Maven these managed 
flags were simply ignored and had no effect on the build. With the 
644ac9c40ad41bf61e3b099918af33b8eb950621 maven build these optional flags were 
now being managed across any jackson dependencies in all sub-projects. Since 
jackson-module-jaxb-annotations was not declared as a direct dependency in 
log4j-core, but was only a transitive dependency of jackson-dataformat-xml, 
this ended up being marked as ‘optional’ and removed from the test-classpath.

Removing the ‘optional’ flags from the dependencyManagement section in the 
top-level pom.xml cleans up the build and should work with both old and future 
versions of Maven.  

On Wednesday, 6 July 2016 at 19:45, Stuart McCulloch wrote:

> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
> MNG-5227 and other breaking changes were rolled back
>  
> I just tried with a maven distribution built from latest master 
> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing  
>  
> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>  
> > A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
> > I'm using it here and there.
> >  
> > To replicate the 3.4.0-S failure (works fine on 3.3.9):
> >  
> > Download
> > https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
> >  
> > (this link will be gone in a couple of days)
> >  
> > Or checkout the tag with "git clone
> > https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then "git
> > checkout tags/log4j-2.6.2-rc1”
> >  
> > Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
> > getting:
> >  
> > Failed tests:
> > XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
> > [http://logging.apache.org/log4j/2.0/events;>], does not contain:
> > [ > XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
> > line3 incorrect: [], must have two-space indentation
> > XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
> > XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
> > Tests in error:
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
> > NoClassDefFound
> > StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
> > com/fasterxml/jackson/module/ja...
> > XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
> > com/fasterxml/jackson...
> > XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
> > NoClassDefFound
> > org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
> > Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
> >  
> > org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
> > Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
> >  
> > org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
> > Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
> >  
> > Everything works fine with Maven 3.3.9.
> >  
> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T08:41:47-08:00)
> > Maven home: E:\Java\apache-maven-3.3.9
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> >  
> > Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
> > 2016-06-11T12:17:57-07:00)
> > Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program 

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Gary Gregory]

On Wed, Jul 6, 2016 at 11:52 AM, Karl Heinz Marbaise 
wrote:

> Hi Gary,
>
> On 7/6/16 8:47 PM, Gary Gregory wrote:
>
>> On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch 
>> wrote:
>>
>> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)
>>> before MNG-5227 and other breaking changes were rolled back
>>>
>>> I just tried with a maven distribution built from latest master
>>> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing
>>>
>>>
>> Is there a download for that?
>>
>
> Should I create one?


If you want folks like me to test something up to date, yes ;-)

Gary

>
>
> Kind regards
> Karl Heinz Marbaise
>
>
>> Gary
>>
>>
>>
>>> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>>>
>>> A while back, a post made available a 3.4.0 SNAPSHOT build for testing.

>>> So
>>>
 I'm using it here and there.

 To replicate the 3.4.0-S failure (works fine on 3.3.9):

 Download


>>> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>>>

 (this link will be gone in a couple of days)

 Or checkout the tag with "git clone
 https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then

>>> "git
>>>
 checkout tags/log4j-2.6.2-rc1”

 Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I

>>> am
>>>
 getting:

 Failed tests:
 XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
 [http://logging.apache.org/log4j/2.0/events;>], does not

>>> contain:
>>>
 [>>> XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
 line3 incorrect: [], must have two-space indentation
 XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
 XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
 Tests in error:
 MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
 com/fasterxml/ja...
 MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
 com/fasterxml/ja...
 MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
 com/fasterxml/ja...
 ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
 NoClassDefFound
 StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
 NoClassDefFound
 XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
 com/fasterxml/jackson/module/ja...
 XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
 com/fasterxml/jackson...
 XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
 NoClassDefFound
 XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
 NoClassDefFound

 org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.
>>> apache.logging.log4j.core.net.server.SslXmlSocketServerTest
>>>
 Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
 com/fasterxml/jackson/m...
 Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer


 org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.
>>> apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
>>>
 Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
 com/fasterxml/jackson/m...
 Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer


 org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.
>>> apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
>>>
 Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
 com/fasterxml/jackson/m...
 Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

 Everything works fine with Maven 3.3.9.

 Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
 2015-11-10T08:41:47-08:00)
 Maven home: E:\Java\apache-maven-3.3.9
 Java version: 1.8.0_91, vendor: Oracle Corporation
 Java home: C:\Program Files\Java\jdk1.8.0_91\jre
 Default locale: en_US, platform encoding: Cp1252
 OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

 Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
 2016-06-11T12:17:57-07:00)
 Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
 Java version: 1.8.0_91, vendor: Oracle Corporation
 Java home: C:\Program Files\Java\jdk1.8.0_91\jre
 Default locale: en_US, platform encoding: Cp1252
 OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

 Thank you
 Gary (Apache Logging PMC)

 --
 E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |

>>> ggreg...@apache.org (mailto:ggreg...@apache.org)
>>>
 Java Persistence with Hibernate, Second Edition
 
 JUnit in Action, Second Edition 
 Spring Batch in Action 

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Karl Heinz Marbaise]

Hi Gary,

On 7/6/16 8:47 PM, Gary Gregory wrote:

On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch  wrote:


That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)
before MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing



Is there a download for that?


Should I create one?

Kind regards
Karl Heinz Marbaise



Gary




On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:


A while back, a post made available a 3.4.0 SNAPSHOT build for testing.

So

I'm using it here and there.

To replicate the 3.4.0-S failure (works fine on 3.3.9):

Download


https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip


(this link will be gone in a couple of days)

Or checkout the tag with "git clone
https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then

"git

checkout tags/log4j-2.6.2-rc1”

Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I

am

getting:

Failed tests:
XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
[http://logging.apache.org/log4j/2.0/events;>], does not

contain:

[], must have two-space indentation
XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
Tests in error:
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
NoClassDefFound
StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
NoClassDefFound
XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
com/fasterxml/jackson/module/ja...
XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
com/fasterxml/jackson...
XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
NoClassDefFound
XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
NoClassDefFound


org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest

Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer



org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest

Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer



org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest

Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

Everything works fine with Maven 3.3.9.

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
2016-06-11T12:17:57-07:00)
Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

Thank you
Gary (Apache Logging PMC)

--
E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |

ggreg...@apache.org (mailto:ggreg...@apache.org)

Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Karl Heinz Marbaise]

Hi,

thanks Stuart...that's right.

Kind regards
Karl Heinz Marbaise
On 7/6/16 8:45 PM, Stuart McCulloch wrote:

That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master 
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing

On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:


A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
I'm using it here and there.

To replicate the 3.4.0-S failure (works fine on 3.3.9):

Download
https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip

(this link will be gone in a couple of days)

Or checkout the tag with "git clone
https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then "git
checkout tags/log4j-2.6.2-rc1”

Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
getting:

Failed tests:
XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
[http://logging.apache.org/log4j/2.0/events;>], does not contain:
[], must have two-space indentation
XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
Tests in error:
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
NoClassDefFound
StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
NoClassDefFound
XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
com/fasterxml/jackson/module/ja...
XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
com/fasterxml/jackson...
XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
NoClassDefFound
XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
NoClassDefFound
org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer

org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer

org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

Everything works fine with Maven 3.3.9.

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
2016-06-11T12:17:57-07:00)
Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

Thank you
Gary (Apache Logging PMC)


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Gary Gregory]

On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch  wrote:

> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)
> before MNG-5227 and other breaking changes were rolled back
>
> I just tried with a maven distribution built from latest master
> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing
>

Is there a download for that?

Gary


>
> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>
> > A while back, a post made available a 3.4.0 SNAPSHOT build for testing.
> So
> > I'm using it here and there.
> >
> > To replicate the 3.4.0-S failure (works fine on 3.3.9):
> >
> > Download
> >
> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
> >
> > (this link will be gone in a couple of days)
> >
> > Or checkout the tag with "git clone
> > https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then
> "git
> > checkout tags/log4j-2.6.2-rc1”
> >
> > Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I
> am
> > getting:
> >
> > Failed tests:
> > XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
> > [http://logging.apache.org/log4j/2.0/events;>], does not
> contain:
> > [ > XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
> > line3 incorrect: [], must have two-space indentation
> > XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
> > XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
> > Tests in error:
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
> > NoClassDefFound
> > StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
> > com/fasterxml/jackson/module/ja...
> > XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
> > com/fasterxml/jackson...
> > XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
> > NoClassDefFound
> >
> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
> > Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
> >
> >
> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
> > Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
> >
> >
> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
> > Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
> >
> > Everything works fine with Maven 3.3.9.
> >
> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T08:41:47-08:00)
> > Maven home: E:\Java\apache-maven-3.3.9
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> >
> > Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
> > 2016-06-11T12:17:57-07:00)
> > Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"
> >
> > Thank you
> > Gary (Apache Logging PMC)
> >
> > --
> > E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |
> ggreg...@apache.org (mailto:ggreg...@apache.org)
> > Java Persistence with Hibernate, Second Edition
> > 
> > JUnit in Action, Second Edition 
> > Spring Batch in Action 
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
> >
>
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! 

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master 
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing  

On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:

> A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
> I'm using it here and there.
>  
> To replicate the 3.4.0-S failure (works fine on 3.3.9):
>  
> Download
> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>  
> (this link will be gone in a couple of days)
>  
> Or checkout the tag with "git clone
> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then "git
> checkout tags/log4j-2.6.2-rc1”
>  
> Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
> getting:
>  
> Failed tests:
> XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
> [http://logging.apache.org/log4j/2.0/events;>], does not contain:
> [ XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
> line3 incorrect: [], must have two-space indentation
> XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
> XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
> Tests in error:
> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> com/fasterxml/ja...
> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> com/fasterxml/ja...
> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> com/fasterxml/ja...
> ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
> NoClassDefFound
> StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
> NoClassDefFound
> XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
> com/fasterxml/jackson/module/ja...
> XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
> com/fasterxml/jackson...
> XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
> NoClassDefFound
> XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
> NoClassDefFound
> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
> Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
> com/fasterxml/jackson/m...
> Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
>  
> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
> Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> com/fasterxml/jackson/m...
> Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
>  
> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
> Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> com/fasterxml/jackson/m...
> Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
>  
> Everything works fine with Maven 3.3.9.
>  
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9
> Java version: 1.8.0_91, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>  
> Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
> 2016-06-11T12:17:57-07:00)
> Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
> Java version: 1.8.0_91, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"
>  
> Thank you
> Gary (Apache Logging PMC)
>  
> --  
> E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) | 
> ggreg...@apache.org (mailto:ggreg...@apache.org)
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>  
>