Re: Ask for a shepherd for MESOS-4440

2016-09-16 Thread Vinod Kone
Adam, looks like you shepherded MESOS-3763. Can you shepherd this as well?

On Sun, Sep 4, 2016 at 6:38 PM, Yongqiao Wang 
wrote:

> Hi guys,
>
>
> In MESOS-3763 ticket, we have exposed http::internal::request function in
> libprocess/http, so in MESOS-4440 ticket, we need to cleaning up the
> http::internal::get/post/delete functions, I have submitted four patches
> to clean up the http::internal::get function, cloud someone can help to
> shepherd this ticket?
>
>
> Thanks!
>
>
> --
> Regards!
> Grady YQ. Wang(王勇桥)
> --
> Software Engineer Of IBM Platform Computing
> E-mail: grady.w...@foxmail.com
> WeChat ID: gradyYQwang
> Address: 3/F,No.42 GAO XIN LIU ROAD,Xian,Shanxi 710075 China
> If you can control yourself, then you can control everything.
> --


Re: Choice between LOG(FATAL) and EXIT(EXIT_FAILURE)

2016-09-16 Thread Vinod Kone
We typically used LOG(FATAL) when we were interested in the stack trace. If
not, we preferred to use EXIT(EXIT_FAILURE). While that was the original
intention, not sure if we have been following that distinction diligently.

Separately, we should fix EXIT to log at ERROR level instead of just
printing to to stderr.

On Tue, Aug 30, 2016 at 10:42 AM, Zhitao Li  wrote:

> Hi,
>
> Can someone explain better about when we should use LOG(FATAL) and when
> EXIT(EXIT_FAILURE) in Mesos codebase?
>
> One thing is that EXIT(EXIT_FAILURE) does not seem to leave anything in the
> level separated GLOG files so it could be mysterious to people who relies
> on that for debugging issues.
>
> I see we have about 100 call sites to LOG(FATAL) and 200 call sites
> to EXIT(EXIT_FAILURE) at the moment.
>
> Many thanks!
>
> --
> Cheers,
>
> Zhitao Li
>


Re: Unified cgroups isolator

2016-09-16 Thread tommy xiao
Awesome! you are rocks star!

Kudos to @haosdent and @qianzhang!

2016-09-15 4:36 GMT+08:00 Charles Allen :

> That's awesome, great work!
>
>
> On Tue, Sep 13, 2016 at 5:10 PM Qian Zhang  wrote:
>
>> Thanks @haosdent's awesome work and @Jie's great shepherding and guidance
>> on this project!
>>
>>
>> Thanks,
>> Qian Zhang
>>
>> On Wed, Sep 14, 2016 at 7:56 AM, Gilbert Song 
>> wrote:
>>
>>> Awesome!
>>>
>>> Kudos to @haosdent and @qianzhang!
>>>
>>> On Tue, Sep 13, 2016 at 11:22 AM, haosdent  wrote:
>>>
 Really appreciate @qian and @jie's great helps on this! It makes us
 easier to add cgroups isolation for rest subsystem.

 Additionally, if you find any changes about unified cgroups isolator
 break your environment, please let us know. I would
 try to fix asap.

 On Wed, Sep 14, 2016 at 1:59 AM, Jie Yu  wrote:

> Hi,
>
> We just merged the unified cgroups isolator. Huge shout out to
> @haosdent and @qianzhang to make this happen!
> https://issues.apache.org/jira/browse/MESOS-4697
>
> Just to give you some context. Previously, it's a huge pain to add a
> new cgroups subsystem to Mesos because it requires creating a new isolator
> (a lot of code duplication). Now, we merge all the subsystems into one
> single isolator, that makes adding a new subsystem very easy.
>
> More importantly, the new cgroups isolator supports cgroups v2!
>
> - Jie
>



 --
 Best Regards,
 Haosdent Huang

>>>
>>>
>>


-- 
Deshi Xiao
Twitter: xds2000
E-mail: xiaods(AT)gmail.com