[GitHub] mesos pull request #256: Correct spelling errors in the docs

[bbannier]

Github user bbannier commented on a diff in the pull request:

https://github.com/apache/mesos/pull/256#discussion_r161343683
  
--- Diff: docs/endpoints/files/browse.json.md ---
@@ -20,7 +20,7 @@ Query parameters:
 
 
 ### AUTHENTICATION ###
-This endpoint requires authentication iff HTTP authentication is
+This endpoint requires authentication if HTTP authentication is
--- End diff --

I created to track removal of these files; the fix is in principal trivial, 
we just need to make sure to not break existing tooling.

Regarding this change, I was educated by a native speaker that the spelling 
here is actually valid and intended when I tried to perform a similar change, 
https://reviews.apache.org/r/46934/.


---

[GitHub] mesos issue #255: Add curl examples to operator-http-api

[vinodkone]

Github user vinodkone commented on the issue:

https://github.com/apache/mesos/pull/255
  
@nhandler  Thanks for doing this! Awesome. Do I take it that you tested all 
these commands? Also, is the EOF required in all the curl commands?


---

[GitHub] mesos pull request #256: Correct spelling errors in the docs

[bmahler]

Github user bmahler commented on a diff in the pull request:

https://github.com/apache/mesos/pull/256#discussion_r161337083
  
--- Diff: docs/endpoints/files/browse.json.md ---
@@ -20,7 +20,7 @@ Query parameters:
 
 
 ### AUTHENTICATION ###
-This endpoint requires authentication iff HTTP authentication is
+This endpoint requires authentication if HTTP authentication is
--- End diff --

Sure, however this file is actually generated from source, so the change 
would need to be made there:
https://github.com/apache/mesos/blob/1.4.0/src/files/files.cpp#L352-L371

https://github.com/apache/mesos/blob/1.4.0/3rdparty/libprocess/include/process/help.hpp#L82-L90

I think @bbannier was looking into whether we could remove generated 
markdown since they're no longer needed. We now generate them at the time of 
publishing the website.


---

[GitHub] mesos pull request #251: Update presentations.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/mesos/pull/251


---

[GitHub] mesos pull request #256: Correct spelling errors in the docs

[ralic]

Github user ralic commented on a diff in the pull request:

https://github.com/apache/mesos/pull/256#discussion_r161336318
  
--- Diff: docs/endpoints/files/browse.json.md ---
@@ -20,7 +20,7 @@ Query parameters:
 
 
 ### AUTHENTICATION ###
-This endpoint requires authentication iff HTTP authentication is
+This endpoint requires authentication if HTTP authentication is
--- End diff --

Since it is documentation, would it be better not to use acronym ? So that 
translation of the documentation maybe access by machine or the reader easier.


---

[GitHub] mesos issue #249: Update presentations.md

[bmahler]

Github user bmahler commented on the issue:

https://github.com/apache/mesos/pull/249
  
Thanks, can you close this PR in favor of that one?


---

[GitHub] mesos pull request #256: Correct spelling errors in the docs

[bmahler]

Github user bmahler commented on a diff in the pull request:

https://github.com/apache/mesos/pull/256#discussion_r161334491
  
--- Diff: docs/endpoints/files/browse.json.md ---
@@ -20,7 +20,7 @@ Query parameters:
 
 
 ### AUTHENTICATION ###
-This endpoint requires authentication iff HTTP authentication is
+This endpoint requires authentication if HTTP authentication is
--- End diff --

We should leave as 'iff' since this is a short form of "if and only if". 
Ditto on the other cases.


---

[GitHub] mesos pull request #256: Correct spelling errors in the docs

[bmahler]

Github user bmahler commented on a diff in the pull request:

https://github.com/apache/mesos/pull/256#discussion_r161334849
  
--- Diff: docs/app-framework-development-guide.md ---
@@ -91,13 +91,13 @@ virtual void offerRescinded(SchedulerDriver* driver, 
const OfferID& offerId);
  * Invoked when the status of a task has changed (e.g., a slave is
  * lost and so the task is lost, a task finishes and an executor
  * sends a status update saying so, etc). If implicit
- * acknowledgements are being used, then returning from this
+ * acknowledgments are being used, then returning from this
--- End diff --

I'm inclined to leave in the extra "e" since I believe both spellings are 
acceptable FWICT and we have more with the extra "e":

➜  mesos git:(master) ✗ grep -Ri acknowledgements src | wc -l
 149
➜  mesos git:(master) ✗ grep -Ri acknowledgments src | wc -l
   6

Ditto for the other cases.


---

[GitHub] mesos issue #253: Remove missing MUGs from site

[pleia2]

Github user pleia2 commented on the issue:

https://github.com/apache/mesos/pull/253
  
Sure thing, closing.


---

[GitHub] mesos pull request #253: Remove missing MUGs from site

[pleia2]

Github user pleia2 closed the pull request at:

https://github.com/apache/mesos/pull/253


---

[GitHub] mesos issue #253: Remove missing MUGs from site

[bmahler]

Github user bmahler commented on the issue:

https://github.com/apache/mesos/pull/253
  
No worries! I just realized that the tooling left behind some dirty state 
and these changes were pulled into the next PR I committed: 
370b5b634d1132a34022ec184a3056de46b45c4a.

Sorry about that! :( Are you able to close this?


---

[GitHub] mesos pull request #257: Add new MesosCons, fix 404s on to presentations.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/mesos/pull/257


---

Re: Replacing ad hoc virtualenvs for testing and linting with tox

[Stephan Erb]

For the Apache Aurora project we solved the need for a virtualenv by using a 
wrapper-script that will bootstrap a virtualenv on demand. It only requires 
Python to be installed but no other packages. It works flawlessly on Mac and 
Linux. Maybe this idea is also useful for Mesos. 

Virtualenv wrapper script:  
https://github.com/apache/aurora/blob/master/build-support/virtualenv
Example usage: 
https://github.com/apache/aurora/blob/master/build-support/python/make-pycharm-virtualenv#L47-L48

Best regards,
Stephan

On 11.01.18, 19:55, "Eric Chung"  wrote:

Hi Benno,

There are different ways to approach this:

1. Ideal case: instead of requiring the `virtualenv` package (e.g. on
debian), require `tox` instead. Since virtualenv is a dependency of tox, we
will not break any existing code that requires virtualenv. The benefit of
this is that we will not need a "meta" virtaulenv for installing tox.
Downside is that this might break if the user doesn't have enough
permissions to install packages on the host.

2. More pragmatic case: setup a minimal "meta" virtualenv that installs tox
only. This can be done in the `support` dir and the rest of the code that
requires tox can call tox from there. Benefit is that this won't require
any dependency changes and should "just work" without any disruption.
Downside is that we still will need some bash scripts to manage the "meta"
virtualenv.

To answer your last question, I don't think this will effect the python
bindings, at least initially. The tests that I aim to run with tox are
mostly CLI-related. In the long term though, it may be worth considering
using tox to perform all python-related build/test tasks.

Eric

On Thu, Jan 11, 2018 at 6:33 AM, Benno Evers  wrote:

> Hi Eric,
>
> Do I understand correctly that you want to require all developers to
> install tox so that it can be called from a post-commit hook to create a
> virtualenv in which it will then install pylint with all its dependencies
> and use that to lint the changed python files? Would it be possible to 
just
> require all developers to install pylint instead?
>
> Also, since you mention that you want to use tox to run unit tests in
> src/python, do you plan to integrate this with the existing mesos build
> system(s)? E.g., would it respect the python-related configuration 
settings
> like `PYTHON`, `PYTHON_VERSION`, `--disable-python`,
> `--disable-python-dependency-install`. Or is this change unrelated to
> building the python bindings?
>
> Best regards,
> Benno
>
> On Tue, Jan 9, 2018 at 3:29 PM, Armand Grillet 
> wrote:
>
>> Having distributed tox.ini files and being able to run tests for
>> multiple environments will be helpful to develop the new Mesos CLI thus
>> I support this change.
>>
>> Requiring developers to install tox is indeed the biggest concern with
>> this change; however, this process should be straightforward as it uses 
pip.
>>
>> 2018-01-09 10:03 GMT+01:00 Kevin Klues :
>>
>>> I'm the one who asked Eric to send this email. I've been meaning to
>>> comment on it and haven't gotten around to it. I support it. We just 
need
>>> to make sure and update our CI appropriately for the new dependency (and
>>> make devs aware of it).
>>>
>>>
>>> On Tue, Jan 9, 2018 at 4:03 AM Benjamin Mahler 
>>> wrote:
>>>
 +armand, benno, kevin

 On Fri, Jan 5, 2018 at 12:04 PM, Eric Chung  wrote:

> Hello mesos devs,
>
> I'd like to propose that we replace some of our bash scripts for
> building
> ad hoc virtualenvs with tox ,
> a tool
> for automating lifecycle management of virtualenvs using declarative
> configuration files.
>
> Specifically, virtualenvs created for the purpose of linting
> (support/.virtaulenv) and unit testing (in src/python) can be managed
> by
> tox, which provide the following benefits:
>
> 1. Eliminate the need for maintaining shell scripts for managing
> virtualenvs
> 2. We will no longer need to install *ALL* dependencies into the same
> virtualenv for the purpose of linting -- we can have distributed
> tox.ini
> files in wherever python linting is required, and just run tox there.
> 3. Easily run tests for multiple environments, e.g. python3 vs 
python2.
> This will make migration to python3 much easier, which we are facing
> increasing pressure to address.
>
> The biggest concern here would probably the change in