[GitHub] metron issue #767: METRON-1196 Increment master version number to 0.4.2 for ...
Github user kylerichardson commented on the issue: https://github.com/apache/metron/pull/767 Absolutely, I've logged METRON-1210 for this. ---
[GitHub] metron issue #767: METRON-1196 Increment master version number to 0.4.2 for ...
Github user kylerichardson commented on the issue: https://github.com/apache/metron/pull/767 There are so many `pom.xml` files to change. Have we considered using a metron_version property in the parent/root pom to avoid needing to change so many files in future releases? If folks agree, I'd be happy to do the leg work and submit a PR. ---
[GitHub] metron issue #659: METRON-1053 Relocate Metron Docker
Github user kylerichardson commented on the issue: https://github.com/apache/metron/pull/659 +1, thanks for taking this on --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #659: METRON-1053 Relocate Metron Docker
Github user kylerichardson commented on the issue: https://github.com/apache/metron/pull/659 Going to run this up now. I'll get my feedback in today. On Mon, Jul 24, 2017 at 10:02 AM, JonZeolla <notificati...@github.com> wrote: > I took a high level look when it first came out - no concerns. I'm mobile > only until Thursday so don't hold this up based on me. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/metron/pull/659#issuecomment-317432077>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AJ6R3VNjA3oLfQnrBkLKm6idoMnLVRDSks5sRKPrgaJpZM4OdCOL> > . > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #579: METRON-941 fix PaloAltoParser
Github user kylerichardson commented on the issue: https://github.com/apache/metron/pull/579 Given these unit tests have been broken for quite some time and @ctramnitz has thoroughly tested in his environment and that this is a relatively minor change, I'm okay to move it forward especially with a JIRA in to address these broken 'AbstractConfigTest' tests holistically in METRON-962. +1 from me but would prefer a second to commit without tests. @ctramnitz as discussed please upload public safe sample logs to the JIRA to assist with test development. -Kyle > On Jun 5, 2017, at 5:40 PM, Matt Foley <notificati...@github.com> wrote: > > @ctramnitz says (in email): "I didnât touch unit tests because it was already broken before. > We agreed to put this into a separate ticket (METRON-962) as it applies to other parsers as well. > For now, METRON-941 fixes an actual bug (parsing is broken with the current code)." > > @ottobackwards and @justinleet (principles on METRON-962), do you agree we should go ahead and commit this without a viable PaloAltoParser unit test? Or wait for METRON-962? > > @kylerichardson , what is your opinion on the issue? > Thanks. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions
Github user kylerichardson commented on the issue: https://github.com/apache/metron/pull/530 I'm working on a config only parser for Blue Coat and am planning on using this to build it as an extension. Should also provide a good opportunity to review and test the PR. Given its size, is this a good candidate for a feature branch in the repo? Might give it more weight to get more community reviews/feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #579: METRON-941 fix PaloAltoParser
Github user kylerichardson commented on the issue: https://github.com/apache/metron/pull/579 Thanks for the contribution! Would you mind having a look at the unit tests for this parser and updating them? From a quick glance, the unit test appears to be defunct. It's using `AbstractConfigTest` to read in test data from a file that doesn't exist anyone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
