[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306750505 I have created an issue on my github side: https://github.com/werpu/jsfs_js_ts/issues/26 I will fix the bugs there first and will keep an update on the status. Once everything is fixed, it is merged back into the pull request. So if you want to keep track of things, you can follow there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306315248 Thanks for the reports, I will tackle every single one of those issues tomorrow. the f:param is clearly still an issue in the new form encoding code as for the rest I will have a deeper look. Most if not all should be fixed tomorrow or the day after tomorrow. Thanks for reporting the test results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
volosied commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306168003 Another thing I just noticed: The ajax file submissions (single / multiple) doesn't seem to work. https://github.com/jakartaee/faces/tree/master/tck/faces40/inputFile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
volosied commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306143241 @werpu Wanted to give you a quick update. Most tests are passing, but I see a few issues 1) f:param doesn't to be properly sent. For example: ``` ``` The code above sends the following in the form data: `0 "message,Hello+World"`. ``` 0"message,Hello+World" form1_SUBMIT "1" jakarta.faces.ViewState "N2RjNThlYTRlZjExNjJiODAwMDAwMDAz" jakarta.faces.ClientWindow "10tijvumt" form1:_idcl "form1:submitButton" ``` However, previously (working case), `message "Hello+World"` was sent. ``` form1_SUBMIT "1" jakarta.faces.ViewState "ZjAyNTllMDgwODcxZTFlOTAwMDAwMDA0" jakarta.faces.ClientWindow "-uveyxftzi" message "Hello+World" form1:_idcl "form1:submitButton" ``` This causes our app to fail since ExternalContext's getRequestParameterMap() cannot find "message". 2) Clicking "Click Here" on `ELImplicitObjectsViaCDI/index.xhtml` open up a new tab, but this shouldn't happen. See apps and source. 3) Our Websocket Listener's onOpen call is called during the page loading, but it should only occur on the button click. https://user-images.githubusercontent.com/5934310/200405665-cb383264-3a5c-44c8-9eae-47bee0c85f15.png;> URL is: `WebSocket/faces40/OpenCloseWebSocketTest.jsf` 4) Related to the websocket issue above, pressing the onClose button (to close websocket channel) encounter this exception: ``` Uncaught TypeError: e.components[s].onclose is not a function onclose http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 onclose http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 bindCallbacks http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 open http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 open http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 open http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 init http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 init http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2 http://localhost:9080/WebSocket/faces40/OpenCloseWebSocketTest.jsf:20 ``` 5) Our html unit library is encoutnering a script exception? I don't don't see this in the browser, so I think it's just our library. We'll try to see if it goes away with a version update. I validated the JavaScript syntax myself (compressed and uncompressed files) and I didn't find anything. However, could you also double check? Exception isn't clear where this "error" is. ``` com.gargoylesoftware.htmlunit.ScriptException: syntax error (http://localhost:8010/CDIManagedProperty/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces#2) ``` Source code can be found: https://github.com/OpenLiberty/open-liberty/tree/integration/dev/com.ibm.ws.jsf.2.3_fat/test-applications/ELImplicitObjectsViaCDI.war https://github.com/OpenLiberty/open-liberty/tree/integration/dev/com.ibm.ws.jsf.2.3_fat/test-applications/WebSocket.war But I've also attached the apps. [Apps.zip](https://github.com/apache/myfaces/files/9955133/Apps.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MYFACES-4492) NPE when no label is specified on
[
https://issues.apache.org/jira/browse/MYFACES-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Nicolucci resolved MYFACES-4492.
-
Resolution: Fixed
> NPE when no label is specified on
> -
>
> Key: MYFACES-4492
> URL: https://issues.apache.org/jira/browse/MYFACES-4492
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.2.15, 2.3.10, 2.3-next-M7, 3.0.2, 4.0.0-RC2
>Reporter: Paul Nicolucci
>Assignee: Paul Nicolucci
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.3-next-M8, 2.2.16, 4.0.0-RC3
>
>
> TCK Test failure information:
> *faces23/uiinput:*
> *Background:* [https://github.com/eclipse-ee4j/mojarra/issues/4734]
> *App:*
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces23/uiinput/src/main/webapp/issue4734.xhtml]
> *Test:*
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces23/uiinput/src/test/java/ee/jakarta/tck/faces/test/javaee8/uiinput/Issue4734IT.java#L38]
> *The above test fails on MyFaces with the following Exception:*
>
> {noformat}
> jakarta.servlet.ServletException: label is null.
> at jakarta.faces.webapp.FacesServlet.service(FacesServlet.java:255)
> at
> com.ibm.ws.webcontainer.servlet.ServletWrapper.service(ServletWrapper.java:1258)
> at
> com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:746)
> at
> com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:443)
> at
> com.ibm.ws.webcontainer.filter.WebAppFilterChain.invokeTarget(WebAppFilterChain.java:193)
> at
> com.ibm.ws.webcontainer.filter.WebAppFilterChain.doFilter(WebAppFilterChain.java:98)
> at
> com.ibm.ws.security.jaspi.JaspiServletFilter.doFilter(JaspiServletFilter.java:56)
> at
> com.ibm.ws.webcontainer.filter.FilterInstanceWrapper.doFilter(FilterInstanceWrapper.java:201)
> at
> com.ibm.ws.webcontainer.filter.WebAppFilterChain.doFilter(WebAppFilterChain.java:91)
> at
> com.ibm.ws.webcontainer.filter.WebAppFilterManager.doFilter(WebAppFilterManager.java:1002)
> at
> com.ibm.ws.webcontainer.filter.WebAppFilterManager.invokeFilters(WebAppFilterManager.java:1140)
> at com.ibm.ws.webcontainer.webapp.WebApp.handleRequest(WebApp.java:5058)
> at
> com.ibm.ws.webcontainer.osgi.DynamicVirtualHost$2.handleRequest(DynamicVirtualHost.java:316)
> at
> com.ibm.ws.webcontainer.WebContainer.handleRequest(WebContainer.java:1007)
> at
> com.ibm.ws.webcontainer.osgi.DynamicVirtualHost$2.run(DynamicVirtualHost.java:281)
> at
> com.ibm.ws.http.dispatcher.internal.channel.HttpDispatcherLink$TaskWrapper.run(HttpDispatcherLink.java:1239)
> at
> com.ibm.ws.http.dispatcher.internal.channel.HttpDispatcherLink.wrapHandlerAndExecute(HttpDispatcherLink.java:468)
> at
> com.ibm.ws.http.dispatcher.internal.channel.HttpDispatcherLink.ready(HttpDispatcherLink.java:427)
> at
> com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.handleDiscrimination(HttpInboundLink.java:566)
> at
> com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.handleNewRequest(HttpInboundLink.java:500)
> at
> com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.processRequest(HttpInboundLink.java:360)
> at
> com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.ready(HttpInboundLink.java:327)
> at
> com.ibm.ws.tcpchannel.internal.NewConnectionInitialReadCallback.sendToDiscriminators(NewConnectionInitialReadCallback.java:167)
> at
> com.ibm.ws.tcpchannel.internal.NewConnectionInitialReadCallback.complete(NewConnectionInitialReadCallback.java:75)
> at
> com.ibm.ws.tcpchannel.internal.WorkQueueManager.requestComplete(WorkQueueManager.java:514)
> at
> com.ibm.ws.tcpchannel.internal.WorkQueueManager.attemptIO(WorkQueueManager.java:584)
> at
> com.ibm.ws.tcpchannel.internal.WorkQueueManager.workerRun(WorkQueueManager.java:968)
> at
> com.ibm.ws.tcpchannel.internal.WorkQueueManager$Worker.run(WorkQueueManager.java:1057)
> at
> com.ibm.ws.threading.internal.ExecutorServiceImpl$RunnableWrapper.run(ExecutorServiceImpl.java:245)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:866)
> Caused by: java.lang.NullPointerException: label is null.
> at org.apache.myfaces.core.api.shared.lang.Assert.notNull(Assert.java:35)
> at jakarta.faces.model.SelectItem.setLabel(SelectItem.java:145)
> at
> org.apache.myfaces.core.api.shared.SelectItemsUtil.createSelectItem(SelectItemsUtil.java:61)
> at
> org.apache.myfaces.core.api.shared.SelectItemsIterator.hasNext(SelectItemsIterator.java:108)
> at
>
[GitHub] [myfaces] melloware merged pull request #376: MYFACES-4492: don't NPE when no label is set
melloware merged PR #376: URL: https://github.com/apache/myfaces/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci opened a new pull request, #376: MYFACES-4492: don't NPE when no label is set
pnicolucci opened a new pull request, #376: URL: https://github.com/apache/myfaces/pull/376 https://issues.apache.org/jira/browse/MYFACES-4492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] melloware merged pull request #375: MYFACES-4492: don't NPE when no label is set
melloware merged PR #375: URL: https://github.com/apache/myfaces/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci opened a new pull request, #375: MYFACES-4492: don't NPE when no label is set
pnicolucci opened a new pull request, #375: URL: https://github.com/apache/myfaces/pull/375 https://issues.apache.org/jira/browse/MYFACES-4492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] melloware merged pull request #374: MYFACES-4492: don't NPE when no label is set
melloware merged PR #374: URL: https://github.com/apache/myfaces/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci merged pull request #373: MYFACES-4492: don't NPE when no label is set
pnicolucci merged PR #373: URL: https://github.com/apache/myfaces/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] pnicolucci opened a new pull request, #374: MYFACES-4492: don't NPE when no label is set
pnicolucci opened a new pull request, #374: URL: https://github.com/apache/myfaces/pull/374 https://issues.apache.org/jira/browse/MYFACES-4492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1305224968 Btw. theoretically we also could replace the codebase or add the next gen codebase to 2.3 (as second loading option) the codebase can work in both namespaces, via frontend shims) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
