volosied commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1306143241
@werpu
Wanted to give you a quick update. Most tests are passing, but I see a few
issues
1) f:param doesn't to be properly sent. For example:
```
<h:commandButton id="submitButton" value="Click here"
action="#{elImplicitObjectBean.execute}">
<f:param name="message" value="Hello World"/>
</h:commandButton>
```
The code above sends the following in the form data: `0
"message,Hello+World"`.
```
0 "message,Hello+World"
form1_SUBMIT "1"
jakarta.faces.ViewState "N2RjNThlYTRlZjExNjJiODAwMDAwMDAz"
jakarta.faces.ClientWindow "10tijvumt"
form1:_idcl "form1:submitButton"
```
However, previously (working case), `message "Hello+World"` was sent.
```
form1_SUBMIT "1"
jakarta.faces.ViewState "ZjAyNTllMDgwODcxZTFlOTAwMDAwMDA0"
jakarta.faces.ClientWindow "-uveyxftzi"
message "Hello+World"
form1:_idcl "form1:submitButton"
```
This causes our app to fail since ExternalContext's getRequestParameterMap()
cannot find "message".
2) Clicking "Click Here" on `ELImplicitObjectsViaCDI/index.xhtml` open up a
new tab, but this shouldn't happen. See apps and source.
3) Our Websocket Listener's onOpen call is called during the page loading,
but it should only occur on the button click.
<img width="490" alt="image"
src="https://user-images.githubusercontent.com/5934310/200405665-cb383264-3a5c-44c8-9eae-47bee0c85f15.png";>
URL is: `WebSocket/faces40/OpenCloseWebSocketTest.jsf`
4) Related to the websocket issue above, pressing the onClose button (to
close websocket channel) encounter this exception:
```
Uncaught TypeError: e.components[s].onclose is not a function
onclose
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
onclose
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
bindCallbacks
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
open
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
open
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
open
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
init
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
init
http://localhost:9080/WebSocket/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces:2
<anonymous>
http://localhost:9080/WebSocket/faces40/OpenCloseWebSocketTest.jsf:20
```
5) Our html unit library is encoutnering a script exception? I don't don't
see this in the browser, so I think it's just our library. We'll try to see if
it goes away with a version update. I validated the JavaScript syntax myself
(compressed and uncompressed files) and I didn't find anything. However, could
you also double check? Exception isn't clear where this "error" is.
```
com.gargoylesoftware.htmlunit.ScriptException: syntax error
(http://localhost:8010/CDIManagedProperty/jakarta.faces.resource/faces.js.jsf?ln=jakarta.faces#2)
```
Source code can be found:
https://github.com/OpenLiberty/open-liberty/tree/integration/dev/com.ibm.ws.jsf.2.3_fat/test-applications/ELImplicitObjectsViaCDI.war
https://github.com/OpenLiberty/open-liberty/tree/integration/dev/com.ibm.ws.jsf.2.3_fat/test-applications/WebSocket.war
But I've also attached the apps.
[Apps.zip](https://github.com/apache/myfaces/files/9955133/Apps.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/5934310/200405665-cb383264-3a5c-44c8-9eae-47bee0c85f15.png"](https://user-images.githubusercontent.com/5934310/200405665-cb383264-3a5c-44c8-9eae-47bee0c85f15.png"){kind=link}