[jira] [Commented] (TOBAGO-1589) Sorting in sheet work not with Mojarra 2.0
[ https://issues.apache.org/jira/browse/TOBAGO-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379956#comment-16379956 ] Bernd Bohmann commented on TOBAGO-1589: --- It's looks like components are not being created correctly while rendering. > Sorting in sheet work not with Mojarra 2.0 > -- > > Key: TOBAGO-1589 > URL: https://issues.apache.org/jira/browse/TOBAGO-1589 > Project: MyFaces Tobago > Issue Type: Bug > Components: Themes >Affects Versions: 2.0.9, 3.0.0-alpha-4 >Reporter: Udo Schnurpfeil >Assignee: Bernd Bohmann >Priority: Minor > Fix For: 4.1.1 > > > There is still a problem with Mojarra 2.0. > With Mojarra 2.1 this is fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOBAGO-1589) Sorting in sheet work not with Mojarra 2.0
[ https://issues.apache.org/jira/browse/TOBAGO-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379958#comment-16379958 ] Bernd Bohmann commented on TOBAGO-1589: --- The problem should exists with all mojarra versions. > Sorting in sheet work not with Mojarra 2.0 > -- > > Key: TOBAGO-1589 > URL: https://issues.apache.org/jira/browse/TOBAGO-1589 > Project: MyFaces Tobago > Issue Type: Bug > Components: Themes >Affects Versions: 2.0.9, 3.0.0-alpha-4 >Reporter: Udo Schnurpfeil >Assignee: Bernd Bohmann >Priority: Minor > Fix For: 4.1.1 > > > There is still a problem with Mojarra 2.0. > With Mojarra 2.1 this is fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bohmber opened a new pull request #2: Tobago 1589
bohmber opened a new pull request #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2 Fix for the mojarra issue. Created the components transient and move decode to sheet back. The explicit remove of the component is needed for mojarra 2.3 (they have the DynamicActionComponent List inside the state handling. Looks like it's an other workaround for some crap and they did not respect the transient property) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lofwyr14 commented on a change in pull request #2: Tobago 1589
lofwyr14 commented on a change in pull request #2: Tobago 1589
URL: https://github.com/apache/myfaces-tobago/pull/2#discussion_r171195827
##
File path:
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
##
@@ -132,13 +139,86 @@ public void decode(final FacesContext facesContext,
final UIComponent component)
}
RenderUtils.decodedStateOfTreeData(facesContext, sheet);
+decodeSheetAction(facesContext, sheet);
+decodeColumnAction(facesContext, columns);
/* this will be done by the javax.faces.component.UIData.processDecodes()
because these are facets.
for (UIComponent facet : sheet.getFacets().values()) {
facet.decode(facesContext);
}
*/
}
+ private void decodeColumnAction(final FacesContext facesContext,
List columns) {
+for (final AbstractUIColumnBase column : columns) {
+ final boolean sortable = ComponentUtils.getBooleanAttribute(column,
Attributes.sortable);
+ if (sortable) {
+final String sourceId =
facesContext.getExternalContext().getRequestParameterMap().get("javax.faces.source");
+final String columnId = column.getClientId(facesContext);
+final String sorterId = columnId + "_" + UISheet.SORTER_ID;
+
+if (sorterId.equals(sourceId)) {
+ final UIData data = (UIData) column.getParent();
+ data.queueEvent(new SortActionEvent(data, column));
+}
+ }
+}
+ }
+
+
+ private void decodeSheetAction(final FacesContext facesContext, UISheet
component) {
Review comment:
please use final as parameter qualifier
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] lofwyr14 commented on a change in pull request #2: Tobago 1589
lofwyr14 commented on a change in pull request #2: Tobago 1589
URL: https://github.com/apache/myfaces-tobago/pull/2#discussion_r171195751
##
File path:
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
##
@@ -132,13 +139,86 @@ public void decode(final FacesContext facesContext,
final UIComponent component)
}
RenderUtils.decodedStateOfTreeData(facesContext, sheet);
+decodeSheetAction(facesContext, sheet);
+decodeColumnAction(facesContext, columns);
/* this will be done by the javax.faces.component.UIData.processDecodes()
because these are facets.
for (UIComponent facet : sheet.getFacets().values()) {
facet.decode(facesContext);
}
*/
}
+ private void decodeColumnAction(final FacesContext facesContext,
List columns) {
Review comment:
please use final as parameter qualifier
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] lofwyr14 commented on a change in pull request #2: Tobago 1589
lofwyr14 commented on a change in pull request #2: Tobago 1589
URL: https://github.com/apache/myfaces-tobago/pull/2#discussion_r171195972
##
File path:
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
##
@@ -132,13 +139,86 @@ public void decode(final FacesContext facesContext,
final UIComponent component)
}
RenderUtils.decodedStateOfTreeData(facesContext, sheet);
+decodeSheetAction(facesContext, sheet);
+decodeColumnAction(facesContext, columns);
/* this will be done by the javax.faces.component.UIData.processDecodes()
because these are facets.
for (UIComponent facet : sheet.getFacets().values()) {
facet.decode(facesContext);
}
*/
}
+ private void decodeColumnAction(final FacesContext facesContext,
List columns) {
+for (final AbstractUIColumnBase column : columns) {
+ final boolean sortable = ComponentUtils.getBooleanAttribute(column,
Attributes.sortable);
+ if (sortable) {
+final String sourceId =
facesContext.getExternalContext().getRequestParameterMap().get("javax.faces.source");
+final String columnId = column.getClientId(facesContext);
+final String sorterId = columnId + "_" + UISheet.SORTER_ID;
+
+if (sorterId.equals(sourceId)) {
+ final UIData data = (UIData) column.getParent();
+ data.queueEvent(new SortActionEvent(data, column));
+}
+ }
+}
+ }
+
+
+ private void decodeSheetAction(final FacesContext facesContext, UISheet
component) {
+final String sourceId =
facesContext.getExternalContext().getRequestParameterMap().get("javax.faces.source");
+
+final String clientId = component.getClientId(facesContext);
+if (LOG.isDebugEnabled()) {
+ LOG.debug("sourceId = '{}'", sourceId);
+ LOG.debug("clientId = '{}'", clientId);
+}
+
+final String sheetClientIdWithAction = clientId +
UINamingContainer.getSeparatorChar(facesContext) + SUFFIX_PAGE_ACTION;
Review comment:
line width > 120 (please run checkstyle)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (TOBAGO-1862) Paging links in Sheet should not use href="#/"
Udo Schnurpfeil created TOBAGO-1862: --- Summary: Paging links in Sheet should not use href="#/" Key: TOBAGO-1862 URL: https://issues.apache.org/jira/browse/TOBAGO-1862 Project: MyFaces Tobago Issue Type: Bug Components: Themes Reporter: Udo Schnurpfeil href should not be used in this manner -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (TOBAGO-1863) Create an outline markup for buttons
Henning Noeth created TOBAGO-1863: - Summary: Create an outline markup for buttons Key: TOBAGO-1863 URL: https://issues.apache.org/jira/browse/TOBAGO-1863 Project: MyFaces Tobago Issue Type: New Feature Components: Core Affects Versions: 4.1.0 Reporter: Henning Noeth If the markup is set, the CSS class 'btn-outline-*' is used instead of 'btn-*'. https://getbootstrap.com/docs/4.0/components/buttons/#outline-buttons -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (TOBAGO-1864) Check allowedChildComponenents attribute of tag declarations
Henning Noeth created TOBAGO-1864: - Summary: Check allowedChildComponenents attribute of tag declarations Key: TOBAGO-1864 URL: https://issues.apache.org/jira/browse/TOBAGO-1864 Project: MyFaces Tobago Issue Type: Task Components: Core Affects Versions: 4.1.0 Reporter: Henning Noeth Currently the 'allowedChildComponenents' is in a bad maintenance state. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bohmber commented on issue #2: Tobago 1589
bohmber commented on issue #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#issuecomment-369291178 Checkstyle errors are fixed now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bohmber commented on issue #2: Tobago 1589
bohmber commented on issue #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#issuecomment-369297478 Added more fixes for Mojarra. Mojarra is like Klendathu This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bohmber commented on issue #2: Tobago 1589
bohmber commented on issue #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#issuecomment-369352423 There is still an issue with mojarra 2.0 PostAddToViewEvent, Head and StateHandling in mojarra 2.0. No more energy to find a workaround for the crap mojarra impl. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bohmber closed pull request #2: Tobago 1589
bohmber closed pull request #2: Tobago 1589
URL: https://github.com/apache/myfaces-tobago/pull/2
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java
b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java
index 78cd3d84d..2b459ffa3 100644
---
a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java
+++
b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java
@@ -419,6 +419,7 @@ public boolean getRendersChildren() {
.createComponent(facesContext, UIMeta.COMPONENT_TYPE,
RendererTypes.Meta.name());
viewportMeta.setName("viewport");
viewportMeta.setContent("width=device-width, initial-scale=1.0");
+viewportMeta.setTransient(true);
metas.add(0, viewportMeta);
}
@@ -426,6 +427,7 @@ public boolean getRendersChildren() {
final UIMeta charsetMeta = (UIMeta) facesContext.getApplication()
.createComponent(facesContext, UIMeta.COMPONENT_TYPE,
RendererTypes.Meta.name());
charsetMeta.setCharset(charset);
+charsetMeta.setTransient(true);
metas.add(0, charsetMeta);
}
}
diff --git
a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetPageCommandRenderer.java
b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetPageCommandRenderer.java
index 4b9707f26..bbc15b160 100644
---
a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetPageCommandRenderer.java
+++
b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetPageCommandRenderer.java
@@ -19,71 +19,11 @@
package org.apache.myfaces.tobago.internal.renderkit.renderer;
-import org.apache.myfaces.tobago.component.Attributes;
-import org.apache.myfaces.tobago.event.SheetAction;
-import org.apache.myfaces.tobago.event.PageActionEvent;
-import org.apache.myfaces.tobago.event.SortActionEvent;
-import org.apache.myfaces.tobago.util.ComponentUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import javax.faces.component.UIColumn;
-import javax.faces.component.UIComponent;
-import javax.faces.component.UIData;
-import javax.faces.context.FacesContext;
-import javax.faces.event.ActionEvent;
-import java.util.Map;
-
public class SheetPageCommandRenderer extends LinkRenderer {
private static final Logger LOG =
LoggerFactory.getLogger(SheetPageCommandRenderer.class);
- @Override
- public void decode(final FacesContext facesContext, final UIComponent
component) {
-final String sourceId =
facesContext.getExternalContext().getRequestParameterMap().get("javax.faces.source");
-final String clientId = component.getClientId(facesContext);
-if (LOG.isDebugEnabled()) {
- LOG.debug("sourceId = '{}'", sourceId);
- LOG.debug("clientId = '{}'", clientId);
-}
-
-if (clientId.equals(sourceId)) {
-
- final SheetAction action = (SheetAction)
ComponentUtils.getAttribute(component, Attributes.sheetAction);
- ActionEvent event = null;
-
- switch (action) {
-case first:
-case prev:
-case next:
-case last:
- event = new PageActionEvent(component.getParent(), action);
- break;
-case toPage:
-case toRow:
- event = new PageActionEvent(component.getParent(), action);
- Integer target = (Integer) ComponentUtils.getAttribute(component,
Attributes.pagingTarget);
- if (target == null) {
-final Map map =
facesContext.getExternalContext().getRequestParameterMap();
-final Object value = map.get(clientId);
-try {
- target = Integer.parseInt((String) value);
-} catch (final NumberFormatException e) {
- LOG.error("Can't parse integer value for action " +
action.name() + ": " + value);
- break;
-}
- }
- ((PageActionEvent) event).setValue(target);
- break;
-case sort:
- final UIColumn column = (UIColumn) component.getParent();
- final UIData data = (UIData) column.getParent();
- event = new SortActionEvent(data, column);
- break;
-default:
- LOG.error("Unknown action '{}' found!", action);
- }
- component.queueEvent(event);
-}
- }
}
diff --git
a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.j
[jira] [Commented] (TOBAGO-1589) Sorting in sheet work not with Mojarra 2.0
[ https://issues.apache.org/jira/browse/TOBAGO-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380912#comment-16380912 ] Hudson commented on TOBAGO-1589: FAILURE: Integrated in Jenkins build Tobago Trunk #1310 (See [https://builds.apache.org/job/Tobago%20Trunk/1310/]) TOBAGO-1589 sheet paging and sorting mojarra fix (bommel: rev 36c414463c017578284388a1f61658725bf47968) * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetPageCommandRenderer.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java TOBAGO-1589 sheet paging and sorting mojarra fix fixed checkstyle errors (bommel: rev a6bb8531b9ec1c9eb44e3255b921d14faf0478db) * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java TOBAGO-1589 sheet paging and sorting mojarra fix more fixes for mojarra (bommel: rev 08b34be623cdae2811ae140b8a5c4e92a897e402) * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java * (edit) tobago-tool/tobago-tool-apt/src/main/resources/org/apache/myfaces/tobago/apt/component.stg > Sorting in sheet work not with Mojarra 2.0 > -- > > Key: TOBAGO-1589 > URL: https://issues.apache.org/jira/browse/TOBAGO-1589 > Project: MyFaces Tobago > Issue Type: Bug > Components: Themes >Affects Versions: 2.0.9, 3.0.0-alpha-4 >Reporter: Udo Schnurpfeil >Assignee: Bernd Bohmann >Priority: Minor > Fix For: 4.1.1 > > > There is still a problem with Mojarra 2.0. > With Mojarra 2.1 this is fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (TOBAGO-1865) The style tag is rendered as an empty row in dropdown menus
Henning Noeth created TOBAGO-1865:
-
Summary: The style tag is rendered as an empty row in dropdown
menus
Key: TOBAGO-1865
URL: https://issues.apache.org/jira/browse/TOBAGO-1865
Project: MyFaces Tobago
Issue Type: Bug
Components: Core
Affects Versions: 4.1.0
Reporter: Henning Noeth
Example:
{code:xml}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [VOTE] release of MyFaces Core 2.3.0
Hi Eduardo, thanks for building the release. I plan to check it on the weekend. Sorry for the delay... Cheers Dennis
