[GitHub] jtulach commented on issue #2: Add Automatic-Module-Name attribute to manifest files
jtulach commented on issue #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2#issuecomment-343644018 Hello David. You mention JUnit: from there it is just a step to TDD. I believe TDD is a great way to balance ability to donate patches with the burden of their maintenance. All I am asking for (at minimal level) is to follow TDD: e.g. Have a test with your change. Any kind of (automated) test will do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Lombok (and perhaps other broken annotation processors) makes Netbeans nuts.
The issue mentions IntelliJ IDEA being also broken so it seems like a general Lombok problem, not something NetBeans specific. Are you using an Ant or a Maven project? Did you disable Compile On Save from the project settings (as I assume this might impact Lombok postprocessing)? --emi > Original Message >Subject: Lombok (and perhaps other broken annotation processors) makes >Netbeans nuts. >Local Time: November 10, 2017 8:49 PM >UTC Time: November 10, 2017 6:49 PM >From: victorwssi...@gmail.com >To: dev@netbeans.incubator.apache.org > >I am an user (not a dev) of Lombok, and I'm facing issues with using Lombok > in Netbeans. > > Currently, lombok do not works (at least for me) with Netbeans if using > Java 9. It does seem to work when I compile it by using Gradle at the > command line. See this: > >https://github.com/rzwitserloot/lombok/issues/1435 > > Also, if lombok, when doing its back-magic annotation processing is able to > mess up netbeans, so something else would probably also be. Although the > lombok guys will eventually fix this issue on their side and even if it is > unfeasible to handle every case of a broken annotation processor messing > with the IDE for whichever reason, Netbeans should at least try to handle > this issue graciously. > > Victor Williams Stafusa da Silva
[GitHub] junichi11 commented on issue #264: Check whether line endings are LF with Travis CI
junichi11 commented on issue #264: Check whether line endings are LF with Travis CI URL: https://github.com/apache/incubator-netbeans/pull/264#issuecomment-343635498 @geertjanw Thanks a lot for your review! Jan is working on #269. So I'll fix `.travis.yml` again after Jan's changes are merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] junichi11 commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?
junichi11 commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343635104 > Unfortunately, I don't know how to test the Travis build without having a pull request open. @jlahoda Why not enable Travis CI in your repository(https://github.com/jlahoda/incubator-netbeans) when you need it(It can be disabled/enabled easily)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dschoorl commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files
dschoorl commented on a change in pull request #2: Add Automatic-Module-Name
attribute to manifest files
URL:
https://github.com/apache/incubator-netbeans-html4j/pull/2#discussion_r150360512
##
File path: pom.xml
##
@@ -327,6 +327,7 @@
org.netbeans.html.boot.impl:org.netbeans.html.boot.fx:org.netbeans.html.context.
${publicPackages},META-INF.services.*;-noimport:=true;-split-package:=first
${bundleSymbolicName}
+
${bundleSymbolicName}
Review comment:
Hi Jaroslav,
This change is meant only to provide stable automatic module names in case
users will use this as a dependency in their JDK9 application, anticipating on
making the code modular later on. It appears to me that you want to expand this
scope. That's fine, but not trivial and not what I signed up for.
I have very limited time and I have no experience with osgi, felix or
html4j. So I don't think I am the right guy for the tasks you are asking.
I am not sure what is tested with the integration tests you request. Would
those not test the workings of Java9 and / or the maven-bundle-plugin? I think
such a test is a lot of effort (for me to do, given my experience) in relation
to this change. I rather spend my time on E.g. the re-licensing or JUnit5
support or something for Netbeans IDE.
Kind regards,
Dave
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jtulach commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files
jtulach commented on a change in pull request #2: Add Automatic-Module-Name
attribute to manifest files
URL:
https://github.com/apache/incubator-netbeans-html4j/pull/2#discussion_r150342117
##
File path: pom.xml
##
@@ -327,6 +327,7 @@
org.netbeans.html.boot.impl:org.netbeans.html.boot.fx:org.netbeans.html.context.
${publicPackages},META-INF.services.*;-noimport:=true;-split-package:=first
${bundleSymbolicName}
+
${bundleSymbolicName}
Review comment:
OK, we have a new attribute in `MANIFEST.MF` file. However I'd like to see a
test (e.g. example) what this is good for.
Please note that there is also `Export-Package` attribute. If we really want
to support JDK9, then we shall `export` these packages and make the rest
inaccessible. Can you modify the build script to also properly specify exported
packages?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?
jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343593703 @geertjanw - please don't merge yet, the original failure was intentional, the new one is not, need to figure out how this all should work. (I'll remove the [work-in-progress] when it seems good. (Unfortunately, I don't know how to test the Travis build without having a pull request open.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[VOTE] Release Apache NetBeans HTML/Java API version 1.5.1
Dear members of Apache NetBeans community. I've prepared a bugfix release of HTML/Java API. It is available as build #20 at https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-html4j-release/20/ The above URL contains the ZIP file with sources, its MD5 and SHA1 checksum files and content of the .asc file. The list of changes made since version 1.5 can be found here: https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-html4j-release/20/changes It contains licensing related fixes (JSON library change and #98) as well as essential functionality fixes (bug #99 - the cause of random test failures of previous version 1.5) I've done the basic testing on Linux and Mac, as well as I tried to use the version 1.5.1 in Bck2Brwsr VM (works fine). I believe the new version of HTML/Java API is releasable at this point. Please take the ZIP file for a spin and vote to approve the release and to request the approval of the Incubator PMC to publish it on our site. Everyone is encouraged to vote, including non-committers. This vote shall close in the usual 72 hours. -jt PS:
[GitHub] geertjanw commented on issue #264: Check whether line endings are LF with Travis CI
geertjanw commented on issue #264: Check whether line endings are LF with Travis CI URL: https://github.com/apache/incubator-netbeans/pull/264#issuecomment-343586187 +1 looks good to me. Would be good if someone else reviewed this too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] geertjanw commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?
geertjanw commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343584533 Ironically, the Travis build failed, can I merge this one anyway? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jlahoda opened a new pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?
jlahoda opened a new pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269 ?-and-licenses failures. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Lombok (and perhaps other broken annotation processors) makes Netbeans nuts.
I am an user (not a dev) of Lombok, and I'm facing issues with using Lombok in Netbeans. Currently, lombok do not works (at least for me) with Netbeans if using Java 9. It does seem to work when I compile it by using Gradle at the command line. See this: https://github.com/rzwitserloot/lombok/issues/1435 Also, if lombok, when doing its back-magic annotation processing is able to mess up netbeans, so something else would probably also be. Although the lombok guys will eventually fix this issue on their side and even if it is unfeasible to handle every case of a broken annotation processor messing with the IDE for whichever reason, Netbeans should at least try to handle this issue graciously. Victor Williams Stafusa da Silva
[GitHub] ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore
ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore URL: https://github.com/apache/incubator-netbeans/pull/252#issuecomment-343466528 connect to NETBEANS-134 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jlahoda commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.
jlahoda commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343462476 Uh, I thought Rat excludes "notices", but apparently is doing so based on filenames (and these filenames are not as expected). So yes, I guess these need to be excluded from Rat. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates
junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-343459163 @sarveshkesharwani Great to hear. We can merge your change without problems after you send it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] junichi11 commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.
junichi11 commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343457986 @jlahoda It seems that there is no license header in README-bin.txt and README-src.txt. Should these be excluded from rat? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JaroslavTulach commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo?
JaroslavTulach commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo? URL: https://github.com/apache/incubator-netbeans/pull/265#issuecomment-343432251 Nicely done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343432026 The shortcut is set here: https://github.com/apache/incubator-netbeans/pull/1/commits/67bdd60109474c543c010d3f818cfb36abb9c0c9#r150193869 The functionality is still there, if you right click on an editor tab -> Split -> Vertically. So I decoupled the functionality from https://github.com/apache/incubator-netbeans/pull/3/commits/5dc272ebffd95dfd55720ebfdd697d8ff319c862#diff-c2b5538f4bdcf56983c605aebf73887a and created new classes for each action to set the ActionReference. Now you can use the functionality like before via Right click on editor tab -> Split -> Vertically OR you can use the shortcut, which I set to Ctrl + Alt + Shift + V or you can set your own. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JaroslavTulach commented on issue #268: Run verify libs and licenses and rat for platform for pull requests
JaroslavTulach commented on issue #268: Run verify libs and licenses and rat for platform for pull requests URL: https://github.com/apache/incubator-netbeans/pull/268#issuecomment-343430969 Excellent. I believe we shall add more and more tests of the platform once we stabilize them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Chris2011 commented on a change in pull request #1: Feature/248233 - Shortcuts for document splitting
Chris2011 commented on a change in pull request #1: Feature/248233 - Shortcuts
for document splitting
URL: https://github.com/apache/incubator-netbeans/pull/1#discussion_r150193869
##
File path:
core.multiview/src/org/netbeans/core/multiview/actions/SplitDocumentVerticallyAction.java
##
@@ -0,0 +1,88 @@
+/*
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+ *
+ * Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved.
+ *
+ * Oracle and Java are registered trademarks of Oracle and/or its affiliates.
+ * Other names may be trademarks of their respective owners.
+ *
+ * The contents of this file are subject to the terms of either the GNU
+ * General Public License Version 2 only ("GPL") or the Common
+ * Development and Distribution License("CDDL") (collectively, the
+ * "License"). You may not use this file except in compliance with the
+ * License. You can obtain a copy of the License at
+ * http://www.netbeans.org/cddl-gplv2.html
+ * or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
+ * specific language governing permissions and limitations under the
+ * License. When distributing the software, include this License Header
+ * Notice in each file and include the License file at
+ * nbbuild/licenses/CDDL-GPL-2-CP. Oracle designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Oracle in the GPL Version 2 section of the License file that
+ * accompanied this code. If applicable, add the following below the
+ * License Header, with the fields enclosed by brackets [] replaced by
+ * your own identifying information:
+ * "Portions Copyrighted [year] [name of copyright owner]"
+ *
+ * If you wish your version of this file to be governed by only the CDDL
+ * or only the GPL Version 2, indicate your decision by adding
+ * "[Contributor] elects to include this software in this distribution
+ * under the [CDDL or GPL Version 2] license." If you do not indicate a
+ * single choice of license, a recipient has the option to distribute
+ * your version of this file under either the CDDL, the GPL Version 2 or
+ * to extend the choice of license to its licensees as provided above.
+ * However, if you add GPL Version 2 code and therefore, elected the GPL
+ * Version 2 license, then the option applies only if the new code is
+ * made subject to such option by the copyright holder.
+ *
+ * Contributor(s):
+ */
+package org.netbeans.core.multiview.actions;
+
+import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
+import javax.swing.Action;
+import javax.swing.JSplitPane;
+import org.openide.awt.ActionID;
+import org.openide.awt.ActionReference;
+import org.openide.awt.ActionRegistration;
+import org.openide.util.NbBundle;
+import org.openide.windows.TopComponent;
+import org.openide.windows.WindowManager;
+
+/**
+ *
+ * @author Chris2011
+ */
+@ActionID(
+category = "Tools",
+id = "org.netbeans.core.multiview.SplitDocumentVerticallyAction"
+)
+@ActionRegistration(
+displayName = "#LBL_ValueSplitVertical"
+)
+@ActionReference(path = "Shortcuts", name = "DOS-V")
Review comment:
Added shortcut
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] geertjanw closed pull request #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.
geertjanw closed pull request #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/nbbuild/build.xml b/nbbuild/build.xml index 0b55f9489..4af0e1ec2 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -295,6 +295,7 @@ + @@ -1505,8 +1506,11 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d + + + @@ -1552,6 +1556,9 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d + + + @@ -1566,6 +1573,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d + diff --git a/o.n.bootstrap/readme/README-bin.txt b/o.n.bootstrap/readme/README-bin.txt new file mode 100644 index 0..7a9676a72 --- /dev/null +++ b/o.n.bootstrap/readme/README-bin.txt @@ -0,0 +1,7 @@ +This is a NetBeans Plaform binary build. + +JavaHelp note: JavaHelp is not distributed in this build. +If your application needs it, you may need to supply it +using -Djhall.jar=. At runtime, you may need to supply it using +--cp:a diff --git a/o.n.bootstrap/readme/README-src.txt b/o.n.bootstrap/readme/README-src.txt new file mode 100644 index 0..96573dadf --- /dev/null +++ b/o.n.bootstrap/readme/README-src.txt @@ -0,0 +1,3 @@ +This is a NetBeans Platform source zip. + +To build the NetBeans Platform, run "ant". The built platform will be in nbbuild/netbeans. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] geertjanw commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.
geertjanw commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343401546 Looks good, merging, will work on the content in the readmes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
