Re: website: PMC members also listed as committers?
Marton,
Thanks for raising the question and implementing the solution!
Regards,
David Handermann
On Thu, Feb 22, 2024 at 12:14 PM Marton Szasz wrote:
>
> Hi Joe, and anyone interested,
>
> I initially didn't look at the code, just wanted to confirm that it
> wasn't a conscious decision. Your first reply encouraged me to take a
> look at the code, and it seems the change in the committer list was
> probably just a side effect of dynamically fetching the nifi group
> members from Apache. I agree that it's a nice change to no longer have
> to update the list manually, except for this small issue.
>
> After some digging in the Hugo docs, the change wasn't too difficult to
> make, so I submitted a pull request to exclude PMC members from the
> committer list: https://github.com/apache/nifi-site/pull/83
>
> Thanks,
> Marton
>
> On 2/21/24 21:35, Joe Witt wrote:
> > For anyone interested in improving the logic here is where the page lives:
> >
> > https://github.com/apache/nifi-site/blob/main/content/community/_index.md
> >
> > It utilizes this directive/entry such as
> > {{< project-members project="nifi" >}}
> >
> > That is powered by a short-code in hugo terms (I'm told) which can be found
> > here
> > https://github.com/apache/nifi-site/blob/main/themes/nifi/layouts/shortcodes/project-members.html
> >
> > That short-code leverages information which is found in
> > https://github.com/apache/nifi-site/blob/main/config.toml
> > on lines 31 and 32.
> >
> > Perhaps the solution is to improve the logic of the short-code such that it
> > allows a second argument such as 'exclude-project' which might look like
> > {{< project-members project="nifi" exclude-project="nifi-pmc">}}
> >
> > Then update the short code such that if the second argument is provided we
> > remove names in the 'nifi' list that are also in the 'nifi-pmc' list.
> >
> > Not sure what mechanisms/etc.. are available but this should give anyone
> > motivated good context to work with.
> >
> > Thanks
> >
> > On Wed, Feb 21, 2024 at 1:18 PM Joe Witt wrote:
> >
> >> Marton
> >>
> >> I wasn't sure why so I checked the source [1] and found a very nice
> >> improvement which is the page is now dynamically generated reflecting our
> >> actual membership/roster in ASF records. So people don't need to mess with
> >> this anymore which is great.
> >>
> >> It is duplicative between PMC and Committership listing and ideally we
> >> only show the delta since being a PMC member implies committership. I'm
> >> sure someone could improve that logic to only list the committers.
> >>
> >> [1]
> >> https://github.com/apache/nifi-site/blob/main/content/community/_index.md
> >>
> >> On Wed, Feb 21, 2024 at 10:17 AM Marton Szasz wrote:
> >>
> >>> Hi all,
> >>>
> >>> I just noticed that on the people page of the nifi website, PMC members
> >>> are also listed under committers. This seems to be a recent change,
> >>> maybe since the redesign?
> >>>
> >>> Old website without name duplication:
> >>>
> >>> https://web.archive.org/web/20231208050808/https://nifi.apache.org/people.html
> >>> New website with name duplication:https://nifi.apache.org/community/
> >>>
> >>> Is this change intentional? If so, why? I find it a bit confusing.
> >>>
> >>> Thanks,
> >>> Marton
> >>>
> >>>
Re: website: PMC members also listed as committers?
Hi Joe, and anyone interested,
I initially didn't look at the code, just wanted to confirm that it
wasn't a conscious decision. Your first reply encouraged me to take a
look at the code, and it seems the change in the committer list was
probably just a side effect of dynamically fetching the nifi group
members from Apache. I agree that it's a nice change to no longer have
to update the list manually, except for this small issue.
After some digging in the Hugo docs, the change wasn't too difficult to
make, so I submitted a pull request to exclude PMC members from the
committer list: https://github.com/apache/nifi-site/pull/83
Thanks,
Marton
On 2/21/24 21:35, Joe Witt wrote:
For anyone interested in improving the logic here is where the page lives:
https://github.com/apache/nifi-site/blob/main/content/community/_index.md
It utilizes this directive/entry such as
{{< project-members project="nifi" >}}
That is powered by a short-code in hugo terms (I'm told) which can be found
here
https://github.com/apache/nifi-site/blob/main/themes/nifi/layouts/shortcodes/project-members.html
That short-code leverages information which is found in
https://github.com/apache/nifi-site/blob/main/config.toml
on lines 31 and 32.
Perhaps the solution is to improve the logic of the short-code such that it
allows a second argument such as 'exclude-project' which might look like
{{< project-members project="nifi" exclude-project="nifi-pmc">}}
Then update the short code such that if the second argument is provided we
remove names in the 'nifi' list that are also in the 'nifi-pmc' list.
Not sure what mechanisms/etc.. are available but this should give anyone
motivated good context to work with.
Thanks
On Wed, Feb 21, 2024 at 1:18 PM Joe Witt wrote:
Marton
I wasn't sure why so I checked the source [1] and found a very nice
improvement which is the page is now dynamically generated reflecting our
actual membership/roster in ASF records. So people don't need to mess with
this anymore which is great.
It is duplicative between PMC and Committership listing and ideally we
only show the delta since being a PMC member implies committership. I'm
sure someone could improve that logic to only list the committers.
[1]
https://github.com/apache/nifi-site/blob/main/content/community/_index.md
On Wed, Feb 21, 2024 at 10:17 AM Marton Szasz wrote:
Hi all,
I just noticed that on the people page of the nifi website, PMC members
are also listed under committers. This seems to be a recent change,
maybe since the redesign?
Old website without name duplication:
https://web.archive.org/web/20231208050808/https://nifi.apache.org/people.html
New website with name duplication:https://nifi.apache.org/community/
Is this change intentional? If so, why? I find it a bit confusing.
Thanks,
Marton
Re: Block start/stop processors
Isha, Wait, by "lefthand toolbox" are you referring to the process group's toolbar start button or to the start button in the pallet at the upper left of the page? Please clarify. Thanks On 2/22/24 04:39, Isha Lamboo wrote: always use the right-click context menu on a process group you want to stop/start and never use the button in the lefthand toolbox. Right-clicking the PG also selects it, so you don't have the risk of clicking stop with no selection.
RE: Block start/stop processors
Hi Alexandra, The workaround we use is to always use the right-click context menu on a process group you want to stop/start and never use the button in the lefthand toolbox. Right-clicking the PG also selects it, so you don't have the risk of clicking stop with no selection. Removing the operate permission on the main canvas and adding it to all process groups is probably the real solution, but a lot of work indeed. Regards, Isha -Oorspronkelijk bericht- Van: alexandru.d...@orange.com Verzonden: dinsdag 20 februari 2024 10:41 Aan: dev@nifi.apache.org Onderwerp: Block start/stop processors [You don't often get email from alexandru.d...@orange.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello! My name is Alexandru Duță and I am working at Orange Services Romania. We are actively using Apache NiFi in our projects and we have a problem that we want to avoid in the future. We think that you can help us with that. It happened for us (the admins), by mistake, to start/stop all the processors from the NiFi root page, and because we have over 5000 processors in our projects, this bring us a lot of difficulties. Is there a way to block this kind of requests? We don’t want to do that through the permissions, because how I said, we are admins. We were thinking is there is a possibility of a pop-up page to be displayed when this is happening, that will ask for our confirmation or if we can block those nifi-api requests. Thank you in advance for your answer! Best regards, Alexandru Duță Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
