[GitHub] [incubator-nlpcraft] syermakov commented on pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models
syermakov commented on pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-625923342 @Ifropc Thank you very much for sharing, this feature looks very promising! I would suggest the following improvements: - Add Apache license header to all files - Use `logging` module instead of the `print` function - Do we need matplotlib-related functions (`mk_graph`, etc) in `bertft.py`, isn't it better to move them directly to jupiter notebook? - May be rename `enricher` folder to `syn_enricher` (just a proposal, ideas?) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [GitHub] [incubator-nlpcraft] Ifropc opened a new pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models
Hi Gleb, thank you very much for your contribution, it looks really promising! Regards, Sergey On Fri, May 8, 2020 at 6:52 PM Ifropc wrote: > > Hello everybody! > > I created a pull request for implementing auto-enriching user models with > synonyms (NLPCRAFT-11), please see details in PR on Github. > > Comments are appreciated, if any. > > Thanks, > Gleb. > > ‐‐‐ Original Message ‐‐‐ > On Thursday, May 7, 2020 11:19 PM, GitBox g...@apache.org wrote: > > Ifropc opened a new pull request #1: > URL: https://github.com/apache/incubator-nlpcraft/pull/1 > This pull request should resolve NLPCRAFT-11: auto-enrich user models > with synonyms > Proposed approach uses Bert (RoBerta) model to generate synonyms for > given context, masking target word. Afterwards, output is filtered with > FastTest for specified context. > This feature could also be integrated with NLPCRAFT-41 > > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > >
Re: [GitHub] [incubator-nlpcraft] Ifropc opened a new pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models
Hello everybody! I created a pull request for implementing auto-enriching user models with synonyms (NLPCRAFT-11), please see details in PR on Github. Comments are appreciated, if any. Thanks, Gleb. ‐‐‐ Original Message ‐‐‐ On Thursday, May 7, 2020 11:19 PM, GitBox g...@apache.org wrote: Ifropc opened a new pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1 This pull request should resolve NLPCRAFT-11: auto-enrich user models with synonyms Proposed approach uses Bert (RoBerta) model to generate synonyms for given context, masking target word. Afterwards, output is filtered with FastTest for specified context. This feature could also be integrated with NLPCRAFT-41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NLPCRAFT-11) We need to auto-enrich user models with synonyms from WordNet.
[ https://issues.apache.org/jira/browse/NLPCRAFT-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NLPCRAFT-11: --- Labels: pull-request-available (was: ) > We need to auto-enrich user models with synonyms from WordNet. > -- > > Key: NLPCRAFT-11 > URL: https://issues.apache.org/jira/browse/NLPCRAFT-11 > Project: NLPCraft > Issue Type: New Feature > Components: server >Reporter: Aaron Radzinski >Assignee: Sergey Makov >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-nlpcraft] Ifropc opened a new pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models
Ifropc opened a new pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1 This pull request should resolve [NLPCRAFT-11: auto-enrich user models with synonyms](https://issues.apache.org/jira/projects/NLPCRAFT/issues/NLPCRAFT-11?filter=allopenissues) Proposed approach uses Bert (RoBerta) model to generate synonyms for given context, masking target word. Afterwards, output is filtered with FastTest for specified context. This feature could also be integrated with [NLPCRAFT-41](https://issues.apache.org/jira/projects/NLPCRAFT/issues/NLPCRAFT-41?filter=allopenissues) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
