syermakov commented on pull request #1:
URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-625923342


   @Ifropc Thank you very much for sharing, this feature looks very promising! 
   
   I would suggest the following improvements:
    - Add Apache license header to all files
    - Use `logging` module instead of the `print` function 
    - Do we need matplotlib-related functions (`mk_graph`, etc) in `bertft.py`, 
isn't it better to move them directly to jupiter notebook?
    - May be rename `enricher` folder to `syn_enricher` (just a proposal, 
ideas?)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to