[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #5962: arch/riscv: Rename SCRATCH_HARTID_OFFSET to RISCV_HARTID_OFFSET

[GitBox]

xiaoxiang781216 commented on code in PR #5962:
URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841350940


##
arch/risc-v/src/common/riscv_percpu.h:
##
@@ -38,10 +38,11 @@
  * Pre-processor Definitions
  /
 
-#ifdef __ASSEMBLY__
-#define SCRATCH_HARTID_OFFSET   (0 * INT_REG_SIZE)
-#else
-#define SCRATCH_HARTID_OFFSET   offsetof(riscv_percpu_s, hartid)
+#define RISCV_PERCPU_HARTID_OFFSET   (0 * INT_REG_SIZE)
+
+#ifndef __ASSEMBLY__
+static_assert(RISCV_PERCPU_HARTID_OFFSET == offsetof(riscv_percpu_s, hartid),

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5962: arch/riscv: Rename SCRATCH_HARTID_OFFSET to RISCV_HARTID_OFFSET

[GitBox]

pkarashchenko commented on code in PR #5962:
URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841283611


##
arch/risc-v/src/common/riscv_percpu.h:
##
@@ -38,10 +38,11 @@
  * Pre-processor Definitions
  /
 
-#ifdef __ASSEMBLY__
-#define SCRATCH_HARTID_OFFSET   (0 * INT_REG_SIZE)
-#else
-#define SCRATCH_HARTID_OFFSET   offsetof(riscv_percpu_s, hartid)
+#define RISCV_PERCPU_HARTID_OFFSET   (0 * INT_REG_SIZE)
+
+#ifndef __ASSEMBLY__
+static_assert(RISCV_PERCPU_HARTID_OFFSET == offsetof(riscv_percpu_s, hartid),

Review Comment:
   I think we need to move static assert to C file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

liuguo09 commented on issue #17: Add Dockerfile for CI system and hook into 
GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#issuecomment-602171894
 
 
   > @liuguo09 Sorry it took me so long to get this together after I pointed 
you at my proof of concept. I was trying to get some extra build caching things 
done with it via Github Actions but it seems there docker registry does not 
support it. I still have some basic cache enabled that will only be used if the 
registry starts supporting it in the future, otherwise it just warns and moves 
on with the build.
   
   @btashton Thanks for your great work. As to the caching things, we could 
refine them later once supported by github docker registry. When this PR merged 
and the new docker image available, we could replace my own 
liuguo09/ubuntu-nuttx docker to make the CI more official and efficient : )


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

liuguo09 commented on a change in pull request #17: Add Dockerfile for CI 
system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396072819
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,58 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
+  push:
+# Publish `master` as Docker `latest` image.
+branches:
+  - master
+paths:
+  - 'docker/**'
+
+  # Run builds for any PRs.
+  pull_request:
+paths:
+  - 'docker/**'
+
+env:
+  # TODO: Change variable to your image's name.
+  IMAGE_NAME: nuttx-ci-linux
+
+jobs:
+  # Push image to GitHub Packages.
+  push:
+runs-on: ubuntu-latest
+env:
+  DOCKER_BUILDKIT: 1
+  IMAGE_TAG: docker.pkg.github.com/${{ github.repository }}/nuttx-ci-linux
+steps:
+  - uses: actions/checkout@v2
+
+  - name: Log into registry
+run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login 
docker.pkg.github.com -u ${{ github.actor }} --password-stdin
 
 Review comment:
   Does github.actor and secrets token settings already ready for testing repo?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #18: Configure python environment and install esptool

[GitBox]

xiaoxiang781216 commented on issue #18: Configure python environment and 
install esptool
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/18#issuecomment-602170823
 
 
   > @xiaoxiang781216 Will this suffice to fix 
[437](https://github.com/apache/incubator-nuttx/pull/437) ?
   > The POSTBUILD script also copies the bootloader and the partition table 
from the IDF directory.
   
   Yes, I thinks so.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

liuguo09 commented on a change in pull request #17: Add Dockerfile for CI 
system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396072392
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,58 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
+  push:
+# Publish `master` as Docker `latest` image.
+branches:
+  - master
+paths:
+  - 'docker/**'
+
+  # Run builds for any PRs.
+  pull_request:
+paths:
+  - 'docker/**'
 
 Review comment:
   I'm not very familiar with github action. Does github action support 
multiple workflows for testing repo, here docker_linux.yml and later 
docker_windows.yml?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] Ouss4 commented on issue #18: Configure python environment and install esptool

[GitBox]

Ouss4 commented on issue #18: Configure python environment and install esptool
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/18#issuecomment-602169680
 
 
   @xiaoxiang781216 Will this suffice to fix 
[437](https://github.com/apache/incubator-nuttx/pull/437) ?
   The POSTBUILD script also copies the bootloader and the partition table from 
the IDF directory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on issue #17: Add Dockerfile for CI system and hook 
into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#issuecomment-602163664
 
 
   https://github.com/apache/incubator-nuttx/pull/437


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #18: Configure python environment and install esptool

[GitBox]

xiaoxiang781216 commented on a change in pull request #18: Configure python 
environment and install esptool
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/18#discussion_r396066270
 
 

 ##
 File path: cibuild.sh
 ##
 @@ -118,6 +123,7 @@ function xtensa-esp32-gcc-toolchain {
 rm xtensa-esp32-elf-gcc8_2_0-esp32-2019r1-rc2-linux-amd64.tar
   fi
   xtensa-esp32-elf-gcc --version
+  pip install esptool
 
 Review comment:
   can we check some file doesn't exist before install esptool like we check 
$prebuilt/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #18: Configure python environment and install esptool

[GitBox]

xiaoxiang781216 commented on a change in pull request #18: Configure python 
environment and install esptool
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/18#discussion_r396066155
 
 

 ##
 File path: cibuild.sh
 ##
 @@ -24,6 +24,11 @@ apps=$WD/../apps
 tools=$WD/../tools
 prebuilt=$WD/../prebuilt
 
+# Python User Env
+PIP_USER=yes
+PYTHONUSERBASE=$WD/../pylocal
 
 Review comment:
   How about change the path to:
   PYTHONUSERBASE=$prebuilt/pylocal
   like other tools


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396065947
 
 

 ##
 File path: docker/linux/Dockerfile
 ##
 @@ -0,0 +1,153 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+FROM ubuntu:19.04 AS builder-base
+# NOTE WE ARE NOT REMOVEING APT CACHE.
+# This should only be used for temp build images that artifacts will be copied 
from
+RUN apt-get update -qq && apt-get install -y -qq \
+  curl \
+  xz-utils
+
+###
+# Base image that should be used to prepare tools from nuttx-tools
+###
+FROM builder-base AS nuttx-tools
+
+RUN apt-get install -y -qq \
+  flex \
+  bison \
+  gperf \
+  libncurses5-dev \
+  make 
+
+RUN mkdir /tools
+WORKDIR /tools
+
+RUN mkdir -p /tools/nuttx-tools
+RUN curl -s -L https://bitbucket.org/nuttx/tools/get/9ad3e1ee75c7.tar.gz \
+  | tar -C nuttx-tools --strip-components=1 -xz
+
+RUN cd nuttx-tools/kconfig-frontends \
+  && ./configure --enable-mconf --disable-gconf --disable-qconf 
--enable-static --prefix=/tools/kconfig-frontends \
+  && make install
+
+RUN cd nuttx-tools \
+  && mkdir genromfs \
+  && tar -C genromfs --strip-components=1 -xf genromfs-0.5.2.tar.gz \
+  && cd genromfs \
+  && make install PREFIX=/tools/genromfs
+
+CMD [ "/bin/bash" ]
+
+###
+# Base image that should be used to prepare arch build images
+###
+FROM builder-base AS nuttx-toolchain-base
+
+RUN mkdir /tools
+WORKDIR /tools
+
+###
+# Build image for tool required by ARM builds
+###
+FROM nuttx-toolchain-base AS nuttx-toolchain-arm
+# Download the latest ARM GCC toolchain prebuilt by ARM
+RUN mkdir gcc-arm-none-eabi && \
+  curl -s -L  
"https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/gcc-arm-none-eabi-9-2019-q4-major-x86_64-linux.tar.bz2?revision=108bd959-44bd-4619-9c19-26187abf5225=en=E788CE92E5DFD64B2A8C246BBA91A249CB8E2D2D;
 \
+  | tar -C gcc-arm-none-eabi --strip-components 1 -xj
+
+###
+# Build image for tool required by Pinguino builds
+###
+FROM nuttx-toolchain-base AS nuttx-toolchain-pinguino
+# Download the pinguino compilers. Note this includes both 8bit and 32bit
+# toolchains and builds for multiple host systems. Only copy what is needed.
+RUN mkdir pinguino-compilers && \
+  curl -s -L 
"https://github.com/PinguinoIDE/pinguino-compilers/archive/62db5158d7f6d41c6fadb05de81cc31dd81a1958.tar.gz;
 \
+  | tar -C pinguino-compilers --strip-components=2 --wildcards -xz */linux64
+
+###
+# Build image for tool required by RISCV builds
+###
+FROM nuttx-toolchain-base AS nuttx-toolchain-riscv
+# Download the latest RISCV GCC toolchain prebuilt by SiFive
+RUN mkdir riscv64-unknown-elf-gcc && \
+  curl -s -L 
"https://static.dev.sifive.com/dev-tools/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14.tar.gz;
 \
+  | tar -C riscv64-unknown-elf-gcc --strip-components 1 -xz
+
+###
+# Build image for tool required by ESP32 builds
+###
+FROM nuttx-toolchain-base AS nuttx-toolchain-esp32
+# Download the latest ESP32 GCC toolchain prebuilt by Espressif
+RUN mkdir xtensa-esp32-elf-gcc && \
+  curl -s -L 
"https://dl.espressif.com/dl/xtensa-esp32-elf-gcc8_2_0-esp32-2019r1-rc2-linux-amd64.tar.xz;
 \
+  | tar -C xtensa-esp32-elf-gcc --strip-components 1 -xJ
+
+

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396065709
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,58 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
+  push:
+# Publish `master` as Docker `latest` image.
+branches:
+  - master
+paths:
+  - 'docker/**'
+
+  # Run builds for any PRs.
+  pull_request:
+paths:
+  - 'docker/**'
 
 Review comment:
   Should we change to docker/linux/**?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396065702
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,58 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
+  push:
+# Publish `master` as Docker `latest` image.
+branches:
+  - master
+paths:
+  - 'docker/**'
 
 Review comment:
   Should we change to docker/linux/**?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton opened a new pull request #18: Configure python environment and install esptool

[GitBox]

btashton opened a new pull request #18: Configure python environment and 
install esptool
URL: https://github.com/apache/incubator-nuttx-testing/pull/18
 
 
   This configures a the python user installation environment and then installs 
the `esptool` dependency.  Should resolve the nightly build issue and enable us 
to more easily install python dependencies in the ci scripts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056621
 
 

 ##
 File path: docker/linux/Dockerfile
 ##
 @@ -0,0 +1,151 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   Ok, understand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

btashton commented on a change in pull request #17: Add Dockerfile for CI 
system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056574
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,54 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
 
 Review comment:
   Just kicked off a build with this condition, should be good, but a little 
hard to test until the first action is merged into this repo


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

btashton commented on a change in pull request #17: Add Dockerfile for CI 
system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056440
 
 

 ##
 File path: docker/linux/Dockerfile
 ##
 @@ -0,0 +1,151 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+FROM ubuntu:19.04 AS builder-base
+# NOTE WE ARE NOT REMOVEING APT CACHE.
+# This should only be used for temp build images that artifacts will be copied 
from
+RUN apt-get update -qq && apt-get install -y -qq \
+  curl \
+  xz-utils
+
+FROM builder-base AS nuttx-tools
+
+RUN apt-get install -y -qq \
+  curl \
 
 Review comment:
   Good catch. Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

btashton commented on a change in pull request #17: Add Dockerfile for CI 
system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056207
 
 

 ##
 File path: docker/linux/Dockerfile
 ##
 @@ -0,0 +1,151 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   Changing the name from `Dockerfile` is actually kind of annoying for some 
clients like `buildctl` which will actually build this faster, also it breaks 
syntax highlighting since there is no known extension, just a filename standard.
   
   It also gives us a folder for OS specific assets that might want to be 
included which might be nice.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

xiaoxiang781216 commented on issue #13: docker: initial checkin Dockerfile for 
nuttx github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-602150298
 
 
   Replace by https://github.com/apache/incubator-nuttx-testing/pull/17, let 
close it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 closed pull request #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

xiaoxiang781216 closed pull request #13: docker: initial checkin Dockerfile for 
nuttx github action container
URL: https://github.com/apache/incubator-nuttx-testing/pull/13
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 closed pull request #2: Multibranch pipeline job example

[GitBox]

xiaoxiang781216 closed pull request #2: Multibranch pipeline job example
URL: https://github.com/apache/incubator-nuttx-testing/pull/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #2: Multibranch pipeline job example

[GitBox]

xiaoxiang781216 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-602150220
 
 
   Since the current ci system base on github action, let's close this now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055892
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,54 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
 
 Review comment:
   Can we tadd a condition to trigger the yml only when docker/linux/Dockerfile 
get modified.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055462
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,56 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
+  push:
+# Publish `master` as Docker `latest` image.
+branches:
+  - master
+
+  # Run builds for any PRs.
+  pull_request:
+
+env:
+  # TODO: Change variable to your image's name.
+  IMAGE_NAME: nuttx-ci-linux
+
+jobs:
+  # Push image to GitHub Packages.
+  push:
+runs-on: ubuntu-latest
+env:
+  DOCKER_BUILDKIT: 1
+  IMAGE_TAG: docker.pkg.github.com/${{ github.repository }}/nuttx-ci-linux
+steps:
+  - run: echo ${{github.ref}}
+  - run: echo ${{github.event.ref}}
+  - uses: actions/checkout@v2
+
+  - name: Log into registry
+run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login 
docker.pkg.github.com -u ${{ github.actor }} --password-stdin
+
+  - name: Build Linux image
+run: |
+  echo "Building Linux Image using cache from $IMAGE_TAG"
+
+  docker build \
+--build-arg BUILDKIT_INLINE_CACHE=1 \
+--cache-from $IMAGE_TAG \
+--tag $IMAGE_TAG \
+-f ./docker/linux/Dockerfile ./docker/
+
+  - name: Push Linux image
+if: (github.event_name == 'push') && (github.ref == 
'refs/heads/master')
+run: |
+  docker push $IMAGE_TAG
 
 Review comment:
   Add \n to avoid the red dot mark at the end of line


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055892
 
 

 ##
 File path: .github/workflows/docker_linux.yml
 ##
 @@ -0,0 +1,54 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: Docker-Linux
+
+on:
 
 Review comment:
   Can we add a condition to trigger the yml only when docker/linux/Dockerfile 
get modified.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055102
 
 

 ##
 File path: docker/linux/Dockerfile
 ##
 @@ -0,0 +1,151 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+FROM ubuntu:19.04 AS builder-base
+# NOTE WE ARE NOT REMOVEING APT CACHE.
+# This should only be used for temp build images that artifacts will be copied 
from
+RUN apt-get update -qq && apt-get install -y -qq \
+  curl \
+  xz-utils
+
+FROM builder-base AS nuttx-tools
+
+RUN apt-get install -y -qq \
+  curl \
 
 Review comment:
   remove, done by builder-base


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for 
CI system and hook into GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055526
 
 

 ##
 File path: docker/linux/Dockerfile
 ##
 @@ -0,0 +1,151 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   How about we change docker/linux/Dockerfile to docker/linux? The folder 
docker already declare that this is place to put Dockfile.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

btashton commented on issue #17: Add Dockerfile for CI system and hook into 
GitHub Actions
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/17#issuecomment-602144959
 
 
   @liuguo09 Sorry it took me so long to get this together after I pointed you 
at my proof of concept.  I was trying to get some extra build caching things 
done with it via Github Actions but it seems there docker registry does not 
support it.  I still have some basic cache enabled that will only be used if 
the registry starts supporting it in the future, otherwise it just warns and 
moves on with the build.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton opened a new pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

[GitBox]

btashton opened a new pull request #17: Add Dockerfile for CI system and hook 
into GitHub Actions
URL: https://github.com/apache/incubator-nuttx-testing/pull/17
 
 
   This is a reworking of the Docker container to be used with the GitHub 
Action CI job for github.com/apache/incubator-nuttx
   
   This should likely replace the PR #13 producing a more modular and smaller 
docker image.  This will also build the docker image on a PR, but will also 
publish it to this project only on merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] masayuki2009 commented on issue #16: Add xtensa esp32 boards build support

[GitBox]

masayuki2009 commented on issue #16: Add xtensa esp32 boards build support
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/16#issuecomment-601514544
 
 
   It looks good to me.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #16: Add xtensa esp32 boards build support

[GitBox]

xiaoxiang781216 merged pull request #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #16: Add xtensa esp32 boards build support

[GitBox]

liuguo09 commented on a change in pull request #16: Add xtensa esp32 boards 
build support
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395425971
 
 

 ##
 File path: testlist/mips-riscv-x86-xtensa.dat
 ##
 @@ -5,3 +5,5 @@
 -nr5m100-nexys4:nsh
 
 /x86
+
+/xtensa
 
 Review comment:
   You are right. Firstly enable xtensa esp32 boards build in full testlit done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support

[GitBox]

xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 
boards build support
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395423947
 
 

 ##
 File path: testlist/mips-riscv-x86-xtensa.dat
 ##
 @@ -5,3 +5,5 @@
 -nr5m100-nexys4:nsh
 
 /x86
+
+/xtensa
 
 Review comment:
   Should we move the change to:
   
https://github.com/apache/incubator-nuttx-testing/blob/master/testlist/full.dat
   since xtensa-esp32-gcc-toolchain is just used for the nightly build.
   So we can enable esp32 step by step.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support

[GitBox]

xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 
boards build support
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395423947
 
 

 ##
 File path: testlist/mips-riscv-x86-xtensa.dat
 ##
 @@ -5,3 +5,5 @@
 -nr5m100-nexys4:nsh
 
 /x86
+
+/xtensa
 
 Review comment:
   Should we move the change to:
   
https://github.com/apache/incubator-nuttx-testing/blob/master/testlist/full.dat
   since xtensa-esp32-gcc-toolchain is just used for the nightly build.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #16: Add xtensa esp32 boards build support

[GitBox]

liuguo09 commented on issue #16: Add xtensa esp32 boards build support
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/16#issuecomment-601506539
 
 
   Take care to merge the change since github action docker image and matrix 
boards should be updated synchronously.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #16: Add xtensa esp32 boards build support

[GitBox]

liuguo09 opened a new pull request #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16
 
 
   1. Add xtensa esp32 gcc toolchain
   2. Add xtensa esp32 boards into testlist
   
   Note nuttx and apps github action workflows also need update accordingly:
   1. docker image updated with xtensa toolchain firstly
   2. use 'mips-riscv-x86-xtensa'  instead of 'mips-riscv-x86' in matrix boards


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599889055
 
 
   > My plan was to use the incubator-nuttx-testing repo. I can submit a PR 
with this and the action to the repo.
   
   That's great!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton edited a comment on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

btashton edited a comment on issue #13: docker: initial checkin Dockerfile for 
nuttx github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599870749
 
 
   My plan was to use the incubator-nuttx-testing repo. I can submit a PR with 
this and the action to the repo. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599870749
 
 
   My plan was to use the incubator-nuttx-testing container. I can submit a PR 
with this and the action to the repo. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo

[GitBox]

xiaoxiang781216 merged pull request #14: cibuild.sh: switch to use the recent 
bitbucket tools repo
URL: https://github.com/apache/incubator-nuttx-testing/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599860083
 
 
   Or is it possible just using the incubator-nuttx-testing to hold dockerfile 
and do docker publish github action?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599857989
 
 
   Yes, I noticed the docker publish github aciton. It seems more flexible than 
docker hub.  If taking github package registry approach, do we need an official 
repo such as incubator-nuttx-build-contianers or use personal contianer project 
as yours is enough? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599852966
 
 
   Did you notice that the docker container is now built via actions and stored 
in the GitHub package registry? That means it would be stored in the project 
and not require docker hub. But we can go that way I'm just not sure how much 
access we have to GitHub secrets for uploading the image. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599851653
 
 
   > @liuguo09 Sorry this took me so long. Have a look at what I have done over 
here:
   > https://github.com/btashton/nuttx-build-containers
   > 
   > The docker file is split into a bunch of stages which makes it a lot 
faster to rebuild and keeps the build time dependencies isolated from the rest 
of the image. Note that I am not downloading all of the toolchains now instead 
of copying local ones in.
   
   @btashton I notice it reduce half of time for pull the docker. It's really a 
good job. I totally agree with using a bunch of stages in Dockerfile to faster 
rebuild.  Do we need a official nuttx build contianer repo or just include it 
in testing repo? 
   
   > 
   > I also have a github action wired up to that to create the docker image 
and place it in the github project package registry.
   
   Since now we are using our own account to create docker image, how about 
switch to  the official https://hub.docker.com/u/apache to hold it? I have 
issued a Jira before  https://issues.apache.org/jira/browse/INFRA-19930 and the 
Infra team have responded to help setup.  And it required the nuttx committer 
permission to access. You may the right person to access as you are skilled in 
docker : )
   > 
   > On thing I think we should consider is using that structure to create 
images that each have the needed toolchains they are very large and the ARM 
builds should not be paying the cost of the RISCV, but I think this is a later 
improvement that can be made.
   
   If the time reduced not much now, I think it may be well to keep arm and 
riscv toolchains  together now. But considering more toolchains coming for 
other archs, it may be reasonable to restructure in later improvement.
   
   > 
   > You can see this integrated and running here:
   > https://github.com/btashton/incubator-nuttx/runs/508883969
   > 
   > Let me know how you think and we can look at moving it forward.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599307751
 
 
   @btashton thanks, I'll look into it and feedback later. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599183244
 
 
   @liuguo09  Sorry this took me so long.   Have a look at what I have done 
over here:
   https://github.com/btashton/nuttx-build-containers
   
   The docker file is split into a bunch of stages which makes it a lot faster 
to rebuild and keeps the build time dependencies isolated from the rest of the 
image.  Note that I am not downloading all of the toolchains now instead of 
copying local ones in.
   
   I also have a github action wired up to that to create the docker image and 
place it in the github project package registry. 
   
   On thing I think we should consider is using that structure to create images 
that each have the needed toolchains they are very large and the ARM builds 
should not be paying the cost of the RISCV, but I think this is a later 
improvement that can be made.
   
   You can see this integrated and running here:
   https://github.com/btashton/incubator-nuttx/runs/508883969
   
   Let me know how you think and we can look at moving it forward. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #15: cibuild.sh: make sure git log print out the last commit

[GitBox]

xiaoxiang781216 merged pull request #15: cibuild.sh: make sure git log print 
out the last commit
URL: https://github.com/apache/incubator-nuttx-testing/pull/15
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #15: cibuild.sh: make sure git log print out the last commit

[GitBox]

liuguo09 commented on issue #15: cibuild.sh: make sure git log print out the 
last commit
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/15#issuecomment-598066049
 
 
   @xiaoxiang781216 @masayuki2009 please take a look. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #15: cibuild.sh: make sure git log print out the last commit

[GitBox]

liuguo09 opened a new pull request #15: cibuild.sh: make sure git log print out 
the last commit
URL: https://github.com/apache/incubator-nuttx-testing/pull/15
 
 
   Add 'git log -1' to make sure we know where the last commit is.
   
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo

[GitBox]

liuguo09 opened a new pull request #14: cibuild.sh: switch to use the recent 
bitbucket tools repo
URL: https://github.com/apache/incubator-nuttx-testing/pull/14
 
 
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-596146010
 
 
   Sorry I don't remember very clearly. It seems in the workflow checkout 
stages, it mentioned to use 2.18 or later version. With the os version git 
2.17.1, it doesn't work well. I'll confirm it later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-596034731
 
 
   > @liuguo09 I'll make some detailed comments tonight. Including the 
multistage image which will resolve the issue of the local builds of the tools.
   
   Wish your feedback : )


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on a change in pull request #13: docker: initial checkin 
Dockerfile for nuttx github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r389218688
 
 

 ##
 File path: docker/Dockerfile
 ##
 @@ -0,0 +1,34 @@
+FROM ubuntu:18.04
+MAINTAINER Haitao Liu
+
+RUN dpkg --add-architecture i386
+RUN apt-get update
+RUN apt-get install -y git-core automake bison build-essential flex gperf wget 
libx11-dev libxext-dev u-boot-tools
+RUN apt-get install -y lib32z1-dev lib32ncurses5-dev libc6-dev-i386 
libx11-dev:i386 libxext-dev:i386
+RUN apt-get install -y curl gettext
+RUN apt-get install -y libcurl4-openssl-dev
+RUN apt-get install -y xxd
+RUN apt-get install -y unzip
+RUN apt-get clean
+RUN mkdir /prebuilt
+
+WORKDIR /prebuilt
+
+ADD gcc-arm-none-eabi.tar.gz ./
 
 Review comment:
   I'll update it later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 commented on a change in pull request #13: docker: initial checkin 
Dockerfile for nuttx github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r389218702
 
 

 ##
 File path: docker/Dockerfile
 ##
 @@ -0,0 +1,34 @@
+FROM ubuntu:18.04
 
 Review comment:
   Update it later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx 
github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-595823686
 
 
   @liuguo09 I'll make some detailed comments tonight. Including the multistage 
image which will resolve the issue of the local builds of the tools. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

xiaoxiang781216 commented on a change in pull request #13: docker: initial 
checkin Dockerfile for nuttx github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r388753487
 
 

 ##
 File path: docker/Dockerfile
 ##
 @@ -0,0 +1,34 @@
+FROM ubuntu:18.04
 
 Review comment:
   Change Dockerfile to another specific name, because other people may add 
macOS or Windows dockerfile later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

xiaoxiang781216 commented on a change in pull request #13: docker: initial 
checkin Dockerfile for nuttx github action container
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r388753286
 
 

 ##
 File path: docker/Dockerfile
 ##
 @@ -0,0 +1,34 @@
+FROM ubuntu:18.04
+MAINTAINER Haitao Liu
+
+RUN dpkg --add-architecture i386
+RUN apt-get update
+RUN apt-get install -y git-core automake bison build-essential flex gperf wget 
libx11-dev libxext-dev u-boot-tools
+RUN apt-get install -y lib32z1-dev lib32ncurses5-dev libc6-dev-i386 
libx11-dev:i386 libxext-dev:i386
+RUN apt-get install -y curl gettext
+RUN apt-get install -y libcurl4-openssl-dev
+RUN apt-get install -y xxd
+RUN apt-get install -y unzip
+RUN apt-get clean
+RUN mkdir /prebuilt
+
+WORKDIR /prebuilt
+
+ADD gcc-arm-none-eabi.tar.gz ./
 
 Review comment:
   change to download from offical release website


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #13: docker: initial checkin Dockerfile for nuttx github action container

[GitBox]

liuguo09 opened a new pull request #13: docker: initial checkin Dockerfile for 
nuttx github action container
URL: https://github.com/apache/incubator-nuttx-testing/pull/13
 
 
   The corresponding docker image:
   docker pull liuguo09/ubuntu-nuttx:tagname
   
   Now it is temporarily use personal account to place. Swith to apache docker
   once available. Also note the toolchains packages used in Dockerfile are all
   locally added which should be downloaded from network instead in future.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #12: cibuild.sh: use pushd/popd to make sure testlist path correctly

[GitBox]

xiaoxiang781216 merged pull request #12: cibuild.sh: use pushd/popd to make 
sure testlist path correctly
URL: https://github.com/apache/incubator-nuttx-testing/pull/12
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #12: cibuild.sh: use pushd/popd to make sure testlist path correctly

[GitBox]

liuguo09 opened a new pull request #12: cibuild.sh: use pushd/popd to make sure 
testlist path correctly
URL: https://github.com/apache/incubator-nuttx-testing/pull/12
 
 
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #11: Split check testlist to enable multiple jobs in CI build

[GitBox]

xiaoxiang781216 merged pull request #11: Split check testlist to enable 
multiple jobs in CI build
URL: https://github.com/apache/incubator-nuttx-testing/pull/11
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

[GitBox]

liuguo09 commented on a change in pull request #11: Split check testlist to 
enable multiple jobs in CI build
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387615991
 
 

 ##
 File path: cibuild.sh
 ##
 @@ -174,11 +174,11 @@ function run_builds {
   local ncpus=`grep -c ^processor /proc/cpuinfo`
   local options="-j $ncpus"
 
-  if [ "X$build" = "Xcheck" ]; then
 
 Review comment:
   Good suggestion. Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

[GitBox]

liuguo09 commented on a change in pull request #11: Split check testlist to 
enable multiple jobs in CI build
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387615954
 
 

 ##
 File path: cibuild.sh
 ##
 @@ -174,11 +174,11 @@ function run_builds {
   local ncpus=`grep -c ^processor /proc/cpuinfo`
   local options="-j $ncpus"
 
-  if [ "X$build" = "Xcheck" ]; then
+  if [ "X$build" != "Xfull" ]; then
 
 Review comment:
   Ok, done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

[GitBox]

xiaoxiang781216 commented on a change in pull request #11: Split check testlist 
to enable multiple jobs in CI build
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387533561
 
 

 ##
 File path: cibuild.sh
 ##
 @@ -174,11 +174,11 @@ function run_builds {
   local ncpus=`grep -c ^processor /proc/cpuinfo`
   local options="-j $ncpus"
 
-  if [ "X$build" = "Xcheck" ]; then
 
 Review comment:
   should we pass -x from command line instead of the hardcode relateship 
between full.data and -x?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

[GitBox]

xiaoxiang781216 commented on a change in pull request #11: Split check testlist 
to enable multiple jobs in CI build
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387532564
 
 

 ##
 File path: cibuild.sh
 ##
 @@ -174,11 +174,11 @@ function run_builds {
   local ncpus=`grep -c ^processor /proc/cpuinfo`
   local options="-j $ncpus"
 
-  if [ "X$build" = "Xcheck" ]; then
+  if [ "X$build" != "Xfull" ]; then
 
 Review comment:
   Should we remove -b and support pass the mulitple file here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #11: Split check testlist to enable multiple jobs in CI build

[GitBox]

liuguo09 opened a new pull request #11: Split check testlist to enable multiple 
jobs in CI build
URL: https://github.com/apache/incubator-nuttx-testing/pull/11
 
 
   In github action free version, up to 20 jobs could be run to speed up
   CI build.
   
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] Ouss4 merged pull request #10: Revert "fulllist: remove sim:mtdpart and sim:mtdrwb configs"

[GitBox]

Ouss4 merged pull request #10: Revert "fulllist: remove sim:mtdpart and 
sim:mtdrwb configs"
URL: https://github.com/apache/incubator-nuttx-testing/pull/10
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #4: Add prebuilt gperf needed in kconfig-frontends configure

[GitBox]

xiaoxiang781216 commented on issue #4: Add prebuilt gperf needed in 
kconfig-frontends configure
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/4#issuecomment-591956401
 
 
   Create a JIRA for gperf:
   https://issues.apache.org/jira/browse/INFRA-19896


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 opened a new pull request #10: Revert "fulllist: remove sim:mtdpart and sim:mtdrwb configs"

[GitBox]

xiaoxiang781216 opened a new pull request #10: Revert "fulllist: remove 
sim:mtdpart and sim:mtdrwb configs"
URL: https://github.com/apache/incubator-nuttx-testing/pull/10
 
 
   since INFRA fix this issue:
   https://github.com/apache/infrastructure-p6/pull/258


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

[GitBox]

xiaoxiang781216 merged pull request #9: fulllist: remove sim:mtdpart and 
sim:mtdrwb configs
URL: https://github.com/apache/incubator-nuttx-testing/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

[GitBox]

xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and 
sim:mtdrwb configs
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/9#issuecomment-591387371
 
 
   Let's wait INFRA fix libz.a issue and then revert this patch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

[GitBox]

xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and 
sim:mtdrwb configs
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/9#issuecomment-591387069
 
 
   Reopen in INFRA project:
   https://issues.apache.org/jira/browse/INFRA-19890


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

[GitBox]

liuguo09 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb 
configs
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/9#issuecomment-591381542
 
 
   Issue a jira for Apache Infra to install lib32z1-dev:
   https://issues.apache.org/jira/browse/NUTTX-2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

[GitBox]

liuguo09 opened a new pull request #9: fulllist: remove sim:mtdpart and 
sim:mtdrwb configs
URL: https://github.com/apache/incubator-nuttx-testing/pull/9
 
 
   Remove sim:mtdpart and sim:mtdrwb configs since i386 libz not available
   now in Apache Jenkins slaves. Revert this change once i386 libz installed.
   
   Build error logs:
   /usr/bin/ld: skipping incompatible //usr/lib/x86_64-linux-gnu/libz.so when 
searching for -lz
   /usr/bin/ld: skipping incompatible //usr/lib/x86_64-linux-gnu/libz.a when 
searching for -lz
   /usr/bin/ld: cannot find -lz
   collect2: error: ld returned 1 exit status
   
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #8: cibuild.sh: remove -si option since testbuild.sh updated

[GitBox]

xiaoxiang781216 commented on issue #8: cibuild.sh: remove -si option since 
testbuild.sh updated
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/8#issuecomment-587496156
 
 
   Follow up this change:
   https://github.com/apache/incubator-nuttx/pull/298


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #8: cibuild.sh: remove -si option since testbuild.sh updated

[GitBox]

liuguo09 opened a new pull request #8: cibuild.sh: remove -si option since 
testbuild.sh updated
URL: https://github.com/apache/incubator-nuttx-testing/pull/8
 
 
   Since -si/sl options have been removed from testbuild.sh, so remove
   it here.
   
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

[GitBox]

maht commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-585334298
 
 
   Well, not sure if the pipeline shared library can work from a subdirectory, 
according with documentation 
(https://jenkins.io/doc/book/pipeline/shared-libraries/). I agree it would be 
desirable, but if possible, it would require some extra research. I think that 
if not really a strong impediment and just I suggestion, we should go with 
default expected usage (or maybe just create an additional repository for the 
shared library, but this is also troublesome, I guess).
   
   I still have no Apache Jenkins access nor LDAP account. I think it would 
help to speed up the setup if I had access (possibly limited to a previously 
created job/folder inside Jenkins only for NuttX). Maybe @justinmclean can help 
with that, but not sure. If not I can help you setting the job, as commented 
before.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #2: Multibranch pipeline job example

[GitBox]

liuguo09 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-584984210
 
 
   That's good.  Another thing I wonder if it is necessary for us to create a 
subdirectory jenkins to hold the pipeline job stuffs. And create subdir travis 
If travis CI stuffs coming.  Anyway, it' a suggestion.  You changes look good 
to me :)
   @maht , do your apache jenkins access permission available now? I think you 
would be the right person to create jenkins pipeline job for nitghtly build and 
tune it if needed on it. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

[GitBox]

maht commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-584760466
 
 
   I pushed new versions of the commits. Now the main repository is checked out 
in `$WORKSPACE/nuttx` directory, at the same level as `apps` and `testing`, as 
expected by `cibuild.sh`. This is preferable over repeating the code of 
checkout for `apps` and `testing`. The problem is that it makes this script 
specific for `incubator-nuttx` CI (not directly reusable for 
`incubator-nuttx-apps` or `incubator-nuttx-testing`), but at this stage that 
should not be a problem. We can improve it in next iterations. Also, the job 
XML config now add the 'Cleanup before checkout' option, despite a 'Clean' 
stage is also added. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] maht commented on a change in pull request #2: Multibranch pipeline job example

[GitBox]

maht commented on a change in pull request #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#discussion_r377561127
 
 

 ##
 File path: vars/runContinuousIntegrationPipeline.groovy
 ##
 @@ -0,0 +1,103 @@
+#!/usr/bin/env groovy
+
+/
+ * vars/runContinuousIntegrationPipeline.groovy 
+ * Logic for the Continuous Integration pipeline
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+def call() {
+  pipeline {
+agent {
+  node {
+   label 'ubuntu'
+  }
+}
+environment {
+  EXAMPLE_ENV = 'example_value'
+  // GIT_CREDENTIALS_ID = ''
+  NUTTX_APPS_REPO_URL = 'https://github.com/apache/incubator-nuttx-apps'
+  NUTTX_TESTING_REPO_URL = 
'https://github.com/apache/incubator-nuttx-testing'
+}
+stages {
+  stage('Checkout') {
+   steps {
+ deleteDir() // clean up our workspace
 
 Review comment:
   No, sorry, this is not ok. It need to update the script. It should be 
checked out in the `nuttx/` path. Let me fix it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #2: Multibranch pipeline job example

[GitBox]

liuguo09 commented on a change in pull request #2: Multibranch pipeline job 
example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#discussion_r377536019
 
 

 ##
 File path: vars/runContinuousIntegrationPipeline.groovy
 ##
 @@ -0,0 +1,103 @@
+#!/usr/bin/env groovy
+
+/
+ * vars/runContinuousIntegrationPipeline.groovy 
+ * Logic for the Continuous Integration pipeline
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+def call() {
+  pipeline {
+agent {
+  node {
+   label 'ubuntu'
+  }
+}
+environment {
+  EXAMPLE_ENV = 'example_value'
+  // GIT_CREDENTIALS_ID = ''
+  NUTTX_APPS_REPO_URL = 'https://github.com/apache/incubator-nuttx-apps'
+  NUTTX_TESTING_REPO_URL = 
'https://github.com/apache/incubator-nuttx-testing'
+}
+stages {
+  stage('Checkout') {
+   steps {
+ deleteDir() // clean up our workspace
+ sh 'ls'
+ sh 'printenv'
+ 
+ // incubator-nuttx-apps repository master //
+ 
+ checkout([
+ $class: 'GitSCM',
+ // branches: [[name: '*/master']], // default one
+ doGenerateSubmoduleConfigurations: false,
+ extensions: [[$class: 'RelativeTargetDirectory', 
relativeTargetDir: 'apps']],
+ submoduleCfg: [],
+ userRemoteConfigs: [[
+ // credentialsId: "${GIT_CREDENTIALS_ID}",
+ url: "${NUTTX_APPS_REPO_URL}",
+ refspec: '+refs/heads/master:refs/remotes/origin/master',
+ ]]
+ ])
+ ///
+ // incubator-nuttx-testing repository master //
+ ///
+ checkout([
+ $class: 'GitSCM',
+ // branches: [[name: '*/master']], // default one
+ doGenerateSubmoduleConfigurations: false,
+ extensions: [[$class: 'RelativeTargetDirectory', 
relativeTargetDir: 'testing']],
+ submoduleCfg: [],
+ userRemoteConfigs: [[
+ // credentialsId: "${GIT_CREDENTIALS_ID}",
+ url: "${NUTTX_TESTING_REPO_URL}",
+ refspec: '+refs/heads/master:refs/remotes/origin/master',
+ ]]
+ ])
+ /
+ // some commands to check everything is ok //
+ /
+ sh 'ls'
+ sh 'cd apps; git show'
+ sh 'cd testing; git show'
+   }
+  }
+  stage('Builds') {
+   steps {
+ sh './testing/cibuild.sh -b full'
 
 Review comment:
   Since I have update cibuild.sh to decouple -b option without setup repos. 
Should we checkout nuttx repo like the above apps and testing repo? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #2: Multibranch pipeline job example

[GitBox]

liuguo09 commented on a change in pull request #2: Multibranch pipeline job 
example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#discussion_r377534899
 
 

 ##
 File path: vars/runContinuousIntegrationPipeline.groovy
 ##
 @@ -0,0 +1,103 @@
+#!/usr/bin/env groovy
+
+/
+ * vars/runContinuousIntegrationPipeline.groovy 
+ * Logic for the Continuous Integration pipeline
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+def call() {
+  pipeline {
+agent {
+  node {
+   label 'ubuntu'
+  }
+}
+environment {
+  EXAMPLE_ENV = 'example_value'
+  // GIT_CREDENTIALS_ID = ''
+  NUTTX_APPS_REPO_URL = 'https://github.com/apache/incubator-nuttx-apps'
+  NUTTX_TESTING_REPO_URL = 
'https://github.com/apache/incubator-nuttx-testing'
+}
+stages {
+  stage('Checkout') {
+   steps {
+ deleteDir() // clean up our workspace
 
 Review comment:
   @maht, I used the scripts setup jenkins pipiline job locally well. But I 
notice the nuttx repo firstly checkouted before deleteDir from the build log. 
Is this right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #7: cibuild.sh: decouple -b option to do run_builds only

[GitBox]

xiaoxiang781216 merged pull request #7: cibuild.sh: decouple -b option to do 
run_builds only
URL: https://github.com/apache/incubator-nuttx-testing/pull/7
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #6: Get the full directory name of the cibuild.sh no matter where called …

[GitBox]

liuguo09 opened a new pull request #6: Get the full directory name of the 
cibuild.sh no matter where called …
URL: https://github.com/apache/incubator-nuttx-testing/pull/6
 
 
   …from
   
   Or it would fail to set nuttx/apps/tools/prebuilt dirs correctly when 
cibuild.sh
   is not called by 'cd testing; ./cibuild.sh'. For example, it would break 
jenkins
   groovy script which call with ./testing/cibuild.sh.
   
   Change-Id: I8a9d4a6534578a472952668c0172cd6f5bedff8e
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build …

[GitBox]

liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail 
fast for check build …
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/5#issuecomment-583400349
 
 
   Thanks. @maht @xiaoxiang781216 could you help review and merge if ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build …

[GitBox]

liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail 
fast for check build …
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/5#issuecomment-583279728
 
 
   This change also depends on 
https://github.com/apache/incubator-nuttx/pull/221.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #5: Call testbuild.sh with -x option to set it fail fast for check build …

[GitBox]

liuguo09 opened a new pull request #5: Call testbuild.sh with -x option to set 
it fail fast for check build …
URL: https://github.com/apache/incubator-nuttx-testing/pull/5
 
 
   …error
   
   For PR check build, call testbuild.sh with -x option to set it fail fast if
   build error occured. Note that for full build, it keeps on going build 
anyway.
   
   Change-Id: I46b77cc4632dd2c8e1749ab81a275fa1ff5a505c
   Signed-off-by: liuhaitao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #2: Multibranch pipeline job example

[GitBox]

liuguo09 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-583278543
 
 
   > @davids5 I have not tested in builds.apache.org Jenkins, since I have no 
rights to create the pipeline job. I tested it on an external Jenkins server I 
created, that is pointing to my forks of the repos (github.com/maht/*) instead 
of apache ones: http://nuttx.ci.midocloud.net:8080/job/nuttx/job/master/2/ 
(classical view) 
http://nuttx.ci.midocloud.net:8080/blue/organizations/jenkins/nuttx/detail/master/2/pipeline
 (new "Blue Ocean" UI style) Last one failed because I have no 'make' in the 
Jenkins slave (I need to install it when I have time). The definition of the 
job is the same as described by 
https://github.com/apache/incubator-nuttx-testing/pull/2/files#diff-f3b70337f738c1b93a5fe2f8c215770a
 , so it can be used to create it on builds.apache.org by someone with enough 
rights. Feedback is welcome :)
   > […](#)
   > On Tue, Feb 4, 2020 at 1:54 PM Xiang Xiao ***@***.***> wrote: Here is a 
test build: 
https://builds.apache.org/view/Incubator%20Projects/job/NuttX-Nightly-Build/18/console
 It fail due to this know issue: 
[apache/incubator-nuttx#102](https://github.com/apache/incubator-nuttx/pull/102)
 
<[apache/incubator-nuttx#102](https://github.com/apache/incubator-nuttx/pull/102)>
 We need fix it to get the stable output. — You are receiving this because you 
were mentioned. Reply to this email directly, view it on GitHub 
<#2?email_source=notifications_token=AA5UI75ZLWCTEQYC2GP4BBDRBFQQBA5CNFSM4KMVT5F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKXQTZI#issuecomment-581896677>,
 or unsubscribe 

 .
   
   @maht I'll pull it to verify the pipeline way in my local jenkins firstly. 
And feedback later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] davids5 commented on issue #2: Multibranch pipeline job example

[GitBox]

davids5 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582533612
 
 
   >Or make some changes to do out of tree build to speedup parallelize configs 
build time.
   
   Yes. This will help. You do realize this is all in the PX4 CI and we are 
reinventing the wheel one spoke at a time here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #2: Multibranch pipeline job example

[GitBox]

btashton commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582510709
 
 
   You can run between 20-60 concurrent jobs depending on what account type the 
Apache org is under. I would expect each build to be it's own job, and you can 
set it to fail fast. I have also set these up before to tailor the jobs based 
on labels. You could have a minimal set that always run and then add CI/ARM 
label and have it trigger every Arm build, but this may be over engineering at 
this point.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #2: Multibranch pipeline job example

[GitBox]

liuguo09 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582500074
 
 
   > I pushed for this a couple times but it seemed full steam ahead for 
Jenkins. My plan was to wait for some of the ci scripts to stabilize and make 
my case again. Especially with the free access to windows and osx builds.
   > 
   > These days of modern CI, I don't know very many other OSS projects that 
are moving onto Jenkins. Most are there because they have it already and it 
works. A lot have moved to gitlab, circleci, travis, etc...
   > 
   > This all said I don't have the time to do the work right now so I should 
really just stay out of it if others want to.
   
   I have just simply tested github action in my fork with 
https://github.com/liuguo09/incubator-nuttx-testing/blob/github-action-test-1/.github/workflows/ci.yml.
 And the result in 
https://github.com/liuguo09/incubator-nuttx-testing/runs/427035372?check_suite_focus=true.
 It really do a good job. 
   
   I think it doesn't matter much whether use Apache jenkins or Github actions 
to do CI. The most important thing would be how to define PR check build, to 
choose some typical configs build or full build. If check build should behave 
like full build, then how to reduce the whole build time. In my previous 
testbuild result with Apache jenkins(apache build server) and Github 
action(using Github-hosted 2-cores cpu runner), it takes 3~4 hours to finish 
the whole build process.
   
   Use more powerful apache build server or powerful self-hosted github action 
runner may help. Or make some changes to do out of tree build to speedup 
parallelize configs build time.  Wish more discussion coming : )


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] btashton commented on issue #2: Multibranch pipeline job example

[GitBox]

btashton commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582189612
 
 
   I pushed for this a couple times but it seemed full steam ahead for Jenkins. 
My plan was to wait for some of the ci scripts to stabilize and make my case 
again.  Especially with the free access to windows and osx builds.
   
   These days of modern CI, I don't know very many other OSS projects that are 
moving onto Jenkins. Most are there because they have it already and it works. 
A lot have moved to gitlab,  circleci, travis, etc...
   
   This all said I don't have the time to do the work right now so I should 
really just stay out of it if others want to. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] davids5 commented on issue #2: Multibranch pipeline job example

[GitBox]

davids5 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582159472
 
 
   >Just be aware that the build servers are a shared resource from all 
projects and we are expected to not make unreasonable demands on it. I’m not 
sure if the above would be unreasonable or not.
   
   Yet another great argument  for github actions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] justinmclean commented on issue #2: Multibranch pipeline job example

[GitBox]

justinmclean commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582122695
 
 
   Hi,
   > I think the " nightly build" mind set is not the way this should be looked 
at. 24Hr cycle time is not going to move this project along. The build need to 
be parallelized and with results like 100 config builds in < 10 Minutes
   > 
   Just be aware that the build servers are a shared resource from all projects 
and we are expected to not make unreasonable demands on it. I’m not sure if the 
above would be unreasonable or not.
   
   Thanks,
   Justin
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] davids5 commented on issue #2: Multibranch pipeline job example

[GitBox]

davids5 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582033081
 
 
   >Yes, regarding time concerns check option should take less time than full 
and can be shortened if needed by simply removing/commenting out some test 
cases. 
   
   Why? If full does not work the build is broken and the PR should not come in.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #2: Multibranch pipeline job example

[GitBox]

xiaoxiang781216 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-581985725
 
 
   > I have no rights on `github.com/apache/incubator-nuttx` to inject triggers 
towards my Jenkins, neither
   > rights to create jobs in builds.apache.org (I submited the ICLA, but 
having access rights is another story, as it is understandable by security 
reasons) but I can help @xiaoxiang781216 or other admin via mail/wiki/videocall 
if needed.
   
   @maht I amn't familiar with Jenkins, so you can work with @liuguo09 to 
finish the pipeline, but I can help to do any amin work if required.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

[GitBox]

maht commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-581980751
 
 
   Yes, regarding time concerns `check` option should take less time than 
`full` and can be shortened if needed by simply removing/commenting out some 
test cases. Then, we can parallelize it (I can try to make a proof-of-concept 
later today) by using some adaptation to the groovy script, either statically 
or dynamically generating the "dots" in the pipeline (see 
https://plugins.jenkins.io/workflow-cps). This will shorten the time and allow 
more tests without impacting CI feedback delay to pull requests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #2: Multibranch pipeline job example

[GitBox]

liuguo09 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-581977370
 
 
   > @davids5 @patacongo @jerpelea
   > 
   > Totally agree, and that was and is the original intention. This is just a 
skeleton to build upon: I think we should merge this pull request, and then, 
once it is being triggered correctly by pull request according to the agreed 
workflow, we could improve it by changing this groovy shared library (we won't 
need to ever (or seldom) change the `tools/Jenkinsfile` in core OS repo 
`apache/incubator-nuttx` needed to trigger the multibranch pipeline).
   > 
   > For example, I just used the `cibuild.sh -b full` as in the nightly, but 
in fact should be using the short list: `cibuild.sh -b check`.
   > 
   > We can iterate this aside of the core OS repo. For example, it could be 
easy to modify the groovy script to make it look like the parallelized pipeline 
@davids5 have shown.
   > 
   > To do that, another Jenkinsfile will be added to testing repo itself, and 
another multibranch pipeline should be created, so that the pipeline itself can 
be tested (from pull request branches to `apache/incubator-nuttx-testing`) 
independently from the core OS stable pipeline (the defined in `master` branch 
of `apache/incubator-nuttx-testing`). (By the way, I need to add the "meta" 
pipeline testing job as well, when I have time).
   > 
   > But not having still these jobs defined already in builds.apache.org makes 
it difficult to test/iterate by now.
   > 
   > Hope that this clarify my proposal.
   
   That's right.  As @maht said, cibuild.sh and testlist files are designed in 
mind to support both nightly build and check build with  `cibuild.sh -b full` 
and `cibuild.sh -b check`. Start simple, one freestyle NuttX Nightly Build job 
has been setup in builds.apache.org to verify nightly build firstly.  Then 
check build which hook with incoming PR should be available later. As for build 
time, with ccache enabled and powerful build machines(for example, donate 
powerful machine), I think it could be reduced more.
   
   I also agree that it would be better to use jenkins pipeline way for more 
advantages as @maht and @davids5 mentioned. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

[GitBox]

maht commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-581969346
 
 
   I have no rights on `github.com/apache/incubator-nuttx` to inject triggers 
towards my Jenkins, neither
   rights to create jobs in builds.apache.org (I submited the ICLA, but having 
access rights is another story, as it is understandable by security reasons) 
but I can help @xiaoxiang781216 or other admin via mail/wiki/videocall if 
needed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

[GitBox]

maht commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-581943694
 
 
   @davids5 @patacongo @jerpelea 
   
   Totally agree, and that was and is the original intention. This is just a 
skeleton to build upon: I think we should merge this pull request, and then, 
once it is being triggered correctly by pull request according to the agreed 
workflow, we could improve it by changing this groovy shared library (we won't 
need to ever (or seldom) change the `tools/Jenkinsfile` in core OS repo 
`apache/incubator-nuttx` needed to trigger the multibranch pipeline).
   
   For example, I just used the `cibuild.sh -b full` as in the nightly, but in 
fact should be using the short list: `cibuild.sh -b check`.
   
   We can iterate this aside of the core OS repo. For example, it could be easy 
to modify the groovy script to make it look like the parallelized pipeline 
@davids5 have shown.
   
   To do that, another Jenkinsfile will be added to testing repo itself, and 
another multibranch pipeline should be created, so that the pipeline itself can 
be tested (from pull request branches to `apache/incubator-nuttx-testing`)  
independently from the core OS stable pipeline (the defined in `master` branch 
of `apache/incubator-nuttx-testing`). (By the way, I need to add the "meta" 
pipeline testing job as well, when I have time).
   
   But not having still these jobs defined already in builds.apache.org makes 
it difficult to test/iterate by now.
   
   Hope that this clarify my proposal.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services