Re: Unused jQuery MockJax Plugin

[Aditya Sharma]

Thanks Michael and Jacques :-)

Done for trunk at r1851013 and R18.12 at r1851014

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Thu, Jan 10, 2019 at 7:13 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Aditya, Michael,
>
> Yes indeed it's not used in OFBiz, I think we are good to remove it and
> mention it in OFBIZ-9978
>
> Jacques
>
> Le 10/01/2019 à 11:37, Aditya Sharma a écrit :
> >   Thanks for the quick response Michael.
> >
> > Indeed it was upgraded with the Jquery upgrade at
> > https://issues.apache.org/jira/browse/OFBIZ-9978  but there was no
> trace of
> > its use. Even I couldn't find it being loaded.
> > I guess it is used by jquery.validation for test
> >
> https://github.com/jquery-validation/jquery-validation/blob/master/test/test.js
> > &
> > must have been added in OFBiz by mistake.
> >
> >
> > Thanks and Regards,
> >
> > *Aditya Sharma* | Enterprise Software Engineer
> > HotWax Commerce  by HotWax Systems
> > 
> > [image: https://www.linkedin.com/in/aditya-p-sharma/]
> > 
> >
> >
> > On Thu, Jan 10, 2019 at 2:55 PM Michael Brohl 
> > wrote:
> >
> >> Hi Aditya,
> >>
> >> a quick search shows that it was added in r1815824 by Jacques for the
> >> update from Jquery 1.11.0 to JQuery 3.2.1.
> >>
> >> Maybe it's a dependency or part of the Jquery stack?
> >>
> >> Regards,
> >>
> >> Michael
> >>
> >> Am 10.01.19 um 10:07 schrieb Aditya Sharma:
> >>> Hello all,
> >>>
> >>> I can't find any use of the jQuery MockJax
> >>>  Plugin included in
> OFBiz.
> >> If
> >>> it is not used anywhere, we can remove it.
> >>>
> >>> Is there anything I am missing?
> >>>
> >>> Thanks and Regards,
> >>>
> >>> *Aditya Sharma* | Enterprise Software Engineer
> >>> HotWax Commerce  by HotWax Systems
> >>> 
> >>> [image: https://www.linkedin.com/in/aditya-p-sharma/]
> >>> 
> >>>
> >>
>

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

[Mathieu Lirzin]

Hello,

Deepak Nigam  writes:

> Thank you, Jacques, for looking into it.
>
> In my case, there is only one webapp with the empty mount point and I want
> to use the autoLogin cookie. But the code is written in such a way that in
> case of empty mount point 'webappInfo' object is coming null due to which
> autoLogin cookie is not getting created and added in the response object.
> UtilHttp.getApplicationName(request) method is returning the string 'root'
> and ComponentConfig.getWebappInfo((String)
> context.getAttribute("_serverId"), UtilHttp.getApplicationName(request)) is
> trying to find the webapp using the mountpoint 'root' and hence unable to
> find it.
>
> Please refer the below code for more information:

After a quick look, It seems that the code you are refering to is being
modified (and hopefully improved) by the patch series I submitted a few
months ago in OFBIZ-10606 [1].  Jacques has started the review process
in last november.

If you have some time, I would appreciate if you could check if the
issue you are describing is still present there and maybe propose a way
to fix the issue if that is the case.

Thanks.

[1] https://issues.apache.org/jira/browse/OFBIZ-10606 

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Re: Session timeout for webapps

[Deepak Nigam]

Thanks, Jacques and Girish.

Yes, it makes sense to get back to web.xml for the session timeout value.

On Fri, Jan 11, 2019 at 11:13 AM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi Jacques
>
> Yes, we should put back the session timeout declaration in web.xml. Given
> the fact that we can always mix web.xml and Annotation based configuration,
> it only makes sense to let web.xml decide the session timeout and even if
> we have the session listener (via web.xml declaration or Annotation), we
> should not programatically try to override the setting.
>
> Thanks and Regards,
> Girish
>
>
> On Thu, Jan 10, 2019 at 7:14 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi Deepak, Girish,
> >
> > I had a look at the issue. The specifications of Java Servlet
> > Specification 3.0 don't include an annotation to change the session time
> > out.
> >
> > https://www.baeldung.com/servlet-session-timeout
> >
> >
> https://stackoverflow.com/questions/20389833/session-timeout-config-with-no-web-xml-file
> >
> > I think the best solution is to put back what we had before, ie set it to
> > a value (it was 1 hour before) in all web.xml file and remove the
> >
> > session.setMaxInactiveInterval(60*60); //in seconds
> >
> > line in ControlEventListener::sessionCreated
> >
> > I thought about keeping this line if a check to null for the session
> > timeout value (from web.xml) was positive.
> > But by default Tomcat sets it to 30 min (so it's never null) and it's
> > possible but hard to change in OFBiz (eg to a known specific
> extraordinary
> > value
> > that could be checked instead of null as above)
> > So it could be confusing and anyway best practice is to prefer convention
> > over configuration, even if in this case it's much redundant.
> >
> > I think we can reopen OFBIZ-6655 and handle it there, with an
> explanation.
> >
> > Other ideas?
> >
> > Jacques
> >
> > Le 09/01/2019 à 10:11, Girish Vasmatkar a écrit :
> > > Hi Deepak
> > >
> > > By the time sessionCreated is called in an HttpSessionListener, the
> > session
> > > has already been created. I am sure if you try to get the HttpSession
> > from
> > > the HttpSessionEvent object, it will have what you defined in
> > >  tag.
> > >
> > > But the code is overriding the timeout using setMaxInactiveInterval to
> 1
> > > hour that is why it is looking like web.xml is not being given
> > > precedence over programmatic session configuration.
> > >
> > > Whether web.xml takes precedence over annotation does not apply in this
> > > case because anyway the session timeout value is being overridden by
> the
> > > code. The tomcat container definitely reads session-timeout from
> web.xml
> > > and assigns timeout for the session accordingly. But since a listener
> is
> > > configured for session lifecycle management, it invokes the method and
> > > there the session value is being overridden.
> > >
> > > Try to set 2 minutes session timeout in web.xml and remove
> > > session.setMaxInactiveInterval(60*60).
> > > I would say you will be logged out after 2 minutes. If that is not the
> > > case, pl let me know.
> > >
> > > I hope I understood your question and problem correctly.
> > >
> > > Best,
> > > Girish
> > >
> > >
> > >
> > > On Wed, Jan 9, 2019 at 1:53 PM Deepak Nigam <
> deepak.nigam1...@gmail.com>
> > > wrote:
> > >
> > >> Thanks, Jacques.
> > >>
> > >> Apart from the hardcoded thing, I am not able to override the session
> > >> timeout value using  tag in web.xml.
> > >>
> > >> On Tue, Jan 8, 2019 at 1:55 PM Jacques Le Roux <
> > >> jacques.le.r...@les7arts.com>
> > >> wrote:
> > >>
> > >>> Hi Deepak,
> > >>>
> > >>> You are right, it's hardcoded and should not. I have no time to go
> > >> further
> > >>> at the moment, but I'll ASAP
> > >>>
> > >>> Thanks
> > >>>
> > >>> Jacques
> > >>>
> > >>> Le 08/01/2019 à 06:10, Deepak Nigam a écrit :
> >  Hello all,
> > 
> >  I tried to set the session timeout for the 'ecommerce' and the
> >  'webtools' components using  of web.xml, but unable
> to
> > >> do
> >  so. Session for the logged-in user remains active even after the set
> > >>> time.
> >  On further research, I found that we did some changes in this area
> in
> > >> the
> >  ticket OFBIZ-6655  >.
> > >> We
> >  have hard coded the session timeout (1 hr) in the sessionCreated()
> > >> method
> >  of ControlEventListner class. As per the comments in the Jira
> ticket,
> >  session timeout declarations in web.xml have been removed by the use
> >  of @WebListner annotation. This is to avoid duplicates things
> > >> everywhere
> > >>> in
> >  web.xml files. Since the web.xml files have precedence on
> annotations,
> > >>> the
> >  setting can be easily overridden when necessary.
> > 
> >  But the @WebListner is missing in the ControlEventListner class.
> Also,
> > >> I
> > >>> am
> >  unable to override the 

Re: Session timeout for webapps

[Girish Vasmatkar]

Hi Jacques

Yes, we should put back the session timeout declaration in web.xml. Given
the fact that we can always mix web.xml and Annotation based configuration,
it only makes sense to let web.xml decide the session timeout and even if
we have the session listener (via web.xml declaration or Annotation), we
should not programatically try to override the setting.

Thanks and Regards,
Girish


On Thu, Jan 10, 2019 at 7:14 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak, Girish,
>
> I had a look at the issue. The specifications of Java Servlet
> Specification 3.0 don't include an annotation to change the session time
> out.
>
> https://www.baeldung.com/servlet-session-timeout
>
> https://stackoverflow.com/questions/20389833/session-timeout-config-with-no-web-xml-file
>
> I think the best solution is to put back what we had before, ie set it to
> a value (it was 1 hour before) in all web.xml file and remove the
>
> session.setMaxInactiveInterval(60*60); //in seconds
>
> line in ControlEventListener::sessionCreated
>
> I thought about keeping this line if a check to null for the session
> timeout value (from web.xml) was positive.
> But by default Tomcat sets it to 30 min (so it's never null) and it's
> possible but hard to change in OFBiz (eg to a known specific extraordinary
> value
> that could be checked instead of null as above)
> So it could be confusing and anyway best practice is to prefer convention
> over configuration, even if in this case it's much redundant.
>
> I think we can reopen OFBIZ-6655 and handle it there, with an explanation.
>
> Other ideas?
>
> Jacques
>
> Le 09/01/2019 à 10:11, Girish Vasmatkar a écrit :
> > Hi Deepak
> >
> > By the time sessionCreated is called in an HttpSessionListener, the
> session
> > has already been created. I am sure if you try to get the HttpSession
> from
> > the HttpSessionEvent object, it will have what you defined in
> >  tag.
> >
> > But the code is overriding the timeout using setMaxInactiveInterval to 1
> > hour that is why it is looking like web.xml is not being given
> > precedence over programmatic session configuration.
> >
> > Whether web.xml takes precedence over annotation does not apply in this
> > case because anyway the session timeout value is being overridden by the
> > code. The tomcat container definitely reads session-timeout from web.xml
> > and assigns timeout for the session accordingly. But since a listener is
> > configured for session lifecycle management, it invokes the method and
> > there the session value is being overridden.
> >
> > Try to set 2 minutes session timeout in web.xml and remove
> > session.setMaxInactiveInterval(60*60).
> > I would say you will be logged out after 2 minutes. If that is not the
> > case, pl let me know.
> >
> > I hope I understood your question and problem correctly.
> >
> > Best,
> > Girish
> >
> >
> >
> > On Wed, Jan 9, 2019 at 1:53 PM Deepak Nigam 
> > wrote:
> >
> >> Thanks, Jacques.
> >>
> >> Apart from the hardcoded thing, I am not able to override the session
> >> timeout value using  tag in web.xml.
> >>
> >> On Tue, Jan 8, 2019 at 1:55 PM Jacques Le Roux <
> >> jacques.le.r...@les7arts.com>
> >> wrote:
> >>
> >>> Hi Deepak,
> >>>
> >>> You are right, it's hardcoded and should not. I have no time to go
> >> further
> >>> at the moment, but I'll ASAP
> >>>
> >>> Thanks
> >>>
> >>> Jacques
> >>>
> >>> Le 08/01/2019 à 06:10, Deepak Nigam a écrit :
>  Hello all,
> 
>  I tried to set the session timeout for the 'ecommerce' and the
>  'webtools' components using  of web.xml, but unable to
> >> do
>  so. Session for the logged-in user remains active even after the set
> >>> time.
>  On further research, I found that we did some changes in this area in
> >> the
>  ticket OFBIZ-6655 .
> >> We
>  have hard coded the session timeout (1 hr) in the sessionCreated()
> >> method
>  of ControlEventListner class. As per the comments in the Jira ticket,
>  session timeout declarations in web.xml have been removed by the use
>  of @WebListner annotation. This is to avoid duplicates things
> >> everywhere
> >>> in
>  web.xml files. Since the web.xml files have precedence on annotations,
> >>> the
>  setting can be easily overridden when necessary.
> 
>  But the @WebListner is missing in the ControlEventListner class. Also,
> >> I
> >>> am
>  unable to override the session timeout in web.xml even after putting
> >> the
>  @WebListner annotation in ControlEventListner class.
> 
>  Please let me know if this is a real issue or I am doing something
> >> wrong?
>  Thanks & Regards
>  --
>  Deepak Nigam
>  HotWax Systems Pvt. Ltd.
> 
>

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

[Deepak Nigam]

Thank you, Jacques, for looking into it.

In my case, there is only one webapp with the empty mount point and I want
to use the autoLogin cookie. But the code is written in such a way that in
case of empty mount point 'webappInfo' object is coming null due to which
autoLogin cookie is not getting created and added in the response object.
UtilHttp.getApplicationName(request) method is returning the string 'root'
and ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"), UtilHttp.getApplicationName(request)) is
trying to find the webapp using the mountpoint 'root' and hence unable to
find it.

Please refer the below code for more information:



// Set an autologin cookie for the webapp if it requests it
public static String autoLoginSet(HttpServletRequest request,
HttpServletResponse response) {
Delegator delegator = (Delegator) request.getAttribute("delegator");
HttpSession session = request.getSession();
GenericValue userLogin = (GenericValue) session.getAttribute("userLogin");
ServletContext context = request.getServletContext();
WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"),
UtilHttp.getApplicationName(request));

if (userLogin != null && webappInfo != null &&
webappInfo.isAutologinCookieUsed()) {
Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request),
userLogin.getString("userLoginId"));
autoLoginCookie.setMaxAge(60 * 60 * 24 * 365);
autoLoginCookie.setDomain(EntityUtilProperties.getPropertyValue("url",
"cookie.domain", delegator));
autoLoginCookie.setPath("/" +
UtilHttp.getApplicationName(request).replaceAll("/","_"));
autoLoginCookie.setSecure(true);
autoLoginCookie.setHttpOnly(true);
response.addCookie(autoLoginCookie);
return autoLoginCheck(delegator, session,
userLogin.getString("userLoginId"));
} else {
return "success";
}
}

==

public static WebappInfo getWebappInfo(String serverName, String webAppName) {
WebappInfo webappInfo = null;
List webappsInfo = getAppBarWebInfos(serverName);
for(WebappInfo currApp : webappsInfo) {
String currWebAppName = currApp.getMountPoint().replace("/",
"").replace("*", "");
if (webAppName.equals(currWebAppName)) {
webappInfo = currApp;
break;
}
}
return webappInfo;
}

=


On Thu, Jan 10, 2019 at 7:31 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> It's not a problem if we create an autologin cookie even if it's not used,
> just unclean.
> So in this case we could force the same cookie values but the name and
> path to "root".
>
> But what happens if we have several empty mountpoints, is that a problem?
> I guess if we deploy on root there is only 1 webapp?
>
> It would be good to reuse OFBIZ-10635 to keep the information there,
> thanks.
>
> HTH
>
> Jacques
>
> Le 10/01/2019 à 09:26, Deepak Nigam a écrit :
> > Hello all,
> >
> > In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(),
> > system fetches the webAppInfo by using the
> > method ComponentConfig.getWebappInfo(). In this method, serverId and
> > applicationName are passed as the arguments.
> >
> > *WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
> > context.getAttribute("_serverId"),
> UtilHttp.getApplicationName(request));*
> >
> > If the mount-point of the web app is set as an empty string, then 'root'
> > will be used as the application name, due to which the object webAppInfo
> > will come null. If the webAppInfo is null then the autoLogin cookie will
> > not be created and added to the response object by the system.
> >
> > Suggestions are welcomed to handle this scenario.
> >
> >
> > Thanks & Regards
> > --
> > Deepak Nigam
> > HotWax Systems Pvt. Ltd
> >
>

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

[Jacques Le Roux]

Hi Deepak,

It's not a problem if we create an autologin cookie even if it's not used, just 
unclean.
So in this case we could force the same cookie values but the name and path to 
"root".

But what happens if we have several empty mountpoints, is that a problem?
I guess if we deploy on root there is only 1 webapp?

It would be good to reuse OFBIZ-10635 to keep the information there, thanks.

HTH

Jacques

Le 10/01/2019 à 09:26, Deepak Nigam a écrit :

Hello all,

In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(),
system fetches the webAppInfo by using the
method ComponentConfig.getWebappInfo(). In this method, serverId and
applicationName are passed as the arguments.

*WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"), UtilHttp.getApplicationName(request));*

If the mount-point of the web app is set as an empty string, then 'root'
will be used as the application name, due to which the object webAppInfo
will come null. If the webAppInfo is null then the autoLogin cookie will
not be created and added to the response object by the system.

Suggestions are welcomed to handle this scenario.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd

Re: Session timeout for webapps

[Jacques Le Roux]

Hi Deepak, Girish,

I had a look at the issue. The specifications of Java Servlet Specification 3.0 
don't include an annotation to change the session time out.

   https://www.baeldung.com/servlet-session-timeout
   
https://stackoverflow.com/questions/20389833/session-timeout-config-with-no-web-xml-file

I think the best solution is to put back what we had before, ie set it to a 
value (it was 1 hour before) in all web.xml file and remove the

   session.setMaxInactiveInterval(60*60); //in seconds

line in ControlEventListener::sessionCreated

I thought about keeping this line if a check to null for the session timeout 
value (from web.xml) was positive.
But by default Tomcat sets it to 30 min (so it's never null) and it's possible but hard to change in OFBiz (eg to a known specific extraordinary value 
that could be checked instead of null as above)

So it could be confusing and anyway best practice is to prefer convention over 
configuration, even if in this case it's much redundant.

I think we can reopen OFBIZ-6655 and handle it there, with an explanation.

Other ideas?

Jacques

Le 09/01/2019 à 10:11, Girish Vasmatkar a écrit :

Hi Deepak

By the time sessionCreated is called in an HttpSessionListener, the session
has already been created. I am sure if you try to get the HttpSession from
the HttpSessionEvent object, it will have what you defined in
 tag.

But the code is overriding the timeout using setMaxInactiveInterval to 1
hour that is why it is looking like web.xml is not being given
precedence over programmatic session configuration.

Whether web.xml takes precedence over annotation does not apply in this
case because anyway the session timeout value is being overridden by the
code. The tomcat container definitely reads session-timeout from web.xml
and assigns timeout for the session accordingly. But since a listener is
configured for session lifecycle management, it invokes the method and
there the session value is being overridden.

Try to set 2 minutes session timeout in web.xml and remove
session.setMaxInactiveInterval(60*60).
I would say you will be logged out after 2 minutes. If that is not the
case, pl let me know.

I hope I understood your question and problem correctly.

Best,
Girish



On Wed, Jan 9, 2019 at 1:53 PM Deepak Nigam 
wrote:


Thanks, Jacques.

Apart from the hardcoded thing, I am not able to override the session
timeout value using  tag in web.xml.

On Tue, Jan 8, 2019 at 1:55 PM Jacques Le Roux <
jacques.le.r...@les7arts.com>
wrote:


Hi Deepak,

You are right, it's hardcoded and should not. I have no time to go

further

at the moment, but I'll ASAP

Thanks

Jacques

Le 08/01/2019 à 06:10, Deepak Nigam a écrit :

Hello all,

I tried to set the session timeout for the 'ecommerce' and the
'webtools' components using  of web.xml, but unable to

do

so. Session for the logged-in user remains active even after the set

time.

On further research, I found that we did some changes in this area in

the

ticket OFBIZ-6655 .

We

have hard coded the session timeout (1 hr) in the sessionCreated()

method

of ControlEventListner class. As per the comments in the Jira ticket,
session timeout declarations in web.xml have been removed by the use
of @WebListner annotation. This is to avoid duplicates things

everywhere

in

web.xml files. Since the web.xml files have precedence on annotations,

the

setting can be easily overridden when necessary.

But the @WebListner is missing in the ControlEventListner class. Also,

I

am

unable to override the session timeout in web.xml even after putting

the

@WebListner annotation in ControlEventListner class.

Please let me know if this is a real issue or I am doing something

wrong?

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.

Re: Unused jQuery MockJax Plugin

[Jacques Le Roux]

Hi Aditya, Michael,

Yes indeed it's not used in OFBiz, I think we are good to remove it and mention 
it in OFBIZ-9978

Jacques

Le 10/01/2019 à 11:37, Aditya Sharma a écrit :

  Thanks for the quick response Michael.

Indeed it was upgraded with the Jquery upgrade at
https://issues.apache.org/jira/browse/OFBIZ-9978  but there was no trace of
its use. Even I couldn't find it being loaded.
I guess it is used by jquery.validation for test
https://github.com/jquery-validation/jquery-validation/blob/master/test/test.js
&
must have been added in OFBiz by mistake.


Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Thu, Jan 10, 2019 at 2:55 PM Michael Brohl 
wrote:


Hi Aditya,

a quick search shows that it was added in r1815824 by Jacques for the
update from Jquery 1.11.0 to JQuery 3.2.1.

Maybe it's a dependency or part of the Jquery stack?

Regards,

Michael

Am 10.01.19 um 10:07 schrieb Aditya Sharma:

Hello all,

I can't find any use of the jQuery MockJax
 Plugin included in OFBiz.

If

it is not used anywhere, we can remove it.

Is there anything I am missing?

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]

Re: Unused jQuery MockJax Plugin

[Aditya Sharma]

 Thanks for the quick response Michael.

Indeed it was upgraded with the Jquery upgrade at
https://issues.apache.org/jira/browse/OFBIZ-9978  but there was no trace of
its use. Even I couldn't find it being loaded.
I guess it is used by jquery.validation for test
https://github.com/jquery-validation/jquery-validation/blob/master/test/test.js
&
must have been added in OFBiz by mistake.


Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Thu, Jan 10, 2019 at 2:55 PM Michael Brohl 
wrote:

> Hi Aditya,
>
> a quick search shows that it was added in r1815824 by Jacques for the
> update from Jquery 1.11.0 to JQuery 3.2.1.
>
> Maybe it's a dependency or part of the Jquery stack?
>
> Regards,
>
> Michael
>
> Am 10.01.19 um 10:07 schrieb Aditya Sharma:
> > Hello all,
> >
> > I can't find any use of the jQuery MockJax
> >  Plugin included in OFBiz.
> If
> > it is not used anywhere, we can remove it.
> >
> > Is there anything I am missing?
> >
> > Thanks and Regards,
> >
> > *Aditya Sharma* | Enterprise Software Engineer
> > HotWax Commerce  by HotWax Systems
> > 
> > [image: https://www.linkedin.com/in/aditya-p-sharma/]
> > 
> >
>
>

Re: Unused jQuery MockJax Plugin

[Michael Brohl]

Hi Aditya,

a quick search shows that it was added in r1815824 by Jacques for the 
update from Jquery 1.11.0 to JQuery 3.2.1.


Maybe it's a dependency or part of the Jquery stack?

Regards,

Michael

Am 10.01.19 um 10:07 schrieb Aditya Sharma:

Hello all,

I can't find any use of the jQuery MockJax
 Plugin included in OFBiz. If
it is not used anywhere, we can remove it.

Is there anything I am missing?

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]






smime.p7s
Description: S/MIME Cryptographic Signature

Unused jQuery MockJax Plugin

[Aditya Sharma]

Hello all,

I can't find any use of the jQuery MockJax
 Plugin included in OFBiz. If
it is not used anywhere, we can remove it.

Is there anything I am missing?

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

[Jacques Le Roux]

Thanks Deepak,

I'll have a look ASAP

Jadques

Le 10/01/2019 à 09:26, Deepak Nigam a écrit :

Hello all,

In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(),
system fetches the webAppInfo by using the
method ComponentConfig.getWebappInfo(). In this method, serverId and
applicationName are passed as the arguments.

*WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"), UtilHttp.getApplicationName(request));*

If the mount-point of the web app is set as an empty string, then 'root'
will be used as the application name, due to which the object webAppInfo
will come null. If the webAppInfo is null then the autoLogin cookie will
not be created and added to the response object by the system.

Suggestions are welcomed to handle this scenario.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd

Unable to set the autoLogin Cookie when mount-point is set as an empty string

[Deepak Nigam]

Hello all,

In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(),
system fetches the webAppInfo by using the
method ComponentConfig.getWebappInfo(). In this method, serverId and
applicationName are passed as the arguments.

*WebappInfo webappInfo = ComponentConfig.getWebappInfo((String)
context.getAttribute("_serverId"), UtilHttp.getApplicationName(request));*

If the mount-point of the web app is set as an empty string, then 'root'
will be used as the application name, due to which the object webAppInfo
will come null. If the webAppInfo is null then the autoLogin cookie will
not be created and added to the response object by the system.

Suggestions are welcomed to handle this scenario.


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd