from:"Jacques Le Roux $Commented$ $JIRA$"

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-20 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258121#comment-13258121
]

Jacques Le Roux commented on OFBIZ-4813:

I guess for the spinner in Tomahawk you need to check the Theme setting (path
to images). But then it gets maybe more complicated and it's easier to keep the
duplicated gif.

About AJAX_SERVER_REPLY_MSG_REGEXPATTERN. I'd prefer to keep the message in the
layered popup instead of in an alert box, except if you want to resolve the
i18n issue: just try with French to see what I mean...

ajax autocomplete and dialog during session timeout
---

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
Fix For: SVN trunk

Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch,
ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif

1. autocomplete feature shows the message no records found during a session
timeout. This could be misleading for the user.
2. During a session timeout, clicking on ajax dialog button shows a large
frame containing a message indicating session has timeout. Should show a
more detailed message.
3. All ajax dialogs are on the left of browser window.
A number of fixes have been implemented for this issue.
1. At session timeout, user enters a character into autocomplete input box
results in a alert window popup.
2. At session timeout, clicking on ajax dialog button will cause alert window
to popup.
3. A large round spinner is shown when the ajax dialog is loading. This
spinner image comes from http://mentalized.net/activity-indicators/ and is
royalty free. Note the round spinner does not show in Tomahawk theme as it
uses its own spinner.
4. Now all ajax dialogs are centered.
5. Change session timeout message to something more detailed.
6. Server response to ajax request now contain html tags.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-20 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258289#comment-13258289
]

Jacques Le Roux commented on OFBIZ-4813:

Wai,

Of course this was after applying the additional patch

# So I have this change in the css, else I'd not speak about it as an issue
# It's clearly showing the French message and accents are not handled. I
quickly tried some workaounds and gave up. Accents are handled when the message
is shown in the layered popup, that's why I did not want to waste too much time
on it. In the popup is ok with me, not need for an alert box
# Seems that it depends on theme, I did not see it with Tomahawk but yes with
others it shows

ajax autocomplete and dialog during session timeout
---

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
Fix For: SVN trunk

Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch,
ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-20 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258291#comment-13258291
]

Jacques Le Roux commented on OFBIZ-4813:

Of course, for the point 1, I removed the spinner from Tomahawk and it does not
show, at least here...

ajax autocomplete and dialog during session timeout
---

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
Fix For: SVN trunk

Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch,
ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-20 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258302#comment-13258302
]

Jacques Le Roux commented on OFBIZ-4813:

Oops, sorry I checked you are right for the Tomahawk spinner. I got conflict
with your additional patch (certainly some hunk where already in) somehow I did
not spot I had still

background-image:url(/tomahawk/images/spinner.gif);

One worry less ;)

ajax autocomplete and dialog during session timeout
---

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
Fix For: SVN trunk

Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch,
ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-19 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257840#comment-13257840
]

Jacques Le Roux commented on OFBIZ-4813:

Wai,

Are you sure that removing the spinner in Tomahawk works? Here it does not it
seems...

Also I did not see any spinner repeated before. Is there a specific use case to
reproduce?

ajax autocomplete and dialog during session timeout
---

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
Fix For: SVN trunk

Attachments: ofbiz-4813-additional.patch, ofbiz-4813.patch,
ofbiz-4813.patch, ofbiz-4813.patch, spinner.gif

[jira] [Commented] (OFBIZ-2729) special security should be required for setting passwords

2012-04-19 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258034#comment-13258034
 ] 

Jacques Le Roux commented on OFBIZ-2729:


Ping

  special security should be required for setting passwords
 --

 Key: OFBIZ-2729
 URL: https://issues.apache.org/jira/browse/OFBIZ-2729
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
Reporter: Si Chen

  This issue was first brought up here: 
 https://sourceforge.net/forum/message.php?msg_id=7496877
  Basically, any user with PARTYMGR_CREATE/UPDATE  permissions can set the 
 password of another user. This creates opportunity for  Malfeasance. For 
 example, a customer service rep  could set the password of the admin user.
 A simple solution would be to create a new security permission 
 PARTYMGR_PASSWD  and require that permission  for setting or changing 
 password of a different user, instead of using PARTYMGR_UPDATE.  
 PARTYMGR_PASSWD  could then be associated with  the administrative user.
  An alternative is to use the SECURITY_UPDATE  permission instead of 
 PARTYMGR_UPDATE  or  a new PARTYMGR_PASSWD  permission.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4760) catalog of the XML schema of Ofbiz for Eclipse

2012-04-18 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256235#comment-13256235
 ] 

Jacques Le Roux commented on OFBIZ-4760:


Thanks for Confluence update Francis

 catalog of the XML schema of Ofbiz for Eclipse
 --

 Key: OFBIZ-4760
 URL: https://issues.apache.org/jira/browse/OFBIZ-4760
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Francis ANDRE
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: .catalog.xml


 Hi
 This the catalog of the XML schema of Ofbiz for Eclipse. Just import it and 
 this will avoid Eclipse to go to the web for checking the xml files against 
 their schema.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4822) eCommerce Profile Improve Button Naming Consistency

2012-04-18 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256676#comment-13256676
]

Jacques Le Roux commented on OFBIZ-4822:

Tom,

authview quickly fixed for now at r1327562
Interesting:
{quote}
That said the authview is used inconsistently in eCommerce and only in the ftl
files in the Customer folder.
It calls the authview request in the controller which sets https before calling
main view.
The donePage call is set to viewprofile, which sets https, from all of the edit
forms off viewprofile.
So authview does not appear to be adding any value. The code would be clearer
without it.
{quote}

I tend to agree from what yo are saying (no review I mean). Would you mind to
provide a patch to remove it, did you test it?

{quote}
It is not completely clear to me where donePage is picking up is value.
{quote}
I had a look before committing, since this is in the profile screen, and at the
top of it there is a call to the editperson screen, then it's intially set
there with default-value=viewprofile

I agree with your 3 points, good catches. I saw also that you put the buttons
at top and bottom where they were missing (maybe it was you say in point 3.
BTW...)

eCommerce Profile Improve Button Naming Consistency
---

Key: OFBIZ-4822
URL: https://issues.apache.org/jira/browse/OFBIZ-4822
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: demo-trunk
Reporter: Tom Burns
Assignee: Jacques Le Roux
Priority: Minor
Fix For: SVN trunk

Attachments: OFBIZ-4822 eCommerce Profile GoBack Improvement.patch

This follows from OFBIZ-4814 bug fix.
In eCommerce the naming and display of back buttons is inconsistent across
the Profile Editing screens.
Example:
Changes Password label should be Go Back but is [Go Back]

[jira] [Commented] (OFBIZ-4812) Avoid the ClassNotFoundException on the jdbc driver used by jackrabbit component

2012-04-17 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255411#comment-13255411
 ] 

Jacques Le Roux commented on OFBIZ-4812:


Jacopo,

* About r1308085: it's really harmless and I can't see any issues with that. 
* r1326300 is really something important for Eclipse users, notably those wich 
uses releases where the schemas (XSDs) on site are not in sync with their XML 
files. I still wait Francis's documentation about that on wiki BTW ;)

I guess Francis is more interested by debugging mode than running in Eclipse. 
Else I agree it does not make sense.

 Avoid the ClassNotFoundException on the jdbc driver used by jackrabbit 
 component
 

 Key: OFBIZ-4812
 URL: https://issues.apache.org/jira/browse/OFBIZ-4812
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3, Sun SDK 1.6.0_30, PostgreSQL 9.2
Reporter: Francis ANDRE
 Attachments: jackrabbit-core-2.3.3.jar


 Hi
 When running ofbiz under Eclipse with the sources directories as classpath 
 and not the ofbiz-*.jar, the jcr component fails to load the jdbc driver 
 because jackrabbit-core is using Class.forName() instead of using the current 
 classloader of the thread. see https://issues.apache.org/jira/browse/JCR-3288
 I provide with this issue a jackrabbit-core-2.3.3.jar patched as described in 
 the JCR-3288 issue.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4812) Avoid the ClassNotFoundException on the jdbc driver used by jackrabbit component

2012-04-17 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255425#comment-13255425
 ] 

Jacques Le Roux commented on OFBIZ-4812:


I must say I never crossed issues using the other method (direct debug run) as 
well... I could revert r1308085, Francis?

 Avoid the ClassNotFoundException on the jdbc driver used by jackrabbit 
 component
 

 Key: OFBIZ-4812
 URL: https://issues.apache.org/jira/browse/OFBIZ-4812
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3, Sun SDK 1.6.0_30, PostgreSQL 9.2
Reporter: Francis ANDRE
 Attachments: jackrabbit-core-2.3.3.jar


 Hi
 When running ofbiz under Eclipse with the sources directories as classpath 
 and not the ofbiz-*.jar, the jcr component fails to load the jdbc driver 
 because jackrabbit-core is using Class.forName() instead of using the current 
 classloader of the thread. see https://issues.apache.org/jira/browse/JCR-3288
 I provide with this issue a jackrabbit-core-2.3.3.jar patched as described in 
 the JCR-3288 issue.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4812) Avoid the ClassNotFoundException on the jdbc driver used by jackrabbit component

2012-04-17 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255426#comment-13255426
 ] 

Jacques Le Roux commented on OFBIZ-4812:


I do the same than Sascah, actually this is clearly explained for a long time 
at  
https://cwiki.apache.org/confluence/display/OFBIZ/Running+and+Debugging+OFBiz+in+Eclipse

Francis did you follow those advices before creating OFBIZ-4777?


 Avoid the ClassNotFoundException on the jdbc driver used by jackrabbit 
 component
 

 Key: OFBIZ-4812
 URL: https://issues.apache.org/jira/browse/OFBIZ-4812
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3, Sun SDK 1.6.0_30, PostgreSQL 9.2
Reporter: Francis ANDRE
 Attachments: jackrabbit-core-2.3.3.jar


 Hi
 When running ofbiz under Eclipse with the sources directories as classpath 
 and not the ofbiz-*.jar, the jcr component fails to load the jdbc driver 
 because jackrabbit-core is using Class.forName() instead of using the current 
 classloader of the thread. see https://issues.apache.org/jira/browse/JCR-3288
 I provide with this issue a jackrabbit-core-2.3.3.jar patched as described in 
 the JCR-3288 issue.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-17 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255912#comment-13255912
]

Jacques Le Roux commented on OFBIZ-4813:

Hi Wai,

Agreed on CommonSessionTimeoutPleaseLogIn change. Better having it only in
English than keeping confusing/worrying previous even if we lose some
translation.

Agreed on removal of code requestUrl = getViewNameWithSeparator(requestUrl) +
...:

I let you provide a new patch to apply soon.

Thanks

ajax autocomplete and dialog during session timeout
---

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai
Attachments: ofbiz-4813.patch, spinner.gif

[jira] [Commented] (OFBIZ-4822) eCommerce Profile Improve Button Naming Consistency

2012-04-17 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255922#comment-13255922
 ] 

Jacques Le Roux commented on OFBIZ-4822:


Tom,

double checking I found
{code}
Modified: 
ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/changepassword.ftl
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/changepassword.ftl?rev=1327269r1=1327268r2=1327269view=diff
==
--- 
ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/changepassword.ftl
 (original)
+++ 
ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/customer/changepassword.ftl
 Tue Apr 17 20:12:11 2012
@@ -17,9 +17,10 @@ specific language governing permissions 
 under the License.
 --
 div class=screenlet
-  h2${uiLabelMap.PartyChangePassword}/h2
-  a href=@ofbizUrlauthview/${donePage}/@ofbizUrl 
class=button[${uiLabelMap.CommonGoBack}]/a
-  a href=javascript:document.getElementById('changepasswordform').submit() 
class=button[${uiLabelMap.CommonSave}]/a
+  h2${uiLabelMap.PartyChangePassword}/h2  
+  nbsp;a href=@ofbizUrl${donePage}/@ofbizUrl 
class=button${uiLabelMap.CommonGoBack}/a
+  nbsp;a 
href=javascript:document.getElementById('changepasswordform').submit() 
class=button${uiLabelMap.CommonSave}/a
{code}

I guess the authview/ removing was not intended, right?

 eCommerce Profile Improve Button Naming Consistency
 ---

 Key: OFBIZ-4822
 URL: https://issues.apache.org/jira/browse/OFBIZ-4822
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: demo-trunk
Reporter: Tom Burns
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4822 eCommerce Profile GoBack Improvement.patch


 This follows from OFBIZ-4814 bug fix.
 In eCommerce the naming and display of back buttons is inconsistent across 
 the Profile Editing screens.
 Example:
 Changes Password label should be Go Back but is [Go Back]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-17 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256038#comment-13256038
]

Jacques Le Roux commented on OFBIZ-4813:

Sounds good,I will wait a timeout to check before committing. I wonder if we
should not also replace the Tomahawk spinner?

ajax autocomplete and dialog during session timeout
---

Key: OFBIZ-4813
URL: https://issues.apache.org/jira/browse/OFBIZ-4813
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Wai
Assignee: Jacques Le Roux
Attachments: ofbiz-4813.patch, ofbiz-4813.patch, ofbiz-4813.patch,
spinner.gif

[jira] [Commented] (OFBIZ-4810) createPartyContactMech: check for infoString is done without using the contactMechTypeId

2012-04-16 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254649#comment-13254649
 ] 

Jacques Le Roux commented on OFBIZ-4810:


Hi Michael,

You commented out 
{code}
entity-one entity-name=ContactMechType 
value-field=contactMechType
field-map field-name=contactMechTypeId 
from-field=partyAndContactMech.contactMechTypeId/
/entity-one
{code}

But you left 
{code}
if-compare operator=equals value=N field=contactMechType.hasTable/
{code}

This is inconsistent. Did you intend to also remove the check upon 
contactMechType.hasTable (and forgot)? And then why to remove this check?

BTW I'd use rather if-compare-field, but that's very minor.

 createPartyContactMech: check for infoString is done without using the 
 contactMechTypeId
 

 Key: OFBIZ-4810
 URL: https://issues.apache.org/jira/browse/OFBIZ-4810
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk
Reporter: Michael Brohl
Assignee: Sascha Rodekamp
 Fix For: SVN trunk

 Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch


 The check for an existing infoString should use the contactMechTypeId.
 I will provide a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4814) eCommerce Profile Back Button Fail

2012-04-16 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255302#comment-13255302
]

Jacques Le Roux commented on OFBIZ-4814:

Hi Tom,

There are actually 3 parts in this issue. And you should deliver a patch for
each. Let me explain:
# is a bug fix and should be backported in branches releases
# is an improvement and should go only in trunk
# is a bug fix but should go only in trunk. I thought about it this weekend but
believed I had only forgot the debug labels in the template so waited for
someone to react. It was worse indeed.

I'd have separated the commits by myself but did not quickly spot the part 1

Thanks for your help!

eCommerce Profile Back Button Fail
--

Key: OFBIZ-4814
URL: https://issues.apache.org/jira/browse/OFBIZ-4814
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: demo-trunk
Reporter: Tom Burns
Priority: Minor
Attachments: OFBIZ-4814 eCommerce Profile GoBack.patch

1. Some navigation buttons reached from the eCommerce Profile screen fail to
return to the Profile screen.
Example:
Login as DemoCustomer
Click Profile
Click Update In the Contact Information Postal Address section.
Click Go Back
Expected: Return to profile page
Actual: Remain on Edit Contact Information page
2. Naming and display of back buttons is inconsistent across Profile Editing
screens.
Example:
Changes Password label should be Go Back but is [Go Back]
3. Create New Postal Address fails from OFBIZ-4801 Rev 1326397
Error message
State/Province --
Selected\Expected State Name = Expression selectedStateName is undefined on
line 163, column 42 in
component://ecommerce/webapp/ecommerce/customer/editcontactmech.ftl. The
problematic instruction: -- == ${selectedStateName} [on line 163,

[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

2012-04-16 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255311#comment-13255311
 ] 

Jacques Le Roux commented on OFBIZ-4813:


Wai,

About the point 4: I purposely decided to put the layered Ajax box at top left 
because it allows an easier maximisation. When centered, if you want to 
increase the surface you have 1st to move it to top left, then increase. When 
in top left one dragging gesture et voilà.

I don't know what others think about that
{code}
 property key=CommonSessionTimeoutPleaseLogIn
-value xml:lang=deSie sind nicht mehr angemeldet. Bitte melden Sie 
sich erneut an./value
-value xml:lang=enYou are not logged in. Please login again./value
-value xml:lang=esNo estÃ¡ conectado. Por favor, vuelva a 
conectarse./value
-value xml:lang=viBáº¡n chÆ°a Ä‘Äƒng nháºp. Vui lÃ²ng Ä‘Äƒng 
nháºp láº¡i./value
+value xml:lang=enYour session has expired.  A login is required.  
You can refresh the page or save your data to login./value
{code}

Why did you replace this (I don't say it's wrong, just to understand what was 
wrong)
{code}
-}
-requestUrl = getViewNameWithSeparator(requestUrl) + presentation= + 
presentation;
+}
{code}

{code}
+var queryArgs = presentation= + presentation;
 if (typeof args == object  jQuery.isArray(args)) {
 for (var i = 0; i  args.length; i++) {
-requestUrlAndArgs += parm + i + = + 
jQuery(args[i]).val();
+queryArgs += parm + i + = + jQuery(args[i]).val();
{code}

If you introduce a timeout, it should be configurable (property)
{code}
+jQuery.ajax({
+type: post,
+url: requestUrl,
+data: queryArgs,
+timeout: 5000,
{code}

Thanks

 ajax autocomplete and dialog during session timeout
 ---

 Key: OFBIZ-4813
 URL: https://issues.apache.org/jira/browse/OFBIZ-4813
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Reporter: Wai
 Attachments: ofbiz-4813.patch, spinner.gif


 1. autocomplete feature shows the message no records found during a session 
 timeout.  This could be misleading for the user.
 2. During a session timeout, clicking on ajax dialog button shows a large 
 frame containing a message indicating session has timeout.  Should show a 
 more detailed message.
 3. All ajax dialogs are on the left of browser window.
 A number of fixes have been implemented for this issue.
 1. At session timeout, user enters a character into autocomplete input box 
 results in a alert window popup.
 2. At session timeout, clicking on ajax dialog button will cause alert window 
 to popup.
 3. A large round spinner is shown when the ajax dialog is loading.  This 
 spinner image comes from http://mentalized.net/activity-indicators/ and is 
 royalty free.  Note the round spinner does not show in Tomahawk theme as it 
 uses its own spinner.
 4. Now all ajax dialogs are centered.
 5. Change session timeout message to something more detailed.
 6. Server response to ajax request now contain html tags.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4815) PATCH to enable NOT-IN operator to performFind

2012-04-16 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255314#comment-13255314
 ] 

Jacques Le Roux commented on OFBIZ-4815:


Thanks Daniel,

Looks good to me, I will test later

 PATCH to enable NOT-IN operator to performFind
 --

 Key: OFBIZ-4815
 URL: https://issues.apache.org/jira/browse/OFBIZ-4815
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Daniel Riquelme
Priority: Minor
  Labels: patch
 Fix For: SVN trunk

 Attachments: OFBIZ-FindServices_NOT-IN.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 This patch will enable NOT-IN operator to the performFind service.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4814) eCommerce Profile Back Button Fail

2012-04-16 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255324#comment-13255324
 ] 

Jacques Le Roux commented on OFBIZ-4814:


You can forget about the point 3, I committed the fix at revision: 1326933  


 eCommerce Profile Back Button Fail
 --

 Key: OFBIZ-4814
 URL: https://issues.apache.org/jira/browse/OFBIZ-4814
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: demo-trunk
Reporter: Tom Burns
Priority: Minor
 Attachments: OFBIZ-4814 eCommerce Profile GoBack.patch


 1. Some navigation buttons reached from the eCommerce Profile screen fail to 
 return to the Profile screen.
 Example:
 Login as DemoCustomer
 Click Profile
 Click Update In the Contact Information  Postal Address section.
 Click Go Back
 Expected: Return to profile page
 Actual: Remain on Edit Contact Information page
 2. Naming and display of back buttons is inconsistent across Profile Editing 
 screens.
 Example:
 Changes Password label should be Go Back but is [Go Back]
 3. Create New Postal Address fails from OFBIZ-4801 Rev 1326397
 Error message
 State/Province --  
 Selected\Expected State Name = Expression selectedStateName is undefined on 
 line 163, column 42 in 
 component://ecommerce/webapp/ecommerce/customer/editcontactmech.ftl. The 
 problematic instruction: -- == ${selectedStateName} [on line 163,
 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4803) Improve Eclipse integration

2012-04-15 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254292#comment-13254292
 ] 

Jacques Le Roux commented on OFBIZ-4803:


Please Francis, open another issue, linked to this one, for the jackrabbit 
patched jar

THanks

 Improve Eclipse integration
 ---

 Key: OFBIZ-4803
 URL: https://issues.apache.org/jira/browse/OFBIZ-4803
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3, Sun SDK 1.6;0_30, PostgreSQL 9.2
Reporter: Francis ANDRE
 Attachments: jackrabbit-core-2.3.3.jar, ofbiz-eclipse.patch


 Hi
 I suggest to improve the integration of ofbiz under Eclipse by adding 4 
 lauching configurations:
 tools/ofbiz.start
 tools/ofbiz.stop
 tools/ofbiz.status
 tools/ofbiz.test
 The ofbiz.start has the specific JVM  property DEBUG set to the value of 
 eclipse -DDEBUG=eclipse so that all ofbiz jars located under each build/lib 
 won't be loaded/added to the classpath. This will allow to continue producing 
 all ofbiz jars with the build.xml while allowing hot replacement of classes 
 when running under the Eclipse's debug launcher.
 Also, I added to this issue a patched version of the 
 jackrabbit-core-2.3.3.jar that should replace the one in the 
 framework/jcr/lib to avoid the jdbc driver exception: See 
 https://issues.apache.org/jira/browse/JCR-3288
 Hope this help

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3155) Enhancing the useability of SFA by including an overview of the agreements of the account into the Account Screen

2012-04-15 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254297#comment-13254297
 ] 

Jacques Le Roux commented on OFBIZ-3155:


Pierre,

As I said (No review) I just created a new patch, no review, hence no commit

 Enhancing the useability of SFA by including an overview of the agreements of 
 the account into the Account Screen
 -

 Key: OFBIZ-3155
 URL: https://issues.apache.org/jira/browse/OFBIZ-3155
 Project: OFBiz
  Issue Type: Improvement
  Components: marketing
Reporter: Pierre Smits
 Fix For: SVN trunk

 Attachments: OFBIZ-3155 sfa-accounts-agreements.patch, 
 sfa-accounts-agreements.patch


 This improvement includes:
 Adding an overview of associated agreements with the account to the account 
 screen
 Adding the functionality to create agreements from the account screen, with 
 setting the default agreement parties (Company and the account)
 The modifications are realized on:
 \applications\accounting\widgets\agreementscreen.xml - setting default 
 agreement parties
 \applications\party\webapp\partymgr\static\partymgr.css - including of style 
 elements for overviews in the bottom position of account screen
 \applications\party\widget\partymgr\profilescreens.xml  - including a screen 
 for partyAgreements
 \applications\party\widget\partymgr\partyforms.xml - including a form to 
 render the overview of agreements for accounts
 \applications\marketing\widget\sfa\sfamenus.xml - including the menu to 
 create new agreements from the acount screen
 \applications\marketing\widget\sfa\commonscreen.xml - including functionality 
 to add the overview of agreements to the bottom of the account screen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4808) Missing helpscreens for Project Mgr application

2012-04-15 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254312#comment-13254312
 ] 

Jacques Le Roux commented on OFBIZ-4808:


Pierre,

Once again, we don't commit improvements in releases branches. This is not a 
bug, nothing crashes or behaves incorrectly, this is an improvement.

This said we could make an exception for help files, like we did in others 
cases (I don't cleary remember when, maybe adding label). 
Because there are very few chances that they introduce regression. Then this 
should be discussed in dev ML

 Missing helpscreens for Project Mgr application
 ---

 Key: OFBIZ-4808
 URL: https://issues.apache.org/jira/browse/OFBIZ-4808
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release Branch 11.04
Reporter: Pierre Smits
 Fix For: Release Branch 11.04

 Attachments: OFBIZ-4808-r11_04-ProjectMgr-helpscreens.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Fixing the missing help screens in project mgr app of R11.04 branch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4797) eCommerce Edit Contact Information use Dependent drop-downs

2012-04-15 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254348#comment-13254348
 ] 

Jacques Le Roux commented on OFBIZ-4797:


Sorry Tom,

Your patch does not apply:

D:\workspace\ofbizCleanpatch -N -p0  0OFBIZ-4797 eCommerce Draft.patch
patching file specialpurpose/ecommerce/widget/CustomerScreens.xml
patching file specialpurpose/ecommerce/widget/CommonScreens.xml
patching file 
specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditContactMech.groovy
patching file 
specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl
Hunk #4 FAILED at 173.
1 out of 4 hunks FAILED -- saving rejects to file 
specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl.rej

rejected:
{code}
--- specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl
+++ specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl
@@ -176,15 +173,23 @@
   input type=text class='inputBox' size=12 maxlength=10 
name=postalCode value=${postalAddressData.postalCode?if_exists} /
 */td
   /tr
-  tr
-td align=right valign=top${uiLabelMap.PartyCountry}/td
-tdnbsp;/td
-td
-  select name=countryGeoId class='selectBox'
-#if postalAddressData.countryGeoId?existsoption 
value='${postalAddressData.countryGeoId}'${selectedCountryName?default(postalAddressData.countryGeoId)}/option/#if
-
${screens.render(component://common/widget/CommonScreens.xml#countries)}
+  tr   
+td align=right valign=top${uiLabelMap.CommonCountry} Postal 
address geoId ${postalAddress.countryGeoId}/td
+tdnbsp;/td  
+td 
+  select name=countryGeoId id=editcontactmechform_countryGeoId
+  
${screens.render(component://common/widget/CommonScreens.xml#countries)}  
  
+  #if (postalAddress?exists)  (postalAddress.countryGeoId?exists)
+#assign defaultCountryGeoId = postalAddress.countryGeoId
+  #else
+#assign defaultCountryGeoId = 
Static[org.ofbiz.base.util.UtilProperties].getPropertyValue(general.properties,
 country.geo.id.default)
+  /#if
+  option selected=selected value=${defaultCountryGeoId}
+  #assign countryGeo = 
delegator.findByPrimaryKey(Geo,Static[org.ofbiz.base.util.UtilMisc].toMap(geoId,defaultCountryGeoId))
+${countryGeo.get(geoName,locale)}
+  /option
   /select
-*/td
+/td
   /tr
 #elseif contactMechTypeId = TELECOM_NUMBER
   tr
{code}

 eCommerce Edit Contact Information use Dependent drop-downs
 ---

 Key: OFBIZ-4797
 URL: https://issues.apache.org/jira/browse/OFBIZ-4797
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: demo-trunk
Reporter: Tom Burns
Assignee: Jacques Le Roux
Priority: Minor
 Attachments: OFBIZ-4797 eCommerce Draft.patch


 Using Dependent drop-downs to filter the State drop down based on the 
 selection in the Country drop-down will improve the usability of the 
 component.
 Current Behavior:
 1. Open eCommerce application
 2. Log in as user with Postal Address say Demo Customer
 3. In the menu bar select Profile
 4. In Contact Information  Postal Address select update.
 5. The Country drop-down value is United States and the State/Province 
 drop-down list displays all geo values.
 After improvement:
 5. The Country drop-down value is United States and the State/Province 
 drop-down list is limited to States in the United States.
 6. Changing the value in the Country drop-down will update State/Province 
 drop-down list with values for the selected country.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4797) eCommerce Edit Contact Information use Dependent drop-downs

2012-04-15 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254389#comment-13254389
]

Jacques Le Roux commented on OFBIZ-4797:

About
{quote}
Dependent Drop Down
The Dependent drop down State/Province defaults to the first record after a
refresh from the Country Postal address.
The State/Province should be blank after a refresh and throw an alert if none
is selected.
For example if the Country changes from US to United Kingdom then Aberdeenshire
is selected.
The selection should be the responsibility of the user.
{quote}

I will not change the way the dependent dropdowns work, too much work and
regression possibilities. Anyway, it's the user responsability to change the
province/state value. Feel free to customise locally...

For other points I agree that issues should be created

eCommerce Edit Contact Information use Dependent drop-downs
---

Key: OFBIZ-4797
URL: https://issues.apache.org/jira/browse/OFBIZ-4797
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: demo-trunk
Reporter: Tom Burns
Assignee: Jacques Le Roux
Priority: Minor
Attachments: OFBIZ-4797 eCommerce Draft.patch, OFBIZ-4797 eCommerce
Draft.patch

Using Dependent drop-downs to filter the State drop down based on the
selection in the Country drop-down will improve the usability of the
component.
Current Behavior:
1. Open eCommerce application
2. Log in as user with Postal Address say Demo Customer
3. In the menu bar select Profile
4. In Contact Information Postal Address select update.
5. The Country drop-down value is United States and the State/Province
drop-down list displays all geo values.
After improvement:
5. The Country drop-down value is United States and the State/Province
drop-down list is limited to States in the United States.
6. Changing the value in the Country drop-down will update State/Province
drop-down list with values for the selected country.

[jira] [Commented] (OFBIZ-4760) catalog of the XML schema of Ofbiz for Eclipse

2012-04-14 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254066#comment-13254066
 ] 

Jacques Le Roux commented on OFBIZ-4760:


Quoting Francis on dev ML:
{quote}
Yes, I think so... See the Oasis catalog specification 
http://www.oasis-open.org/committees/download.php/14810/xml-catalogs.pdf
and also the wiki http://en.wikipedia.org/wiki/XML_Catalog
{quote}



 catalog of the XML schema of Ofbiz for Eclipse
 --

 Key: OFBIZ-4760
 URL: https://issues.apache.org/jira/browse/OFBIZ-4760
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Francis ANDRE
 Attachments: .catalog.xml


 Hi
 This the catalog of the XML schema of Ofbiz for Eclipse. Just import it and 
 this will avoid Eclipse to go to the web for checking the xml files against 
 their schema.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4239) The framework/base tests fail

2012-04-14 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254067#comment-13254067
 ] 

Jacques Le Roux commented on OFBIZ-4239:


Trying again locally, could someone else confirm?

 The framework/base tests fail
 -

 Key: OFBIZ-4239
 URL: https://issues.apache.org/jira/browse/OFBIZ-4239
 Project: OFBiz
  Issue Type: Test
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Trivial
 Fix For: SVN trunk


 Thanks to Adrian's explanation in http://markmail.org/message/ihpdviifcnmk2mhz
 {quote}
 1. The framework/base component unit tests ran successfully.
 2. A new testing framework was introduced and that framework skipped the 
 framework/base unit tests.
 3. Over time, changes were made to framework/base code that caused the 
 tests to fail, but no one noticed because the tests were not being run.
 4. Rev 1085735 fixed the issue that was preventing the framework/base 
 tests from being run.
 5. Now the framework/base tests run, but they fail due to #3.
 {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4239) The framework/base tests fail

2012-04-14 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254074#comment-13254074
]

Jacques Le Roux commented on OFBIZ-4239:

Trying again with
ant clean-all load-demo run-tests
used only
ant load-demo run-tests
last time...

Could be the reason since I used OFBiz for other reasons before...

The framework/base tests fail
-

Key: OFBIZ-4239
URL: https://issues.apache.org/jira/browse/OFBIZ-4239
Project: OFBiz
Issue Type: Test
Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Trivial
Fix For: SVN trunk

Thanks to Adrian's explanation in http://markmail.org/message/ihpdviifcnmk2mhz
{quote}
1. The framework/base component unit tests ran successfully.
2. A new testing framework was introduced and that framework skipped the
framework/base unit tests.
3. Over time, changes were made to framework/base code that caused the
tests to fail, but no one noticed because the tests were not being run.
4. Rev 1085735 fixed the issue that was preventing the framework/base
tests from being run.
5. Now the framework/base tests run, but they fail due to #3.
{quote}

[jira] [Commented] (OFBIZ-4239) The framework/base tests fail

2012-04-14 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254087#comment-13254087
 ] 

Jacques Le Roux commented on OFBIZ-4239:


BUILD SUCCESSFUL is here


 The framework/base tests fail
 -

 Key: OFBIZ-4239
 URL: https://issues.apache.org/jira/browse/OFBIZ-4239
 Project: OFBiz
  Issue Type: Test
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Trivial
 Fix For: SVN trunk

 Attachments: basetests.xml


 Thanks to Adrian's explanation in http://markmail.org/message/ihpdviifcnmk2mhz
 {quote}
 1. The framework/base component unit tests ran successfully.
 2. A new testing framework was introduced and that framework skipped the 
 framework/base unit tests.
 3. Over time, changes were made to framework/base code that caused the 
 tests to fail, but no one noticed because the tests were not being run.
 4. Rev 1085735 fixed the issue that was preventing the framework/base 
 tests from being run.
 5. Now the framework/base tests run, but they fail due to #3.
 {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4805) Change shipping order address failed

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253451#comment-13253451
 ] 

Jacques Le Roux commented on OFBIZ-4805:


Sorry Nicolas, this patch does not apply

 Change shipping order address failed
 

 Key: OFBIZ-4805
 URL: https://issues.apache.org/jira/browse/OFBIZ-4805
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Priority: Minor
 Attachments: OFBIZ-4805.patch


 When you select a new shipping address in order view, operation failed 
 because the service that update orderItemShipGroup haven't all information on 
 carrier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253578#comment-13253578
 ] 

Jacques Le Roux commented on OFBIZ-4768:


I'd recommned Extra as a complete Flat Grey theme variation rather

 Improvement for flatgrey theme
 --

 Key: OFBIZ-4768
 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Reporter: Wai
Priority: Trivial
 Attachments: after-sample-catalogmgr1.png, 
 after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, 
 after-sample-catalogmgr2.png, after-sample-partymgr.png, 
 after-sample-partymgr.png, after-sample-webtools.png, 
 after-sample-webtools.png, before-sample-catalogmgr1.png, 
 before-sample-catalogmgr2.png, before-sample-partymgr.png, 
 before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, 
 ofbiz-4768.patch, ofbiz-style1.patch, ofbiz-style2.patch


 Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4805) Change shipping order address failed

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253706#comment-13253706
 ] 

Jacques Le Roux commented on OFBIZ-4805:


Hi Nicolas,

Before applying your patch on trunk demo I had any problems (but the states 
dependent dropdown not working at load when creating the new adress in the 
layered popup, unrelated).
After having applied your patch locally I have also any issues.

I just would like to know in which case you encoutered this issue to reproduce. 
A carrier must be used?

Note: for both I used DEMO10090 order

 Change shipping order address failed
 

 Key: OFBIZ-4805
 URL: https://issues.apache.org/jira/browse/OFBIZ-4805
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Priority: Minor
 Attachments: OFBIZ-4805.patch, OFBIZ-4805.patch


 When you select a new shipping address in order view, operation failed 
 because the service that update orderItemShipGroup haven't all information on 
 carrier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4763) create and use startup profiles

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253775#comment-13253775
 ] 

Jacques Le Roux commented on OFBIZ-4763:


I closed OFBIZ-3162 as duplicate

 create and use startup profiles
 ---

 Key: OFBIZ-4763
 URL: https://issues.apache.org/jira/browse/OFBIZ-4763
 Project: OFBiz
  Issue Type: New Feature
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
Assignee: Erwan de FERRIERES
 Fix For: SVN trunk


 from this thread 
 http://ofbiz.135035.n4.nabble.com/OFBiz-integration-in-Apache-sonar-instance-td4484597.html
 we should be able to choose a profile when starting OFBiz, which will 
 configure at least the ports used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3490) Create theme build script

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253782#comment-13253782
 ] 

Jacques Le Roux commented on OFBIZ-3490:


HI BJ,

Should we keep this issue open and try to commit your ant task, or close and 
rely on the [wiki 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Visual+Themes+-+How+to] ?

 Create theme build script
 -

 Key: OFBIZ-3490
 URL: https://issues.apache.org/jira/browse/OFBIZ-3490
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Release Branch 09.04, SVN trunk
 Environment: ant build
Reporter: BJ Freeman
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: 3490-themebutild.patch


 I liked the build script for a new component, so I decided to make one for 
 themes.
 unfortunately I am not able to do a patch so included the script.
 I made it so you can pick a  theme as the template and copy the files over to 
 the new theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3907) Product Promo Worker description patch

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253783#comment-13253783
 ] 

Jacques Le Roux commented on OFBIZ-3907:


Ping

 Product Promo Worker description patch
 --

 Key: OFBIZ-3907
 URL: https://issues.apache.org/jira/browse/OFBIZ-3907
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-3907ProductPromoWorker.java.patch, 
 OFBIZ-3907ProductPromoWorker.java.patch


 This patch extend the order adjustment creation. If an order adjustment is 
 created from a product promo the promo text will stores in the order 
 adjustment description. This helps identifying the order adjustment and later 
 on the invoice item type : ITM_PROMOTION_ADJ.
 So long
 Sascha

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4351) Static text for reports at the ordermanager replaced by labels

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253789#comment-13253789
 ] 

Jacques Le Roux commented on OFBIZ-4351:


Ping (before closing)

 Static text for reports at the ordermanager replaced by labels
 --

 Key: OFBIZ-4351
 URL: https://issues.apache.org/jira/browse/OFBIZ-4351
 Project: OFBiz
  Issue Type: Improvement
Reporter: Christian Fischer
Assignee: Jacques Le Roux
 Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, 
 ReportForms.xml.patch, ReportScreens.xml.patch


 Patch includes
 AccountinguiLabels (one missing translation)
 OrderUiLabels (added missing labels for the reports)
 and of course the edited ReportForms and ReportScreens

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4041) Materialized views

2012-04-13 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253818#comment-13253818
]

Jacques Le Roux commented on OFBIZ-4041:

Mmm, I removed this last patch. It seems that there are some chunks which were
rejected and I did not notice.

Materialized views
--

Key: OFBIZ-4041
URL: https://issues.apache.org/jira/browse/OFBIZ-4041
Project: OFBiz
Issue Type: New Feature
Components: framework
Affects Versions: SVN trunk
Reporter: Marc Morin
Assignee: Jacques Le Roux
Attachments: OFBIZ-4041.patch

We make extensive use of view entities in our ofbiz application. We have
noticed that when there is a large dataset and under some complex views, the
query performance was not the best (not a index issue, just complex joins,
etc...).
With some commercial databases like Oracle, etc... we would have used
materialized view semantics available for these dbms, but we are using
PostgreSQL.
So, we have extended the entity layer in Ofbiz to perform the
materialization. This is pretty slick as all you need to do is the following:
view-entity name=myView materialize=true.../view-entity
and the system will do the following:
- create a backing entity called myView that has the same fields as the view
- backing entity has all the indexes inherited from the component entities
- relations (fk,...) inherited from the component entities.
- perform all the ECA actions automatically on all entities used in the view
(direct members and nested members if case of view on views). (This is an
eager update strategy only).
So, the application doesn't change, it still accesses myView, but now, it's
result is returned from the backing entity instead of the complex SQL
statement.
We're pretty excited about this feature!!! Really pushes Ofbiz framework to
next level and allows materialized views to be more broadly used on dbms that
don't naturally support it.
We are prepared to contribute this feature back to the community if desired.
A note of caution about it though we have added a visitor pattern to the
model entities and this feature makes use of it. It would need to come with
it.

[jira] [Commented] (OFBIZ-4793) unify admin port and key setting: single point of definition in start.properties

2012-04-12 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252555#comment-13252555
 ] 

Jacques Le Roux commented on OFBIZ-4793:


Hi Francis,

You are right, I don't expect much confusion (since we can still search) but 
good point, I will remove that

 unify admin port and key setting: single point of definition in 
 start.properties
 

 Key: OFBIZ-4793
 URL: https://issues.apache.org/jira/browse/OFBIZ-4793
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 Sun SDK 1.6.0_30
Reporter: Francis ANDRE
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: ofbiz-admin-port.patch


 Hi
 If someone wants to change the admin password or port, he would have to 
 change currently many files (-- build.xml, various .bat and .sh --). In order 
 to avoid this error-prone pratice, I suggest to centralize the definition of 
 the admin kay and port at 2 single points: the 
 framework/start/src/org/ofbiz/base/start/start.properties and the 
 framework/start/src/org/ofbiz/base/start/jetty.properties
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4793) unify admin port and key setting: single point of definition in start.properties

2012-04-11 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251494#comment-13251494
 ] 

Jacques Le Roux commented on OFBIZ-4793:


Hi Francis,

It looks good to me

All,

Should we not also change the default values in start.java, using those that 
are in the properties file?

 unify admin port and key setting: single point of definition in 
 start.properties
 

 Key: OFBIZ-4793
 URL: https://issues.apache.org/jira/browse/OFBIZ-4793
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 Sun SDK 1.6.0_30
Reporter: Francis ANDRE
Priority: Minor
 Attachments: ofbiz-admin-port.patch


 Hi
 If someone wants to change the admin password or port, he would have to 
 change currently many files (-- build.xml, various .bat and .sh --). In order 
 to avoid this error-prone pratice, I suggest to centralize the definition of 
 the admin kay and port at 2 single points: the 
 framework/start/src/org/ofbiz/base/start/start.properties and the 
 framework/start/src/org/ofbiz/base/start/jetty.properties
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4793) unify admin port and key setting: single point of definition in start.properties

2012-04-11 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251826#comment-13251826
 ] 

Jacques Le Roux commented on OFBIZ-4793:


Francis,

Yes I know, but I mean instead of 

String adminPortStr = getProp(props, ofbiz.admin.port, 0);
adminKey = getProp(props, ofbiz.admin.key, NA);

 unify admin port and key setting: single point of definition in 
 start.properties
 

 Key: OFBIZ-4793
 URL: https://issues.apache.org/jira/browse/OFBIZ-4793
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 Sun SDK 1.6.0_30
Reporter: Francis ANDRE
Assignee: Jacques Le Roux
Priority: Minor
 Attachments: ofbiz-admin-port.patch


 Hi
 If someone wants to change the admin password or port, he would have to 
 change currently many files (-- build.xml, various .bat and .sh --). In order 
 to avoid this error-prone pratice, I suggest to centralize the definition of 
 the admin kay and port at 2 single points: the 
 framework/start/src/org/ofbiz/base/start/start.properties and the 
 framework/start/src/org/ofbiz/base/start/jetty.properties
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4793) unify admin port and key setting: single point of definition in start.properties

2012-04-11 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251905#comment-13251905
 ] 

Jacques Le Roux commented on OFBIZ-4793:


Missed config.java in r1324989, added at r1324990

 unify admin port and key setting: single point of definition in 
 start.properties
 

 Key: OFBIZ-4793
 URL: https://issues.apache.org/jira/browse/OFBIZ-4793
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 Sun SDK 1.6.0_30
Reporter: Francis ANDRE
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: ofbiz-admin-port.patch


 Hi
 If someone wants to change the admin password or port, he would have to 
 change currently many files (-- build.xml, various .bat and .sh --). In order 
 to avoid this error-prone pratice, I suggest to centralize the definition of 
 the admin kay and port at 2 single points: the 
 framework/start/src/org/ofbiz/base/start/start.properties and the 
 framework/start/src/org/ofbiz/base/start/jetty.properties
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4787) Party Manager Default Country in Update

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249482#comment-13249482
 ] 

Jacques Le Roux commented on OFBIZ-4787:


Tom,

Please open a new Jira for It's Country can not be changed because a foreign 
missing parameter on a call to updateEftAccount.

Thanks

 Party Manager Default Country in Update
 ---

 Key: OFBIZ-4787
 URL: https://issues.apache.org/jira/browse/OFBIZ-4787
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk
 Environment: demo-trunk
Reporter: Tom Burns
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: Release Branch 11.04, SVN trunk

 Attachments: OFBIZ-4787 defaultCountryGeoId.patch


 In Party Manager  Profile  Contact Information  Update  the Country drop 
 down always defaults to United States. 
 This is misleading if the Country is not United States. 
 If a user were to change some other address element he/she would have to also 
 re-set Country to keep it from being changed to United States. 
 To reproduce:
 In Party Manager lookup a party with a Postal Address say DemoSupplier*
 In Contact Information  Postal Address Click Update
 In the Country field select any country but United States say Switzerland
 Click Save
 Note - 
 Expect drop down default after save = Switzerland
 Actual drop down default after save = United States
 Click Go Back
 Expect Postal Address country = Switzerland
 Actual Postal Address country = Switzerland
 Click 
 Click Update
 Expect drop down default to be Switzerland
 Actual United States
 * Note: 
 Select any party but Company.  
 It's Country can not be changed because a foreign missing parameter on a call 
 to updateEftAccount.
 This may be a separate issue. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4792) Using GZip compression for js/css files

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249504#comment-13249504
 ] 

Jacques Le Roux commented on OFBIZ-4792:


You are missing a point Mandeep.

OFBiz is already compressing text files. This is done through the embedded 
Tomcat. See in ofbiz-containers.xml
{code}
property name=compressableMimeType value=text/html,text/xml,text/plain/
property name=compression value=on/
{code}

Reference: http://tomcat.apache.org/tomcat-7.0-doc/config/http.html

So my proposition was only to add an yui-compressor-ant-task to compress those 
files as described here http://developer.yahoo.com/yui/compressor/


 Using GZip compression for js/css files
 ---

 Key: OFBIZ-4792
 URL: https://issues.apache.org/jira/browse/OFBIZ-4792
 Project: OFBiz
  Issue Type: New Feature
  Components: ALL APPLICATIONS, specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: Windows/Linux
Reporter: Mandeep Sidhu
Priority: Trivial
  Labels: build, compression, features, javascript
 Fix For: SVN trunk

   Original Estimate: 72h
  Remaining Estimate: 72h

 I was wondering if it is possible to reduce the size of external 
 javascript's/css files being fetched by making use of GZip encoding.
 The feeding server does understand and responds to GZip encoding, however 
 Ofbiz is not requesting the content in GZip format.
 Kindly include this feature so that Ofbiz will include the GZip encoding 
 option in the http header while requesting the external javascript file ?
 Also, if possible integrate the compressor module 
 http://code.google.com/p/yui-compressor-ant-task/
 as suggested by Jacques (Jacques Le Roux jacques.le.roux)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4792) Using GZip compression for js/css files

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249505#comment-13249505
 ] 

Jacques Le Roux commented on OFBIZ-4792:


Note that for bigest files we already use compressed versions (ending by 
min.js, see framework/common/widget/CommonScreens.xml)

 Using GZip compression for js/css files
 ---

 Key: OFBIZ-4792
 URL: https://issues.apache.org/jira/browse/OFBIZ-4792
 Project: OFBiz
  Issue Type: New Feature
  Components: ALL APPLICATIONS, specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: Windows/Linux
Reporter: Mandeep Sidhu
Priority: Trivial
  Labels: build, compression, features, javascript
 Fix For: SVN trunk

   Original Estimate: 72h
  Remaining Estimate: 72h

 I was wondering if it is possible to reduce the size of external 
 javascript's/css files being fetched by making use of GZip encoding.
 The feeding server does understand and responds to GZip encoding, however 
 Ofbiz is not requesting the content in GZip format.
 Kindly include this feature so that Ofbiz will include the GZip encoding 
 option in the http header while requesting the external javascript file ?
 Also, if possible integrate the compressor module 
 http://code.google.com/p/yui-compressor-ant-task/
 as suggested by Jacques (Jacques Le Roux jacques.le.roux)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4792) Using GZip compression for js/css files

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249506#comment-13249506
 ] 

Jacques Le Roux commented on OFBIZ-4792:


and specialpurpose/ecommerce/widget/CommonScreens.xml

 Using GZip compression for js/css files
 ---

 Key: OFBIZ-4792
 URL: https://issues.apache.org/jira/browse/OFBIZ-4792
 Project: OFBiz
  Issue Type: New Feature
  Components: ALL APPLICATIONS, specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: Windows/Linux
Reporter: Mandeep Sidhu
Priority: Trivial
  Labels: build, compression, features, javascript
 Fix For: SVN trunk

   Original Estimate: 72h
  Remaining Estimate: 72h

 I was wondering if it is possible to reduce the size of external 
 javascript's/css files being fetched by making use of GZip encoding.
 The feeding server does understand and responds to GZip encoding, however 
 Ofbiz is not requesting the content in GZip format.
 Kindly include this feature so that Ofbiz will include the GZip encoding 
 option in the http header while requesting the external javascript file ?
 Also, if possible integrate the compressor module 
 http://code.google.com/p/yui-compressor-ant-task/
 as suggested by Jacques (Jacques Le Roux jacques.le.roux)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4794) set different ports for testing in a CI environment (e.g. Jenkins)

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249527#comment-13249527
 ] 

Jacques Le Roux commented on OFBIZ-4794:


Nope, please see [my answer on dev 
ML|http://markmail.org/message/i4u5pijlclgtzwrm]. Also I recommend to add 1 
(not 1 ;) ) to *all* ports in test-containers.xml, even those commented 
out, etc.

 set different ports for testing in a CI environment (e.g. Jenkins)
 --

 Key: OFBIZ-4794
 URL: https://issues.apache.org/jira/browse/OFBIZ-4794
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
 Fix For: SVN trunk

 Attachments: OFBIZ-4794-test-ports.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 In order to run test targets in Jenkins we need to change ports for at least 
 ajp, http and https in test-containers.xml as these ports are most likely to 
 be already in use by the CI server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4792) Add a yui-compressor-ant-task

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249530#comment-13249530
 ] 

Jacques Le Roux commented on OFBIZ-4792:


Commited initial work at revision: 1310983  


 Add a yui-compressor-ant-task
 -

 Key: OFBIZ-4792
 URL: https://issues.apache.org/jira/browse/OFBIZ-4792
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
 Environment: Windows/Linux
Reporter: Mandeep Sidhu
Assignee: Jacques Le Roux
Priority: Trivial
  Labels: build, compression, css, features, javascript
 Fix For: SVN trunk


 The idea is to create an ant task which uses 
 [YUICompressor|http://developer.yahoo.com/yui/compressor/] to dynamically 
 minify our own (or custom for users) js and css files (most of the bigest 
 external ones are already compressed)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4787) Party Manager Default Country in Update

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249574#comment-13249574
]

Jacques Le Roux commented on OFBIZ-4787:

Thank you for the compliment. Actually it's not that hidden. If you look at the
examples:
https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples#DropDownFieldsExampleForm_geoId_title

But I must say a clear example with Freemarker was missing indeed.

Looking forwar for eCommerce and Facility. A Jira for each would be better...

Party Manager Default Country in Update
---

Key: OFBIZ-4787
URL: https://issues.apache.org/jira/browse/OFBIZ-4787
Project: OFBiz
Issue Type: Bug
Components: party
Affects Versions: SVN trunk
Environment: demo-trunk
Reporter: Tom Burns
Assignee: Jacques Le Roux
Priority: Minor
Fix For: Release Branch 11.04, SVN trunk

Attachments: OFBIZ-4787 defaultCountryGeoId.patch

In Party Manager Profile Contact Information Update the Country drop
down always defaults to United States.
This is misleading if the Country is not United States.
If a user were to change some other address element he/she would have to also
re-set Country to keep it from being changed to United States.
To reproduce:
In Party Manager lookup a party with a Postal Address say DemoSupplier*
In Contact Information Postal Address Click Update
In the Country field select any country but United States say Switzerland
Click Save
Note -
Expect drop down default after save = Switzerland
Actual drop down default after save = United States
Click Go Back
Expect Postal Address country = Switzerland
Actual Postal Address country = Switzerland
Click
Click Update
Expect drop down default to be Switzerland
Actual United States
* Note:
Select any party but Company.
It's Country can not be changed because a foreign missing parameter on a call
to updateEftAccount.
This may be a separate issue.

[jira] [Commented] (OFBIZ-4782) load field info by a factory

2012-04-08 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249606#comment-13249606
 ] 

Jacques Le Roux commented on OFBIZ-4782:


Hi Nicolas,

You missed to add
import org.ofbiz.widget.form.FieldInfoFactory;

BTW do you use EXTERN_WIDGET in your own code? Will this not break when a wrong 
fiels type (typo for instance) will be used?


 load field info by a factory
 

 Key: OFBIZ-4782
 URL: https://issues.apache.org/jira/browse/OFBIZ-4782
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Priority: Minor
  Labels: field, screen, widget
 Attachments: OFBIZ-4782.patch


 Improve field info loading by a factory as screen loading.
 this issue is also a helper to define specific customer field without break 
 or modify OFBiz class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4789) Move applications and/or components from their current location to a new location in the OFBiz file hierarchy

2012-04-07 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249314#comment-13249314
 ] 

Jacques Le Roux commented on OFBIZ-4789:


We decided rather to use tasks and SlimDown version than creating sub-tasks. 
Easier to track down said Jacopo, we can keep this main task see if we need it 
though... http://markmail.org/message/ig24enwhs6eth4bl

 Move applications and/or components from their current location to a new 
 location in the OFBiz file hierarchy
 -

 Key: OFBIZ-4789
 URL: https://issues.apache.org/jira/browse/OFBIZ-4789
 Project: OFBiz
  Issue Type: Task
  Components: ALL APPLICATIONS, ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Pierre Smits
 Fix For: SlimDown


 This is the main improvement task to identify the applications, components 
 and/or component parts that the OFBiz community wants to be moved from their 
 current location to another in the file hierarchy.
 Any application, component and/or component part identified for this should 
 be registered as a sub task.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3920) HtmlFormRenderer : with attribute skip-start, lookup fields are broken

2012-04-06 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248228#comment-13248228
 ] 

Jacques Le Roux commented on OFBIZ-3920:


Hi Nicolas,

I wanted to apply your patch and close this issue, OFBIZ-2282 being another 
task. But it's outdated. I guess on your side you merged, could you please 
create a new patch?

 HtmlFormRenderer : with attribute skip-start, lookup fields are broken
 --

 Key: OFBIZ-3920
 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
 Project: OFBiz
  Issue Type: Bug
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: skipStartWithLookup.patch


 When you want to merge to form and use skip-start=true on the second form, 
 all contained lookup are broken. In this case, the javascript used to call 
 Lookup screen are using the form name eg : 'a 
 href=javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', 
 ...)', but with skip-start, the form name isn't present.
 A possible solution is to force lookup field id, but it's not managed on 
 htmlFormMacroLibrary.ftl. I will submit a patch to make this possible. 
 I don't manage problem on descriptionField, this would need to change 
 ModelFormRender and it's a little bit more complicated ;)
 Nicolas

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4775) add a status target to build.xml for getting the status of Ofbiz

2012-04-04 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246102#comment-13246102
 ] 

Jacques Le Roux commented on OFBIZ-4775:


Hi Francis,

Yes, don't get me wrong, it was just to generally explain this point of our 
best practices which, I thought, could maybe not be obvious to you.


 add a status target to build.xml for getting the status of Ofbiz
 

 Key: OFBIZ-4775
 URL: https://issues.apache.org/jira/browse/OFBIZ-4775
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Francis ANDRE
Assignee: Jacopo Cappellato
Priority: Minor
 Attachments: ofbiz-build.xml.patch


 Hi
 This is a minor new target for getting the status of the ofbiz server.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4779) Add an ant task/code/script for dropping all datas from the database

2012-04-03 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245057#comment-13245057
 ] 

Jacques Le Roux commented on OFBIZ-4779:


I agree with Jacopo, I prefer to rely on pgAgmin or such tools and do it by 
hand, it's not often and that hard you want to drop a DB and not that long to 
populate. And like Pierre said the tables/key/indexes phases creation are not 
the longer steps, loading data is longer.

Also since the DB is still (slowly now) evolving, it would require to maintain 
the script when we try to slim down and delegate as much as possible...

 Add an ant task/code/script for dropping all datas from the database
 

 Key: OFBIZ-4779
 URL: https://issues.apache.org/jira/browse/OFBIZ-4779
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 Sun JDK 1.6.0_30 Postgres 9.1
Reporter: Francis ANDRE

 Hi
 It would be nice to have an ant task or a script for cleaning/removing all 
 datas in the databases so that one can restart reloading the seed, 
 seed-initial and then its own data file.
 When developing a new environment for ofbiz, one has always to fix bugs on 
 the entities values in this datafile until it is properly cleaned up. Thus, 
 avoiding the unnecessary create tables/key/indexes phases will shorten the 
 development cycle.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4775) add a status target to build.xml for getting the status of Ofbiz

2012-04-03 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245060#comment-13245060
 ] 

Jacques Le Roux commented on OFBIZ-4775:


Hi Francis,

Good idea. To complete/explain Jacopo's request: we decided some years ago it's 
better to discuss/share new ideas, wishes, etc. in a new thread in dev ML 
before opening a new Jira or adding in one.

Thanks

 add a status target to build.xml for getting the status of Ofbiz
 

 Key: OFBIZ-4775
 URL: https://issues.apache.org/jira/browse/OFBIZ-4775
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Francis ANDRE
Assignee: Jacopo Cappellato
Priority: Minor
 Attachments: ofbiz-build.xml.patch


 Hi
 This is a minor new target for getting the status of the ofbiz server.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4778) Issue in placing an order with a configurable good product without selecting any of the addons associated with it

2012-04-03 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245073#comment-13245073
 ] 

Jacques Le Roux commented on OFBIZ-4778:


Hi,

Could you please describe in more details the issue/s you crossed?

Thanks

 Issue in placing an order with a configurable good product without selecting 
 any of the addons associated with it
 -

 Key: OFBIZ-4778
 URL: https://issues.apache.org/jira/browse/OFBIZ-4778
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Abdul Khadeer
 Fix For: SVN trunk


 Issue in placing an order with a configurable good product without selecting 
 any of the addons associated with it. The code was working with the condition 
 AGGREGATED_CONF.equals(product.getString(productTypeId)) in the trunk 
 revision 122062212/19/11 12:10 PM, but this issue was raised in the 
 revision 1235698 1/25/12 2:31 PM in which the condition was changed to 
 EntityTypeUtil.hasParentType(delegator, ProductType, productTypeId, 
 product.getString(productTypeId), parentTypeId, AGGREGATED).
 We have fixed the issue by switching to the old conditions, let us know if 
 there is any better way to do that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4776) Avoid exiting ofbiz when running in debug mode,i.e with -DDEBUG=true set on theJVM arguments

2012-04-03 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245095#comment-13245095
 ] 

Jacques Le Roux commented on OFBIZ-4776:


Francis,

I finally decided to revert 
[r1308078|http://svn.apache.org/viewvc?view=revisionrevision=1308078] due to 
[some pressure on this commit|http://markmail.org/message/zqguh6ttd2a5jqcb]
And even if I'm quite sure it's not harmful, I don't see either a great need 
for it


 Avoid exiting ofbiz when running in debug mode,i.e with -DDEBUG=true set on 
 theJVM arguments
 

 Key: OFBIZ-4776
 URL: https://issues.apache.org/jira/browse/OFBIZ-4776
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3, JDK 1.6.0_30
Reporter: Francis ANDRE
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: ofbiz-Start.java.patch


 Hi
 This is a patch for allowing to run ofbiz in debug mode,i.e with -DDEBUG=true 
 on the JVM arguments, and avoid to exit from the process when a Error or a 
 StartupException occurs.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

2012-04-02 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244024#comment-13244024
 ] 

Jacques Le Roux commented on OFBIZ-4765:


Yes sorry Markus, I just realize it this morning. I mixed with another issue I 
was working on.

 build.xml in hot-deploy folder is not called correctly in the main build.xml
 

 Key: OFBIZ-4765
 URL: https://issues.apache.org/jira/browse/OFBIZ-4765
 Project: OFBiz
  Issue Type: Wish
Affects Versions: SVN trunk
Reporter: Markus M. May
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4765-fix-buildxml.patch, 
 OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, 
 OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch


 In the current build.xml in the ofbiz-Home-folder, the build target is 
 executed for each subdirectory (framework, application, specialpurpose) with 
 the fileset: 
 filelist dir=. files=specialpurpose/build.xml/
 Only for the hot-deploy folder the fileset is quite different:
 fileset dir=${basedir}/hot-deploy casesensitive=no
exclude name=disabled/**/
include name=*/build.xml/
 /fileset
 This is calling the build.xml directly in the hot-deploy components, which is 
 an error, if you do have several dependent components in there, which needs 
 to get build in the right order. I propose to use the following filelist:
 filelist dir=. files=hot-deploy/build.xml/
 Problem could be, that not every project do have an build.xml file in this 
 folder (or is this already a requirement?). If it is not then we would need 
 to check, if this build.xml is there, then execute this, and otherwise use 
 the already existing one.
 A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

2012-04-02 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244099#comment-13244099
 ] 

Jacques Le Roux commented on OFBIZ-4765:


This seems OK with me, since the previous behaviour is kept (ie when there is 
no build.xml file in hot-deploy dir then the build.xml files - if present - in 
hot-deploy sub-dirs will be used)

Agreed, Jacopo, Hans ?

 build.xml in hot-deploy folder is not called correctly in the main build.xml
 

 Key: OFBIZ-4765
 URL: https://issues.apache.org/jira/browse/OFBIZ-4765
 Project: OFBiz
  Issue Type: Wish
Affects Versions: SVN trunk
Reporter: Markus M. May
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4765-fix-buildxml.patch, 
 OFBIZ-4765-use-hotdeploy-buildxml-if-available-2.patch, 
 OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch


 In the current build.xml in the ofbiz-Home-folder, the build target is 
 executed for each subdirectory (framework, application, specialpurpose) with 
 the fileset: 
 filelist dir=. files=specialpurpose/build.xml/
 Only for the hot-deploy folder the fileset is quite different:
 fileset dir=${basedir}/hot-deploy casesensitive=no
exclude name=disabled/**/
include name=*/build.xml/
 /fileset
 This is calling the build.xml directly in the hot-deploy components, which is 
 an error, if you do have several dependent components in there, which needs 
 to get build in the right order. I propose to use the following filelist:
 filelist dir=. files=hot-deploy/build.xml/
 Problem could be, that not every project do have an build.xml file in this 
 folder (or is this already a requirement?). If it is not then we would need 
 to check, if this build.xml is there, then execute this, and otherwise use 
 the already existing one.
 A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-04-02 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244476#comment-13244476
 ] 

Jacques Le Roux commented on OFBIZ-4768:


I must admit it's really a matter of taste because the variations are very 
slight. For instance I prefer the button in the menu bar in Wai's proposition 
but not the font used for the text in normal buttons.

Also an advantage of Wai's proposition is it's very condensed. So you see more 
of a screen but on the other hand I feel a little stress in the eyes.

I suggest to keep the current theme and to add this new version under Extras 
when the themes will be moved there...

 Improvement for flatgrey theme
 --

 Key: OFBIZ-4768
 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Reporter: Wai
Priority: Trivial
 Attachments: after-sample-catalogmgr1.png, 
 after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, 
 after-sample-catalogmgr2.png, after-sample-partymgr.png, 
 after-sample-partymgr.png, after-sample-webtools.png, 
 after-sample-webtools.png, before-sample-catalogmgr1.png, 
 before-sample-catalogmgr2.png, before-sample-partymgr.png, 
 before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, 
 ofbiz-4768.patch


 Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4779) Add an ant task/code/script for dropping all datas from the database

2012-04-02 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244485#comment-13244485
 ] 

Jacques Le Roux commented on OFBIZ-4779:


Francis,

If I understood well (from Environment: WXP SP3 Sun JDK 1.6.0_30 Postgres 9.1 
above) it's related to Postgres?

 Add an ant task/code/script for dropping all datas from the database
 

 Key: OFBIZ-4779
 URL: https://issues.apache.org/jira/browse/OFBIZ-4779
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 Sun JDK 1.6.0_30 Postgres 9.1
Reporter: Francis ANDRE

 Hi
 It would be nice to have an ant task or a script for cleaning/removing all 
 datas in the databases so that one can restart reloading the seed, 
 seed-initial and then its own data file.
 When developing a new environment for ofbiz, one has always to fix bugs on 
 the entities values in this datafile until it is properly cleaned up. Thus, 
 avoiding the unnecessary create tables/key/indexes phases will shorten the 
 development cycle.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4775) add a status target to build.xml for getting the status of Ofbiz

2012-04-01 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243688#comment-13243688
 ] 

Jacques Le Roux commented on OFBIZ-4775:


Hans, thanks for clarifying, I thought you also did not spot this, and should 
have added a question mark inside the parentheses.
Jacopo, yes I know (I'm used to change the admin key value in Linux scripts ;o) 
just wanted to make this clear.
Francis, then please complete your patch.

Thanks to all

 add a status target to build.xml for getting the status of Ofbiz
 

 Key: OFBIZ-4775
 URL: https://issues.apache.org/jira/browse/OFBIZ-4775
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Francis ANDRE
Assignee: Jacopo Cappellato
Priority: Minor
 Attachments: ofbiz-build.xml.patch


 Hi
 This is a minor new target for getting the status of the ofbiz server.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4775) add a status target to build.xml for getting the status of Ofbiz

2012-04-01 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243690#comment-13243690
 ] 

Jacques Le Roux commented on OFBIZ-4775:


Francis, it's of course also needed in stop ;)

Hans, oops my apologizes, I just realise now that this comment is totally wrong
{quote}
Finally Hans said he reverted his changes at r1304965. But he actually reverted 
only the changes inside the scripts and kept them at root.
{quote}
when you actually re-added the modified startofbiz.sh and stopofbiz.sh in root 
at r1304965, very embarrassing, excuse my mistake.

Still we have these duplicate filenames and different scripts, will this 
continue?


 add a status target to build.xml for getting the status of Ofbiz
 

 Key: OFBIZ-4775
 URL: https://issues.apache.org/jira/browse/OFBIZ-4775
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Francis ANDRE
Assignee: Jacopo Cappellato
Priority: Minor
 Attachments: ofbiz-build.xml.patch


 Hi
 This is a minor new target for getting the status of the ofbiz server.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4777) Add missing ConverterLoader to framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader for running FOBiz in debug under Eclipse

2012-04-01 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243702#comment-13243702
 ] 

Jacques Le Roux commented on OFBIZ-4777:


Francis,

Please take this commit into account in your explanation in Wiki, thanks!

 Add missing ConverterLoader to 
 framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
  for running FOBiz in debug under Eclipse
 

 Key: OFBIZ-4777
 URL: https://issues.apache.org/jira/browse/OFBIZ-4777
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 JDK 1.6.0_30
Reporter: Francis ANDRE
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: ofbiz-services.patch


 Hi
 In order to run OFBiz in debug mode under Eclipse with hot class reloading, 
 one needs to add the following Converters to the services 
 framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
  because they are added at build time by the build.xml of the framework. 
 Thus, they are missing when running OFBiz as an full Eclipse debug launcher.
 org.ofbiz.base.conversion.BooleanConverters
 org.ofbiz.base.conversion.CollectionConverters
 org.ofbiz.base.conversion.DateTimeConverters
 org.ofbiz.base.conversion.JSONConverters
 org.ofbiz.base.conversion.MiscConverters
 org.ofbiz.base.conversion.NetConverters
 org.ofbiz.base.conversion.NumberConverters
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

2012-04-01 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243705#comment-13243705
]

Jacques Le Roux commented on OFBIZ-4765:

Francis, your 2d patch will not apply since it's based on your initial change.
So you need to revert both and reapply your change.
Jacopo, I don't see any problem with the spirit of this patch. But we know some
are using other strategies coupled with ant create-component. Is it ok for you
to apply this patch? Same question for all persons interested, of course...

build.xml in hot-deploy folder is not called correctly in the main build.xml

Key: OFBIZ-4765
URL: https://issues.apache.org/jira/browse/OFBIZ-4765
Project: OFBiz
Issue Type: Wish
Affects Versions: SVN trunk
Reporter: Markus M. May
Priority: Minor
Fix For: SVN trunk

Attachments: OFBIZ-4765-fix-buildxml.patch,
OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch

In the current build.xml in the ofbiz-Home-folder, the build target is
executed for each subdirectory (framework, application, specialpurpose) with
the fileset:
filelist dir=. files=specialpurpose/build.xml/
Only for the hot-deploy folder the fileset is quite different:
fileset dir=${basedir}/hot-deploy casesensitive=no
exclude name=disabled/**/
include name=*/build.xml/
/fileset
This is calling the build.xml directly in the hot-deploy components, which is
an error, if you do have several dependent components in there, which needs
to get build in the right order. I propose to use the following filelist:
filelist dir=. files=hot-deploy/build.xml/
Problem could be, that not every project do have an build.xml file in this
folder (or is this already a requirement?). If it is not then we would need
to check, if this build.xml is there, then execute this, and otherwise use
the already existing one.
A patch will be applied for the first solution.

[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml

2012-04-01 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243709#comment-13243709
 ] 

Jacques Le Roux commented on OFBIZ-4765:


Thanks Hans,

So you agree with Francis's proposition to have a global one in hot-deploy from 
where to handle all created sub-component, right?

 build.xml in hot-deploy folder is not called correctly in the main build.xml
 

 Key: OFBIZ-4765
 URL: https://issues.apache.org/jira/browse/OFBIZ-4765
 Project: OFBiz
  Issue Type: Wish
Affects Versions: SVN trunk
Reporter: Markus M. May
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4765-fix-buildxml.patch, 
 OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch


 In the current build.xml in the ofbiz-Home-folder, the build target is 
 executed for each subdirectory (framework, application, specialpurpose) with 
 the fileset: 
 filelist dir=. files=specialpurpose/build.xml/
 Only for the hot-deploy folder the fileset is quite different:
 fileset dir=${basedir}/hot-deploy casesensitive=no
exclude name=disabled/**/
include name=*/build.xml/
 /fileset
 This is calling the build.xml directly in the hot-deploy components, which is 
 an error, if you do have several dependent components in there, which needs 
 to get build in the right order. I propose to use the following filelist:
 filelist dir=. files=hot-deploy/build.xml/
 Problem could be, that not every project do have an build.xml file in this 
 folder (or is this already a requirement?). If it is not then we would need 
 to check, if this build.xml is there, then execute this, and otherwise use 
 the already existing one.
 A patch will be applied for the first solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4777) Add missing ConverterLoader to framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader for running FOBiz in debug under Eclipse

2012-04-01 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243813#comment-13243813
 ] 

Jacques Le Roux commented on OFBIZ-4777:


Thanks Francis

 Add missing ConverterLoader to 
 framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
  for running FOBiz in debug under Eclipse
 

 Key: OFBIZ-4777
 URL: https://issues.apache.org/jira/browse/OFBIZ-4777
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: WXP SP3 JDK 1.6.0_30
Reporter: Francis ANDRE
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: ofbiz-services.patch


 Hi
 In order to run OFBiz in debug mode under Eclipse with hot class reloading, 
 one needs to add the following Converters to the services 
 framework/entity/src/META-INF/services/org.ofbiz.base.conversion.ConverterLoader
  because they are added at build time by the build.xml of the framework. 
 Thus, they are missing when running OFBiz as an full Eclipse debug launcher.
 org.ofbiz.base.conversion.BooleanConverters
 org.ofbiz.base.conversion.CollectionConverters
 org.ofbiz.base.conversion.DateTimeConverters
 org.ofbiz.base.conversion.JSONConverters
 org.ofbiz.base.conversion.MiscConverters
 org.ofbiz.base.conversion.NetConverters
 org.ofbiz.base.conversion.NumberConverters
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4775) add a status target to build.xml for getting the status of Ofbiz

2012-03-31 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243234#comment-13243234
 ] 

Jacques Le Roux commented on OFBIZ-4775:


Hi Francis,

This is ambiguous because it will not work on Windows (even if I'm sure few 
people use Windows servers)... Also a typo: statuc 
2 possiblities:
# add the same in startofbiz.bat (ie 
ADMIN_PORT=10523
ADMIN_KEY=so3du5kasd5dn
ADMIN=-Dofbiz.admin.port=$ADMIN_PORT -Dofbiz.admin.key=$ADMIN_KEY
# Change the description to =Display status of OFBiz when running in Unix like 
platform


 add a status target to build.xml for getting the status of Ofbiz
 

 Key: OFBIZ-4775
 URL: https://issues.apache.org/jira/browse/OFBIZ-4775
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Francis ANDRE
Priority: Minor
 Attachments: ofbiz-build.xml.patch


 Hi
 This is a minor new target for getting the status of the ofbiz server.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4775) add a status target to build.xml for getting the status of Ofbiz

2012-03-31 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243278#comment-13243278
 ] 

Jacques Le Roux commented on OFBIZ-4775:


This is what I get running _ant status_ if I launch OFBiz using _ant run_:
{code}
D:\workspace\ofbizCleanC:\Program Files\Java\jdk1.6.0_22\bin\java -jar 
framework/base/lib/ant-launcher-1.8.2.jar -lib framework/base/lib/ant status
Buildfile: D:\workspace\ofbizClean\build.xml

status:
 [java] debug: args=[-status]
 [java] debug: command=STATUS
 [java] debug: loaderArgs=[]
 [java] Start.java using configuration file 
org/ofbiz/base/start/start.properties
 [java] Set OFBIZ_HOME to - D:/workspace/ofbizClean
 [java] Current Status : Running

BUILD SUCCESSFUL
Total time: 1 second
D:\workspace\ofbizClean
{code}

But this is what I get running OFBiz using _/tools/startofbiz.bat_
{code}
D:\workspace\ofbizCleanC:\Program Files\Java\jdk1.6.0_22\bin\java -jar 
framework/base/lib/ant-launcher-1.8.2.jar -lib framework/base/lib/ant status
Buildfile: D:\workspace\ofbizClean\build.xml

status:
 [java] Start.java using configuration file 
org/ofbiz/base/start/start.properties
 [java] Set OFBIZ_HOME to - D:/workspace/ofbizClean
 [java] debug: args=[-status]
 [java] debug: command=STATUS
 [java] debug: loaderArgs=[]
 [java] Could not connect to /127.0.0.1:10523
 [java] Current Status : OFBiz is Down

BUILD SUCCESSFUL
Total time: 2 seconds
{code}
Hence my concern about consistency.

Now about startofbiz.bat, here is the history and the reasons of this other 
inconsistency:
# Jacopo decided to move scripts and such from OFBiz root to the tools folder. 
In the same time he changed the code inside the start/stopofbiz.sh scripts
# Hans decided it was not good for start/stopofbiz.sh scripts because he needed 
them in root (seems that adding /tools before was too much an effort,not sure 
why...). So he moved back the start/stopofbiz.sh from tools to root and removed 
the changes in scripts.
# Jacopo asked Hans to revert his changes
# Finally Hans said he reverted his changes at 
[r1304965|http://svn.apache.org/viewvc?view=revisionrevision=1304965]. But he 
actually reverted only the changes inside the scripts and kept them at root.

So we ended with this platforms inconsistency. Only a vote could decide about 
these changes but not sure the community is really worried about that...

 add a status target to build.xml for getting the status of Ofbiz
 

 Key: OFBIZ-4775
 URL: https://issues.apache.org/jira/browse/OFBIZ-4775
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Francis ANDRE
Priority: Minor
 Attachments: ofbiz-build.xml.patch


 Hi
 This is a minor new target for getting the status of the ofbiz server.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4775) add a status target to build.xml for getting the status of Ofbiz

2012-03-31 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243280#comment-13243280
 ] 

Jacques Le Roux commented on OFBIZ-4775:


In other words, Hans's comment on 
[r1304965|http://svn.apache.org/viewvc?view=revisionrevision=1304965]
{quote}
reverting revision 1304679 and 1304687, however leaving the original 
startofbiz.sh and stopofbiz.sh in the root deirectory, this in order not to 
block furher development
{quote}
is also inconsistent because he actually reverted only r1304687. Saying 
Reverting r1304679 and saying however leaving the original startofbiz.sh and 
stopofbiz.sh in the root deirectory, this in order not to block furher 
development is inconsistent (or dishonest). I did not check, relying on the 
comment I thought that temporary copies was kept in root until the changes were 
done on his end. I discovered today it was not, a least so far...


 add a status target to build.xml for getting the status of Ofbiz
 

 Key: OFBIZ-4775
 URL: https://issues.apache.org/jira/browse/OFBIZ-4775
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Francis ANDRE
Priority: Minor
 Attachments: ofbiz-build.xml.patch


 Hi
 This is a minor new target for getting the status of the ofbiz server.
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3790) email password broken

2012-03-31 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243283#comment-13243283
 ] 

Jacques Le Roux commented on OFBIZ-3790:


BREMA Dev Team,

Your patch is in trunk at r 1307895. But I put this note in the commit comment: 
{quote}
This uses  general.properties, defaultFromEmailAddress. So to work 
correctly it still needs defaultFromEmailAddress (default 
=ofbizt...@example.com), mail.smtp.relay.host (default =localhost) and such 
to be set correctly... In other words the message A new password has been 
created and sent to you. Please check your Email. could even more misleading 
if people are not aware about setting SMTP in general.properties...
{quote}

So, for now, I did not backport in releases, nor close this issue, waiting for 
the community reaction about that SMTP issue.

 email password broken
 -

 Key: OFBIZ-3790
 URL: https://issues.apache.org/jira/browse/OFBIZ-3790
 Project: OFBiz
  Issue Type: Bug
Reporter: Si Chen
Assignee: Jacques Le Roux
 Attachments: Screen shot 2010-05-28 at 9.25.05 AM.png, 
 emailPasswd.diff


 Email password feature in party manager is broken.  The log shows:
 2010-05-28 09:24:58,193 (http-0.0.0.0-8543-14) [ 
 ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, 
 encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
 2010-05-28 09:24:58,268 (http-0.0.0.0-8543-14) [ 
 RequestHandler.java:597:INFO ] Ran Event 
 [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], 
 result is [success]
 2010-05-28 09:24:58,275 (http-0.0.0.0-8543-14) [ 
 RequestHandler.java:704:INFO ] Rendering View [forgotPassword], 
 sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1
 2010-05-28 09:24:58,278 (http-0.0.0.0-8543-14) [ 
 ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: 
 component://common/widget/CommonScreens.xml
 2010-05-28 09:24:58,325 (http-0.0.0.0-8543-14) [   
 PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete 
 primary key in find: [GenericEntity:PartyNameView][partyId,null()]
 2010-05-28 09:24:58,520 (http-0.0.0.0-8543-14) [   
 ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: 
 [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28
  09:24:58.518(java.sql.Timestamp)][createdTxStamp,2010-05-28 
 09:24:58.516(java.sql.Timestamp)][hitStartDateTime,2010-05-28 
 09:24:58.193(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-05-28
  09:24:58.518(java.sql.Timestamp)][lastUpdatedTxStamp,2010-05-28 
 09:24:58.516(java.sql.Timestamp)][referrerUrl,https://ntc:8543/partymgr/control/main(java.lang.String)][requestUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][runningTimeMillis,322(java.lang.Long)][serverHostName,domU-12-31-39-00-0F-51(java.lang.String)][serverIpAddress,10.254.31.159(java.lang.String)][visitId,25693(java.lang.String)]
 2010-05-28 09:24:58,521 (http-0.0.0.0-8543-14) [ 
 ControlServlet.java:300:INFO ] [[[forgotPassword] Request Done- 
 total:0.327,since last([forgotPassword] ...):0.327]]
 2010-05-28 09:25:02,715 (http-0.0.0.0-8543-15) [ 
 ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, 
 encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
 2010-05-28 09:25:03,074 (http-0.0.0.0-8543-15) [ 
 UtilProperties.java:871:INFO ] ResourceBundle SecurityextUiLabels (en_US) 
 created in 0.12s with 53 properties
 2010-05-28 09:25:03,075 (http-0.0.0.0-8543-15) [ 
 RequestHandler.java:597:INFO ] Ran Event 
 [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], 
 result is [error]
 2010-05-28 09:25:03,110 (http-0.0.0.0-8543-15) [ 
 RequestHandler.java:400:ERROR] Request forgotPassword caused an error with 
 the following message: Problems with configuration; please contact customer 
 service.
 2010-05-28 09:25:03,111 (http-0.0.0.0-8543-15) [ 
 RequestHandler.java:704:INFO ] Rendering View [forgotPassword], 
 sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1
 2010-05-28 09:25:03,116 (http-0.0.0.0-8543-15) [ 
 ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: 
 component://common/widget/CommonScreens.xml
 2010-05-28 09:25:03,141 (http-0.0.0.0-8543-15) [   
 PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete 
 primary key in find: [GenericEntity:PartyNameView][partyId,null()]
 2010-05-28 09:25:03,380 (http-0.0.0.0-8543-15) [   
 ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: 
 [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28
  09:25:03.378(java.sql.Timestamp)][createdTxStamp,2010-05-28 
 09:25:03.376(java.sql.Timestamp)][hitStartDateTime,2010-05-28

[jira] [Commented] (OFBIZ-1645) Screens to manage Forecast in SFA webapp

2012-03-31 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243309#comment-13243309
 ] 

Jacques Le Roux commented on OFBIZ-1645:


Hi Jacopo, Chirag,

What is the status here should we close as propose Pierre (I see a patch...)?

 Screens to manage Forecast in SFA webapp
 

 Key: OFBIZ-1645
 URL: https://issues.apache.org/jira/browse/OFBIZ-1645
 Project: OFBiz
  Issue Type: New Feature
  Components: marketing
Reporter: Anil K Patel
Priority: Minor
 Attachments: forecast.patch, forecast.patch, forecast.patch, 
 forecast.patch, forecast.patch


 The screens will include:
 • Find Forecast
 • Will be a fairly simple list showing most recent first and paginated; only 
 those associated
 with a sales organization that the current user is associated with will be
 shown
 • Create/Update Forecast
 • Forecast Summary
 • Statistics about Forecast based on information in SalesForecast record and 
 associated
 SalesOpportunity records (with matching organizationPartyId for the Internal
 Sales Organization)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4591) TLD is not loaded from CLASSPATH using Tomcat 7

2012-03-31 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243313#comment-13243313
 ] 

Jacques Le Roux commented on OFBIZ-4591:


Hi Adrian, then should we not close?

 TLD is not loaded from CLASSPATH using Tomcat 7
 ---

 Key: OFBIZ-4591
 URL: https://issues.apache.org/jira/browse/OFBIZ-4591
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
 Environment: Ubntu
Reporter: Chatree Srichart
Priority: Critical
  Labels: 7, tld, tomcat
 Attachments: EnableJarScanner.patch

   Original Estimate: 168h
  Remaining Estimate: 168h

 Hi community.
 I have a problem when I render a JSP page which is defined a taglib, for 
 example:
 %@ taglib prefix=c uri=http://java.sun.com/jsp/jstl/core%
  The problem is TLD definition files are not loaded from CLASSPATH using 
 Tomcat 7.
 To solve this problem we need to delete this line from CatalinaContainer.java 
 file:
 standardJarScanner.setScanClassPath(false);
 because the standard jar scanner is set the default value as true
 After we have done above, we will get these problems.
 =
 1. JAR files are conflicted by different webapp contexts
 =
 The ScheduledExecutorService that submit all webapp contexts does not run 
 them respectively. For example:
 Context(1)
 Context(2)
 Context(3)
 A particular context will read all JAR files from CLASSPATH. The problem is, 
 for example, the Context(2) will start to read all JAR files even though the 
 Context(1) does not finish its task yet. So the Context (2) will not be able 
 to read some JAR file that the Context(1) is reading and causes an error.
 ===
 2. WebslingerAccessLogValve class does not support Tomcat 7
 ===
 If the jar scanner scan jar files from CLASSPATH, it will find 
 WebslingerAccessLogValve class which does not support Tomcat 7
 ===
 3. groovy.jmx.builder.package-info class cannot be loaded
 ===
 groovy.jmx.builder.package-info class cannot be loaded because its name is 
 incorrect. If I remove this class from 
 framework/base/lib/scripting/groovy-all-1.7.7.jar file, this line in 
 macros.xml will cause an error:
 taskdef name=groovyc classname=org.codehaus.groovy.ant.Groovyc 
 classpathref=groovy.class.path/
 
 4. Starting time will slower
 
 A particular webapp context will spend more time to parse JAR file from 
 CLASSPATH to find TLD definition files.
 However I can avoid the TLD problem by copying JAR files that contain TLD 
 definition files into /WEB-INF/lib directory of a particular webapp
 Lastly, I am not sure if we need this feature in the trunk but I think it is 
 useful. If so, please help me to solve the problems.
 Regards,
 Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4773) Migrate to JACOCO for code coverage analysis

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242276#comment-13242276
 ] 

Jacques Le Roux commented on OFBIZ-4773:


Pierre,

I suggest to discuss that on dev ML: more audience (for those who filter)

 Migrate to JACOCO for code coverage analysis
 

 Key: OFBIZ-4773
 URL: https://issues.apache.org/jira/browse/OFBIZ-4773
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: SVN trunk
Reporter: Pierre Smits

 It appears that development of cobertura has stopped since 2010-03-03. And 
 Jacoco (the other open source code coverage analysis tool) seem to be well 
 received by development communities and can also be integrated with jenkins 
 for automated builds and sonar for managing code quality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242465#comment-13242465
 ] 

Jacques Le Roux commented on OFBIZ-4768:


One thing I prefer in other themes is their dropdown menus (I already argued 
about it: why papernews have columns). But I must say that with the OFBiz slim 
down it will be at least easier to search for an Application (notably because 
OOTB they are only alphabetically ordered in English)

 Improvement for flatgrey theme
 --

 Key: OFBIZ-4768
 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Reporter: Wai
Priority: Trivial
 Attachments: after-sample-catalogmgr1.png, 
 after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, 
 after-sample-catalogmgr2.png, after-sample-partymgr.png, 
 after-sample-partymgr.png, after-sample-webtools.png, 
 after-sample-webtools.png, before-sample-catalogmgr1.png, 
 before-sample-catalogmgr2.png, before-sample-partymgr.png, 
 before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, 
 ofbiz-4768.patch


 Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242707#comment-13242707
 ] 

Jacques Le Roux commented on OFBIZ-4768:


From screenshots, I'm not quite sure I prefer the new version. I find it a bit 
more legible but this could be due to the way screenshots were taken. I will 
apply and see by myself...

 Improvement for flatgrey theme
 --

 Key: OFBIZ-4768
 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Reporter: Wai
Priority: Trivial
 Attachments: after-sample-catalogmgr1.png, 
 after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, 
 after-sample-catalogmgr2.png, after-sample-partymgr.png, 
 after-sample-partymgr.png, after-sample-webtools.png, 
 after-sample-webtools.png, before-sample-catalogmgr1.png, 
 before-sample-catalogmgr2.png, before-sample-partymgr.png, 
 before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, 
 ofbiz-4768.patch


 Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4774) Include meta tag 'generator' in the ecommerce theme

2012-03-30 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242719#comment-13242719
 ] 

Jacques Le Roux commented on OFBIZ-4774:


Could be, but not sure company will want to keep it...

 Include meta tag 'generator'  in the ecommerce theme
 

 Key: OFBIZ-4774
 URL: https://issues.apache.org/jira/browse/OFBIZ-4774
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4774-eCommerce-meta-tag-for-generator.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 We should include the tag meta name=generator content=OFBiz - eCommerce 
 into the eCommerce theme. This will help improve visibility when searching 
 for implemented webshops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4768) Improvement for flatgrey theme

2012-03-29 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241391#comment-13241391
 ] 

Jacques Le Roux commented on OFBIZ-4768:


I will try to have a look...

 Improvement for flatgrey theme
 --

 Key: OFBIZ-4768
 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Reporter: Wai
Priority: Trivial
 Attachments: after-sample-catalogmgr1.png, 
 after-sample-catalogmgr2.png, after-sample-partymgr.png, 
 after-sample-webtools.png, before-sample-catalogmgr1.png, 
 before-sample-catalogmgr2.png, before-sample-partymgr.png, 
 before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch


 Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4763) create and use startup profiles

2012-03-28 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240307#comment-13240307
 ] 

Jacques Le Roux commented on OFBIZ-4763:


I think that before doing anytning we need to review all suggestions (including 
David's) and make a mix of them keeping the best on consensus.
This could be done here of if really complicated in a new dev thread

 create and use startup profiles
 ---

 Key: OFBIZ-4763
 URL: https://issues.apache.org/jira/browse/OFBIZ-4763
 Project: OFBiz
  Issue Type: New Feature
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
Assignee: Erwan de FERRIERES
 Fix For: SVN trunk


 from this thread 
 http://ofbiz.135035.n4.nabble.com/OFBiz-integration-in-Apache-sonar-instance-td4484597.html
 we should be able to choose a profile when starting OFBiz, which will 
 configure at least the ports used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4701) renderFormClose is missing arguments containerId, hasRequiredField

2012-03-27 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239269#comment-13239269
 ] 

Jacques Le Roux commented on OFBIZ-4701:


Thanks Ashish!

 renderFormClose is missing arguments containerId, hasRequiredField
 --

 Key: OFBIZ-4701
 URL: https://issues.apache.org/jira/browse/OFBIZ-4701
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 11.04, SVN trunk
Reporter: Kiran Gawde
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: OFBIZ-4701-xxxFormMacroLibrary.patch


 In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, 
 hasRequiredField.
 But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this 
 macro.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4760) catalog of the XML schema of Ofbiz for Eclipse

2012-03-27 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239278#comment-13239278
 ] 

Jacques Le Roux commented on OFBIZ-4760:


Hi Francis,

Are you saying that this way of writing is platform and location independent?

Else we will not commit this. It would be confusing. I will rather update

https://cwiki.apache.org/confluence/display/OFBIZ/Eclipse+Tips#EclipseTips-UsinglocalXSD'swhennointernetconnectionisavailable
with content of my comment here
https://cwiki.apache.org/confluence/display/OFBIZ/Eclipse+Tips#comment-23335459

Thanks

 catalog of the XML schema of Ofbiz for Eclipse
 --

 Key: OFBIZ-4760
 URL: https://issues.apache.org/jira/browse/OFBIZ-4760
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Francis ANDRE
 Attachments: .catalog.xml


 Hi
 This the catalog of the XML schema of Ofbiz for Eclipse. Just import it and 
 this will avoid Eclipse to go to the web for checking the xml files against 
 their schema.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4761) Adding some translations for French

2012-03-27 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239283#comment-13239283
 ] 

Jacques Le Roux commented on OFBIZ-4761:


Thanks Franciss,

Some small remarks

# Are you sure for
 property key=SetupCompanyName
 value xml:lang=enOFBiz: Setup Application /value
+value xml:lang=frNom de la société/value
 value xml:lang=itOFBiz: componente di configurazione/value
 value xml:lang=pt_BROFBiz: Aplicativo de instalação/value
 value xml:lang=zhOFBiz:/value
#  property key=SetupFacility
 value xml:lang=enFacility/value
+value xml:lang=frFacilité/value
Long ago for Facility in French I have decided to use Lieu de stockage (though 
a facility could be more it's used in this sense in OFBiz. De toute façon 
Facilité n'a pas ce sens en français ;)  
# By and large, please split (any) code from labels. In case we need to revert 
it's far easier
# property key=ProductCatalogSeoCreate
 value xml:lang=enCreate SEO category/products/value
+value xml:lang=frCréer un référencement de 
categorie/produits/value
 /property
There is a notion of optimisation in SEO, but I agree it's hard to do better. 
If nobody has a better idea, référencement is ok with me


 Adding some translations for French
 ---

 Key: OFBIZ-4761
 URL: https://issues.apache.org/jira/browse/OFBIZ-4761
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: SVN trunk
Reporter: Francis ANDRE
 Attachments: ofbiz.patch


 Hi
 Here a pacth for adding some translations for French. The patch is in U8-DOS 
 encoding.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4756) ClassNotFoundException: org.eclipse.core.runtime.CoreException

2012-03-27 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239285#comment-13239285
 ] 

Jacques Le Roux commented on OFBIZ-4756:


Francis,

Since i'ts most likely that the way Birt will be integrated in OFBiz will 
change, should we not close this issue as not a problem?

 ClassNotFoundException: org.eclipse.core.runtime.CoreException
 --

 Key: OFBIZ-4756
 URL: https://issues.apache.org/jira/browse/OFBIZ-4756
 Project: OFBiz
  Issue Type: Bug
  Components: commonext/setup
Affects Versions: SVN trunk
 Environment: WXP JDK 1.6.0_25, postgres 9
Reporter: Francis ANDRE

 Hi
 Running ofbiz directly under Eclipse, I got this exception in the Eclipse 
 console while it never appears in the debug.log or ofbiz.log:
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:251:INFO ] Connector 
 AJP/1.3 @ 8009 - not-secure [org.apache.coyote.ajp.Ajp
 Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:248:INFO ] Connector 
 http-bio-0.0.0.0-8080 @ 8080 - not-secure [org.apach
 e.coyote.http11.Http11Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:248:INFO ] Connector 
 http-bio-0.0.0.0-8443 @ 8443 - secure [org.apache.co
 yote.http11.Http11Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:255:INFO ] Started 
 Apache Tomcat/7.0.26
 2012-03-25 10:53:33,500 (main) [  BirtContainer.java:50 :INFO ] Start 
 BIRT container
 2012-03-25 10:53:33,515 (main) [  BirtContainer.java:70 :INFO ] Startup 
 BIRT platform
 Exception in thread main java.lang.NoClassDefFoundError: 
 org/eclipse/core/runtime/CoreException
   at 
 org.eclipse.birt.core.framework.Platform.createPlatformLauncher(Platform.java:115)
   at org.eclipse.birt.core.framework.Platform.startup(Platform.java:74)
   at org.ofbiz.birt.container.BirtContainer.start(BirtContainer.java:71)
   at 
 org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
   at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
   at org.ofbiz.base.start.Start.start(Start.java:289)
   at org.ofbiz.base.start.Start.main(Start.java:119)
 Caused by: java.lang.ClassNotFoundException: 
 org.eclipse.core.runtime.CoreException
   at java.net.URLClassLoader$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4723) Support validation of resource xml files

2012-03-26 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238158#comment-13238158
 ] 

Jacques Le Roux commented on OFBIZ-4723:


Anne,

I don't think so, unless Jacopo and Hans also ran the test on Windows. This bug 
is only known to appear on Windows. The real background problem we have at the 
moment is really that buildbot (OFBiz official CI) does not work, but that's 
another story. Please ask them on dev ML to be sure (in case they don't spot 
our messages)

 Support validation of resource xml files
 

 Key: OFBIZ-4723
 URL: https://issues.apache.org/jira/browse/OFBIZ-4723
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: REV 1297286
Reporter: Anne Jessel
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4723_both.patch, OFBIZ-4723_code_cleanups.patch, 
 OFBIZ-4723_combined.patch, OFBIZ-4723_support-validation-resource-xml.patch


 The xsd for the resource xml files is invalid. In addition, the format of the 
 value of the xml:lang attribute in resource xml files is invalid, according 
 to the xml standard.
 The attached patch:
 * provides a valid xsd
 * updates UtilProperties and the Label Manager to deal with the correct 
 formatting of the xml:lang value, while still working with the old format, 
 following Adrian Crum's recommendation on the mailing list
 * includes simple unit tests for UtilProperties to ensure it does work with 
 both formats
 * changes the Label Manager to include a reference to the new xsd, and to use 
 the correct format of the xml:lang value, when writing a resource xml file.
 This problem exists in released versions, but I doubt it is important enough 
 to back port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4723) Support validation of resource xml files

2012-03-26 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238296#comment-13238296
 ] 

Jacques Le Roux commented on OFBIZ-4723:


Anne,

Oops, it's my fault. I had another changes pending for OFBIZ-4427 and did not 
notice I put this file in a svn changelist, so I did not commit it with the 
others. So I will revert it all reapply and commit and it should be OK.

 Support validation of resource xml files
 

 Key: OFBIZ-4723
 URL: https://issues.apache.org/jira/browse/OFBIZ-4723
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: REV 1297286
Reporter: Anne Jessel
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4723_UtilProperties_only.patch, 
 OFBIZ-4723_both.patch, OFBIZ-4723_code_cleanups.patch, 
 OFBIZ-4723_combined.patch, OFBIZ-4723_support-validation-resource-xml.patch


 The xsd for the resource xml files is invalid. In addition, the format of the 
 value of the xml:lang attribute in resource xml files is invalid, according 
 to the xml standard.
 The attached patch:
 * provides a valid xsd
 * updates UtilProperties and the Label Manager to deal with the correct 
 formatting of the xml:lang value, while still working with the old format, 
 following Adrian Crum's recommendation on the mailing list
 * includes simple unit tests for UtilProperties to ensure it does work with 
 both formats
 * changes the Label Manager to include a reference to the new xsd, and to use 
 the correct format of the xml:lang value, when writing a resource xml file.
 This problem exists in released versions, but I doubt it is important enough 
 to back port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4723) Support validation of resource xml files

2012-03-26 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238297#comment-13238297
 ] 

Jacques Le Roux commented on OFBIZ-4723:


Done at r1305316

 Support validation of resource xml files
 

 Key: OFBIZ-4723
 URL: https://issues.apache.org/jira/browse/OFBIZ-4723
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: REV 1297286
Reporter: Anne Jessel
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4723_UtilProperties_only.patch, 
 OFBIZ-4723_both.patch, OFBIZ-4723_code_cleanups.patch, 
 OFBIZ-4723_combined.patch, OFBIZ-4723_support-validation-resource-xml.patch


 The xsd for the resource xml files is invalid. In addition, the format of the 
 value of the xml:lang attribute in resource xml files is invalid, according 
 to the xml standard.
 The attached patch:
 * provides a valid xsd
 * updates UtilProperties and the Label Manager to deal with the correct 
 formatting of the xml:lang value, while still working with the old format, 
 following Adrian Crum's recommendation on the mailing list
 * includes simple unit tests for UtilProperties to ensure it does work with 
 both formats
 * changes the Label Manager to include a reference to the new xsd, and to use 
 the correct format of the xml:lang value, when writing a resource xml file.
 This problem exists in released versions, but I doubt it is important enough 
 to back port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4627) contribute Ofbiz Vietnamese tranlasting to community from HaNoi

2012-03-26 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238523#comment-13238523
 ] 

Jacques Le Roux commented on OFBIZ-4627:


Please create new, it will be more clear

 contribute Ofbiz Vietnamese tranlasting to community from HaNoi
 ---

 Key: OFBIZ-4627
 URL: https://issues.apache.org/jira/browse/OFBIZ-4627
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Tri Duc Vo
Assignee: Jacques Le Roux
  Labels: features
 Fix For: SVN trunk

 Attachments: CommonUiLabels.xml.patch, CommonUiLabels.xml.patch, 
 CommonUiLabels.xml.patch, CommonUiLabels.xml.patch, EcommerceUiLabels.xml, 
 EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch, 
 EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch, 
 MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch, 
 MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch, 
 OFBIZ-427_VietnameseCommonUiLabels.patch, 
 OFBIZ-427_VietnameseEcommerceUiLabels.patch, 
 OFBIZ-427_VietnameseMarketingUiLabels.patch, 
 OFBIZ-427_VietnameseOrderEntityLabels.patch, 
 OFBIZ-427_VietnameseOrderUiLabels.patch, 
 OFBIZ-427_VietnameseProductEntityLabels.patch, 
 OFBIZ-427_VietnameseProductUiLabels.patch, 
 OFBIZ-427_VietnameseUiLabels.patch, OFBIZ-427_VietnameseUiLabels.patch, 
 OrderEntityLabels.xml.patch, OrderEntityLabels.xml.patch, 
 OrderEntityLabels.xml.patch, OrderEntityLabels.xml.patch, 
 OrderUiLabels.xml.patch, OrderUiLabels.xml.patch, OrderUiLabels.xml.patch, 
 OrderUiLabels.xml.patch, ProductEntityLabels.xml.patch, 
 ProductEntityLabels.xml.patch, ProductEntityLabels.xml.patch, 
 ProductEntityLabels.xml.patch, ProductUiLabels.xml, 
 ProductUiLabels.xml.patch, ProductUiLabels.xml.patch, 
 ProductUiLabels.xml.patch, ProductUiLabels.xml.patch

   Original Estimate: 1,344h
  Remaining Estimate: 1,344h

Dear Ofbiz community
I'm Tri, from HaNoi, VietNam, and now our team build ERP based on Ofbiz 
 opensource. 
Now we're completed translating 80% Ecommerce , 50% Catalog of Ofbiz. And 
 we're going to complete 100% Vietnamese Ofbiz tranlasting and contribute them 
 to community.
We'll attach files soon
Thank you

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4723) Support validation of resource xml files

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237831#comment-13237831
 ] 

Jacques Le Roux commented on OFBIZ-4723:


Thanks Anne,

Commited in trunk at r1305004

The base test suite was successfully run locally once UtilIOTests have been 
commented out (still an issue with it on Windows)

 Support validation of resource xml files
 

 Key: OFBIZ-4723
 URL: https://issues.apache.org/jira/browse/OFBIZ-4723
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: REV 1297286
Reporter: Anne Jessel
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4723_both.patch, OFBIZ-4723_code_cleanups.patch, 
 OFBIZ-4723_combined.patch, OFBIZ-4723_support-validation-resource-xml.patch


 The xsd for the resource xml files is invalid. In addition, the format of the 
 value of the xml:lang attribute in resource xml files is invalid, according 
 to the xml standard.
 The attached patch:
 * provides a valid xsd
 * updates UtilProperties and the Label Manager to deal with the correct 
 formatting of the xml:lang value, while still working with the old format, 
 following Adrian Crum's recommendation on the mailing list
 * includes simple unit tests for UtilProperties to ensure it does work with 
 both formats
 * changes the Label Manager to include a reference to the new xsd, and to use 
 the correct format of the xml:lang value, when writing a resource xml file.
 This problem exists in released versions, but I doubt it is important enough 
 to back port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4580) Categories - calculated trails

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237834#comment-13237834
 ] 

Jacques Le Roux commented on OFBIZ-4580:


Kiran,

As Paul explained and I commented at 
http://svn.apache.org/viewvc?rev=1304454view=rev
{quote}
This service/mathod are not meant to be run on every request. Its best use is 
to generate the trail every so often and store somewhere (a lucene/solr tree, 
entities, cache or so). 
{quote}

So it does not need to be optmised it seems. Else you could provice a patch...


 Categories - calculated trails
 --

 Key: OFBIZ-4580
 URL: https://issues.apache.org/jira/browse/OFBIZ-4580
 Project: OFBiz
  Issue Type: Improvement
Reporter: Paul Piper
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: CategoryWorker-with-trail-export.patch, 
 CategoryWorker.patch, OFBIZ-4580-CategoryWorker-with-trail-export.patch


 Hey folks,
 been a while since I contributed. I noticed that currently ofbiz misses a 
 simple function to generate a category trail. Generating a trail, however, is 
 often useful when generating breadcrums, facetted search results, and proper 
 category trees in general. Hence I created the following as a timesaver:
 {code:title=getCategoryTrail|borderStyle=solid}
 public static  List getCategoryTrail(String productCategoryId,DispatchContext 
 dctx){
   GenericDelegator delegator = (GenericDelegator) 
 dctx.getDelegator();
   ListString trailElements = FastList.newInstance();
 trailElements.add(productCategoryId);
 String parentProductCategoryId = productCategoryId;
 while (UtilValidate.isNotEmpty(parentProductCategoryId)) {
 // find product category rollup
 try {
 ListEntityCondition rolllupConds = FastList.newInstance();
 
 rolllupConds.add(EntityCondition.makeCondition(productCategoryId, 
 parentProductCategoryId));
 rolllupConds.add(EntityUtil.getFilterByDateExpr());
 ListGenericValue productCategoryRollups = 
 delegator.findList(ProductCategoryRollup, 
 EntityCondition.makeCondition(rolllupConds), null, 
 UtilMisc.toList(-fromDate), null, true);
 if (UtilValidate.isNotEmpty(productCategoryRollups)) {
 // add only categories that belong to the top category to 
 trail
 for (GenericValue productCategoryRollup : 
 productCategoryRollups) {
 String trailCategoryId = 
 productCategoryRollup.getString(parentProductCategoryId);
 parentProductCategoryId = trailCategoryId;
 if (trailElements.contains(trailCategoryId)) {
 break;
 }else{
   trailElements.add(trailCategoryId);
 }
 }
 } else {
 parentProductCategoryId = null;
 }
 } catch (GenericEntityException e) {
 Debug.logError(e, Cannot generate trail from product 
 category, module);
 }
 }
 Collections.reverse(trailElements);
 return trailElements;
   }
 {code}
 I suggest to add this to the CategoryWorker.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3790) email password broken

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237849#comment-13237849
 ] 

Jacques Le Roux commented on OFBIZ-3790:


Hi,

I don't see any reasons to remove this block
{code}
if (supposedUserLogin == null) {
// the Username was not found
MapString, String messageMap = UtilMisc.toMap(userLoginId, 
userLoginId);
errMsg = UtilProperties.getMessage(resource, 
loginevents.user_with_the_username_not_found, messageMap, 
UtilHttp.getLocale(request));
request.setAttribute(_ERROR_MESSAGE_, errMsg);
return error;
}
{code}

Could you explain?

 email password broken
 -

 Key: OFBIZ-3790
 URL: https://issues.apache.org/jira/browse/OFBIZ-3790
 Project: OFBiz
  Issue Type: Bug
Reporter: Si Chen
Assignee: Jacques Le Roux
 Attachments: Screen shot 2010-05-28 at 9.25.05 AM.png, 
 emailPasswd.diff


 Email password feature in party manager is broken.  The log shows:
 2010-05-28 09:24:58,193 (http-0.0.0.0-8543-14) [ 
 ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, 
 encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
 2010-05-28 09:24:58,268 (http-0.0.0.0-8543-14) [ 
 RequestHandler.java:597:INFO ] Ran Event 
 [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], 
 result is [success]
 2010-05-28 09:24:58,275 (http-0.0.0.0-8543-14) [ 
 RequestHandler.java:704:INFO ] Rendering View [forgotPassword], 
 sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1
 2010-05-28 09:24:58,278 (http-0.0.0.0-8543-14) [ 
 ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: 
 component://common/widget/CommonScreens.xml
 2010-05-28 09:24:58,325 (http-0.0.0.0-8543-14) [   
 PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete 
 primary key in find: [GenericEntity:PartyNameView][partyId,null()]
 2010-05-28 09:24:58,520 (http-0.0.0.0-8543-14) [   
 ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: 
 [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28
  09:24:58.518(java.sql.Timestamp)][createdTxStamp,2010-05-28 
 09:24:58.516(java.sql.Timestamp)][hitStartDateTime,2010-05-28 
 09:24:58.193(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-05-28
  09:24:58.518(java.sql.Timestamp)][lastUpdatedTxStamp,2010-05-28 
 09:24:58.516(java.sql.Timestamp)][referrerUrl,https://ntc:8543/partymgr/control/main(java.lang.String)][requestUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][runningTimeMillis,322(java.lang.Long)][serverHostName,domU-12-31-39-00-0F-51(java.lang.String)][serverIpAddress,10.254.31.159(java.lang.String)][visitId,25693(java.lang.String)]
 2010-05-28 09:24:58,521 (http-0.0.0.0-8543-14) [ 
 ControlServlet.java:300:INFO ] [[[forgotPassword] Request Done- 
 total:0.327,since last([forgotPassword] ...):0.327]]
 2010-05-28 09:25:02,715 (http-0.0.0.0-8543-15) [ 
 ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, 
 encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
 2010-05-28 09:25:03,074 (http-0.0.0.0-8543-15) [ 
 UtilProperties.java:871:INFO ] ResourceBundle SecurityextUiLabels (en_US) 
 created in 0.12s with 53 properties
 2010-05-28 09:25:03,075 (http-0.0.0.0-8543-15) [ 
 RequestHandler.java:597:INFO ] Ran Event 
 [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], 
 result is [error]
 2010-05-28 09:25:03,110 (http-0.0.0.0-8543-15) [ 
 RequestHandler.java:400:ERROR] Request forgotPassword caused an error with 
 the following message: Problems with configuration; please contact customer 
 service.
 2010-05-28 09:25:03,111 (http-0.0.0.0-8543-15) [ 
 RequestHandler.java:704:INFO ] Rendering View [forgotPassword], 
 sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1
 2010-05-28 09:25:03,116 (http-0.0.0.0-8543-15) [ 
 ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: 
 component://common/widget/CommonScreens.xml
 2010-05-28 09:25:03,141 (http-0.0.0.0-8543-15) [   
 PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete 
 primary key in find: [GenericEntity:PartyNameView][partyId,null()]
 2010-05-28 09:25:03,380 (http-0.0.0.0-8543-15) [   
 ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: 
 [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28
  09:25:03.378(java.sql.Timestamp)][createdTxStamp,2010-05-28 
 09:25:03.376(java.sql.Timestamp)][hitStartDateTime,2010-05-28 
 09:25:02.715(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-05-28
  09:25:03.378(java.sql.Timestamp)][lastUpdatedTxStamp,2010-05-28

[jira] [Commented] (OFBIZ-4591) TLD is not loaded from CLASSPATH using Tomcat 7

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237854#comment-13237854
 ] 

Jacques Le Roux commented on OFBIZ-4591:


Doest this pb still exist?

 TLD is not loaded from CLASSPATH using Tomcat 7
 ---

 Key: OFBIZ-4591
 URL: https://issues.apache.org/jira/browse/OFBIZ-4591
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
 Environment: Ubntu
Reporter: Chatree Srichart
Priority: Critical
  Labels: 7, tld, tomcat
   Original Estimate: 168h
  Remaining Estimate: 168h

 Hi community.
 I have a problem when I render a JSP page which is defined a taglib, for 
 example:
 %@ taglib prefix=c uri=http://java.sun.com/jsp/jstl/core%
  The problem is TLD definition files are not loaded from CLASSPATH using 
 Tomcat 7.
 To solve this problem we need to delete this line from CatalinaContainer.java 
 file:
 standardJarScanner.setScanClassPath(false);
 because the standard jar scanner is set the default value as true
 After we have done above, we will get these problems.
 =
 1. JAR files are conflicted by different webapp contexts
 =
 The ScheduledExecutorService that submit all webapp contexts does not run 
 them respectively. For example:
 Context(1)
 Context(2)
 Context(3)
 A particular context will read all JAR files from CLASSPATH. The problem is, 
 for example, the Context(2) will start to read all JAR files even though the 
 Context(1) does not finish its task yet. So the Context (2) will not be able 
 to read some JAR file that the Context(1) is reading and causes an error.
 ===
 2. WebslingerAccessLogValve class does not support Tomcat 7
 ===
 If the jar scanner scan jar files from CLASSPATH, it will find 
 WebslingerAccessLogValve class which does not support Tomcat 7
 ===
 3. groovy.jmx.builder.package-info class cannot be loaded
 ===
 groovy.jmx.builder.package-info class cannot be loaded because its name is 
 incorrect. If I remove this class from 
 framework/base/lib/scripting/groovy-all-1.7.7.jar file, this line in 
 macros.xml will cause an error:
 taskdef name=groovyc classname=org.codehaus.groovy.ant.Groovyc 
 classpathref=groovy.class.path/
 
 4. Starting time will slower
 
 A particular webapp context will spend more time to parse JAR file from 
 CLASSPATH to find TLD definition files.
 However I can avoid the TLD problem by copying JAR files that contain TLD 
 definition files into /WEB-INF/lib directory of a particular webapp
 Lastly, I am not sure if we need this feature in the trunk but I think it is 
 useful. If so, please help me to solve the problems.
 Regards,
 Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237870#comment-13237870
 ] 

Jacques Le Roux commented on OFBIZ-4715:


Markus,

Dont forget to mark the issues as Patch provided when attaching patch/es

Thanks

 Invoice PDF and Contact Information show Region Code instead of Country Code 
 before the Zip Code
 

 Key: OFBIZ-4715
 URL: https://issues.apache.org/jira/browse/OFBIZ-4715
 Project: OFBiz
  Issue Type: Bug
  Components: party, specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Markus M. May
Assignee: Jacopo Cappellato
Priority: Minor
 Fix For: SVN trunk

 Attachments: 
 OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, 
 OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, 
 OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-initial-commit.patch, 
 OFBIZ-4715-initial-commit.patch


 The Invoice PDF and the Contact Information in the Party application show the 
 Region Code instead of the Country Code before the Zip Code. This will be 
 fine for the US, here in Germany it is rather unusual. 
 I propose to avoid this by removing the Region Code if the country is 
 different then US.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4496) Quick complete Drop Shipment on purchase order causes many warning messages

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237879#comment-13237879
 ] 

Jacques Le Roux commented on OFBIZ-4496:


Should we close this one as duplicate? Or only after applying patches in 
OFBIZ-4517, or?

 Quick complete Drop Shipment on purchase order causes many warning messages
 -

 Key: OFBIZ-4496
 URL: https://issues.apache.org/jira/browse/OFBIZ-4496
 Project: OFBiz
  Issue Type: Bug
  Components: order, specialpurpose/ecommerce
Affects Versions: Release Branch 11.04, SVN trunk
Reporter: Kiran Gawde

 Got following warnings during: Quick complete Drop Shipment on purchase 
 order
 [ServiceEcaCondition.java:156:WARN ] From Field (originFacilityId) is not 
 found in context for createShipment, defaulting to null.
 [ServiceEcaCondition.java:156:WARN ] From Field (destinationFacilityId) is 
 not found in context for createShipment, defaulting to null.
 [Log.java:117:WARN ] 
 [ShipmentServices.xml#setShipmentSettingsFromPrimaryOrder line 532] Cannot 
 find a shipping origin address for WS10123
 [Log.java:117:WARN ] 
 [ShipmentServices.xml#setShipmentSettingsFromPrimaryOrder line 554] Cannot 
 find a shipping destination phone number for WS10123
 [Log.java:117:WARN ] 
 [ShipmentServices.xml#setShipmentSettingsFromPrimaryOrder line 568] Cannot 
 find a shipping origin phone number for WS10123
 [  FieldToResult.java:77 :WARN ] Field value not found with name 
 lookedUpValue.originFacilityId in Map with name 
 [  FieldToResult.java:77 :WARN ] Field value not found with name 
 lookedUpValue.destinationFacilityId in Map with name 
 [Log.java:117:WARN ] [InvoiceServices.xml#getNextInvoiceId 
 line 35] errorPartyPerf
 [InvoiceServices.java:323:WARN ] No billing locations found for order 
 [WS10123] and none were created for Invoice [10061]
 [  FieldToResult.java:77 :WARN ] Field value not found with name 
 contactMechId in Map with name 
 [ServiceEcaCondition.java:156:WARN ] From Field (originFacilityId) is not 
 found in context for updateShipment, defaulting to null.
 [ServiceEcaCondition.java:156:WARN ] From Field (destinationFacilityId) is 
 not found in context for updateShipment, defaulting to null.
 [ServiceEcaCondition.java:156:WARN ] From Field (primaryOrderId) is not found 
 in context for updateShipment, defaulting to null.
 [TransactionUtil.java:375:WARN ] 
  exception report 
 --
 [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this 
 stack trace shows where this is happening:
 Exception: java.lang.Exception
 Message: Error in simple-method [ 
 [file:/D:/EclipseWorkspaces/Autogoza/ofbiz/applications/accounting/script/org/ofbiz/accounting/olap/FactServices.xml#loadSalesInvoiceFact]]:
  ; {Invoice with id AI14 doesn't exist.}
  stack trace 
 ---
 java.lang.Exception: Error in simple-method [ 
 [file:/D:/EclipseWorkspaces/Autogoza/ofbiz/applications/accounting/script/org/ofbiz/accounting/olap/FactServices.xml#loadSalesInvoiceFact]]:
  ; {Invoice with id AI14 doesn't exist.}
 org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:375)
 org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:317)
 org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:870)
 org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:160)
 org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:142)
 org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:78)
 org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:53)
 org.ofbiz.service.ModelServiceReader$GenericInvokerImpl.runSync(ModelServiceReader.java:761)
 _$gen.file_58$.D_58$.EclipseWorkspaces.Autogoza.ofbiz.applications.accounting.servicedef.services_95$olap_46$xml_35$loadSalesInvoiceFact.runSync(file:/D:/EclipseWorkspaces/Autogoza/ofbiz/applications/accounting/servicedef/services_olap.xml#loadSalesInvoiceFact:37)
 org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:399)
 org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:226)
 org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
 org.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:71)
 org.ofbiz.service.job.JobInvoker.run(JobInvoker.java:242)
 java.lang.Thread.run(Thread.java:662)
 
 2011-10-20 12:01:00,823 (default-invoker-Thread-12) [  
 ServiceDispatcher.java:543:ERROR] Error in Service [loadSalesInvoiceFact]: 
 Invoice with id AI14

[jira] [Commented] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237882#comment-13237882
 ] 

Jacques Le Roux commented on OFBIZ-4724:


They have been addressed at 
http://svn.apache.org/viewvc?view=revisionrevision=1302219

 Shopping Cart - One Page Checkout - not continuing
 --

 Key: OFBIZ-4724
 URL: https://issues.apache.org/jira/browse/OFBIZ-4724
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: Any Browser
Reporter: K Sharad Bhushan
  Labels: ofbiz, patch
 Attachments: ecommerce-shopping-cart-script.patch, 
 ecommerce-shopping-cart-script.patch, ecommerce-shopping-cart-script.patch


 While testing with latest trunk - revision at 1297039(March 5 2011), i have 
 observed issues in one page checkout due to javascript. I have identified 
 that the script was not in place to handle response. I happened to modify the 
 script checkoutprocess.js to fix this. i have testing in chrome, mozilla and 
 is working fine. I am attaching the patch for this fix
 Please do review and let me know of of issues. 
 Found there cannot be a patch while creating issue

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4756) ClassNotFoundException: org.eclipse.core.runtime.CoreException

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237939#comment-13237939
 ] 

Jacques Le Roux commented on OFBIZ-4756:


Which release.revision are you using, did you try with trunk HEAD (there have 
been some move recently)?

 ClassNotFoundException: org.eclipse.core.runtime.CoreException
 --

 Key: OFBIZ-4756
 URL: https://issues.apache.org/jira/browse/OFBIZ-4756
 Project: OFBiz
  Issue Type: Bug
  Components: commonext/setup
Affects Versions: SVN trunk
 Environment: WXP JDK 1.6.0_25, postgres 9
Reporter: Francis ANDRE

 Hi
 Running ofbiz directly under Eclipse, I got this exception in the Eclipse 
 console while it never appears in the debug.log or ofbiz.log:
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:251:INFO ] Connector 
 AJP/1.3 @ 8009 - not-secure [org.apache.coyote.ajp.Ajp
 Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:248:INFO ] Connector 
 http-bio-0.0.0.0-8080 @ 8080 - not-secure [org.apach
 e.coyote.http11.Http11Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:248:INFO ] Connector 
 http-bio-0.0.0.0-8443 @ 8443 - secure [org.apache.co
 yote.http11.Http11Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:255:INFO ] Started 
 Apache Tomcat/7.0.26
 2012-03-25 10:53:33,500 (main) [  BirtContainer.java:50 :INFO ] Start 
 BIRT container
 2012-03-25 10:53:33,515 (main) [  BirtContainer.java:70 :INFO ] Startup 
 BIRT platform
 Exception in thread main java.lang.NoClassDefFoundError: 
 org/eclipse/core/runtime/CoreException
   at 
 org.eclipse.birt.core.framework.Platform.createPlatformLauncher(Platform.java:115)
   at org.eclipse.birt.core.framework.Platform.startup(Platform.java:74)
   at org.ofbiz.birt.container.BirtContainer.start(BirtContainer.java:71)
   at 
 org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
   at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
   at org.ofbiz.base.start.Start.start(Start.java:289)
   at org.ofbiz.base.start.Start.main(Start.java:119)
 Caused by: java.lang.ClassNotFoundException: 
 org.eclipse.core.runtime.CoreException
   at java.net.URLClassLoader$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4756) ClassNotFoundException: org.eclipse.core.runtime.CoreException

2012-03-25 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237990#comment-13237990
 ] 

Jacques Le Roux commented on OFBIZ-4756:


This does not definitively disqualify the Birt component but shows another 
reason to put it aside and improve it.

 ClassNotFoundException: org.eclipse.core.runtime.CoreException
 --

 Key: OFBIZ-4756
 URL: https://issues.apache.org/jira/browse/OFBIZ-4756
 Project: OFBiz
  Issue Type: Bug
  Components: commonext/setup
Affects Versions: SVN trunk
 Environment: WXP JDK 1.6.0_25, postgres 9
Reporter: Francis ANDRE

 Hi
 Running ofbiz directly under Eclipse, I got this exception in the Eclipse 
 console while it never appears in the debug.log or ofbiz.log:
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:251:INFO ] Connector 
 AJP/1.3 @ 8009 - not-secure [org.apache.coyote.ajp.Ajp
 Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:248:INFO ] Connector 
 http-bio-0.0.0.0-8080 @ 8080 - not-secure [org.apach
 e.coyote.http11.Http11Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:248:INFO ] Connector 
 http-bio-0.0.0.0-8443 @ 8443 - secure [org.apache.co
 yote.http11.Http11Protocol] started.
 2012-03-25 10:53:33,500 (main) [  CatalinaContainer.java:255:INFO ] Started 
 Apache Tomcat/7.0.26
 2012-03-25 10:53:33,500 (main) [  BirtContainer.java:50 :INFO ] Start 
 BIRT container
 2012-03-25 10:53:33,515 (main) [  BirtContainer.java:70 :INFO ] Startup 
 BIRT platform
 Exception in thread main java.lang.NoClassDefFoundError: 
 org/eclipse/core/runtime/CoreException
   at 
 org.eclipse.birt.core.framework.Platform.createPlatformLauncher(Platform.java:115)
   at org.eclipse.birt.core.framework.Platform.startup(Platform.java:74)
   at org.ofbiz.birt.container.BirtContainer.start(BirtContainer.java:71)
   at 
 org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
   at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
   at org.ofbiz.base.start.Start.start(Start.java:289)
   at org.ofbiz.base.start.Start.main(Start.java:119)
 Caused by: java.lang.ClassNotFoundException: 
 org.eclipse.core.runtime.CoreException
   at java.net.URLClassLoader$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
 Rgds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4724) Shopping Cart - One Page Checkout - not continuing

2012-03-24 Thread Jacques Le Roux (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237480#comment-13237480
]

Jacques Le Roux commented on OFBIZ-4724:

Sorry K Sharad, but your patch does not apply on trunk HEAD

patching file
specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js
Hunk #1 FAILED at 144.
Hunk #2 FAILED at 261.
Hunk #3 FAILED at 299.
Hunk #4 FAILED at 344.
Hunk #5 FAILED at 396.
Hunk #6 succeeded at 411 (offset 5 lines).
Hunk #7 FAILED at 463.
Hunk #8 FAILED at 491.
Hunk #9 FAILED at 535.
8 out of 9 hunks FAILED -- saving rejects to file
specialpurpose/ecommerce/webapp/ecommerce/images/checkoutProcess.js.rej

Please update to trunk HEAD before creating your patch

Shopping Cart - One Page Checkout - not continuing
--

Key: OFBIZ-4724
URL: https://issues.apache.org/jira/browse/OFBIZ-4724
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: Any Browser
Reporter: K Sharad Bhushan
Labels: ofbiz, patch
Attachments: ecommerce-shopping-cart-script.patch,
ecommerce-shopping-cart-script.patch

While testing with latest trunk - revision at 1297039(March 5 2011), i have
observed issues in one page checkout due to javascript. I have identified
that the script was not in place to handle response. I happened to modify the
script checkoutprocess.js to fix this. i have testing in chrome, mozilla and
is working fine. I am attaching the patch for this fix
Please do review and let me know of of issues.
Found there cannot be a patch while creating issue

[jira] [Commented] (OFBIZ-4728) productdetail.ftl shows only primaryProductCategoryId even though a productCategoryId is handed over

2012-03-23 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236382#comment-13236382
 ] 

Jacques Le Roux commented on OFBIZ-4728:


Hi Markus,

productCategoryId is the entity field name, if you see no side effects to 
rename productCategoryId to category in ofbizCatalogAltUrl then I see no 
reasons to not rename it. Please check all other occurences, I found at least 
categorydetail.ftl (commented out), ajaxbreadcrumbs.ftl, 
minilastviewedcategories.ftl, miniproductsummary.ftl, productdetail.ftl, 
ShowBestSellingCategory.ftl, sidedeepcategory.ftl and tellafriend.ftl

 productdetail.ftl shows only primaryProductCategoryId even though a 
 productCategoryId is handed over
 

 Key: OFBIZ-4728
 URL: https://issues.apache.org/jira/browse/OFBIZ-4728
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Markus M. May
Priority: Minor

 On the productsummary.ftl the productUrl is constructed like:
  #assign productUrl@ofbizCatalogAltUrl productId=product.productId 
 productCategoryId=categoryId//#assign
 This works fine, unfortunately in the ProductDetail.groovy the following 
 assignment returns null if the primaryProductCategoryId is not set on the 
 product:
 // get next/previous information for category
 categoryId = parameters.category_id ?: product.primaryProductCategoryId;
 This leads to a nasty NullPointerException in the CatalogScreens.xml. 
 I would propose the following solution in the 
 applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ProductDetail.groovy:
 // get next/previous information for category
 categoryId = parameters.productCategoryId ?: parameters.category_id ?: 
 product.primaryProductCategoryId;
 I am unsure, why the parameter is named productCategoryId after the call of 
 the ofbizCatalogAltUrl, whereas it is named category throughout the rest of 
 the application. Another fix could be to rename this parameter in the 
 ofbizCatalogAltUrl.
 What do you think?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4580) Categories - calculated trails

2012-03-23 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236386#comment-13236386
 ] 

Jacques Le Roux commented on OFBIZ-4580:


Hi Kiran,

Could you elaborate on when/where to set category_id and pcategory?

 Categories - calculated trails
 --

 Key: OFBIZ-4580
 URL: https://issues.apache.org/jira/browse/OFBIZ-4580
 Project: OFBiz
  Issue Type: Improvement
Reporter: Paul Piper
Assignee: Jacques Le Roux
Priority: Minor
 Attachments: CategoryWorker-with-trail-export.patch, 
 CategoryWorker.patch, OFBIZ-4580-CategoryWorker-with-trail-export.patch


 Hey folks,
 been a while since I contributed. I noticed that currently ofbiz misses a 
 simple function to generate a category trail. Generating a trail, however, is 
 often useful when generating breadcrums, facetted search results, and proper 
 category trees in general. Hence I created the following as a timesaver:
 {code:title=getCategoryTrail|borderStyle=solid}
 public static  List getCategoryTrail(String productCategoryId,DispatchContext 
 dctx){
   GenericDelegator delegator = (GenericDelegator) 
 dctx.getDelegator();
   ListString trailElements = FastList.newInstance();
 trailElements.add(productCategoryId);
 String parentProductCategoryId = productCategoryId;
 while (UtilValidate.isNotEmpty(parentProductCategoryId)) {
 // find product category rollup
 try {
 ListEntityCondition rolllupConds = FastList.newInstance();
 
 rolllupConds.add(EntityCondition.makeCondition(productCategoryId, 
 parentProductCategoryId));
 rolllupConds.add(EntityUtil.getFilterByDateExpr());
 ListGenericValue productCategoryRollups = 
 delegator.findList(ProductCategoryRollup, 
 EntityCondition.makeCondition(rolllupConds), null, 
 UtilMisc.toList(-fromDate), null, true);
 if (UtilValidate.isNotEmpty(productCategoryRollups)) {
 // add only categories that belong to the top category to 
 trail
 for (GenericValue productCategoryRollup : 
 productCategoryRollups) {
 String trailCategoryId = 
 productCategoryRollup.getString(parentProductCategoryId);
 parentProductCategoryId = trailCategoryId;
 if (trailElements.contains(trailCategoryId)) {
 break;
 }else{
   trailElements.add(trailCategoryId);
 }
 }
 } else {
 parentProductCategoryId = null;
 }
 } catch (GenericEntityException e) {
 Debug.logError(e, Cannot generate trail from product 
 category, module);
 }
 }
 Collections.reverse(trailElements);
 return trailElements;
   }
 {code}
 I suggest to add this to the CategoryWorker.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4669) sessionAttributes doesn't work from screen widget

2012-03-23 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236400#comment-13236400
 ] 

Jacques Le Roux commented on OFBIZ-4669:


Bump... A patch?

 sessionAttributes doesn't work from screen widget
 -

 Key: OFBIZ-4669
 URL: https://issues.apache.org/jira/browse/OFBIZ-4669
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 11.04, SVN trunk
Reporter: Kiran Gawde

 In the screen widget, add a set action that refers to sessionAttributes, it 
 doesn't work. 
 e.g: Following doesn't work:
 set field=titleProperty value=${sessionAttributes.autoName}/
 Following works:
  set field=titleProperty from-field=autoName from-scope=user/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4627) contribute Ofbiz Vietnamese tranlasting to community from HaNoi

2012-03-23 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236467#comment-13236467
 ] 

Jacques Le Roux commented on OFBIZ-4627:


Ha, also 
ProductCreateNewInventoryItemFacility in th was not closed by /value
I guess it was due to a quirk during patching because you patch is ok for this 
point.

 contribute Ofbiz Vietnamese tranlasting to community from HaNoi
 ---

 Key: OFBIZ-4627
 URL: https://issues.apache.org/jira/browse/OFBIZ-4627
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Tri Duc Vo
Assignee: Jacques Le Roux
  Labels: features
 Fix For: SVN trunk

 Attachments: CommonUiLabels.xml.patch, CommonUiLabels.xml.patch, 
 CommonUiLabels.xml.patch, CommonUiLabels.xml.patch, EcommerceUiLabels.xml, 
 EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch, 
 EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch, 
 MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch, 
 MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch, 
 OFBIZ-427_VietnameseCommonUiLabels.patch, 
 OFBIZ-427_VietnameseEcommerceUiLabels.patch, 
 OFBIZ-427_VietnameseMarketingUiLabels.patch, 
 OFBIZ-427_VietnameseOrderEntityLabels.patch, 
 OFBIZ-427_VietnameseOrderUiLabels.patch, 
 OFBIZ-427_VietnameseProductEntityLabels.patch, 
 OFBIZ-427_VietnameseProductUiLabels.patch, 
 OFBIZ-427_VietnameseUiLabels.patch, OFBIZ-427_VietnameseUiLabels.patch, 
 OrderEntityLabels.xml.patch, OrderEntityLabels.xml.patch, 
 OrderEntityLabels.xml.patch, OrderEntityLabels.xml.patch, 
 OrderUiLabels.xml.patch, OrderUiLabels.xml.patch, OrderUiLabels.xml.patch, 
 OrderUiLabels.xml.patch, ProductEntityLabels.xml.patch, 
 ProductEntityLabels.xml.patch, ProductEntityLabels.xml.patch, 
 ProductEntityLabels.xml.patch, ProductUiLabels.xml, 
 ProductUiLabels.xml.patch, ProductUiLabels.xml.patch, 
 ProductUiLabels.xml.patch, ProductUiLabels.xml.patch

   Original Estimate: 1,344h
  Remaining Estimate: 1,344h

Dear Ofbiz community
I'm Tri, from HaNoi, VietNam, and now our team build ERP based on Ofbiz 
 opensource. 
Now we're completed translating 80% Ecommerce , 50% Catalog of Ofbiz. And 
 we're going to complete 100% Vietnamese Ofbiz tranlasting and contribute them 
 to community.
We'll attach files soon
Thank you

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4580) Categories - calculated trails

2012-03-23 Thread Jacques Le Roux (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236478#comment-13236478
 ] 

Jacques Le Roux commented on OFBIZ-4580:


Thanks Paul I will add your comment in the method and service. We still want to 
wait for Kiran's answer, right?

 Categories - calculated trails
 --

 Key: OFBIZ-4580
 URL: https://issues.apache.org/jira/browse/OFBIZ-4580
 Project: OFBiz
  Issue Type: Improvement
Reporter: Paul Piper
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: CategoryWorker-with-trail-export.patch, 
 CategoryWorker.patch, OFBIZ-4580-CategoryWorker-with-trail-export.patch


 Hey folks,
 been a while since I contributed. I noticed that currently ofbiz misses a 
 simple function to generate a category trail. Generating a trail, however, is 
 often useful when generating breadcrums, facetted search results, and proper 
 category trees in general. Hence I created the following as a timesaver:
 {code:title=getCategoryTrail|borderStyle=solid}
 public static  List getCategoryTrail(String productCategoryId,DispatchContext 
 dctx){
   GenericDelegator delegator = (GenericDelegator) 
 dctx.getDelegator();
   ListString trailElements = FastList.newInstance();
 trailElements.add(productCategoryId);
 String parentProductCategoryId = productCategoryId;
 while (UtilValidate.isNotEmpty(parentProductCategoryId)) {
 // find product category rollup
 try {
 ListEntityCondition rolllupConds = FastList.newInstance();
 
 rolllupConds.add(EntityCondition.makeCondition(productCategoryId, 
 parentProductCategoryId));
 rolllupConds.add(EntityUtil.getFilterByDateExpr());
 ListGenericValue productCategoryRollups = 
 delegator.findList(ProductCategoryRollup, 
 EntityCondition.makeCondition(rolllupConds), null, 
 UtilMisc.toList(-fromDate), null, true);
 if (UtilValidate.isNotEmpty(productCategoryRollups)) {
 // add only categories that belong to the top category to 
 trail
 for (GenericValue productCategoryRollup : 
 productCategoryRollups) {
 String trailCategoryId = 
 productCategoryRollup.getString(parentProductCategoryId);
 parentProductCategoryId = trailCategoryId;
 if (trailElements.contains(trailCategoryId)) {
 break;
 }else{
   trailElements.add(trailCategoryId);
 }
 }
 } else {
 parentProductCategoryId = null;
 }
 } catch (GenericEntityException e) {
 Debug.logError(e, Cannot generate trail from product 
 category, module);
 }
 }
 Collections.reverse(trailElements);
 return trailElements;
   }
 {code}
 I suggest to add this to the CategoryWorker.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

1 2 3 >

1 - 100 of 294 matches

Mail list logo