[jira] [Closed] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-2628. -- Resolution: Fixed Fix Version/s: Release Branch 10.04 Ok doki. I committed the patch in: 10.04 @Rev1392767 11.04 @Rev1392768 12.04 @Rev1392769 Trunk @Rev1392766 So we could finally close the issue :-) ?! No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-and-hidden-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-5045) Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-5045. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Sascha Rodekamp Hi Paul, thanks for the Patch it's committed in Trunk @Rev 1392773 Edit Estimated Ship Date or Estimated Delivery Date brings on date format error --- Key: OFBIZ-5045 URL: https://issues.apache.org/jira/browse/OFBIZ-5045 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Paul Foxworthy Assignee: Sascha Rodekamp Fix For: SVN trunk Attachments: OFBIZ-5045_EditOrderItemEstimatedDates Original Estimate: 1h Remaining Estimate: 1h On demo site, enter the URL https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091 In Action screenlet, choose Edit Items In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale. Click on Update Items. An error message is displayed to say the date is not in the correct format. With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service. updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates. The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n. I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-2628: --- Attachment: OFBIZ-2628-encoding-request-and-hidden-params.patch Hi, I changed your patch slightly and in worked. The Problem is, that VIEW_SIZE is only stored in parameters and not in the context object. A simple containsKey on the context object solves the problem Working with hidden fields work now for me, could you please so a recheck. I created the patch file from trunk. No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-and-hidden-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465398#comment-13465398 ] Sascha Rodekamp commented on OFBIZ-2628: Good morning guys, I tested that on trunk and 11.04 and it works fine. No problems with creating and deleting an attribute. No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465427#comment-13465427 ] Sascha Rodekamp commented on OFBIZ-2628: Ah ok i only tested with special chars like + and äöü, which works fine. But the a space is really a problem. Let's see what we can do here... No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464605#comment-13464605 ] Sascha Rodekamp commented on OFBIZ-2628: Hm, the patch OFBIZ-2628-encoding-hidden-post-params.patch break the encoding again. No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464627#comment-13464627 ] Sascha Rodekamp commented on OFBIZ-2628: I applied the patch on trunk. Which causes the same issue as described in the in the bug description. No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464682#comment-13464682 ] Sascha Rodekamp commented on OFBIZ-2628: Ok no problem, can you give me a short example of your problem that I can reproduce it here on my machine? No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464773#comment-13464773 ] Sascha Rodekamp commented on OFBIZ-2628: Hey, thanks for the new patch. The encoding of the parameters works now. But I get NPE's when loading the global decorator on different pages i.e.: https://localhost:8443/content/control/ListWebSiteContent?webSiteId=CmsSite The exception occurs in: WidgetWorker.makeHiddenFormLinkForm No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463783#comment-13463783 ] Sascha Rodekamp commented on OFBIZ-2628: I finally back form my holiday. Great observation Wojciech, I will check that. No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463783#comment-13463783 ] Sascha Rodekamp edited comment on OFBIZ-2628 at 9/27/12 2:07 AM: - I'm finally back form my holiday. Great observation Wojciech, I will check that. Edit: The changes work great, I can't identify any side effects. I committed the changes in Trunk @Rev1390542 12.04 @Rev1390546 11.04 @Rev1390544 was (Author: sascha): I finally back form my holiday. Great observation Wojciech, I will check that. No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-2628. -- Resolution: Fixed Fix Version/s: (was: Release Branch 10.04) Release Branch 12.04 No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4915) Lookup Form not working with Arabic characters
[ https://issues.apache.org/jira/browse/OFBIZ-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442993#comment-13442993 ] Sascha Rodekamp commented on OFBIZ-4915: Hi Taher, thanks for working on this issue. I committed your patch in release 11.04 @Rev 1377987 release 12.04 @Rev 1377986 trunk @Rev 1377988 Regards Sascha Lookup Form not working with Arabic characters -- Key: OFBIZ-4915 URL: https://issues.apache.org/jira/browse/OFBIZ-4915 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: Release Branch 11.04, Release Branch 12.04 Reporter: Taher Alkhateeb Assignee: Jacques Le Roux Priority: Minor Labels: form, jQuery, javascript, lookup Fix For: Release Branch 12.04 Attachments: fieldlookup.patch, search_party_after_submit.png, search_party_before_submit.png, XHR_Screenshot_27_06_2012.png Any field in a form that uses the lookup target-form-name=WhateverForm/ would not return results when searching in Arabic. I suspect the main offender is javascript/jQuery when parsing user input. For example, if I go to https://localhost:8443/ordermgr/control/findorders and click on Party ID, and search the firstname or lastname in arabic, no values are returned and the value in the search box changes from arabic to some weird encoding ( e.g. حسن becomes Øس٠) Also, after some investigation, I came to the realization that this only happens when the lookup field has presentation=layer, if however, the presentation=window then it works normally which leads me to conclude definitely that this is javascript/jQuery issue of parsing input data. More specifically, this is javascript not processing with the correct encoding (unicode in this case). I know this because if I paste the unicode representation directly to the input box then it searches correctly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4982) js issue causes error when invalid dates are entered
[ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4982: -- Assignee: Sascha Rodekamp js issue causes error when invalid dates are entered Key: OFBIZ-4982 URL: https://issues.apache.org/jira/browse/OFBIZ-4982 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Christoph Neuroth Assignee: Sascha Rodekamp Priority: Minor Attachments: ofbiz-i18n_dateinput_null_fix.patch Reproduce: Enter 123 in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4982) js issue causes error when invalid dates are entered
[ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429114#comment-13429114 ] Sascha Rodekamp commented on OFBIZ-4982: Hi Christoph, thanks for the patch. One thought that comes in my mind: Is it a good idea to remove wrong date inputs? It's obvious when you type 123 in the Date/Time field. But what if the user accidentally switched day and month which could also result in an exception. If we remove the wrong input field this wouldn't be noticed at all. Is it possible to use a custom validation to highlight the field on a wrong input? Many thanks Sascha js issue causes error when invalid dates are entered Key: OFBIZ-4982 URL: https://issues.apache.org/jira/browse/OFBIZ-4982 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Christoph Neuroth Assignee: Sascha Rodekamp Priority: Minor Attachments: ofbiz-i18n_dateinput_null_fix.patch Reproduce: Enter 123 in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4982) js issue causes error when invalid dates are entered
[ https://issues.apache.org/jira/browse/OFBIZ-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4982. -- Resolution: Fixed Fix Version/s: SVN trunk Hi Christoph, you're patch is in trunk @Rev 1370123 Many thanks Sascha js issue causes error when invalid dates are entered Key: OFBIZ-4982 URL: https://issues.apache.org/jira/browse/OFBIZ-4982 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Christoph Neuroth Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: ofbiz-i18n_dateinput_null_fix.patch Reproduce: Enter 123 in a DateField. This will trigger a JS exception and the invalid value will be sent to the server on form submission, probably causing server-side exceptions in badly written backend code, resulting in really bad error messages for the user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4752) Error in Content CMS click Find
[ https://issues.apache.org/jira/browse/OFBIZ-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4752. -- Resolution: Not A Problem Fix Version/s: SVN trunk Will close this issue now. If this error occurs again we can reopen it. Error in Content CMS click Find - Key: OFBIZ-4752 URL: https://issues.apache.org/jira/browse/OFBIZ-4752 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk Environment: demo-trunk Reporter: Tom Burns Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk To reproduce: In Content Manager (https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind) select CMS then click Find button located above the title CMS Content Find Expected: ? Actual: Error message org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://content/widget/cms/CMSScreens.xml#AdminSearch]: java.lang.IllegalArgumentException: Error running script at location [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: no segments* file found in org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: [indexhere.txt] (Error running script at location [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: no segments* file found in org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: [indexhere.txt]) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4281) parse javascript link wrongly in lookup layer dialog if there's slash '/' in data
[
https://issues.apache.org/jira/browse/OFBIZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp closed OFBIZ-4281.
--
Resolution: Fixed
Thanks Leon fixed in Trunk @Rev1358988
parse javascript link wrongly in lookup layer dialog if there's slash '/' in
data
-
Key: OFBIZ-4281
URL: https://issues.apache.org/jira/browse/OFBIZ-4281
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Assignee: Sascha Rodekamp
Priority: Trivial
Fix For: SVN trunk
Attachments: fieldlookup.js.patch
e.g. in lookup dialog (in layer mode), one href value of a link is
javascript:set_value('123/ABC');, then the ofbiz framework will parse it to
javascript:lookupAjaxRequest('ABC'');presentation=layer'). It's wrong.
Correct one should be given href itself.
to fix:
judge whether the link contains javascript:set_ before split it by slash
'/'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4950) Lookup filed with target-parameter attribute set cannot be displayed.
[ https://issues.apache.org/jira/browse/OFBIZ-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4950: -- Assignee: Sascha Rodekamp Lookup filed with target-parameter attribute set cannot be displayed. - Key: OFBIZ-4950 URL: https://issues.apache.org/jira/browse/OFBIZ-4950 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4950.patch if lookup field has attribute target-parameter set, then there's javascript error in front end and lookup icon disappears. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4950) Lookup filed with target-parameter attribute set cannot be displayed.
[ https://issues.apache.org/jira/browse/OFBIZ-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4950. -- Resolution: Fixed Hi Leon, many thanks. I committed your patch in Trunk @Rev1357098 Have a good day Sascha Lookup filed with target-parameter attribute set cannot be displayed. - Key: OFBIZ-4950 URL: https://issues.apache.org/jira/browse/OFBIZ-4950 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4950.patch if lookup field has attribute target-parameter set, then there's javascript error in front end and lookup icon disappears. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4951) entity/src ommited in .classpath that makes project built failed in eclipse.
[ https://issues.apache.org/jira/browse/OFBIZ-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4951. -- Resolution: Duplicate Assignee: Sascha Rodekamp Right, it's already fixed. Anyway thanks for reporting Leon! Have a good day Sascha entity/src ommited in .classpath that makes project built failed in eclipse. -- Key: OFBIZ-4951 URL: https://issues.apache.org/jira/browse/OFBIZ-4951 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Assignee: Sascha Rodekamp Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4951.patch in latest revision of trunk, the classpathentry of entity/src is removed for some reason, it causes eclipse unalbe to build project successfully. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4948) Render checkbox field as same behavior as radiobox
[ https://issues.apache.org/jira/browse/OFBIZ-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4948. -- Resolution: Fixed Assignee: Sascha Rodekamp Hi Leon, thanks for the patch. It's committed in trunk @Rev1355291 Render checkbox field as same behavior as radiobox -- Key: OFBIZ-4948 URL: https://issues.apache.org/jira/browse/OFBIZ-4948 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Leon Assignee: Sascha Rodekamp Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4948.patch when rendering a radio field in form widget, the generated html codes looks like: spaninput type=radio ...blahblah/span. The radio box and its description are wrapped by span and it's easy to change css style for both of them (radio and description), not only for radio type input. But the check box is rendered in another way without span around. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4915) Lookup Form not working with Arabic characters
[ https://issues.apache.org/jira/browse/OFBIZ-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402881#comment-13402881 ] Sascha Rodekamp commented on OFBIZ-4915: Hi Taher, when sending data to the server I used the jQuery serialize() function to read the input parameter form the form. The serialize function uses standard URL encoding. Could this be a problem. you can find the code in the function lookupFormAjaxRequest(). Have a good day Sascha Lookup Form not working with Arabic characters -- Key: OFBIZ-4915 URL: https://issues.apache.org/jira/browse/OFBIZ-4915 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: Release Branch 11.04, Release Branch 12.04 Reporter: Taher Alkhateeb Assignee: Jacques Le Roux Priority: Minor Labels: form, jQuery, javascript, lookup Attachments: XHR_Screenshot_27_06_2012.png, search_party_after_submit.png, search_party_before_submit.png Any field in a form that uses the lookup target-form-name=WhateverForm/ would not return results when searching in Arabic. I suspect the main offender is javascript/jQuery when parsing user input. For example, if I go to https://localhost:8443/ordermgr/control/findorders and click on Party ID, and search the firstname or lastname in arabic, no values are returned and the value in the search box changes from arabic to some weird encoding ( e.g. حسن becomes Øس٠) Also, after some investigation, I came to the realization that this only happens when the lookup field has presentation=layer, if however, the presentation=window then it works normally which leads me to conclude definitely that this is javascript/jQuery issue of parsing input data. More specifically, this is javascript not processing with the correct encoding (unicode in this case). I know this because if I paste the unicode representation directly to the input box then it searches correctly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4633) Contact List Lookup is not working in catalog for products.
[ https://issues.apache.org/jira/browse/OFBIZ-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4633. -- Resolution: Fixed Assignee: Sascha Rodekamp Hi Arpit, thanks for the patch it's committed in turnk @Rev 1351584 Contact List Lookup is not working in catalog for products. --- Key: OFBIZ-4633 URL: https://issues.apache.org/jira/browse/OFBIZ-4633 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Arpit Singh Pandya Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4633.patch Contact List Lookup is not working in catalog for product in Communications tab, when creating new Communication Event for new product. I have tested it on local and on demo-trunk, not sure about other versions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-3504) possible null exception in CompanyHeader.groovy due to incorrect check (fix included)
[
https://issues.apache.org/jira/browse/OFBIZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp closed OFBIZ-3504.
--
Resolution: Fixed
Assignee: Sascha Rodekamp
Already fixed in Rev956402
possible null exception in CompanyHeader.groovy due to incorrect check (fix
included)
-
Key: OFBIZ-3504
URL: https://issues.apache.org/jira/browse/OFBIZ-3504
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Mike Voytovich
Assignee: Sascha Rodekamp
Priority: Minor
Fix For: SVN trunk
Attachments: CompanyHeader.groovy.patch
Original Estimate: 0h
Remaining Estimate: 0h
There's a minor bug in
applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
which can cause a null exception.
It should be checking orh.getBillFromParty() for null, instead of
orh.getBillToParty().
Here's the fix:
Index:
repos/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
===
---
repos/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
(revision 73)
+++
repos/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
(revision 74)
@@ -67,7 +67,7 @@
orh = new OrderReadHelper(orderHeader);
// for sales order, the logo party is the BILL_FROM_VENDOR of the
order. If that's not available, we'll use the OrderHeader's ProductStore's
payToPartyId
if (SALES_ORDER.equals(orderHeader.orderTypeId)) {
-if (orh.getBillToParty()) {
+if (orh.getBillFromParty()) {
partyId = orh.getBillFromParty().partyId;
} else {
productStore = orderHeader.getRelatedOne(ProductStore);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4741) Error in Find Content Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4741. -- Resolution: Not A Problem Fix Version/s: SVN trunk Assignee: Sascha Rodekamp Hi Tom, seems that the lookup works again, i'm able to select a locale string in the trunk when searching for content. Thanks for reporting. Sascha Error in Find Content Lookup Key: OFBIZ-4741 URL: https://issues.apache.org/jira/browse/OFBIZ-4741 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk Reporter: Tom Burns Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk To reproduce: In Content Manager select Content (https://demo-trunk.ofbiz.apache.org/content/control/findContent) Click Lookup Icon for Locale String Expected: Lookup Locale dialog Actual: Error message org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#LookupDecorator]: java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4752) Error in Content CMS click Find
[
https://issues.apache.org/jira/browse/OFBIZ-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395845#comment-13395845
]
Sascha Rodekamp commented on OFBIZ-4752:
Hi Tom,
seems that you hadn't create your search index.
{code}
javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException:
no segments* file found in
org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
{code}
Go to WebTools - Run Service and run the indexTree service. After creating
the index the search should work.
Let me now if this work for you.
Have a good day
Sascha
Error in Content CMS click Find
-
Key: OFBIZ-4752
URL: https://issues.apache.org/jira/browse/OFBIZ-4752
Project: OFBiz
Issue Type: Bug
Components: content
Affects Versions: SVN trunk
Environment: demo-trunk
Reporter: Tom Burns
Priority: Minor
To reproduce:
In Content Manager
(https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind)
select CMS then click Find button located above the title CMS Content
Find
Expected: ?
Actual: Error message
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen
[component://content/widget/cms/CMSScreens.xml#AdminSearch]:
java.lang.IllegalArgumentException: Error running script at location
[component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]:
javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException:
no segments* file found in
org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files:
[indexhere.txt] (Error running script at location
[component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]:
javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException:
no segments* file found in
org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index
lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files:
[indexhere.txt])
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4752) Error in Content CMS click Find
[ https://issues.apache.org/jira/browse/OFBIZ-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4752: -- Assignee: Sascha Rodekamp Error in Content CMS click Find - Key: OFBIZ-4752 URL: https://issues.apache.org/jira/browse/OFBIZ-4752 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk Environment: demo-trunk Reporter: Tom Burns Assignee: Sascha Rodekamp Priority: Minor To reproduce: In Content Manager (https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind) select CMS then click Find button located above the title CMS Content Find Expected: ? Actual: Error message org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://content/widget/cms/CMSScreens.xml#AdminSearch]: java.lang.IllegalArgumentException: Error running script at location [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: no segments* file found in org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: [indexhere.txt] (Error running script at location [component://content/webapp/content/WEB-INF/actions/cms/Search.groovy]: javax.script.ScriptException: org.apache.lucene.index.IndexNotFoundException: no segments* file found in org.apache.lucene.store.MMapDirectory@/home/ofbiz/trunk/applications/content/index lockFactory=org.apache.lucene.store.NativeFSLockFactory@4bbbf4ee: files: [indexhere.txt]) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4741) Error in Find Content Lookup
[
https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395874#comment-13395874
]
Sascha Rodekamp commented on OFBIZ-4741:
Hi Ankit, Hi Tom
my button is also displaied (FF13, IE8).
But you are right the filtering doesn't work. The GetLocaleList.groovy calls
every time:
{code}
availableLocales = UtilMisc.availableLocales()
{code}
and gets the full locale list (and not a filtered one).
Error in Find Content Lookup
Key: OFBIZ-4741
URL: https://issues.apache.org/jira/browse/OFBIZ-4741
Project: OFBiz
Issue Type: Bug
Components: content
Affects Versions: SVN trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor
Fix For: SVN trunk
Attachments: Content Missing Locale Lookup.jpg, Content With Locale
Lookup on localhost.jpg
To reproduce:
In Content Manager select Content
(https://demo-trunk.ofbiz.apache.org/content/control/findContent)
Click Lookup Icon for Locale String
Expected: Lookup Locale dialog
Actual: Error message
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen
[component://common/widget/CommonScreens.xml#LookupDecorator]:
java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to
java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-4741) Error in Find Content Lookup
[
https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395874#comment-13395874
]
Sascha Rodekamp edited comment on OFBIZ-4741 at 6/18/12 1:16 PM:
-
Hi Ankit, Hi Tom
my button is also visible (FF13, IE8).
But you are right the filtering doesn't work. The GetLocaleList.groovy calls
every time:
{code}
availableLocales = UtilMisc.availableLocales()
{code}
and gets the full locale list (and not a filtered one).
was (Author: sascha):
Hi Ankit, Hi Tom
my button is also displaied (FF13, IE8).
But you are right the filtering doesn't work. The GetLocaleList.groovy calls
every time:
{code}
availableLocales = UtilMisc.availableLocales()
{code}
and gets the full locale list (and not a filtered one).
Error in Find Content Lookup
Key: OFBIZ-4741
URL: https://issues.apache.org/jira/browse/OFBIZ-4741
Project: OFBiz
Issue Type: Bug
Components: content
Affects Versions: SVN trunk
Reporter: Tom Burns
Assignee: Sascha Rodekamp
Priority: Minor
Fix For: SVN trunk
Attachments: Content Missing Locale Lookup.jpg, Content With Locale
Lookup on localhost.jpg
To reproduce:
In Content Manager select Content
(https://demo-trunk.ofbiz.apache.org/content/control/findContent)
Click Lookup Icon for Locale String
Expected: Lookup Locale dialog
Actual: Error message
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen
[component://common/widget/CommonScreens.xml#LookupDecorator]:
java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to
java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4741) Error in Find Content Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13396524#comment-13396524 ] Sascha Rodekamp commented on OFBIZ-4741: Hi Tom, yes good point. The Locale lookup form seems useless. We should discuss in the ML if we should rollback. Error in Find Content Lookup Key: OFBIZ-4741 URL: https://issues.apache.org/jira/browse/OFBIZ-4741 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk Reporter: Tom Burns Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: Content Missing Locale Lookup.jpg, Content With Locale Lookup on localhost.jpg To reproduce: In Content Manager select Content (https://demo-trunk.ofbiz.apache.org/content/control/findContent) Click Lookup Icon for Locale String Expected: Lookup Locale dialog Actual: Error message org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#LookupDecorator]: java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4836: --- Affects Version/s: (was: SVN trunk) Fix Version/s: (was: SVN trunk) Assignee: Sascha Rodekamp Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Pierre Smits Assignee: Sascha Rodekamp Priority: Blocker Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy .patch, OFBIZ-4836_JCR_MultiTenancy.patch, jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4836. -- Resolution: Fixed Issue fixed in jackrabbit20120501 branch @ Rev 1347578 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Pierre Smits Assignee: Sascha Rodekamp Priority: Blocker Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy .patch, OFBIZ-4836_JCR_MultiTenancy.patch, jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4836: --- Attachment: OFBIZ-4836_JCR_MultiTenancy.patch Hi, now we have different repositories for each tenant. We have to make sure, that the JcrDataSource is filled for the tenant user. If there is no entry in the entity for a certain tenant defined, i create a default repository path: /data/jcr/tenantId Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy .patch, OFBIZ-4836_JCR_MultiTenancy.patch, jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271349#comment-13271349 ] Sascha Rodekamp commented on OFBIZ-4836: Hi Pierre, nope. I think I did something wrong with my tenant setup. I will try to reproduce your issue. Btw. I use now the new jackrabbit branch for development. Regards, Sascha Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy .patch, jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4836: --- Attachment: OFBIZ-4836_JCR_MultiTenancy .patch Hi Pierre, here is a first suggestions for multi tenancy and jackrabbit. In this version each tenant gets is own repository. Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk Attachments: OFBIZ-4836-jcr-entity.patch, OFBIZ-4836_JCR_MultiTenancy .patch, jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4846) Trying to cache Visit, but Visit has neverCache-option set
[ https://issues.apache.org/jira/browse/OFBIZ-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4846: -- Assignee: Sascha Rodekamp Trying to cache Visit, but Visit has neverCache-option set -- Key: OFBIZ-4846 URL: https://issues.apache.org/jira/browse/OFBIZ-4846 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Sebastian Leitner Assignee: Sascha Rodekamp Priority: Trivial Fix For: SVN trunk Attachments: ServerHitBin_CacheUsageVisit.patch The Visit-entity has the neverCache-option set, but ServerHitBin is trying to cache it anyway. This should be avoided. I will attach a patch for this (rather trivial change). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4846) Trying to cache Visit, but Visit has neverCache-option set
[ https://issues.apache.org/jira/browse/OFBIZ-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4846. -- Resolution: Fixed Thanks Sebastian your patch is in Trunk @Rev 1330768 Trying to cache Visit, but Visit has neverCache-option set -- Key: OFBIZ-4846 URL: https://issues.apache.org/jira/browse/OFBIZ-4846 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Sebastian Leitner Assignee: Sascha Rodekamp Priority: Trivial Fix For: SVN trunk Attachments: ServerHitBin_CacheUsageVisit.patch The Visit-entity has the neverCache-option set, but ServerHitBin is trying to cache it anyway. This should be avoided. I will attach a patch for this (rather trivial change). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4841) Have a workspace for each application/component in a repository
[ https://issues.apache.org/jira/browse/OFBIZ-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261347#comment-13261347 ] Sascha Rodekamp commented on OFBIZ-4841: Separating the concerns in the repository by using different workspaces is, IMHO, a good approach. That could make maintenance of the repository and right management easier. Have a workspace for each application/component in a repository --- Key: OFBIZ-4841 URL: https://issues.apache.org/jira/browse/OFBIZ-4841 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Critical In order to separate access to jcr content each application should have its own workspace in the repository. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4842) Write configuration documentation for the Jackrabbit integration
[ https://issues.apache.org/jira/browse/OFBIZ-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261406#comment-13261406 ] Sascha Rodekamp commented on OFBIZ-4842: I started a configuration document: https://cwiki.apache.org/confluence/display/OFBIZ/Configuration+document Write configuration documentation for the Jackrabbit integration Key: OFBIZ-4842 URL: https://issues.apache.org/jira/browse/OFBIZ-4842 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Good documentation on the implementation and configuration assist the adoption of the solution -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4836: --- Issue Type: Sub-task (was: Bug) Parent: OFBIZ-4659 Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260348#comment-13260348 ] Sascha Rodekamp commented on OFBIZ-4836: Hi Pierre, yes that's possible. A multi-tenancy support isn't implemented yet. You welcome to provide a patch. Which information do we need in a content node to provide multi-tenancy? Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260423#comment-13260423 ] Sascha Rodekamp commented on OFBIZ-4836: Hi Pierre, yes i would also go this way. A separate repository for each tenant. Having tenant nodes would be a high effort and a lot of code. A lot of code means many potential security issues :-) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4840) Make homedir for JCR configurable
[ https://issues.apache.org/jira/browse/OFBIZ-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260540#comment-13260540 ] Sascha Rodekamp commented on OFBIZ-4840: Hi, the homedir can be configured in the jcr-config.xml file. The JCRFactoryImpl.java read the homedir from the xml file. Make homedir for JCR configurable - Key: OFBIZ-4840 URL: https://issues.apache.org/jira/browse/OFBIZ-4840 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Critical Fix For: SVN trunk Currently the homedir for jcr is set in JCRFactoryImpl.java. This should be set through a property in a configuration file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260550#comment-13260550
]
Sascha Rodekamp commented on OFBIZ-4836:
Hi Pierre,
not sure if i understand you right. Why we have to inject the delegator in the
homedir?
I'm looking for a way to configure different homedirs in the jcr-config.xml.
Somthing like:
{code}
!-- jcr home directory --
home-dirs
home-dir path=runtime/data/jcr_1/ /
home-dir path=runtime/data/jcr_2/ /
/home-dirs
{code}
Than i'm able to load a repository instance for each tenant. But I'm not sure
where to store the reference between the tenant and his repository instance, do
you have an idea?
Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
-
Key: OFBIZ-4836
URL: https://issues.apache.org/jira/browse/OFBIZ-4836
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Blocker
Fix For: SVN trunk
When having multiple tenants and one of the users (of a tenant) creates
(uploads) a file to JCR then this file is visible to all users of all tenants
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4836: --- Attachment: jcr-config.xml Maybe it's better to extend the whole config not only the home dir. That gives us the possibility to use a tenant independent JCR implementation. What do you think? Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk Attachments: jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260582#comment-13260582 ] Sascha Rodekamp edited comment on OFBIZ-4836 at 4/24/12 2:09 PM: - Maybe it's better to extend the whole config not only the home dir (see jcr-config.xml file). That gives us the possibility to use a tenant independent JCR implementation. What do you think? was (Author: sascha): Maybe it's better to extend the whole config not only the home dir. That gives us the possibility to use a tenant independent JCR implementation. What do you think? Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk Attachments: jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4840) Make homedir for JCR configurable
[
https://issues.apache.org/jira/browse/OFBIZ-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260596#comment-13260596
]
Sascha Rodekamp commented on OFBIZ-4840:
Nevermind.
The last one is the default value.
{code}
homeDir = UtilXml.childElementAttribute(configRootElement, home-dir, path,
runtime/data/jcr/);
{code}
Make homedir for JCR configurable
-
Key: OFBIZ-4840
URL: https://issues.apache.org/jira/browse/OFBIZ-4840
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Priority: Critical
Fix For: SVN trunk
Currently the homedir for jcr is set in JCRFactoryImpl.java.
This should be set through a property in a configuration file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4836) Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260599#comment-13260599 ] Sascha Rodekamp commented on OFBIZ-4836: Ah ok Pierre i got it. Maybe this will work also for the repository. I will try a few things and come back to you. Best Regards Sascha Jackrabbit (jcr) doesn't work nice with multi-tenancy aspect of OFBiz - Key: OFBIZ-4836 URL: https://issues.apache.org/jira/browse/OFBIZ-4836 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Priority: Blocker Fix For: SVN trunk Attachments: jcr-config.xml When having multiple tenants and one of the users (of a tenant) creates (uploads) a file to JCR then this file is visible to all users of all tenants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4403) The Orders tab in Catalog Products is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114511#comment-13114511 ] Sascha Rodekamp commented on OFBIZ-4403: Thanks Jacques ;) The Orders tab in Catalog Products is not working. Key: OFBIZ-4403 URL: https://issues.apache.org/jira/browse/OFBIZ-4403 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk Reporter: Atul Vani Assignee: Sascha Rodekamp Fix For: Release 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-4403.patch, OFBIZ-4403.patch, OFBIZ-4403.patch The Orders tab in Catalog Products is not working. The reason being that the CommonProductDecorator has got a condition 'notif-empty field=product//not' in it, which fails for the ViewProductOrder screen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4436) OnePageCheckout should reuse UpdateCart while first time rendering
[ https://issues.apache.org/jira/browse/OFBIZ-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112354#comment-13112354 ] Sascha Rodekamp commented on OFBIZ-4436: Hi Kiran, i rethink my previous comment. And i think i was wrong. We don't need a separate ftl, because UpdateCart is the original Screen which is used to update a shopping cart so it is absolutely sufficient to reuse this screen in (for example) the OnePageCheckOutProcess.ftl, there shouldn't be any confusions about it. OnePageCheckout should reuse UpdateCart while first time rendering -- Key: OFBIZ-4436 URL: https://issues.apache.org/jira/browse/OFBIZ-4436 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04 Reporter: Kiran Gawde Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4436-OrderScreensXml.patch, OFBIZ-4436-UpdateCartReuse.patch When shipping options or coupon are changed the entire cart is updated by invoking UpdateCart. It returns output of UpdateCart screen. The same screen should be reused during original rendering to avoid code duplication. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4436) OnePageCheckout should reuse UpdateCart while first time rendering
[ https://issues.apache.org/jira/browse/OFBIZ-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4436. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Thanks Kiran your patch is in Trunk @Rev1173975 11.04 @Rev1173978 OnePageCheckout should reuse UpdateCart while first time rendering -- Key: OFBIZ-4436 URL: https://issues.apache.org/jira/browse/OFBIZ-4436 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04 Reporter: Kiran Gawde Assignee: Sascha Rodekamp Priority: Minor Fix For: Release Branch 11.04, SVN trunk Attachments: OFBIZ-4436-OrderScreensXml.patch, OFBIZ-4436-UpdateCartReuse.patch When shipping options or coupon are changed the entire cart is updated by invoking UpdateCart. It returns output of UpdateCart screen. The same screen should be reused during original rendering to avoid code duplication. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4437) PostalAddress for Contact in Admin doesn't filter states by country
[ https://issues.apache.org/jira/browse/OFBIZ-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4437. -- Resolution: Fixed Fix Version/s: SVN trunk There was an error in the entitymodel definition for the GeoAssocAndGeoToWithState View-Entity. Fix is in Trunk @Rev1173996 PostalAddress for Contact in Admin doesn't filter states by country --- Key: OFBIZ-4437 URL: https://issues.apache.org/jira/browse/OFBIZ-4437 Project: OFBiz Issue Type: Bug Components: party Reporter: Kiran Gawde Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Create new PostalAddress for Contact via Admin. It shows the United States as country but the states list shows all the states. It should filter the list to show US states. Also the state list should should update as soon as country changes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OFBIZ-4428) trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site = ERROR
[
https://issues.apache.org/jira/browse/OFBIZ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112425#comment-13112425
]
Sascha Rodekamp edited comment on OFBIZ-4428 at 9/22/11 9:06 AM:
-
Hi mz4wheeler,
a simple explanation:
Before the last update 1130415 we have the following line in the screen
definition
{code}
set field=productStoreId from-field=parameters.viewProductStoreId/
set field=productStoreId from-field=parameters.productStoreId
default-value=${productStoreId}/
{code}
Hans removed both lines. The result is, the FTL don't know ${productStoreId}.
I'm not sure why Hans remove both lines, if he did this on purpose or
accidentally. Maybe he could give a short answer.
So we have to alternatives, the one you suggested and reintegrate
{code}
set field=productStoreId from-field=parameters.productStoreId
default-value=${productStoreId}/
{code}
was (Author: sascha):
Hi mz4wheeler,
a simple explanation:
Before the last update 1130415 we have the following line in the screen
definition
{code}
set field=productStoreId from-field=parameters.viewProductStoreId/
set field=productStoreId from-field=parameters.productStoreId
default-value=${productStoreId}/
{code}
Hans removed both lines. The result is, the FTL don't know ${productStoreId}.
I'm not sure why Hans remove both lines, if he did this on purpose or
accidentally. Maybe he could give a short answer.
So we have to alternatives, the one you suggested and reintegrate
{code}
set field=productStoreId from-field=parameters.productStoreId
default-value=${productStoreId}/
{code}
trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site =
ERROR
Key: OFBIZ-4428
URL: https://issues.apache.org/jira/browse/OFBIZ-4428
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: Ubuntu
Reporter: mz4wheeler
Assignee: Sascha Rodekamp
Using trunk, you are unable to create a new web site. The result is:
Bad Request
Your browser sent a request that this server could not understand.
Apache/2.2.14 (Ubuntu) Server at demo-trunk.ofbiz.apache.org Port 443
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4428) trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site = ERROR
[
https://issues.apache.org/jira/browse/OFBIZ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112425#comment-13112425
]
Sascha Rodekamp commented on OFBIZ-4428:
Hi mz4wheeler,
a simple explanation:
Before the last update 1130415 we have the following line in the screen
definition
{code}
set field=productStoreId from-field=parameters.viewProductStoreId/
set field=productStoreId from-field=parameters.productStoreId
default-value=${productStoreId}/
{code}
Hans removed both lines. The result is, the FTL don't know ${productStoreId}.
I'm not sure why Hans remove both lines, if he did this on purpose or
accidentally. Maybe he could give a short answer.
So we have to alternatives, the one you suggested and reintegrate
{code}
set field=productStoreId from-field=parameters.productStoreId
default-value=${productStoreId}/
{code}
trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site =
ERROR
Key: OFBIZ-4428
URL: https://issues.apache.org/jira/browse/OFBIZ-4428
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Environment: Ubuntu
Reporter: mz4wheeler
Assignee: Sascha Rodekamp
Using trunk, you are unable to create a new web site. The result is:
Bad Request
Your browser sent a request that this server could not understand.
Apache/2.2.14 (Ubuntu) Server at demo-trunk.ofbiz.apache.org Port 443
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4441) UtilXml firstChildElement should use getNodeName instead of getLocalName
[ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112444#comment-13112444 ] Sascha Rodekamp commented on OFBIZ-4441: Hi Kiran, i also don't understand why this two places uses getLocalName(). Just to clarify, getLocalName returns null when the Element is created while the schema namespace processing is turned off. So i think using getNodeName should work more reliable in this place. I found a few other places where getLocalName could be replaced with getNodeName could you confirm? Any opinions? UtilXml firstChildElement should use getNodeName instead of getLocalName Key: OFBIZ-4441 URL: https://issues.apache.org/jira/browse/OFBIZ-4441 Project: OFBiz Issue Type: Bug Components: framework Reporter: Kiran Gawde Priority: Minor Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4441) UtilXml firstChildElement should use getNodeName instead of getLocalName
[ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4441: --- Attachment: OFBIZ-4441_XmlElementGetNodeName.patch UtilXml firstChildElement should use getNodeName instead of getLocalName Key: OFBIZ-4441 URL: https://issues.apache.org/jira/browse/OFBIZ-4441 Project: OFBiz Issue Type: Bug Components: framework Reporter: Kiran Gawde Priority: Minor Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4428) trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site = ERROR
[ https://issues.apache.org/jira/browse/OFBIZ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112457#comment-13112457 ] Sascha Rodekamp commented on OFBIZ-4428: Thanks Hans trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site = ERROR Key: OFBIZ-4428 URL: https://issues.apache.org/jira/browse/OFBIZ-4428 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Environment: Ubuntu Reporter: mz4wheeler Assignee: Sascha Rodekamp Using trunk, you are unable to create a new web site. The result is: Bad Request Your browser sent a request that this server could not understand. Apache/2.2.14 (Ubuntu) Server at demo-trunk.ofbiz.apache.org Port 443 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4424) EntityListIterator not being closed after storing incoming email
[ https://issues.apache.org/jira/browse/OFBIZ-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4424. -- Resolution: Fixed Fix Version/s: Release Branch 11.04 Hi Varun, if have submitted a slightly modified version of your patch, i moved the close() in a finally block. The changes are in TRUNK @Rev 1173518 11.04 @Rev 1173520 10.04 @Rev 1173519 Thanks for your effort! EntityListIterator not being closed after storing incoming email Key: OFBIZ-4424 URL: https://issues.apache.org/jira/browse/OFBIZ-4424 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Release 10.04, SVN trunk Environment: OFBiz 10.04 release, OS - Ubuntu, DB - PostgreSQL Reporter: Varun Bhansaly Assignee: Sascha Rodekamp Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-4424.patch CommunicationEventServices.buildListOfWorkEffortInfoFromEmailAddresses() does not close the entity list iterator resulting in error messages like - 2011-09-16 06:15:43,736 [ERROR] EntityListIterator Not Closed for Entity [WorkEffortContactMechView], caught in Finalize -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4422) Using equals() with different object types
[
https://issues.apache.org/jira/browse/OFBIZ-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp closed OFBIZ-4422.
--
Resolution: Fixed
Fix Version/s: SVN trunk
Release Branch 11.04
Release Branch 10.04
Thanks Dimitri,
your Patch is in
Trunk @Rev1173592
10.04 @Rev1173594
11.04 @Rev1173593
Using equals() with different object types
--
Key: OFBIZ-4422
URL: https://issues.apache.org/jira/browse/OFBIZ-4422
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Dimitri Unruh
Assignee: Sascha Rodekamp
Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
Attachments: OFBIZ-4422.patch
In the RunningService.java the equals methods is buggy:
{code}
public boolean equals(Object o) {
if (o != null o instanceof RunningService) {
RunningService x = (RunningService) o;
if (this.model.equals(x) this.mode == x.getMode()
this.startStamp.equals(x.getStartStamp())) {
return true;
}
}
return false;
}
{code}
this.model.equals(x) compares to different classes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4421) Impossible ClassCast
[
https://issues.apache.org/jira/browse/OFBIZ-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp closed OFBIZ-4421.
--
Resolution: Fixed
Fix Version/s: SVN trunk
Release Branch 11.04
Release Branch 10.04
Thanks Dimitri,
your Patch is in
trunk @Rev1173596
10.04 @Rev1173600
11.04 @Rev1173601
Impossible ClassCast
Key: OFBIZ-4421
URL: https://issues.apache.org/jira/browse/OFBIZ-4421
Project: OFBiz
Issue Type: Bug
Components: product
Reporter: Dimitri Unruh
Assignee: Sascha Rodekamp
Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
Attachments: OFBIZ-4421.patch
A cast in ProductSearch.java is impossible:
{code}
public boolean equals(Object obj) {
ProductSearchConstraint psc = (ProductSearchConstraint) obj;
if (psc instanceof FeatureConstraint) {
FeatureSetConstraint that = (FeatureSetConstraint) psc;
...
{code}
The FeatureSetConstraint cast will always throw a ClassCastException.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4425) Wrong use of toArray() method
[
https://issues.apache.org/jira/browse/OFBIZ-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp closed OFBIZ-4425.
--
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Dimitri (again :-) )
Your patch is in trunk @Rev1173607
Wrong use of toArray() method
-
Key: OFBIZ-4425
URL: https://issues.apache.org/jira/browse/OFBIZ-4425
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Dimitri Unruh
Assignee: Sascha Rodekamp
Fix For: SVN trunk
Attachments: OFBIZ-4425.patch
just a short example:
{code}
CollectionString foo;
String[] temp = (String[]) foo.toArray();
{code}
So we will get (usually ) a ClassCastException, because toArray() return an
Object[]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4436) OnePageCheckout should reuse UpdateCart while first time rendering
[ https://issues.apache.org/jira/browse/OFBIZ-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109516#comment-13109516 ] Sascha Rodekamp commented on OFBIZ-4436: Hi Kiran, that's really true we have a code duplication here. The question is if we should include the UpdateCart in the OnePageCheckOut Ftl, i can imagine, that this can confuse developers. I.e. when someone changes the updateCart FTL and he don't notice that we have a relation to the OnePageCheckOut. That could possible break the OPCO, got my point? I would prefer to create a generic FTL called ShoppingCartCheckOutFirstStep.ftl (i think we could find a shorter/better name), place the Step 1 code in the new file and include this one in the UpdateCart and the OPCO. Any opinions? OnePageCheckout should reuse UpdateCart while first time rendering -- Key: OFBIZ-4436 URL: https://issues.apache.org/jira/browse/OFBIZ-4436 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04 Reporter: Kiran Gawde Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4436-OrderScreensXml.patch, OFBIZ-4436-UpdateCartReuse.patch When shipping options or coupon are changed the entire cart is updated by invoking UpdateCart. It returns output of UpdateCart screen. The same screen should be reused during original rendering to avoid code duplication. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4436) OnePageCheckout should reuse UpdateCart while first time rendering
[ https://issues.apache.org/jira/browse/OFBIZ-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4436: -- Assignee: Sascha Rodekamp OnePageCheckout should reuse UpdateCart while first time rendering -- Key: OFBIZ-4436 URL: https://issues.apache.org/jira/browse/OFBIZ-4436 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04 Reporter: Kiran Gawde Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4436-OrderScreensXml.patch, OFBIZ-4436-UpdateCartReuse.patch When shipping options or coupon are changed the entire cart is updated by invoking UpdateCart. It returns output of UpdateCart screen. The same screen should be reused during original rendering to avoid code duplication. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4437) PostalAddress for Contact in Admin doesn't filter states by country
[ https://issues.apache.org/jira/browse/OFBIZ-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4437: -- Assignee: Sascha Rodekamp PostalAddress for Contact in Admin doesn't filter states by country --- Key: OFBIZ-4437 URL: https://issues.apache.org/jira/browse/OFBIZ-4437 Project: OFBiz Issue Type: Bug Components: party Reporter: Kiran Gawde Assignee: Sascha Rodekamp Priority: Minor Create new PostalAddress for Contact via Admin. It shows the United States as country but the states list shows all the states. It should filter the list to show US states. Also the state list should should update as soon as country changes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4428) trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site = ERROR
[ https://issues.apache.org/jira/browse/OFBIZ-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4428: -- Assignee: Sascha Rodekamp trunk: Catalog - Stores - ANYSTORE - Web Sites - Create New Web Site = ERROR Key: OFBIZ-4428 URL: https://issues.apache.org/jira/browse/OFBIZ-4428 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Environment: Ubuntu Reporter: mz4wheeler Assignee: Sascha Rodekamp Using trunk, you are unable to create a new web site. The result is: Bad Request Your browser sent a request that this server could not understand. Apache/2.2.14 (Ubuntu) Server at demo-trunk.ofbiz.apache.org Port 443 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4437) PostalAddress for Contact in Admin doesn't filter states by country
[ https://issues.apache.org/jira/browse/OFBIZ-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109277#comment-13109277 ] Sascha Rodekamp commented on OFBIZ-4437: Hi Kiran, i already saw that. That shouldn't be to hard to fix, so i will look into it in the next days. Thanks for reporting. PostalAddress for Contact in Admin doesn't filter states by country --- Key: OFBIZ-4437 URL: https://issues.apache.org/jira/browse/OFBIZ-4437 Project: OFBiz Issue Type: Bug Components: party Reporter: Kiran Gawde Assignee: Sascha Rodekamp Priority: Minor Create new PostalAddress for Contact via Admin. It shows the United States as country but the states list shows all the states. It should filter the list to show US states. Also the state list should should update as soon as country changes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4425) Wrong use of toArray() method
[
https://issues.apache.org/jira/browse/OFBIZ-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp reassigned OFBIZ-4425:
--
Assignee: Sascha Rodekamp
Wrong use of toArray() method
-
Key: OFBIZ-4425
URL: https://issues.apache.org/jira/browse/OFBIZ-4425
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Dimitri Unruh
Assignee: Sascha Rodekamp
Attachments: OFBIZ-4425.patch
just a short example:
{code}
CollectionString foo;
String[] temp = (String[]) foo.toArray();
{code}
So we will get (usually ) a ClassCastException, because toArray() return an
Object[]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4424) EntityListIterator not being closed after storing incoming email
[ https://issues.apache.org/jira/browse/OFBIZ-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4424: -- Assignee: Sascha Rodekamp EntityListIterator not being closed after storing incoming email Key: OFBIZ-4424 URL: https://issues.apache.org/jira/browse/OFBIZ-4424 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Release 10.04, SVN trunk Environment: OFBiz 10.04 release, OS - Ubuntu, DB - PostgreSQL Reporter: Varun Bhansaly Assignee: Sascha Rodekamp Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4424.patch CommunicationEventServices.buildListOfWorkEffortInfoFromEmailAddresses() does not close the entity list iterator resulting in error messages like - 2011-09-16 06:15:43,736 [ERROR] EntityListIterator Not Closed for Entity [WorkEffortContactMechView], caught in Finalize -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4418) Replace String concatenation in a loop
[ https://issues.apache.org/jira/browse/OFBIZ-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4418. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri. Your Patch is in Trunk @Rev1170961 Replace String concatenation in a loop -- Key: OFBIZ-4418 URL: https://issues.apache.org/jira/browse/OFBIZ-4418 Project: OFBiz Issue Type: Improvement Components: accounting, content, framework, marketing, product Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4418.patch I changend some methods building a String using concatenation in a loop. We can obtaine better performance by using a StringBuilder -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4414) Missing UiLabel and typos on Anonymous Checkout
[ https://issues.apache.org/jira/browse/OFBIZ-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4414. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Thanks Carsten for your Patch, it is in Trunk @ Rev1170968 10.04 @ Rev1170969 11.04 @ Rev1170971 Missing UiLabel and typos on Anonymous Checkout --- Key: OFBIZ-4414 URL: https://issues.apache.org/jira/browse/OFBIZ-4414 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release 10.04, SVN trunk Environment: n/a Reporter: Carsten Schinzer Assignee: Sascha Rodekamp Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-4414_MissingUiLabelandtyposonAnonymousCheckout.patch Original Estimate: 0.5h Remaining Estimate: 0.5h custsetting.ftl has typos: Opening tag lable is used on four occasions instead of label while closing tags correctly refer to /label. Header of section refers to EcommerceUiLabel EcommerceYourNamePhoneAndEmail which is not present in specialpurpose/ecommerce/config/EcommerceUiLabels.xml. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4417) blockingTestScv Service is set to export=true
[ https://issues.apache.org/jira/browse/OFBIZ-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4417: -- Assignee: Sascha Rodekamp blockingTestScv Service is set to export=true --- Key: OFBIZ-4417 URL: https://issues.apache.org/jira/browse/OFBIZ-4417 Project: OFBiz Issue Type: Bug Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Critical Attachments: OFBIZ-4417.patch blockingTestScv Service is set to export=true without any user authorisation. So it is possible to crash the whole system. I guess it is not necessary to export this service, or did I miss something? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4419) getOrderStatus service is defined with export=true
[ https://issues.apache.org/jira/browse/OFBIZ-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4419: -- Assignee: Sascha Rodekamp getOrderStatus service is defined with export=true Key: OFBIZ-4419 URL: https://issues.apache.org/jira/browse/OFBIZ-4419 Project: OFBiz Issue Type: Bug Components: order Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Attachments: OFBIZ-4419.patch The getOrderStatus service is defined with export=true without to do any authorization checks. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4419) getOrderStatus service is defined with export=true
[ https://issues.apache.org/jira/browse/OFBIZ-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4419. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri. Your Patch is in Trunk @Rev1171020 getOrderStatus service is defined with export=true Key: OFBIZ-4419 URL: https://issues.apache.org/jira/browse/OFBIZ-4419 Project: OFBiz Issue Type: Bug Components: order Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Fix For: SVN trunk Attachments: OFBIZ-4419.patch The getOrderStatus service is defined with export=true without to do any authorization checks. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4417) blockingTestScv Service is set to export=true
[ https://issues.apache.org/jira/browse/OFBIZ-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4417. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri, your patch is in Trunk @Rev1171028 blockingTestScv Service is set to export=true --- Key: OFBIZ-4417 URL: https://issues.apache.org/jira/browse/OFBIZ-4417 Project: OFBiz Issue Type: Bug Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Critical Fix For: SVN trunk Attachments: OFBIZ-4417.patch blockingTestScv Service is set to export=true without any user authorisation. So it is possible to crash the whole system. I guess it is not necessary to export this service, or did I miss something? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4420) IO stream objects are not closed
[ https://issues.apache.org/jira/browse/OFBIZ-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4420: -- Assignee: Sascha Rodekamp IO stream objects are not closed Key: OFBIZ-4420 URL: https://issues.apache.org/jira/browse/OFBIZ-4420 Project: OFBiz Issue Type: Bug Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4420.patch Some methods are creating an IO stream object without closing it, so it could result on a descriptor leak. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4420) IO stream objects are not closed
[ https://issues.apache.org/jira/browse/OFBIZ-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105376#comment-13105376 ] Sascha Rodekamp commented on OFBIZ-4420: Jap that looks good, but we should keep in mind, when moving to Java7 that we refactor this code and use the try-with-resources statements (Just a reminder). http://download.oracle.com/javase/7/docs/technotes/guides/language/try-with-resources.html IO stream objects are not closed Key: OFBIZ-4420 URL: https://issues.apache.org/jira/browse/OFBIZ-4420 Project: OFBiz Issue Type: Bug Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4420.patch Some methods are creating an IO stream object without closing it, so it could result on a descriptor leak. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4421) Impossible ClassCast
[
https://issues.apache.org/jira/browse/OFBIZ-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp reassigned OFBIZ-4421:
--
Assignee: Sascha Rodekamp
Impossible ClassCast
Key: OFBIZ-4421
URL: https://issues.apache.org/jira/browse/OFBIZ-4421
Project: OFBiz
Issue Type: Bug
Components: product
Reporter: Dimitri Unruh
Assignee: Sascha Rodekamp
Attachments: OFBIZ-4421.patch
A cast in ProductSearch.java is impossible:
{code}
public boolean equals(Object obj) {
ProductSearchConstraint psc = (ProductSearchConstraint) obj;
if (psc instanceof FeatureConstraint) {
FeatureSetConstraint that = (FeatureSetConstraint) psc;
...
{code}
The FeatureSetConstraint cast will always throw a ClassCastException.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4422) Using equals() with different object types
[
https://issues.apache.org/jira/browse/OFBIZ-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp reassigned OFBIZ-4422:
--
Assignee: Sascha Rodekamp
Using equals() with different object types
--
Key: OFBIZ-4422
URL: https://issues.apache.org/jira/browse/OFBIZ-4422
Project: OFBiz
Issue Type: Bug
Components: framework
Reporter: Dimitri Unruh
Assignee: Sascha Rodekamp
Attachments: OFBIZ-4422.patch
In the RunningService.java the equals methods is buggy:
{code}
public boolean equals(Object o) {
if (o != null o instanceof RunningService) {
RunningService x = (RunningService) o;
if (this.model.equals(x) this.mode == x.getMode()
this.startStamp.equals(x.getStartStamp())) {
return true;
}
}
return false;
}
{code}
this.model.equals(x) compares to different classes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4423) very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog.
[ https://issues.apache.org/jira/browse/OFBIZ-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4423: -- Assignee: Sascha Rodekamp very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog. Key: OFBIZ-4423 URL: https://issues.apache.org/jira/browse/OFBIZ-4423 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Assignee: Sascha Rodekamp Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4423-fieldlookup.patch In IE, if you use link's href to call javascript function and its parameter contains encoded multi-bytes characters, such as %E2%82%AC which is the result of encodeURI(€), IE will incorrectly unescape it to ⬠and then javascript call return unexpected result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4423) very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog.
[ https://issues.apache.org/jira/browse/OFBIZ-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4423. -- Resolution: Fixed Thanks Leon your patch is in Trunk @Rev.1171391 very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog. Key: OFBIZ-4423 URL: https://issues.apache.org/jira/browse/OFBIZ-4423 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Assignee: Sascha Rodekamp Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4423-fieldlookup.patch In IE, if you use link's href to call javascript function and its parameter contains encoded multi-bytes characters, such as %E2%82%AC which is the result of encodeURI(€), IE will incorrectly unescape it to ⬠and then javascript call return unexpected result. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4405) Some inefficient Map iterations
[ https://issues.apache.org/jira/browse/OFBIZ-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4405. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri for your effort, your small modified patch is in trunk @Rev1170447. Some inefficient Map iterations --- Key: OFBIZ-4405 URL: https://issues.apache.org/jira/browse/OFBIZ-4405 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4405.patch Some Methods in InvoiceServices.java handles inefficient Map iterations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4404) Missing german conditional label
[ https://issues.apache.org/jira/browse/OFBIZ-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4404. -- Resolution: Fixed Fix Version/s: Release 09.04 SVN trunk Release Branch 11.04 Release Branch 10.04 Thanks Dimitri, your patch is in trunk, release 9.04, release 10.04 and release 11.04 Missing german conditional label Key: OFBIZ-4404 URL: https://issues.apache.org/jira/browse/OFBIZ-4404 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release 09.04 Attachments: conditional.xml.patch one german label in conditional.xml is missing -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4403) The Orders tab in Catalog Products is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104345#comment-13104345 ] Sascha Rodekamp commented on OFBIZ-4403: Hi Atul thanks for your effort. Your patch is in trunk and release 11.04. Could provide a working patch for release 10.04. The Orders tab in Catalog Products is not working. Key: OFBIZ-4403 URL: https://issues.apache.org/jira/browse/OFBIZ-4403 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk Reporter: Atul Vani Assignee: Sascha Rodekamp Fix For: Release 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-4403.patch, OFBIZ-4403.patch, OFBIZ-4403.patch The Orders tab in Catalog Products is not working. The reason being that the CommonProductDecorator has got a condition 'notif-empty field=product//not' in it, which fails for the ViewProductOrder screen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4342) Ajax callings in CheckoutProcess.js are not handling server-side errors correctly
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104346#comment-13104346 ] Sascha Rodekamp commented on OFBIZ-4342: Hey Jonatan any news for this issue? Ajax callings in CheckoutProcess.js are not handling server-side errors correctly - Key: OFBIZ-4342 URL: https://issues.apache.org/jira/browse/OFBIZ-4342 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Jonatan Soto Assignee: Sascha Rodekamp Labels: ajax, checkout Attachments: patch.txt Original Estimate: 2h Remaining Estimate: 2h All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4356) Exception when entering wrong current password on requirePasswordChange
[
https://issues.apache.org/jira/browse/OFBIZ-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp reassigned OFBIZ-4356:
--
Assignee: Sascha Rodekamp
Exception when entering wrong current password on requirePasswordChange
---
Key: OFBIZ-4356
URL: https://issues.apache.org/jira/browse/OFBIZ-4356
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Mirko Vogelsmeier
Assignee: Sascha Rodekamp
Attachments: OFBIZ-4356.patch
Here is a step-by-step how the error occures:
1) Request a new password by entering your userlogin
2) Login and you will get to the requirePasswordChange-Page (depending on
properties)
3) If you enter a wrong current password on this page the exception is thrown.
OFBiz tries to call the service updatePassword with a bad userLogin and an
Exception is thrown:
org.ofbiz.service.ServiceAuthException: User authorization is required for
this service: updatePassword
[updatePassword::file:/C:/Workspace/apache_ofbiz/framework/common/servicedef/services.xml::Update
a UserLogin
Password::javaorg.ofbiz.common.login.LoginServices::updatePassword::UserLogin::true::false::true::true::false::0::[]::[]::{userLoginId=userLoginId::String::IN::null::UserLogin::userLoginId::true::false::true::false::none::null::false,
currentPassword=currentPassword::String::IN::null::UserLogin::currentPassword::true::false::true::false::none::null::false,
newPassword=newPassword::String::IN::null::UserLogin::newPassword::true::false::true::false::none::null::false,
newPasswordVerify=newPasswordVerify::String::IN::null::UserLogin::newPasswordVerify::true::false::true::false::none::null::false,
passwordHint=passwordHint::String::IN::null::UserLogin::passwordHint::true::false::true::false::none::null::false,
updatedUserLogin=updatedUserLogin::org.ofbiz.entity.GenericValue::OUT::null::UserLogin::updatedUserLogin::false::false::true::false::none::null::false,
responseMessage=responseMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessage=errorMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessageList=errorMessageList::java.util.List::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
successMessage=successMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
successMessageList=successMessageList::java.util.List::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
userLogin=userLogin::org.ofbiz.entity.GenericValue::INOUT::null::null::null::null::null::true::false::true::false::null::null::true,
login.username=login.username::String::IN::null::null::null::null::null::true::false::true::false::null::null::true,
login.password=login.password::String::IN::null::null::null::null::null::true::false::true::false::null::null::true,
locale=locale::java.util.Locale::INOUT::null::null::null::null::null::true::false::true::false::null::null::true,
timeZone=timeZone::java.util.TimeZone::INOUT::null::null::null::null::null::true::false::true::false::null::null::true}::{userLoginId::String::IN::null::UserLogin::userLoginId::true::false::true::false::none::null::false,
currentPassword::String::IN::null::UserLogin::currentPassword::true::false::true::false::none::null::false,
newPassword::String::IN::null::UserLogin::newPassword::true::false::true::false::none::null::false,
newPasswordVerify::String::IN::null::UserLogin::newPasswordVerify::true::false::true::false::none::null::false,
passwordHint::String::IN::null::UserLogin::passwordHint::true::false::true::false::none::null::false,
updatedUserLogin::org.ofbiz.entity.GenericValue::OUT::null::UserLogin::updatedUserLogin::false::false::true::false::none::null::false,
responseMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessageList::java.util.List::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
successMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
successMessageList::java.util.List::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
userLogin::org.ofbiz.entity.GenericValue::INOUT::null::null::null::null::null::true::false::true::false::null::null::true,
login.username::String::IN::null::null::null::null::null::true::false::true::false::null::null::true,
[jira] [Closed] (OFBIZ-4356) Exception when entering wrong current password on requirePasswordChange
[
https://issues.apache.org/jira/browse/OFBIZ-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp closed OFBIZ-4356.
--
Resolution: Fixed
Fix Version/s: SVN trunk
Release Branch 11.04
Thanks Mirko for Reporting and many thanks Dimitri for fixing this issue.
The patch is in Trunk and Release 11.04 @Rev:1170473.
Exception when entering wrong current password on requirePasswordChange
---
Key: OFBIZ-4356
URL: https://issues.apache.org/jira/browse/OFBIZ-4356
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Mirko Vogelsmeier
Assignee: Sascha Rodekamp
Fix For: Release Branch 11.04, SVN trunk
Attachments: OFBIZ-4356.patch
Here is a step-by-step how the error occures:
1) Request a new password by entering your userlogin
2) Login and you will get to the requirePasswordChange-Page (depending on
properties)
3) If you enter a wrong current password on this page the exception is thrown.
OFBiz tries to call the service updatePassword with a bad userLogin and an
Exception is thrown:
org.ofbiz.service.ServiceAuthException: User authorization is required for
this service: updatePassword
[updatePassword::file:/C:/Workspace/apache_ofbiz/framework/common/servicedef/services.xml::Update
a UserLogin
Password::javaorg.ofbiz.common.login.LoginServices::updatePassword::UserLogin::true::false::true::true::false::0::[]::[]::{userLoginId=userLoginId::String::IN::null::UserLogin::userLoginId::true::false::true::false::none::null::false,
currentPassword=currentPassword::String::IN::null::UserLogin::currentPassword::true::false::true::false::none::null::false,
newPassword=newPassword::String::IN::null::UserLogin::newPassword::true::false::true::false::none::null::false,
newPasswordVerify=newPasswordVerify::String::IN::null::UserLogin::newPasswordVerify::true::false::true::false::none::null::false,
passwordHint=passwordHint::String::IN::null::UserLogin::passwordHint::true::false::true::false::none::null::false,
updatedUserLogin=updatedUserLogin::org.ofbiz.entity.GenericValue::OUT::null::UserLogin::updatedUserLogin::false::false::true::false::none::null::false,
responseMessage=responseMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessage=errorMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessageList=errorMessageList::java.util.List::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
successMessage=successMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
successMessageList=successMessageList::java.util.List::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
userLogin=userLogin::org.ofbiz.entity.GenericValue::INOUT::null::null::null::null::null::true::false::true::false::null::null::true,
login.username=login.username::String::IN::null::null::null::null::null::true::false::true::false::null::null::true,
login.password=login.password::String::IN::null::null::null::null::null::true::false::true::false::null::null::true,
locale=locale::java.util.Locale::INOUT::null::null::null::null::null::true::false::true::false::null::null::true,
timeZone=timeZone::java.util.TimeZone::INOUT::null::null::null::null::null::true::false::true::false::null::null::true}::{userLoginId::String::IN::null::UserLogin::userLoginId::true::false::true::false::none::null::false,
currentPassword::String::IN::null::UserLogin::currentPassword::true::false::true::false::none::null::false,
newPassword::String::IN::null::UserLogin::newPassword::true::false::true::false::none::null::false,
newPasswordVerify::String::IN::null::UserLogin::newPasswordVerify::true::false::true::false::none::null::false,
passwordHint::String::IN::null::UserLogin::passwordHint::true::false::true::false::none::null::false,
updatedUserLogin::org.ofbiz.entity.GenericValue::OUT::null::UserLogin::updatedUserLogin::false::false::true::false::none::null::false,
responseMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
errorMessageList::java.util.List::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
successMessage::String::OUT::null::null::null::null::null::true::false::true::false::null::null::true,
[jira] [Assigned] (OFBIZ-4415) Some small improvements with Map iterations
[ https://issues.apache.org/jira/browse/OFBIZ-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4415: -- Assignee: Sascha Rodekamp Some small improvements with Map iterations --- Key: OFBIZ-4415 URL: https://issues.apache.org/jira/browse/OFBIZ-4415 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4415.patch, OFBIZ-4415.patch Some Methods in * UtilHttp.java * DatabaseUtil.java * WidgetContextCacheKey.java * CoreEvents.java handles inefficient Map iterations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4416) Building a String using concatenation in a loop
[ https://issues.apache.org/jira/browse/OFBIZ-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4416: -- Assignee: Sascha Rodekamp Building a String using concatenation in a loop --- Key: OFBIZ-4416 URL: https://issues.apache.org/jira/browse/OFBIZ-4416 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4416.patch In UtilValidate.java some methods building a String using concatenation in a loop. We can obtaine better performance by using a StringBuilder -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4416) Building a String using concatenation in a loop
[ https://issues.apache.org/jira/browse/OFBIZ-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4416. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Thanks Dimitri, your Patch is in trunk @Rev1170520 Release 11.04 @Rev1170521 Building a String using concatenation in a loop --- Key: OFBIZ-4416 URL: https://issues.apache.org/jira/browse/OFBIZ-4416 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Fix For: Release Branch 11.04, SVN trunk Attachments: OFBIZ-4416.patch In UtilValidate.java some methods building a String using concatenation in a loop. We can obtaine better performance by using a StringBuilder -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4415) Some small improvements with Map iterations
[ https://issues.apache.org/jira/browse/OFBIZ-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4415. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri. Your patch is in trunk @Rev1170525 Some small improvements with Map iterations --- Key: OFBIZ-4415 URL: https://issues.apache.org/jira/browse/OFBIZ-4415 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4415.patch, OFBIZ-4415.patch Some Methods in * UtilHttp.java * DatabaseUtil.java * WidgetContextCacheKey.java * CoreEvents.java handles inefficient Map iterations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4414) Missing UiLabel and typos on Anonymous Checkout
[ https://issues.apache.org/jira/browse/OFBIZ-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4414: -- Assignee: Sascha Rodekamp Missing UiLabel and typos on Anonymous Checkout --- Key: OFBIZ-4414 URL: https://issues.apache.org/jira/browse/OFBIZ-4414 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release 10.04, SVN trunk Environment: n/a Reporter: Carsten Schinzer Assignee: Sascha Rodekamp Priority: Minor Fix For: Release Branch 10.04 Attachments: OFBIZ-4414_MissingUiLabelandtyposonAnonymousCheckout.patch Original Estimate: 0.5h Remaining Estimate: 0.5h custsetting.ftl has typos: Opening tag lable is used on four occasions instead of label while closing tags correctly refer to /label. Header of section refers to EcommerceUiLabel EcommerceYourNamePhoneAndEmail which is not present in specialpurpose/ecommerce/config/EcommerceUiLabels.xml. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4418) Replace String concatenation in a loop
[ https://issues.apache.org/jira/browse/OFBIZ-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4418: -- Assignee: Sascha Rodekamp Replace String concatenation in a loop -- Key: OFBIZ-4418 URL: https://issues.apache.org/jira/browse/OFBIZ-4418 Project: OFBiz Issue Type: Improvement Components: accounting, content, framework, marketing, product Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4418.patch I changend some methods building a String using concatenation in a loop. We can obtaine better performance by using a StringBuilder -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4404) Missing german conditional label
[ https://issues.apache.org/jira/browse/OFBIZ-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4404: -- Assignee: Sascha Rodekamp Missing german conditional label Key: OFBIZ-4404 URL: https://issues.apache.org/jira/browse/OFBIZ-4404 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Attachments: conditional.xml.patch one german label in conditional.xml is missing -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4403) The Orders tab in Catalog Products is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4403: -- Assignee: Sascha Rodekamp The Orders tab in Catalog Products is not working. Key: OFBIZ-4403 URL: https://issues.apache.org/jira/browse/OFBIZ-4403 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk Reporter: Atul Vani Assignee: Sascha Rodekamp Fix For: Release 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-4403.patch The Orders tab in Catalog Products is not working. The reason being that the CommonProductDecorator has got a condition 'notif-empty field=product//not' in it, which fails for the ViewProductOrder screen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4403) The Orders tab in Catalog Products is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102597#comment-13102597 ] Sascha Rodekamp commented on OFBIZ-4403: Hi Atul, that looks good at a first glace. I'll have a deeper look this evening. :-) Cheers The Orders tab in Catalog Products is not working. Key: OFBIZ-4403 URL: https://issues.apache.org/jira/browse/OFBIZ-4403 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk Reporter: Atul Vani Assignee: Sascha Rodekamp Fix For: Release 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-4403.patch, OFBIZ-4403.patch, OFBIZ-4403.patch The Orders tab in Catalog Products is not working. The reason being that the CommonProductDecorator has got a condition 'notif-empty field=product//not' in it, which fails for the ViewProductOrder screen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4405) Some inefficient Map iterations
[ https://issues.apache.org/jira/browse/OFBIZ-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4405: -- Assignee: Sascha Rodekamp Some inefficient Map iterations --- Key: OFBIZ-4405 URL: https://issues.apache.org/jira/browse/OFBIZ-4405 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Dimitri Unruh Assignee: Sascha Rodekamp Priority: Minor Attachments: OFBIZ-4405.patch Some Methods in InvoiceServices.java handles inefficient Map iterations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-765) Create New Customer fails if done after initial/aborted anonymous checkout
[ https://issues.apache.org/jira/browse/OFBIZ-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-765: -- Attachment: OFBIZ-765_CreateNewCustomerAfterAnonCheckout.patch Hi David, hi Scott, i've a small snippet to fix this issue. I only could reproduce this error when trying to register after a initial/aborted anon checkout. David you said there are certain other places where this occurs. Could you remember in which cases the exception raises? Create New Customer fails if done after initial/aborted anonymous checkout -- Key: OFBIZ-765 URL: https://issues.apache.org/jira/browse/OFBIZ-765 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: David E. Jones Attachments: OFBIZ-765_CreateNewCustomerAfterAnonCheckout.patch Create New Customer fails if done after initial/aborted anonymous checkout. The solution to this would be to add something to the new customer event that detects that an anonymous user was in the session and cart, and then to have it remove that user when ready and replace it with the new customer account created. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4377) to get the correct jquery.ui.datepicker-xx-XX.js
[ https://issues.apache.org/jira/browse/OFBIZ-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4377. -- Resolution: Fixed Thanks Leon for the patch, it's committed @Rev1163533 to get the correct jquery.ui.datepicker-xx-XX.js -- Key: OFBIZ-4377 URL: https://issues.apache.org/jira/browse/OFBIZ-4377 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: JsLanguageFileMapping.patch It uses locale (e.g. zh_TW) to form the jquery.ui.datepicker file name in method JsLanguageFileMappingCreator.createJsLanguageFileMapping, but jquery uses dash (-) instead of underscore (_) to concat the language code and country code, such as zh-TW vs. zh_TW. A very trivial update to JsLanguageFileMappingCreator.java, and after that, update the JsLanguageFileMapping.java file by running service createJsLanguageFileMapping. In attached, contains both of patches to these two files. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4342) Ajax callings in CheckoutProcess.js are not handling server-side errors correctly
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13094396#comment-13094396 ] Sascha Rodekamp commented on OFBIZ-4342: Hi Jonatan, i tested your patch and must say it breaks the OnePageCheckOut, when I try to go to step two nothing happens. Could you please investigate? Another small thing, when you create a patch please try to replace all tabs with spaces. Thanks for your help Sascha Ajax callings in CheckoutProcess.js are not handling server-side errors correctly - Key: OFBIZ-4342 URL: https://issues.apache.org/jira/browse/OFBIZ-4342 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Jonatan Soto Assignee: Sascha Rodekamp Labels: ajax, checkout Attachments: patch.txt Original Estimate: 2h Remaining Estimate: 2h All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
